ScriptUO
Official ScriptUO EasyUO Scripts => Script Debug => Topic started by: xxcaptainxx on August 13, 2008, 07:30:29 PM
-
Well here it goes i know a lot of you are masters or close to it out there, but i have been working on this simple script for a spell and can't seem to get it to function properly, so i figured i would post it here for help and so everyone can get a chuckle :)...... Ohh yeah i don't know how to make one of the boxs to put it in so you can copy and all so i am just going to past it
;========================================
;Name: XxCaptainxX's Heal & Warn
;Author: XxCaptainxX
;Version: What comes befor beta? :)
;========================================
mainloop:
gosub counter
gosub check
gosub heal
goto mainloop
;-------Counter-(Crosses-Fingers)--------
sub counter
finditem ZLF
if #findkind <> -1
{
if #findStack <= 20
{
EVENT ExMsg #charID 3 33 You are Low on bandaids!$
}
;-------Checker-(Maybe)------------------
sub check
If #hits < #maxHits
return %true
return %false
}
;-------Heal-(hopefully)-----------------
sub heal
if #result %true
finditem ZLF
{
if #findkind <> -1
{
set #lobjectId #findId
event macro 17
target 5s
event macro 23
wait 10s 8
}
return
-
This is what i came up with off your script. You need something to tell it that it is done healing and if needed to it will try to heal again. so i added
set %fullheal You_finish_applying_the
set %retry You_apply_the_bandages
set %lilheal You_heal_what_little_damage_your
set %tryagain That_being_is_not_damaged
set %wait You_must_wait_to_perform_another_action
to the first of the script
and this to the healing sub
repeat
{
wait 0
}
until %fullheal in #sysmsg || %lilheal in #sysmsg || %retry in #sysmsg || %tryagain in #sysmsg || %wait in #sysMsg
and i added my own healing sub that you can use if wanted.
and i changed your %true and %false to #true #false
here is the completed version
;========================================
;Name: XxCaptainxX's Heal & Warn
;Author: XxCaptainxX
;Version: What comes befor beta? Smiley
;========================================
set %fullheal You_finish_applying_the
set %retry You_apply_the_bandages
set %lilheal You_heal_what_little_damage_your
set %tryagain That_being_is_not_damaged
set %wait You_must_wait_to_perform_another_action
mainloop:
gosub counter
gosub check
gosub healtest
goto mainloop
;-------Counter-(Crosses-Fingers)--------
sub counter
finditem ZLF
if #findkind <> -1
{
if #findStack <= 20
{
EVENT ExMsg #charID 3 33 You are Low on bandaids!$
}
}
;-------Checker-(Maybe)------------------
sub check
If #hits < #maxHits
{
return #true
}
return #false
;-------Heal-(hopefully)-----------------
sub heal
if #result #true
finditem ZLF
{
if #findkind <> -1
{
set #lobjectId #findId
event macro 17
target 5s
event macro 23
repeat
{
wait 0
}
until %fullheal in #sysmsg || %lilheal in #sysmsg || %retry in #sysmsg || %tryagain in #sysmsg || %wait in #sysMsg
}
return
sub healtest
if #result #true
{
event macro 58
repeat
{
wait 0
}
until %fullheal in #sysmsg || %lilheal in #sysmsg || %retry in #sysmsg || %tryagain in #sysmsg || %wait in #sysMsg
}
return
-
Ohh yeah i don't know how to make one of the boxs to put it in so you can copy and all so i am just going to past it
To help you in the future,
a code box is made as follows:
"["code"]" (Do not use the " and no spaces) This starts your code box.
Paste all of your code and then to end you rcode box.
"["/code"]" (Again, do not use the " and no spaces)
:)
-
Just click the (http://www.scriptuo.com/smf/Themes/default/images/bbc/code.gif) icon to get the code block. Then just put your code in between the separators.
-
One thing to remember when useing #finditem is to always check the #findkind. The way you are useing it it will find your aids in packs first and then on the ground. The problem is that if somone was to drop aids on the ground out of your reach it will mess the script up.
I would write the counter sub like this
sub counter
finditem ZLF C_ , #backpackid
if #findkind = 0 && #findstack <= 20
EVENT ExMsg #charID 3 33 You are Low on bandaids!
if #findkind = -1
event exmsg #charid 3 33 You are out of bandaids!
return
At this point you could add in a bandaid restocking.
The same with the actual heal sub
;-------Heal-(hopefully)-----------------
sub heal
if #result #true
finditem ZLF c_ , #backpackid
{
if #findkind = 0 ; -1 not found, 0 in a container, 1 on the ground
{
set #lobjectId #findId
event macro 17
target 5s
event macro 23
repeat
{
wait 0
}
until %fullheal in #sysmsg || %lilheal in #sysmsg || %retry in #sysmsg || %tryagain in #sysmsg || %wait in #sysMsg
}
return
Hope this helps you in your quest to become a master scripter.
-
thanks for that, i am not sure how to do the restock.. any chances you could give me a lead? :) that and i want to add chiv in.. i have been looking at trails healing script but my eyes cross when i look at it to much :)
-
Hope this helps you in your quest to become a master scripter.
Hey good to see the Cstalker isn't stalking in the shadows anymore. ;)
-
Restocking is easy. It depends on where you have your bandaids at
this is one of the subs i use for restocking,
;----------------------------------
;%1 Type or ID of the item to restock
;%2 the amount to grab
;%3 the container to grab from
;%4 the container to drop to
Sub Restock
Finditem %1 C_ , %3
if #findkind = 0 && #findstack >= %2
{
exevent drag #findid %2
exevent dropc %4
wait 10
return true
}
event exmsg #charid 3 0 You do not have enough of that item.
return false
then you just use
gosub restock XX XXX XXXXXX XXXXXX
where the xs are %1 thru %4 that are in the sub.
As far as adding chiv, you use use the event macros where you need them
-
i am kind of confused with the %'s do i just replace the % with id's like to grab?
or
gosub restock CLF 100 CJR QQk
???
Thanks
-
Almost :)
CLF, CJR and QQK are types, meaning a type of item. IDs define a certain item/stack etc.
%3 and %4 must be ids and not types.
So lets say your source container's id is XJUGKQD and your target container's id is BKMUSPD you can use:
gosub restock CLF 100 XJUGKQD BKMUSPD
An easy way to manually check an id is just to drag the item around and then check #LLIFTEDID in easyuo.
-
what if the bag is inside the bank
or if i wanted a cursor to come up so i could target bag or item?
-
easy
event macro 1 0 Bank
wait 15
set #TARGCURS 1
event exmsg #charid 3 0 Target your bag now
repeat
{
wait 1
}
until #TARGCURS = 0
Set %WhatBagYouWant #ltargetid
-
alas this will cause it to look right away once it runs out, so maybe i should make a like button or something for when i am at the bank and need the restock. this silly thing just gets more and more complicated
-
alas this will cause it to look right away once it runs out, so maybe i should make a like button or something for when i am at the bank and need the restock. this silly thing just gets more and more complicated
Just remember, some of the folks helping out have made or had hands in making fully AFK gold farmers, to kill, heal, loot, bank and go back for more. So, yeah, can be overload, but they will also give you small steps
-
Ok i am kinda confused. What are you wanting to do exatly? Are you wanting to recall to the bank, unload your stuff, restock you if needed and continue on your way? You ask for code on how to bring up a target cursor and then use it to pick a bag. I was assumeing that you wanted that as part of your setup section of your script.
I just wrote my first fully auto leather gathering script and this is the basic jest of it
;-----------------------------------------------------------------------
; stuff you need to set to make script work RIGHT
;-----------------------------------------------------------------------
Set %beatle MAGK ; Id of your beetle
set %beatlepack UTFSZMD ; pack inside of beetle
set %lootbag RHIJJND ; bag inside your backpack for loot
set %resourcebox CZANLMD ; ID of secure within reach of homerune
set %heavyshit JJG_sto_pof_guf ; items you want moved to the beetle
set %dropspot_runebookid ZFUEBRD ; default runebook for drop location
set %hunted_runebookid BYLKBRD ; default runebook for dungeon
set %magery false ; true = recall false = sacred journey
set %healspell 202 ; 28 = greater heal, 3 = Heal, 202 = Close Wounds
set %loot JJG_OZF_DEG_rwf_guf_sto_pof_TTO_GMF_OKF ; stuff you want to loot
set %the_hunted ih_FE_AE_uf_QE_AF_ye_XE_DF_CD_RGB_PGB_SGB_JD_gb ; critters to kill
set %Evade_Critters ye_XE_DF_CD
;--------------------------------------------------------------------
set %knives CNF_GMH ; tools use to cut corpses dagger_skinning knife_
set %VSwait 5 ; very short wait
set %MSwait 10 ; medium wait
set %LSwait 15 ; long wait
gosub setup
gosub Define_rail
gosub steed setup
;------------------------------
;Main loop
;------------------------------
start:
gosub weightcheck
gosub recall_to_spot %dropspot_runebookid
gosub positionpacks
gosub unloadall
gosub recall_to_spot %hunted_runebookid
gosub positionpacks
gosub enter_level_1
if %menu_check = start
{
for %i 1 %endspot
{
gosub remount
gosub check_health
gosub menu_check
set %oldcharposx #charposx
set %oldcharposy #charposy
set %oldcharposz #charposz
set %x %x . %i
set %y %y . %i
set %z %z . %i
gosub Weightcheck
gosub moveto_spot %x %y %z %oldcharposx %oldcharposy
set %enemyfound false
repeat
{
gosub kill
}
until %enemyfound = false
set %corpsefound false
repeat
{
gosub findcorpse
gosub moveto_spot %x %y %z %oldcharposx %oldcharposy
gosub check_health
gosub kill
}
until %corpsefound = false
}
gosub leave_level_1
goto start
that is just the main loop, I have 21 other subs that handle the auto killing, moving, checking health, weight, mana, when to recall to unload, when to restock..... The list goes on.
this is the restock sub
Sub Supply_check
Finditem RWF C_ , #backpackid ; this is arrows
if #FINDSTACK < 100
{
set %tograb 300 - #FINDSTACK
set #lobjectid %resourcebox
wait %vSwait
event macro 17 0
wait %vSwait
contpos 0 0
wait %vSwait
Finditem RWF C_ , %resourcebox
IF #FINDSTACK >= %tograb
{
exevent drag #findid %tograb
exevent dropc #backpackid
wait %MSwait
}
Else
{
event exmsg #charid 3 70 Out of arrows
halt
}
}
finditem ZLF C_ , #backpackid ; this is bandaids
if #findstack < 25
{
set %tograb 100 - #FINDSTACK
set #lobjectid %resourcebox
wait %vSwait
event macro 17 0
wait %vSwait
contpos 0 0
wait %vSwait
Finditem ZLF C_ , %resourcebox
IF #FINDSTACK >= %tograb
{
exevent drag #findid %tograb
exevent dropc #backpackid
wait %MSwait
}
Else
{
event exmsg #charid 3 70 Out of arrows
halt
}
}
return
As you can see in that sub, i search my pack for arrows and then if the amount of arrows are lower than 100 it will restock me back to 300 arrows. The same goes with the bandaids. You just need to make sure you have enough on you to make a complete round between what you are doing and your recalling to the bank.
The restocking code above is about the best I have come up with so it should give you a good start on how its done.
-
well what i am doing now is learning different commands. but ultimately i want to make a healing script like TM's but i also want it to heal pets and maybe have a consicrate option
-
ok here is the restocker. but i set up the supply bag threw targeting int he initial setup when starting up script. i am not sure how to call upon it later in this sub
;------Restocker-(Kind-Of)----------------
;----------------------------------
;%1 Type or ID of the item to restock
;%2 the amount to grab
;%3 the container to grab from
;%4 the container to drop to
Sub Restock CLF 100 (Here is the problem can i put "#lobjectid %secure" here?) GQJTJMD <---- LOOK AT THIS LINE!!!
Finditem %1 C_ , %3
if #findkind = 0 && #findstack >= %2
{
exevent drag #findid %2
exevent dropc %4
wait 10
return true
}
event exmsg #charid 3 0 You do not have enough of that item.
return false
-
Well, first of all, you dont want to post any ids, or use ids in code that you make public, they are character specific (traceable to those that know how (UO)) Anyways,
gosub restock CLF 100 %secure_id %drop_container_id
then in your code you posted, you would just have...
Sub Restock
nothing is after it. You will pass the parameters when calling the sub, as above with the gosub line. this is how it is useful because later on you can call sub again, for different items and containers
gosub restock POF 1000000 %you %me
That would call your restock sub, take 1million gold from you and drop it to me
Another thing, after your exevent drag, you need a wait of atleast 10 in there
-
My big problem is setting up my resource bag so that it ask for it in the begining of the script and then will call it back when it is time to use it for the restock. this is my code so far i understand it needs a bunch of work yet, but i dont feel i can move on till this gets figured out. here is my script as of now
;========================================
;Name: XxCaptainxX's Heal & Warn
;Author: XxCaptainxX
;Version: What comes befor beta? Smiley
;========================================
set %fullheal You_finish_applying_the
set %retry You_apply_the_bandages
set %lilheal You_heal_what_little_damage_your
set %tryagain That_being_is_not_damaged
set %wait You_must_wait_to_perform_another_action
gosub setsecure
mainloop:
gosub counter
gosub check
gosub heal
gosub restock
goto mainloop
;-------Set-up-secure-pack---------------
sub setsecure
display yesno Are you using your bank?$
if #dispRes = yes
{
nextCPos 25 500
msg Bank$
wait %short_delay
}
display OK Please target your supply container.$
wait %short_delay
set #targcurs 1
wait %short_delay
WaitTarget:
if #targcurs = 0
{
set %resourcebox #ltargetid
return
}
goto WaitTarget
return
;-------Counter-(Crosses-Fingers)--------
sub counter
finditem ZLF C_ , #backpackid
if #findkind = 0 && #findstack <= 20
EVENT ExMsg #charID 3 33 You are Low on bandaids!
if #findkind = -1
event exmsg #charid 3 33 You are out of bandaids!
return
;-------Checker-(Maybe)------------------
sub check
If #hits < #maxHits
{
return #true
}
return #false
;-------Heal-(hopefully)-----------------
sub heal
if #result #true
finditem ZLF c_ , #backpackid
{
if #findkind = 0 ; -1 not found, 0 in a container, 1 on the ground
{
set #lobjectId #findId
event macro 17
target 5s
event macro 23
repeat
{
wait 0
}
until %fullheal in #sysmsg || %lilheal in #sysmsg || %retry in #sysmsg || %tryagain in #sysmsg || %wait in #sysMsg
}
return
;------Restocker-(Kind-Of)----------------
Sub restock
finditem ZLF C_ , #backpackid ; this is bandaids
if #findstack < 25
{
set %tograb 100 - #FINDSTACK
set #lobjectid %resourcebox
wait %vSwait
event macro 17 0
wait %vSwait
contpos 0 0
wait %vSwait
Finditem ZLF C_ , %resourcebox
IF #FINDSTACK >= %tograb
{
exevent drag #findid %tograb
exevent dropc #backpackid
wait %MSwait
}
}
return
if i do the restock with my personal resource bag ID setup in it it works fine so i know it is just a problem of recalling my initial setup
p.s. be at the bank when you initialy start this up and have a bag with aids in it.
-
;-------Set-up-secure-pack---------------
sub setsecure
display yesno Are you using your bank?$
if #dispRes = yes
{
nextCPos 25 500
msg Bank$
wait %short_delay
}
display OK Please target your supply container.
wait %short_delay
set #targcurs 1
target
while #targcurs = 1
wait 0
set %resourcebox #ltargetid
return
Ok, try having your secure sub to this. Sorry I couldn't test anything, but, this should set it. I'm pressed on time, just about ready to leave for work, hope this helps then later someone else hopefully can help.
Also, when using display you do not need a "$" at the end of the line like you do when using msg to say something.
-
that didn't change anything it still won't open the bag and restock bandages... this is really fustrating me :(
-
Ok, so lets take a look at this restock sub... and I'm looking at it on the fly, as I am posting it...
;------Restocker-(Kind-Of)----------------
Sub restock
finditem ZLF C_ , #backpackid ; this is bandaids
if #findstack < 25
{
set %tograb 100 - #FINDSTACK
set #lobjectid %resourcebox
wait %vSwait <---------- where are these defined?
event macro 17 0
wait %vSwait
contpos 0 0
wait %vSwait
Finditem ZLF C_ , %resourcebox
IF #FINDSTACK >= %tograb
{
exevent drag #findid %tograb
; WAIT SOMETHING HERE <--------------
exevent dropc #backpackid
wait %MSwait
}
}
return
And I just now see something, all of these waits, where are they defined? If there's no waits defined, then, well, of course it's not restocking.
Couple of other things, code is code, can look close to others.. some the heal checks and such looks close to Tidus' (Why call it snow when I see Tidus posting it) Leather Farmer. Which uses something else that someone suggested (I want to say TrailMyx with the sys msg items to check for certain bandage notices). All is fine and dandy, we are in debug, and we all have to learn things, just make sure when starting to release if you get there, that we give credit where it's due... guess I'll check this again in morning see if anything helped.
-
but if you pull the restock sub all by it self and hard define what resource bag you want to use it works fine so i don't think it is a timing issue.
-
did you try the change to setting up the resource box that I listed? I'm just wondering.
-
Couple of other things, code is code, can look close to others.. some the heal checks and such looks close to Tidus' (Why call it snow when I see Tidus posting it) Leather Farmer. Which uses something else that someone suggested (I want to say TrailMyx with the sys msg items to check for certain bandage notices). All is fine and dandy, we are in debug, and we all have to learn things, just make sure when starting to release if you get there, that we give credit where it's due... guess I'll check this again in morning see if anything helped.
When it comes to the name Snow... it is because that is where all my first coding came about. I was known as snow to my guild and that is the only people i wrote scripts for. later as i moved to different shards and played different chars i became known as tidus. So i kept the name snow for purposes of scripting even though my name on forums change.
On the sys messages i did write myself and was later edited in a script i saw with someone else. I have those in some "private" scripts i have. I gave them to him earlier in this debug. Rightfully i can say that i may have picked up some things early on in my scripting career from EUO but however i do not remember the source.
With the restocker. Check out the spined leather farmer and you will see my sub Stock. I took this from XII and OMG's Miner and revamped it for bandages. Any questions let me know. :)
-
yes i changed them to 10 just for testing purposes
-
this is the restocker code alone and of course i have it hard set to my resource bag here. why will it not read the set i have in the script?
Restocker works like this..
set %resourcebox huyslmd
finditem ZLF C_ , #backpackid ; this is bandaids
if #findstack < 25
{
set %tograb 100 - #FINDSTACK
set #lobjectid %resourcebox
wait 10
event macro 17 0
wait 10
contpos 0 0
wait %vSwait
Finditem ZLF C_ , %resourcebox
IF #FINDSTACK >= %tograb
{
exevent drag #findid %tograb
exevent dropc #backpackid
wait 5
}
}
return
This is the code to set up the resourcebox.. is there something wrong in here?
display yesno Are you using your bank?$
if #dispRes = yes
{
nextCPos 25 500
msg Bank
wait %short_delay
}
display OK Please target your supply container.
wait %short_delay
set #targcurs 1
target
while #targcurs = 1
wait 0
set %resourcebox #ltargetid
return
did a syntax check and not sure what this means
Method count: 55
Command count: 55
*** Pass 1 - Label accounting:
*** Error - Braces not balanced. Imbalanced by: 1
Subroutine labels = 5
Tag labels = 1
7 Code block(s).
0 Warnings(s) encountered.
*** Pass 2 - Execution [SYNTAXCHECK]
1 Error(s) encountered.
-
***EDITED***
Okay here is my Stocking sub out of the leather script. Modified for your use though.
sub Stock
_opensecure:
if %banking = yes
{
event macro 1 0 Bank
wait 5
}
finditem %bandies C_ , #backpackid
if #findstack <= 3
{
set %amount ( 100 - #findstack )
set #lobjectid %container
event macro 17 0
wait 10
finditem %bandies C_ , %container
if #findkind = -1
{
display You are out of bandies and have no way to heal. Get some more bandies and start over.
halt
}
exevent drag #findid %amount
wait 5
exevent dropc #backpackid
}
}
wait 10
gosub TM_TravelFromRuneBook %travel %currentposition %currentposition %yourrunebook
Return
The main thing about this in comparison to yours, is wait times and your drag and drop.
Basically I'm searching my backpack. Then i search for my container. Then search for the items needed in container. Then i drag and drop items in container.
Also to help with your set %tograb 100 - #findstack i would make it like this set %togram ( 100 - #findstack ) basically you are telling to do the equation first then make it set to %tograb
and this is how i would get my bank setup
Display yesno Are you at Bank?
if #dispRes = yes
{
set %banking yes
event macro 1 0 Bank
wait 5
if #conttype = IKF
set %container #contid
}
if #dispRes = no
{
set %banking no
set #targcurs 1
target
while #targcurs = 1
wait 0
set %container #ltargetid
}
-
out of curiostity does it work for you, unfortunetly it is not working for me.
-
i am not sure, because i am at work. i had to write the code and edit it from there. Another problem you have to remember.. we don't know what freeshard you play. We don't know the mechanics of it. So it just might not work the way we think it should.
-
i am thinking that the rule are aprox the same since everything i have gotten from the site has worked great... there is no speacial super anything on the server just like osi