Having trouble with me new spellbook filler script.

[Citrus82]

Edit: I rebuilt the click subs and a few others in a different way and they're fixed now, and my script just filled its first spell book, it still has a few minor bugs to tweak, but i'm good to go at the moment, please disregard the post below, thanks.

I was building a script that fills a spellbook, the way it is suppose to work is, you have one container that hold your reg, blank scrolls, and empty spellbooks, and a optional container that has pre-made spell scrolls. If you have the optional bag of pre-made scrolls it will search for the current spell in that bag, if it find the scroll it drops it in the book, if not it makes the scroll and drops it in the book.

The problem is it gets screwed up when it tries to craft scrolls, it's like the click coordinates are off, but i tested them separately and they work fine. Sorry about my shoddy scripting skills, please don't poke fun.

Code: [Select]

set %use_scroll_bag 1
set %scrollspot 1
set %spellbooks MPF
set %pen PBG
;==================================================
set %blank_scrolls DPF
set %black_pearl KUF
set %blood_moss JUF
set %garlic KZF
set %ginseng JZF
set %mandrake_root MZF
set %nightshade WZF
set %spiders_silk RZF
set %sulfurous_ash SZF
;==================================================
;==================================================
gosub reg_box
goSub bag_o_scrolls_check
gosub spellbook
gosub current_scroll
main:
gosub search_bag
gosub drop_to_Book
goto main
;==================================================
Sub bag_o_scrolls_check
display yesno do you have a bag of scrolls you would also like to use?
if #dispRes = Yes
{
wait 10
display Please target the container of scrolls.
set #lTargetID X
set #targCurs 1
wait 2
Wait_for_container:
if #lTargetID = X
{
goto Wait_for_container
}
set %scrollbag #LTARGETID
set %use_scroll_bag 2
}
return
;==================================================
sub reg_box
display Please target the container with the reagents in it.
set #lTargetID X
set #targCurs 1
wait 2
Wait_for_reagents:
if #lTargetID = X
{
goto Wait_for_reagents
}
set %reg_box #ltargetid
}
return
;==================================================
sub spellbook
finditem %spellbooks C_ , %reg_box
if #FINDCNT < 1
{
display no spellbook found in the reagent box.
halt
}
set %current_book #FINDID
Exevent drag %current_book #FINDSTACK
wait 10
Exevent Dropc #backpackid
wait 10
return
;==================================================
sub current_scroll
gosub scroll_ . %scrollspot
return
;==================================================
sub search_bag
if %use_scroll_bag = 1
{
return
}
finditem %scroll C_ , %scrollbag
if #FINDCNT >= 1
{
Exevent drag #FINDID 1
wait 10
Exevent Dropc #backpackid
wait 20
}
return
;==================================================
sub drop_to_Book
drop_loop:
finditem %scroll C_ , #BACKPACKID
set %current_scroll #FINDID
if #FINDCNT < 1
{
gosub get_regs
gosub make_scroll
gosub mana
goto drop_loop
}
Exevent drag #FINDID #FINDSTACK
wait 10
Exevent Dropc %current_book
wait 1s
ignoreitem %current_scroll
set %scrollspot %scrollspot + 1
return
;==================================================
sub make_scroll
finditem %scroll C_ , #BACKPACKID
if #FINDCNT >= 1
{
return
}
finditem %pen C_ , #BACKPACKID
set #LOBJECTID #FINDID
event macro 17 0
gosub current_scroll
set %x_circle #CONTPOSX + 25
set %x_spot #CONTPOSX + 230
wait 10
click %x_circle %circle
wait 10
click %x_spot %spot
wait 2s
return
;==================================================
sub mana
if ( %scrollspot > 0 ) && ( %scrollspot < 9 )
set %mana 4
if ( %scrollspot > 8 ) && ( %scrollspot < 17 )
set %mana 6
if ( %scrollspot > 16 ) && ( %scrollspot < 25 )
set %mana 9
if ( %scrollspot > 24 ) && ( %scrollspot < 33 )
set %mana 11
if ( %scrollspot > 32 ) && ( %scrollspot < 41 )
set %mana 14
if ( %scrollspot > 40 ) && ( %scrollspot < 49 )
set %mana 20
if ( %scrollspot > 48 ) && ( %scrollspot < 57 )
set %mana 40
if ( %scrollspot > 56 ) && ( %scrollspot < 65 )
set %mana 50
if #MANA < %mana
{
event Macro 13 46
repeat
until #MANA = #MAXMANA
}
return
;==================================================
sub get_regs
Finditem %black_pearl C_ , #BACKPACKID
set %this 5
if #FINDSTACK < 5
{
set %temp_stack ( %this - #FINDSTACK )
Finditem %black_pearl C_ , %reg_box
wait 10
Exevent drag #FINDID %temp_stack
wait 10
Exevent Dropc #BACKPACKID
wait 10
}
Finditem %blood_moss C_ , #BACKPACKID
set %this 5
if #FINDSTACK < 5
{
set %temp_stack ( %this - #FINDSTACK )
Finditem %blood_moss C_ , %reg_box
wait 10
Exevent drag #FINDID %temp_stack
wait 10
Exevent Dropc #BACKPACKID
wait 10
}
Finditem %garlic C_ , #BACKPACKID
set %this 5
if #FINDSTACK < 5
{
set %temp_stack ( %this - #FINDSTACK )
Finditem %garlic C_ , %reg_box
wait 10
Exevent drag #FINDID %temp_stack
wait 10
Exevent Dropc #BACKPACKID
wait 10
}
Finditem %ginseng C_ , #BACKPACKID
set %this 5
if #FINDSTACK < 5
{
set %temp_stack ( %this - #FINDSTACK )
Finditem %ginseng C_ , %reg_box
wait 10
Exevent drag #FINDID %temp_stack
wait 10
Exevent Dropc #BACKPACKID
wait 10
}
Finditem %mandrake_root C_ , #BACKPACKID
set %this 5
if #FINDSTACK < 5
{
set %temp_stack ( %this - #FINDSTACK )
Finditem %mandrake_root C_ , %reg_box
wait 10
Exevent drag #FINDID %temp_stack
wait 10
Exevent Dropc #BACKPACKID
wait 10
}
Finditem %nightshade C_ , #BACKPACKID
set %this 5
if #FINDSTACK < 5
{
set %temp_stack ( %this - #FINDSTACK )
Finditem %nightshade C_ , %reg_box
wait 10
Exevent drag #FINDID %temp_stack
wait 10
Exevent Dropc #BACKPACKID
wait 10
}
Finditem %spiders_silk C_ , #BACKPACKID
set %this 5
if #FINDSTACK < 5
{
set %temp_stack ( %this - #FINDSTACK )
Finditem %spiders_silk C_ , %reg_box
wait 10
Exevent drag #FINDID %temp_stack
wait 10
Exevent Dropc #BACKPACKID
wait 10
}
Finditem %sulfurous_ash C_ , #BACKPACKID
set %this 5
if #FINDSTACK < 5
{
set %temp_stack ( %this - #FINDSTACK )
Finditem %sulfurous_ash C_ , %reg_box
wait 10
Exevent drag #FINDID %temp_stack
wait 10
Exevent Dropc #BACKPACKID
wait 10
}
Finditem %blank_scrolls C_ , #BACKPACKID
set %this 5
if #FINDSTACK < 5
{
set %temp_stack ( %this - #FINDSTACK )
Finditem %blank_scrolls C_ , %reg_box
wait 10
Exevent drag #FINDID %temp_stack
wait 10
Exevent Dropc #BACKPACKID
wait 10
}
return
;==================================================
sub scroll_1
set %scroll NXL
set %circle #contposy + 90
set %spot #contposy + 69
return

sub scroll_2
set %scroll QXL
set %circle #contposy + 92
set %spot #contposy + 90
return

sub scroll_3
set %scroll PXL
set %circle #contposy + 92
set %spot #contposy + 110
return

sub scroll_4
set %scroll AYL
set %circle #contposy + 92
set %spot #contposy + 130
return

sub scroll_5
set %scroll ZXL
set %circle #contposy + 92
set %spot #contposy + 151
return

sub scroll_6
set %scroll CYL
set %circle #contposy + 92
set %spot #contposy + 171
return

sub scroll_7
set %scroll BYL
set %circle #contposy + 92
set %spot #contposy + 190
return

sub scroll_8
set %scroll WXL
set %circle #contposy + 92
set %spot #contposy + 210
return

sub scroll_9
set %scroll VXL
set %circle #contposy + 109
set %spot #contposy + 69
return

sub scroll_10
set %scroll YXL
set %circle #contposy + 109
set %spot #contposy + 90
return

sub scroll_11
set %scroll XXL
set %circle #contposy + 109
set %spot #contposy + 110
return

sub scroll_12
set %scroll IYL
set %circle #contposy + 109
set %spot #contposy + 130
return

sub scroll_13
set %scroll HYL
set %circle #contposy + 109
set %spot #contposy + 151
return

sub scroll_14
set %scroll KYL
set %circle #contposy + 109
set %spot #contposy + 171
return

sub scroll_15
set %scroll JYL
set %circle #contposy + 109
set %spot #contposy + 190
return

sub scroll_16
set %scroll EYL
set %circle #contposy + 109
set %spot #contposy + 210
return

sub scroll_17
set %scroll DYL
set %circle #contposy + 129
set %spot #contposy + 69
return

sub scroll_18
set %scroll GYL
set %circle #contposy + 129
set %spot #contposy + 90
return

sub scroll_19
set %scroll FYL
set %circle #contposy + 129
set %spot #contposy + 110
return

sub scroll_20
set %scroll STL
set %circle #contposy + 129
set %spot #contposy + 130
return

sub scroll_21
set %scroll RTL
set %circle #contposy + 129
set %spot #contposy + 151
return

sub scroll_22
set %scroll UTL
set %circle #contposy + 129
set %spot #contposy + 171
return

sub scroll_23
set %scroll TTL
set %circle #contposy + 129
set %spot #contposy + 190
return

sub scroll_24
set %scroll OTL
set %circle #contposy + 129
set %spot #contposy + 210
return

sub scroll_25
set %scroll NTL
set %circle #contposy + 151
set %spot #contposy + 69
return

sub scroll_26
set %scroll QTL
set %circle #contposy + 151
set %spot #contposy + 90
return

sub scroll_27
set %scroll PTL
set %circle #contposy + 151
set %spot #contposy + 110
return

sub scroll_28
set %scroll AUL
set %circle #contposy + 151
set %spot #contposy + 130
return

sub scroll_29
set %scroll ZTL
set %circle #contposy + 151
set %spot #contposy + 151
return

sub scroll_30
set %scroll CUL
set %circle #contposy + 151
set %spot #contposy + 171
return

sub scroll_31
set %scroll BUL
set %circle #contposy + 151
set %spot #contposy + 190
return

sub scroll_32
set %scroll WTL
set %circle #contposy + 151
set %spot #contposy + 210
return

sub scroll_33
set %scroll VTL
set %circle #contposy + 171
set %spot #contposy + 69
return

sub scroll_34
set %scroll YTL
set %circle #contposy + 171
set %spot #contposy + 90
return

sub scroll_35
set %scroll XTL
set %circle #contposy + 171
set %spot #contposy + 110
return

sub scroll_36
set %scroll IUL
set %circle #contposy + 171
set %spot #contposy + 130
return

sub scroll_37
set %scroll HUL
set %circle #contposy + 171
set %spot #contposy + 151
return

sub scroll_38
set %scroll KUL
set %circle #contposy + 171
set %spot #contposy + 171
return

sub scroll_39
set %scroll JUL
set %circle #contposy + 171
set %spot #contposy + 190
return

sub scroll_40
set %scroll EUL
set %circle #contposy + 171
set %spot #contposy + 210
return

sub scroll_41
set %scroll DUL
set %circle #contposy + 190
set %spot #contposy + 69
return

sub scroll_42
set %scroll GUL
set %circle #contposy + 190
set %spot #contposy + 90
return

sub scroll_43
set %scroll FUL
set %circle #contposy + 190
set %spot #contposy + 110
return

sub scroll_44
set %scroll QUL
set %circle #contposy + 190
set %spot #contposy + 130
return

sub scroll_45
set %scroll PUL
set %circle #contposy + 190
set %spot #contposy + 151
return

sub scroll_46
set %scroll SUL
set %circle #contposy + 190
set %spot #contposy + 171
return

sub scroll_47
set %scroll RUL
set %circle #contposy + 190
set %spot #contposy + 190
return

sub scroll_48
set %scroll MUL
set %circle #contposy + 190
set %spot #contposy + 210
return

sub scroll_49
set %scroll LUL
set %circle #contposy + 210
set %spot #contposy + 69
return

sub scroll_50
set %scroll OUL
set %circle #contposy + 210
set %spot #contposy + 90
return

sub scroll_51
set %scroll NUL
set %circle #contposy + 210
set %spot #contposy + 110
return

sub scroll_52
set %scroll YUL
set %circle #contposy + 210
set %spot #contposy + 130
return

sub scroll_53
set %scroll XUL
set %circle #contposy + 210
set %spot #contposy + 151
return

sub scroll_54
set %scroll AVL
set %circle #contposy + 210
set %spot #contposy + 171
return

sub scroll_55
set %scroll ZUL
set %circle #contposy + 210
set %spot #contposy + 190
return

sub scroll_56
set %scroll UUL
set %circle #contposy + 210
set %spot #contposy + 210
return

sub scroll_57
set %scroll TUL
set %circle #contposy + 230
set %spot #contposy + 69
return

sub scroll_58
set %scroll WUL
set %circle #contposy + 230
set %spot #contposy + 90
return

sub scroll_59
set %scroll VUL
set %circle #contposy + 230
set %spot #contposy + 110
return

sub scroll_60
set %scroll GVL
set %circle #contposy + 230
set %spot #contposy + 130
return

sub scroll_61
set %scroll FVL
set %circle #contposy + 230
set %spot #contposy + 151
return

sub scroll_62
set %scroll IVL
set %circle #contposy + 230
set %spot #contposy + 171
return

sub scroll_63
set %scroll HVL
set %circle #contposy + 230
set %spot #contposy + 190
return

sub scroll_64
set %scroll CVL
set %circle #contposy + 230
set %spot #contposy + 210
return