ScriptUO

Official ScriptUO EasyUO Scripts => Script Library => Crafting => Topic started by: Paulonius on July 14, 2010, 11:04:23 AM

Title: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on July 14, 2010, 11:04:23 AM
This is a tailor trainer that I put together six months or so ago and forgot to post up.  There are actually two scripts you need to run side by side.  The Cutter Upper can be run in a separate window, there are no global variables. I recommend starting the cutter first, but it probably doesn't matter what order you start the scripts.  Just don't wait too long after starting the main script to start the cutter.

Script has been tested on weaver bought cloth, cut from bolts into whatever the square piles are.  Try not to feed it different colored stuff and don't leave reward cloth in your secure as it doesn't have settings to differentiate cloth types.  

I have not run this in a while. Please let me know if you run into any issues.

*Update 8/23/2010*
I updated the item progression to correct gump clicks on oil cloth thrown off by the addition of some gargoyle items.


*Update 12/05/2014*
I fixed a mistake where I had hard-coded the ID for my secure in the max weight, and increased the wait times from one twentieth of a second to half a second. I think most people never hit max weight, so it was a rare issue, but probably a show stopper. I am looking at replacing the cutter with a routine to use a recycle bag. Will post that up if I decide to put that in.

-P
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Wilk on July 30, 2010, 08:56:55 AM
Tailoring 100 to 120.

Roughly 35k cloth. No hangups Paul.

Thank you!
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: powerpig on August 21, 2010, 04:00:00 PM
This wants to create Gargish Half Aprons instead of oil cloth.
I'm assuming they changed the menu around. (I can mess with it and fix it if you want, but it currently isn't functioning the way it should)
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: 12TimesOver on August 21, 2010, 04:48:23 PM
This wants to create Gargish Half Aprons instead of oil cloth.
I'm assuming they changed the menu around. (I can mess with it and fix it if you want, but it currently isn't functioning the way it should)
Why shouldn't it make Gargish Aprons?
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: powerpig on August 21, 2010, 04:58:07 PM
The program itself is set to make oil cloth when less than 920 skill (says in the code), but when you're in that skill range, it makes gargish half aprons instead of the oil cloth
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on August 22, 2010, 07:15:40 AM
Nice catch, its because they added some garg items and I was not aware that it affected the script.  I will take a look and update it.

Oil cloth are very efficient, so I prefer that it make them as long as it can still gain skill.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: 12TimesOver on August 22, 2010, 07:20:52 AM
The program itself is set to make oil cloth when less than 920 skill (says in the code), but when you're in that skill range, it makes gargish half aprons instead of the oil cloth
Ah gotcha. Yeah I usually take oil cloths to 109.2 with a 120 scroll eaten, I didn't catch that's what you meant.

X
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: NObama on August 22, 2010, 07:02:40 PM
I must say, I chuckled at 'cutter upper.'
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: captain1989 on October 18, 2010, 02:26:33 PM
I hope this gets fixed.
However, the cutter upper still works if you just make the max by clicking your sewing kit.
What I do is I leave the cutter upper running, select oil cloth from the list, make max, and for every one that is made, it immediately cuts it.
So if you fix the code, I recommend having it make max instead of making just 1.  =]
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on October 18, 2010, 05:45:29 PM
The problem with making max is that you can't check the skill in sequence and you end up making extra stuff.  I am redirecting my efforts to translating all of my scripts into LUA for OEUO.  This script will not be maintained in UOX pending the termination of that project in the near future.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Endless Night on November 12, 2010, 08:02:45 AM
Nice script .. but i started from zero skills... so made a small addition.. as flower garlands can only be made from 10+ skill (heres the added code ) I also added the cutting function to the main script.. and other tweaks...

Code: [Select]
If #Skill < 100          ; Scull Cap  10 Skill 2 Cloth
   {
   gosub ItemZero
   gosub SetCraftGump
   Return
   }

sub ItemZero        ; Skull Cap
    Set %Threshhold 100
    Set %CurrentToolType %Sewingkit
    Set !CurrentTailorTrainingItemType %ItemZero ; CZH
    Set %CurrentResourceCnt 3
    Set %CurrentResource %Cloth
    Set %XClick1 30
    Set %YClick1 110
    Set %XClick2 230
    Set %YClick2 70
    Set %XClick3 1
    Set %YClick3 1
Return

set %ItemZero CZH
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: dante1337 on November 22, 2010, 05:06:21 AM
works fine but i dont think i have the skill tracking thing set up properly because it starts making fancy dresses or floppy hats for no reason and the cutter doesnt cut them up. Any advice on how to correct this ?

Post Merge: November 22, 2010, 06:20:48 PM
Ok so i figured out my problem. sort of. It says on the to do list make a skill tracking menu. How do i do that ? please help. thanks
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on November 23, 2010, 10:57:52 AM
I am no longer supporting this script in EUO pending conversion to OEUO.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Scrripty on January 28, 2011, 06:12:17 PM
Just used this to 120 a tailor in 3/4ths of a day.  Thanks Paul.  Great script. :)
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: pashadiv on February 04, 2011, 02:21:10 AM
Excellent!  ;D Cutter Upper FTW!
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: SnoWolf on February 05, 2011, 07:29:06 AM
Running this script from 0, seems to be working well, but when i hit around 40 skill it started making shirts and the cutter upper didn't snip em up. Easily rectified though by adding the ID to the find item line. [Figured you may want to add that in later at some point ^_^)

Heres the ID..

Shirt - FCI


I'll edit this post later if i notice any others not being cut up. =)
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gruntman on February 22, 2011, 12:58:15 PM
issue with the script timing out and me getting disconnected...any thoughts anyone please?
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Cerveza on February 22, 2011, 01:04:43 PM
Maybe some more information. What is the script doing, where does it get stuck, what messages are shown, what containers are opened, what gumps are visible, etc...

Script No-workey is difficult to troubleshoot.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on February 22, 2011, 01:17:29 PM
I am working on updating it, so if you can let me know what didn't work for you, I can add it to what I am working on.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Ultima on February 23, 2011, 07:19:46 PM
I'm gonna give this a run again. Today was a bad day in UO as I washed off my 120 Tailoring when using my soulstones. I can't count the number of times I've lost skills I've had stored in a soulstone because of my own negligence. This is probably the 5th time I've done it. Every time I tell myself it's going to be the last time. Yes Yes I know...I need to slow down. You'd think I'd learn after the first time. So this time it was tailoring...

I've used this script one time to 120 Tailoring. I ran it earlier today and my backpack ended up getting filled as it was not cutting. I think I had 30 items in my pack that didn't get cut. The problem is I have 3 other accounts running (BOD Runner) while my 4th account is training Tailoring.  I think the other scripts are interferring with the cutter and creating a conflict.

I'm going to bump up some of the wait times to see if that helps my cause at all. If not I'll just run the FaF'er and the Tailoring at the same time. That's one great thing about the FaF'er is that it really doesn't conflict with any other scripts your running...at least from my experience.

The first time I ran this script I ran into issues when it came time to create oil cloths. We'll see what happens this time around.  I'll post some more feedback after my next run. 
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on February 24, 2011, 05:38:18 AM
Sorry to hear about the screw up, but glad it will give me some more information to update this script with.  This was a pretty early attempt, so I should be able to make it a lot more refined this go-round...
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Ultima on February 25, 2011, 08:15:24 PM
I bumped the wait times up and still had issues with it filling up my pack as well as not grabbing more cloth. So I increased the waits time even more and it ran 6 hours this afternoon without a hitch. The shard I play on I ping 200 so I'm thinking that may have been one of the factors.  I also think running 3 instances of the BOD Runner also created a conflict. I changed the 3 accounts over to the FaFer and everything worked out. After successfully making it through the 6 hour tailoring session I ended with 113.8 Tailoring. One more night and I reckon I'm home free.

No issues this time around with the oil clothes.

What was happening with the back pack filling up was the Tailor Trainer was creating items faster than what the cutter upper could keep up with. I adjusted the wait times to get both scripts synchronized and working in tandem.

This really is a gem of a script. The script works just fine if it's calibrated properly depending the player's connection. Right out of the starting gate it's extremely fast. Even with my increases to the wait time it's much faster that CEO's.

And how nice is it not to have to use up any leather!  8)

Thanks a ton for submitting this and making it available to the public. It has allowed me to gain back my tailoring quickly and easily.

Both your tailoring and your blacksmithing scripts are solid. I'm don't see the need for any changes when they both work.

You know the old saying...

Mission accomplished as far I'm concerned.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on February 26, 2011, 09:08:17 AM
Hmmm. I am thinking that tracking the number of items in your pack might be a good way to determine if the timing is out of synch.  Maybe have the tailor script slow down if it detects too many items until the cutter can catch up...  I will play with the idea and see what I can do.

I am working on combining the tinker/smith/tailor scripts atm.  I want to set it up so that you can point your toon at a container, tell it what skills to train, and forget about it.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gimlet on February 26, 2011, 09:26:13 AM
Is there a command or easy way to determine the total number of items in your backpack?
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Khameleon on February 26, 2011, 09:14:19 PM
event property #backpackid
then phase out Contents ???/125?
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gimlet on February 26, 2011, 09:48:18 PM
event property #backpackid
then phase out Contents ???/125?

So - not easy?

Be nice to have a sub that does this.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on February 28, 2011, 01:29:01 PM
You can do it with two quick lines of code if you don't have any containers in your pack.

Finditem * C_ , #BackpackID
Set %BackpackItemCount #FindCnt

I suppose I could pull it off of the paperdoll backpack container with a string parse as Kham suggests. Seems like something that should have been done already somewhere... 
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: SolidSnake on February 28, 2011, 04:32:50 PM
Hmmm..this script looks good enough to actually make me think about making yet another crafter. I had been wanting to do a full blown all skills crafter on every shard. Saves me a ton of $$ since I have been character transferring whenever I needed one somewhere.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on March 01, 2011, 07:43:22 AM
Yeah, stop transferring toons around.  Craft skills are easy to train up if you start colonizing shards with resource gatherers, you can quickly have gold to get rolling. 
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gruntman on March 04, 2011, 08:53:23 PM
issue with the script """timing out""" and me getting disconnected...any thoughts anyone please?



Ok figured out issue and it was all me.. script worky nice...original issue was toon logging out after timing out as i previously stated however after some checking it was my bad....thanks again...script worked like a charm!
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: teruteru17 on April 15, 2011, 05:16:19 AM
i have a problem.
my tailor skill is 97 now. OSI shard.
stop the program at this point.

Finditem %ItemToMove C_ , %Source
If #findstack <= %QuantityToMove
   {
   Event Macro 8 3
   Wait 5
   Event exmsg #charid 3 4 You need to place more item type %ItemToMove in your Resource Secure and hit play.
   Pause
   Goto OutofResourceLoop

last line, 'Goto OutofResourceLoop' is Highlights.
help me plz :'(

(sorry, my poor English)
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on April 15, 2011, 06:28:07 AM
Your English is fine, I believe that I understood what you meant.  When the script hits a pause, it highlights the next line, so, based on your description, it appears to have failed to locate a resource it needs to continue. This could be ingots if it is trying to make a sewing kit, or it could be cloth, if it is trying to make something from cloth (hopefully gargish kilts at 97 skill).  The script should have opened your journal and given you a system message, (althought I suspect that the system message code I used may be broken).

Can you duplicate the problem?  Are you sure that you have both ingots (iron only) and cloth in your secure? I don't believe bolts work, it has to be cut cloth if I remember correctly. 
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: teruteru17 on April 15, 2011, 07:47:04 PM
THX for replying!

yes, i have lots of iron ingots and cut clothes in my secure.
and i have sewing kits and tinker tools in my backpack.

sorry, my tailor skill is 96.9 now.
hmm, i dont know what happening...
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Outlaw Josey Wales on April 15, 2011, 10:18:10 PM
have u looked at the gump size maybe differnt for your shard or run uo server
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: teruteru17 on April 16, 2011, 12:01:56 AM
trouble was gone.
i tried to raise tailor skill from 96.9 to 97 by myself.
and run this script.
theres no problem for now...
anyway... THX a LOT :D
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Hollywood_Shono on April 28, 2011, 06:12:24 AM
I used this script the other day 0-120 worked perfect... Thanks a lot!
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: alonzo104 on April 28, 2011, 10:48:03 AM
Takes about 12 hrs from 0 - 120 using nothing but cloth.  Total cloth used almost 60k.  Not to shabby.
It only happened once, but during the oil cloth time it wasn't moving the cut up bandaids out of my bag so script was hanging because it couldn't' add more cloth due to me being over max weight. 
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on April 28, 2011, 11:17:48 AM
Good feedback Alonzo.  I think I can check out the overweight check based on that info.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: alonzo104 on April 28, 2011, 02:44:37 PM
Good feedback Alonzo.  I think I can check out the overweight check based on that info.
Appreciate you looking into the issue.  I can tinker and understand code, but I cannot begin to write it.  So I like to test and give as good as feedback as I can, in order to help the pros fix and advance them.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gimlet on April 30, 2011, 07:04:29 AM
Paul

in sub setup

just before Return is a

GoSub InitTinkerGump

But this sub does not exist in the script

Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gimlet on May 03, 2011, 06:58:11 AM
I can not get this script to work - was it changed when it was updated. Hangs before ever trying to make anything. (See post above)

Anybody get this to work recently?
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on May 03, 2011, 09:24:03 AM
I clearly need to look at this one again...
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gimlet on May 03, 2011, 10:13:05 AM
I clearly need to look at this one again...

Thanks!
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on May 04, 2011, 04:21:12 AM
I am currently working on this script. 

Here is my to-do list:

1. Add a reliable verification of correct make
2. Add synch system with cutter
3. Add ROT for Siege/Mugen
4. Add scissor tink sub

Has anyone got any additional suggestions?

@Gim:  I am not sure what is happening for you.  Please download the .10 version I am posting for you on the first page and try running that for me with your journal open.  I inserted a series of system messages to track progress through the script and it should help you to isolate where the issue is cropping up for you.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gimlet on May 04, 2011, 05:27:03 AM
I will try it latter today but please note on a quick glance at the code (just downloaded)

there is no

sub InitTinkerGump

and it is called two times in script
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on May 04, 2011, 05:32:12 AM
I will pull it next time I pass through it.  It doesn't do anything since there is no sub, its a leftover remnant from the conversion from tinker to tailor trainer. 
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: 12TimesOver on May 04, 2011, 05:39:27 AM
Yo hey! Just dl'd since I'm building a new tailor at the moment I figured I might as well jump on the testing bandwagon if you need more eyes ;) I'm not too worried about everything working out the gate so no problemo. I usually use Razor but I get sick of manually loading cloth after oil cloths are done.

X
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on May 04, 2011, 07:37:55 AM
Cool cool 12.  This is one of my first scripts, so its a little buggy.  When it doesn't mis-fire, it cooks.  I am working up a tailor again and working on the script, so let me know if you have issues.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: 12TimesOver on May 04, 2011, 08:59:48 AM
K, just had a little issue.

I started at about 33 or so Tailoring. Started off making Short Pants as I would have expected. Cruised along to 35 at which time it did switch to Fur Capes. It ran fine until 40 and this is when things got odd. I don't see in your skill check section that 40 has an relevance however at 40 it switched to making Fancy Dress's. Of course the Fancy Dress item type (VQL for those that care) isn't in the Cutter Upper list so I have a backpack full of dresses - no biggie there. The question is why in the world it switched to the Fancy Dress to begin with. Haven't had a chance to look at it further yet.

X
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on May 04, 2011, 09:12:33 AM
I am not 100% sure why, but I have a solution for it that I have implimented in a couple of other craft scripts.  I will see about working refining it and putting it in here.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on May 04, 2011, 10:06:32 AM
I managed to get enough resources to start running the script again.

I am not seeing any issues making the wrong stuff, but I am seeing something wonky with the amount of resources it is pulling.  First it pulled too few, and now I am seeing a big build-up of cloth in my pack.  Pretty sure I didn't intend for it to pack around 4000 cloth while working.   Adding this to my list of stuff to fix. 

Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: 12TimesOver on May 04, 2011, 11:08:55 AM
Cool, I'm just going through some stuff on my own now. I love fixing stuff ;)

X
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gimlet on May 04, 2011, 11:27:15 AM
I'm at work - but will start on this latter
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gimlet on May 04, 2011, 01:28:29 PM
OK Paul I should have thought to put in those messages!

The problem is that my cloth is BUI and the script is looking for CUI.
Modifying your code now to see if that was the problem.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gimlet on May 04, 2011, 01:43:29 PM
OK that was the problem

needed to change

set %cloth CUI


to

set %cloth CUI_BUI


Thanks!
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gimlet on May 04, 2011, 01:51:15 PM
Now to add in your subs for ROT

Any suggestions where the best place to put it is?
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on May 05, 2011, 10:16:00 AM
I have to track down an issue in the scissor sub that makes it loop and fill your pack with scissors. Then I will stick in the ROT and repost
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gimlet on May 05, 2011, 10:23:13 AM
great!
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: 12TimesOver on May 05, 2011, 10:30:01 AM
So I'm the only one that ended up with the wierd Fancy Dress issue? That's not good lol.

I actually got inspired to attempt my hand at piecing together a tailor training script of my own; nothing to release, at most I might put it up in my Beta section. Just realizing that most of the fun for me now is writing the scripts rather than using them!

I'll still continue testing this one though, just hadn't identified why Fancy Dresses started getting made yet.

X
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Outlaw Josey Wales on May 05, 2011, 02:38:50 PM
So I'm the only one that ended up with the wierd Fancy Dress issue? That's not good lol.

I actually got inspired to attempt my hand at piecing together a tailor training script of my own; nothing to release, at most I might put it up in my Beta section. Just realizing that most of the fun for me now is writing the scripts rather than using them!

I'll still continue testing this one though, just hadn't identified why Fancy Dresses started getting made yet.

X




Okay now im worried first it was the condoms now you have gotten a fancy dress. What in the world are you planing to do with those items.  Didn t think you swung that way 12

  DUDE WHAT ARE YOU THINKING THERE ARE ENOUGH WOMAN OUT THERE THAT WILL MAKE YOU HAPPY YOU DONT HAVE TO DRESS IN FANCY DRESSES AND GIVE OUT CONDOMS FOR US TO LIKE YOU




HEHEHE I COULDN T RESIST
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: alonzo104 on May 06, 2011, 11:28:33 AM
So I'm the only one that ended up with the wierd Fancy Dress issue? That's not good lol.

I actually got inspired to attempt my hand at piecing together a tailor training script of my own; nothing to release, at most I might put it up in my Beta section. Just realizing that most of the fun for me now is writing the scripts rather than using them!

I'll still continue testing this one though, just hadn't identified why Fancy Dresses started getting made yet.

X

I 120'd 2 tailors with almost the exact same time and amount of resources used as I mentioned in my earlier post.  At no point in time did I have an issue with it making un-wanted items.  I did however have an issue with the amount of cloth pulled, and the dumping of cut oilcloth bandys.  But only on the first time running it, the second time it ran fine w/o any issues.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: 12TimesOver on May 06, 2011, 11:39:04 AM
Thx for the feedback alonzo. I see in your earlier post that you started at 0 and went to 120 so I'll assume you were running the script at the same skill level (40) that switched to fancy dresses for me.

I'll focus more on my own setup to see if I can figure out what went wrong. I suspect it was a lag issue or something when switching between a couple of menu's; won't surprise me if the Fancy Dress is the same Y coordinate or something.

X
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on May 06, 2011, 11:41:59 AM
Hold off 12.  I have a process put together to detect make errors and correct them.  As soon as I fix the scissor sub I will put that process in and repost it. 
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on May 07, 2011, 12:25:55 PM
I updated the script to include ROT timer, fixed the scissors sub, but did not impliment the fancy dress fix.  I think I have to put the cut process back into the main script to address this issue in a reasonable manner.  This will cost some speed, but is probably the best solution as otherwise the recycle process will require significant retooling. This will also put the structure back in line with the other craft scripts, which will serve some of my other goals as well.

In any case, I still have some work to do on this script:

Two immediate priorities appear to be:

Fix the Fancy Dress issue
Fix the weight/load process
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gimlet on May 07, 2011, 01:06:55 PM
Soon as i get a Tailor ps i'll do some testing on seige
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on May 09, 2011, 03:51:23 AM
I reposted with a retooling of the load / weight monitor process.  I actually changed a lot of the script to line it up with my other craft scripts, but most of this should not be noticeable in the run process.  I found a bunch of coding issues that I was able to correct. 

Next mod will be to bring the cut process back into the main script for the Fancy Dress fix. I hate to give up speed, but stability is more important in a craft script.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gimlet on May 09, 2011, 04:05:29 AM
Paul - Thanks i'll try and give ya feed back soon.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gimlet on May 09, 2011, 04:08:25 AM
Thought i might mention - i use your cutter upper (change tool and target) for all my crafting needs. It works great with carpentry!
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on May 09, 2011, 04:34:10 AM
I found an error that causes a loop in the version you downloaded Gim.  Reposting now.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gimlet on May 09, 2011, 07:41:55 AM
k thanks!
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: 12TimesOver on May 09, 2011, 08:36:59 AM
I was inspired by yours Paulo and have decided to try writing my own which, of course, has gotten me off track and back on my standard Crafter sub which is now coming along wonderfully! Of course I'm still 40.6 Tailoring on Pac now, a week later, but I'm having more fun creating the craft sub!

So you're thinking that the Fancy Dress issue was related to the Cutter script?

TBH, I don't think you'll lose that much time with the cutter being a called sub in the tailor script. You don't need to wait for the sewing gump to come back for the call to the cutter sub to kick in and then it's a quick use of scissors and a target and back to "Make Last". I think the stability will be well worth it! In my "ClickNWait" sub (in conjunction with my GumpWait sub) you send it a #TRUE if you want it to wait for the gump to return and a #FALSE if you want to continue forward processing the script without waiting; pretty handy to do things that way. If I remember correctly TM's do the same thing.

X
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: daemonsdiablo on June 22, 2011, 11:47:32 AM
120 in 7 hours, one hangup but a restart fixed it. Thanks PAul
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: slackermandan on July 23, 2011, 04:10:56 PM
The script will make a few of the item for my skill level (116.1) and then goes to the outofresources sub. I have plenty of cloth, ingots, some sewing kits, and a tinker kit all in my pack. My cloth is CUI type. Any suggestions? This is the only script I can find that uses cloth from 115-120! Thanks for all the hard work, hope you have a suggestion for what to do :D
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Masscre on July 25, 2011, 03:38:36 PM
Slacker are you playing OSI or a free shard?
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: slackermandan on July 27, 2011, 01:03:53 PM
OSI shard. I ended up 120ing it by hand in the end. Sorry if the script is for free shards and I missed that somewhere, I just wanted to report the only issues I ran into with it! Thanks to all for the great work on the script :D
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Tidus on September 06, 2011, 07:05:42 AM
So just want to post my problem.  It keeps getting stuck at the gosub of outofrrsources when it looks to move something. Not sure if it is because of the speed it goes through the bumps but I really started having this problem at oil cloths. It will make about 3o oil cloths before it does this.

Let me know if you need more info.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Tidus on September 11, 2011, 05:10:29 PM
So i believe i just figured it out.  You have it as:
Code: [Select]
If #Weight > #Maxweight - 100
   {
   Repeat
   Finditem ZLF C_ , #BackpackID
   Gosub MoveResources ZLF #FindStack #BackpackID RLZZAND
   Finditem ZLF C_ , #BackpackID
   Until #FindCnt = 0
   }

Instead of

Code: [Select]
If #Weight > #Maxweight
   {
   Repeat
   Finditem ZLF C_ , #BackpackID
   Gosub MoveResources ZLF #FindStack #BackpackID %ResourceSecure
   Finditem ZLF C_ , #BackpackID
   Until #FindCnt = 0
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: SolidSnake on October 13, 2011, 05:40:23 PM
The base issue causing this problem, which I had as well, is actually the cutter speed. It was causing the "must wait for" action. That then threw the tailor script into a fit and it stopped seeing the resources in your pack.

I changed the line 23:3 wait on the cutter to 40 from 35 and poof..issue resolved.

A question; Why is this not based on using a salvage bag? It grabs what is needed and throws it into a salvage bag. BingBangBoom....That would eliminate the need for the cutter..wouldn't it?
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on October 14, 2011, 03:54:12 AM
That's a good point.  All of my craft scripts need a re-write, maybe I could make them all recycle bag dependent.  If I made ten or fifteen items and then triggered the bag, it would be a time saver that should not cause problems.  Maybe base the items made on the weight of the item being made or something like that.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: SolidSnake on October 14, 2011, 04:42:27 AM
I think it would be a good thing brother..
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: jockles on October 23, 2011, 10:42:51 PM
Tidus after playing around with the script having the same problem i noticed that if i had only like 600 cloth and a few hundred bolts in the resource bag it would always say out of resources so i bought a few hundred more bolts and cut em up and made sure i had a few thousand cloth there it worked better. seems like if it cant grab 1000+ cloth at a time it goes to out of resources. not sure if it cuts bolts like it suppose to yet.

Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: tinsilftw on September 07, 2012, 05:26:57 PM
You do not know how happy this script makes me. Thank you so much for all your work!  ;D ;D ;D
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Paulonius on September 10, 2012, 06:05:55 AM
Glad you found it useful. Let me know if you run into issues. I am slowly getting back into scripting after a hiatus and will be looking to update some of my scripts that have become broken.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: alonzo104 on January 01, 2013, 12:32:07 PM
Script worked fine yet again.  Took about 10 hours, 50-120.  Didnt count the amount of cloth it used, but it was a hefty amount.

Only issue, from like 100-110/115 it kept pulling way to much cloth.  It'd pull 1000, then 1000, then 2000!  So then i'd be so over loaded it couldn't do anything. Only happened a couple of times, and restarting the script fixed it.  I think it was because UO was lagging and messing up the pull.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Puebles on January 30, 2013, 03:59:32 PM
Two problems so far. Tried to train from 0. Got stuck at 20 skill. Says that i do not have the skill that that the macro is trying too create ate that skill. Trained the skill up at tailor shop. Stuck at 50. Backpack was full. Script no longer cut the items.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Crisis on December 29, 2013, 08:29:44 AM
Just an update to others, this script still works like a champ. If you are too lazy to buy your skill to 30 like I am, you will need to change the script to make the flower garlnds to 25 instead of 20. It gets stuck at 20 because the short pants can't be made till 24.8 skill.

Change this line from:

Code: [Select]
If #Skill < 200          ; Flower Garland 10 Skill 5 Cloth
to

Code: [Select]
If #Skill < 250          ; Flower Garland 10 Skill 5 Cloth
and this line from:

Code: [Select]
Set %Threshhold 200
to

Code: [Select]
Set %Threshhold 250
I also had to use tidus fix that he posted earlier because I got stuck at 97.6 because it couldn't find ZLF which is the bandages. So like he said, change this line:

Code: [Select]
If #Weight > #Maxweight - 100
to

Code: [Select]
If #Weight > #Maxweight
I highly recommend using his Textile Sweatshop script http://www.scriptuo.com/index.php?topic=7567.0 (http://www.scriptuo.com/index.php?topic=7567.0) to make the cloth. Your training will be as cheap as it gets!
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: bendel on February 21, 2014, 09:59:38 AM
So i believe i just figured it out.  You have it as:
Code: [Select]
If #Weight > #Maxweight - 100
   {
   Repeat
   Finditem ZLF C_ , #BackpackID
   Gosub MoveResources ZLF #FindStack #BackpackID RLZZAND
   Finditem ZLF C_ , #BackpackID
   Until #FindCnt = 0
   }

Instead of

Code: [Select]
If #Weight > #Maxweight
   {
   Repeat
   Finditem ZLF C_ , #BackpackID
   Gosub MoveResources ZLF #FindStack #BackpackID %ResourceSecure
   Finditem ZLF C_ , #BackpackID
   Until #FindCnt = 0

Thanks tidus,  this just solve my problem :)
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: juvi on March 02, 2014, 05:30:39 PM
love the script nice and easy
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Hoby on May 06, 2014, 07:37:58 PM
been running this lately with some issues.  Had the fancy dress thing happen a few times, i think its lag related 12x.  Slowed down the click times to 1/2 a sec at the bottom of the script seems pretty stable after that.  I was having issues with it pulling weird random amounts of cloth, sometimes one, sometimes none, sometimes like 4000k!! 
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: tgambit65 on October 05, 2014, 05:43:09 PM
Thanks Man! Works great after that change. And Thanks to Paulonius for the script to begin with!


So i believe i just figured it out.  You have it as:
Code: [Select]
If #Weight > #Maxweight - 100
   {
   Repeat
   Finditem ZLF C_ , #BackpackID
   Gosub MoveResources ZLF #FindStack #BackpackID RLZZAND
   Finditem ZLF C_ , #BackpackID
   Until #FindCnt = 0
   }

Instead of

Code: [Select]
If #Weight > #Maxweight
   {
   Repeat
   Finditem ZLF C_ , #BackpackID
   Gosub MoveResources ZLF #FindStack #BackpackID %ResourceSecure
   Finditem ZLF C_ , #BackpackID
   Until #FindCnt = 0
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: zankin on December 11, 2014, 08:00:09 AM
I had tried using CEO's tailoring script, but it was turning into just a mess.  So far this one is working great, thank you so much!
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: retnuh on February 20, 2015, 07:45:48 AM
So I used this script sometime back before I quit playing UO the last time. Decided to hunt it down again for the new OSI shard I'm playing on. I started from zero and followed the instructions in the posts to change the skill levels on flower garland. After that everything seem to be working good at first, But then it continued to get stuck on out of resources ZLF. I then came back to the posts and continued to read and someone had posted a similar issue with changing the code from

If #Weight > #Maxweight - 100
   {
   Repeat
   Finditem ZLF C_ , #BackpackID
   Gosub MoveResources ZLF #FindStack #BackpackID RLZZAND
   Finditem ZLF C_ , #BackpackID
   Until #FindCnt = 0
   }


To this code

If #Weight > #Maxweight
   {
   Repeat
   Finditem ZLF C_ , #BackpackID
   Gosub MoveResources ZLF #FindStack #BackpackID %ResourceSecure
   Finditem ZLF C_ , #BackpackID
   Until #FindCnt = 0


So I did, but it didn't seem to resolve the issue I was having. So I stopped being an autonomous robot and actually looked at what I was replacing. Found that you must of done an update to the script because the thing I was replacing it with was exactly the same as the code bit I was replacing. So not knowing too much about code I was like well I dunno what resource ZLF is and when I look down towards the bottom of the script for the different resources and stuff it doesn't show me any ZLF, sooooo I just deleted that whole little code snippet lol. Well now that seems to have created a whole separate issue where it continues to pull cloth and craft nothing... Now I know some of this might be attributed to the higher ping on the new shard I'm playing so I'll keep trying to make sense of this whole thing.

And I still need to do the change in the posts that are in the cutter. I'll keep you all posted if I figure anything out.

Also I added an itemid to the type of cloth you can use, but that didn't seem to be the issue as it did it when I went back and got the other itemid cloth.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Wiper on April 03, 2016, 09:37:53 AM
used this script to go from 50 to 120 tailoring it worked flawlessly   :)
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: savestheyday on April 23, 2016, 07:03:14 PM
Used this script to 120, very fast and well put together.  Had one hang up at ~117 skill where it decided to fill my pack with fancy dresses and then just sit there, but after a quick restart it worked again flawlessly.  Much faster and less clunky than CEO turbotailor!  Thanks for sharing!
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Gandolf on June 13, 2017, 11:35:27 AM
Say started to run the scrip work great until bag was full.
The scrip didn't empty my pack bag . Anyideas  ? thx
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Oracle on July 18, 2017, 03:12:08 PM
Say started to run the scrip work great until bag was full.
The scrip didn't empty my pack bag . Any ideas  ? thx

I have a similar issue.  The script was running fine until I noticed hat the backpack was filing up with Fancy Dresses and then stopped, when the backpack was full.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: The Ghost on July 18, 2017, 04:08:54 PM
SO where do you think the script is broken. Try to find a solution to the problem instead of stating the same issue.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Oracle on July 18, 2017, 04:43:45 PM
Trust me.  I am trying to figure out what is happening with the Script.  I was simply stating specifically, instead of generally what the script is doing at the time it fails.  I think it might be the fact that the gumps have changed, since adding in more Eodon items, dinosaur items, or Gargoyle items.  When I get a chance later tonight, I will run the script again and see what line it is failing at to find a solution.

Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: The Ghost on July 18, 2017, 04:47:27 PM
Now you are saying something  good : 
Quote
since adding in more Eodon items, dinosaur items, or Gargoyle items
now use the F7 option and debug.     

Now the question you should ask your self. How can I prove that the cutter work?
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Kandie on March 08, 2019, 08:31:21 AM
Seems I can't run both scripts at once.........I put them in their own easyuo and all in same folder.  What am I doing wrong?
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gimlet on March 08, 2019, 04:58:09 PM
only use one instance of easyuo. Start the cutterupper and then the tailor(last time i used it at least!)
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: The Ghost on March 09, 2019, 09:40:31 AM
To test is the cutter is working,  make a piece and run the cutter alone,  let get this one to work. after we can move the the big build. 

Plus you need cloth  and not bolt available.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: sumsum on March 09, 2019, 11:01:41 AM
I ran this script last month to 120 and it worked well.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Kandie on March 10, 2019, 09:13:52 AM
sumsum, did it throw  the gargish aprons in the trash?  mine wouldn't..   Also thanks for the fast reply guys....  :)  You guys are the BEST ! ! ! !
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: sumsum on March 10, 2019, 11:37:56 AM
I don't remember having to fix any code on mine.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Kandie on March 10, 2019, 01:22:05 PM
it makes the gargish aprons and won't throw them away, as you can not cut them up.....ugh
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Kandie on March 10, 2019, 01:28:31 PM
ok figured it out, you need to change makeyourown to #true from #false then u can pick oil cloth and not make those gargish aprons :)
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: dinodan1001 on July 18, 2020, 01:26:00 PM
Gonna try this put thsnk you
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: CityKitty on September 14, 2020, 06:00:22 PM
This script is just what I was looking for and it's running beautifully so far. I have only one question. I'm sure this must be easy but I'm afraid of mucking everything up. The script calls for cut cloth but I have a ton of folded cloth. I really don't want to buy more cloth, so I'm wondering if the code can be changed to use folded and if so, how.

Thanks in advance for any help.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Crisis on September 14, 2020, 06:50:48 PM
you would just add the id for the folded cloth so it would use either type. I will try and look at it tomorrow and help ya out with it. I am not on a computer with EUO or UO installed right now.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: CityKitty on September 14, 2020, 06:54:15 PM
Thanks so much!
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Crisis on September 15, 2020, 02:56:56 AM
Look for this:
Set %Cloth CUI

and replace with this:
Set %Cloth CUI_BUI

BUI should be the ID for folded cloth. I hope this helps.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: CityKitty on September 15, 2020, 01:24:11 PM
AHA! Well I was on the right track, but I'm so new to this, when I found the cloth, then saw three letters, well, I was like a deer in the headlights. It was not at all what I expected. How do I find the three-letter ID of an item? I've don a few searches but nothing so far.

Thanks so much for taking the time on this! Now, I can use the cloth I'm drowning in and not have to buy more!
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: gimlet on September 15, 2020, 01:29:42 PM
AHA! Well I was on the right track, but I'm so new to this, when I found the cloth, then saw three letters, well, I was like a deer in the headlights. It was not at all what I expected. How do I find the three-letter ID of an item? I've don a few searches but nothing so far.

Thanks so much for taking the time on this! Now, I can use the cloth I'm drowning in and not have to buy more!

I use this!

http://www.scriptuo.com/index.php?topic=188.0 (http://www.scriptuo.com/index.php?topic=188.0)
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Crisis on September 15, 2020, 04:37:41 PM
AHA! Well I was on the right track, but I'm so new to this, when I found the cloth, then saw three letters, well, I was like a deer in the headlights. It was not at all what I expected. How do I find the three-letter ID of an item? I've don a few searches but nothing so far.

Thanks so much for taking the time on this! Now, I can use the cloth I'm drowning in and not have to buy more!

I use this!

http://www.scriptuo.com/index.php?topic=188.0 (http://www.scriptuo.com/index.php?topic=188.0)

Same here! It is an awesome little tool.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: CityKitty on September 16, 2020, 09:55:54 AM
Yes, that tool will help a lot.

The script uses the folded cloth now really well, but I hadn't thought about weight, so I have to stop the script at times because I'm just getting a backpack full error that I might not catch for a while. I remove some cloth and it runs fine again. Is there a way to change that?

Thanks again for the help!
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Crisis on September 16, 2020, 03:14:36 PM
I sent you a PM.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Toymaker on September 02, 2021, 06:17:38 AM
Just ran this on 9-2-21, I was already at 109 tailoring when i started it, however it ran very smooth. it stumbled once at 118.7 when for some reason i ran out of tinker tools, but other than that it was flawless for me. Thank you for such a useful script! I did not really want to farm all the plain leather to get to 120. This was a god send.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: TrackStar on September 13, 2021, 02:25:27 PM
Whats the best way to set this up?

Is this something you can run in a tailor shop or do I need to stockpile a ton of cloth in my house?
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: TrackStar on September 14, 2021, 09:51:37 AM
Around 117.3 it starts saying no item type CUI which is the cut up cloth despite there being plenty.

I tried removing the smallest stack and this seems to have allowed it to keep going for now. I'll update if it gets stuck again.
Title: Re: No Leather Tailor Trainer (uses Gargish Cloth Armor to 120)
Post by: Piller on November 11, 2022, 07:11:04 PM
0-92 so far with no hang ups. Will update when finished.