I started running this script again and I am running into a problem.  After killing a serpent and the boat needs to move to make it lootable the script goes the opposite way of the corpse. for example if the boat needs to go backwards to loot, the script has the character say forward one and it just goes on endlessly going the wrong way. 

I am not sure how to fix the problem.  I don't know how to figure out if the problem lies in the script identifying the character XY or the dead body XY   It calculates the incorrect direction to go based on the location calculated on the comparison of the XY of the body/character.

I tried swapping the forward one/backward one commands in the sub but it did not fix it. It has to be something in the calculation of body/character location.  any help is appreciated.



here is the sub it is getting stuck in
;-------------------------------------------------------------------------------
sub LootSerpent
  namespace push
  namespace local LS
  set !temptargetkindid #LTARGETKIND
  set !templtargetid #LTARGETID
  set !templobjectid #LOBJECTID
  set #LTARGETKIND 1
  finditem YFM G_10 ; locate a dead body
  if #FINDKIND = -1
  {
    namespace pop
    return
  }
  wait 2s
  finditem YFM G_10 ; locate a dead body again, first body may have changed.
 
  event property #FINDID
  if serpent NOTIN #property ; be sure the located body is a serpent of some sort
  {
    ignoreitem #FINDID
    namespace pop
    return
  }
  set !presentserp #FINDID
  ignoreitem #FINDID
  set %deadserpcount %deadserpcount + 1
  set %totalserps %totalserps + 1
  menu set EUOStatus Serpent looting in progress...
  set !tempxxx #CHARPOSX
  set !tempyyy #CHARPOSY
closey:
  set !xdist #CHARPOSX - #FINDX
  set !ydist #CHARPOSY - #FINDY
  if !xdist = -1 && ( !ydist < -1 || !ydist > 1 )
  {
    event macro 3 0 left one
    wait 25
    goto closey
  }
  if ( !xdist = 0 || !xdist = 1 ) && ( !ydist < -1 || !ydist > 1 )
  {
    event macro 3 0 right one
    wait 25
    goto closey
  }
  set !ydist #CHARPOSY - #FINDY
  if !ydist < -1
  {
    event macro 3 0 back one
    wait 25
    goto closey
  }
  if !ydist > 1
  {
    event macro 3 0 forward one
    wait 25
    goto closey
  }
closex:
  set !xdist #CHARPOSX - #FINDX
  if !xdist < -2
  {
    event macro 3 0 right one
    wait 25
    goto closex
  }
  if !xdist > 2
  {
    event macro 3 0 left one
    wait 25
    goto closex
  }

Quote from: TrackStar on August 30, 2021, 06:16:37 AM

Thanks for the info on the CLAw. Sounds like I was using it properly! Glad to know I'm able to work through a lot of this myself and that it, for the most part, is decipherable for me.

Yea, it sounds like I should do a VM. I used to do QA for a web developer a long time ago where I used VM and others extensively as well as various other reasons over the years.

Is there a virtual machine software you prefer? VirtualBox I guess?

I used to use VMWare Workstation until my licenses got too old.  VirtualBox is sufficient (though seems slower).  They both allow for cloning VMs, and that's what's important.  Another nice byproduct of consigning your UO session to the VM is that you can use your computer for general stuff simultaneously since the mouse/keyboard interaction is negated and you can minimize the display so that even OCR-intensive scripts will still work.