Author Topic: Crisis Carpentry Trainer Beta 1.0 *Needs Testers Please*  (Read 32472 times)

0 Members and 1 Guest are viewing this topic.

Offline The Ghost

  • Elite
  • *
  • *
  • Posts: 1917
  • Activity:
    0%
  • Reputation Power: 25
  • The Ghost is on the verge of being accepted.The Ghost is on the verge of being accepted.The Ghost is on the verge of being accepted.The Ghost is on the verge of being accepted.The Ghost is on the verge of being accepted.
  • Respect: +245
  • Referrals: 0
    • View Profile
Re: Crisis Carpentry Trainer Beta 1.0 *Needs Testers Please*
« Reply #15 on: January 05, 2014, 09:26:13 AM »
+1
Loaded 1.3.
 Still ghosting the backpack with tinker and carpentry tool.   The crafting part work 100%    I will have to see how to slow it down a bit on those two sub.   Still can't walk away from it :(

Offline gimlet

  • Very Super Secret
  • Global Moderator
  • *
  • *
  • Posts: 6190
  • Activity:
    3%
  • Reputation Power: 71
  • gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!
  • Gender: Male
  • Respect: +273
  • Referrals: 3
    • View Profile
Re: Crisis Carpentry Trainer Beta 1.0 *Needs Testers Please*
« Reply #16 on: January 05, 2014, 09:35:11 AM »
+1
Everything seems to work well except for the tink menu popping up. Then I get the message to open tink gump and press play.

So at the moment I am just loading my backpack with planes.

I was going to just add a sub to do what your message asks to do but ill wait for next version.

Offline 12TimesOver

  • Another Day, Another Vendetta
  • Global Moderator
  • *
  • *
  • Posts: 3694
  • Activity:
    0%
  • Reputation Power: 41
  • 12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.
  • Gender: Male
  • Respect: +321
  • Referrals: 2
    • View Profile
Re: Crisis Carpentry Trainer Beta 1.0 *Needs Testers Please*
« Reply #17 on: January 05, 2014, 11:39:23 AM »
+1
Running the newest update.

So far not too shabby, 157 gains in about 40 minutes although it kept looping through the move board and craft process after I ran out of boards, didn't notice for 15 minutes or so. For this you could just add a couple of lines when it does a finditem for the boards in the resource container when needing to move more over and if #findkind = -1 there are none left and the script should pause or just halt.

X
When they come for me I'll be sitting at my desk
     with a gun in my hand wearing a bulletproof vest
My, my, my how the time does fly
     when you know you're gonna die by the end of the night

Offline CrisisTopic starter

  • Global Moderator
  • *
  • *
  • Posts: 2998
  • Activity:
    3.4%
  • Reputation Power: 41
  • Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.
  • Gender: Male
  • Scripting well enough to break things!
  • Respect: +205
  • Referrals: 2
    • View Profile
Re: Crisis Carpentry Trainer Beta 1.0 *Needs Testers Please*
« Reply #18 on: January 05, 2014, 11:59:16 AM »
+1
Okay, try V1.4. I added in some extra wait times and adjusted the tool waits. See if this works any better for you. Ghost please let me know if it fixes your issues. I appreciate you making a carpenter just to test this!

Offline 12TimesOver

  • Another Day, Another Vendetta
  • Global Moderator
  • *
  • *
  • Posts: 3694
  • Activity:
    0%
  • Reputation Power: 41
  • 12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.
  • Gender: Male
  • Respect: +321
  • Referrals: 2
    • View Profile
Re: Crisis Carpentry Trainer Beta 1.0 *Needs Testers Please*
« Reply #19 on: January 05, 2014, 02:07:48 PM »
+1
Everything seems to work well except for the tink menu popping up. Then I get the message to open tink gump and press play.
This. Big issue, happens a lot. Instead of pausing the script you should just retry using the tinker tool again.

X
When they come for me I'll be sitting at my desk
     with a gun in my hand wearing a bulletproof vest
My, my, my how the time does fly
     when you know you're gonna die by the end of the night

Offline CrisisTopic starter

  • Global Moderator
  • *
  • *
  • Posts: 2998
  • Activity:
    3.4%
  • Reputation Power: 41
  • Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.
  • Gender: Male
  • Scripting well enough to break things!
  • Respect: +205
  • Referrals: 2
    • View Profile
Re: Crisis Carpentry Trainer Beta 1.0 *Needs Testers Please*
« Reply #20 on: January 05, 2014, 02:27:21 PM »
+1
Everything seems to work well except for the tink menu popping up. Then I get the message to open tink gump and press play.
This. Big issue, happens a lot. Instead of pausing the script you should just retry using the tinker tool again.

X

I made a change but as I looked at it closer I saw that it wasn't right. Is it happening when making more carp tools or more tinker tools? I need to know that before I make any changes. The tinkwait and carpwait subs both have a gump wait in it and the gumpwait sub is where the message is coming from. I am not sure how I can edit the gumpwait without it clicking the wrong tool. I will need to look at the carpwait or the tinkwait but need to know which is causing it to pop up.

« Last Edit: January 05, 2014, 05:17:02 PM by Crisis »

Offline 12TimesOver

  • Another Day, Another Vendetta
  • Global Moderator
  • *
  • *
  • Posts: 3694
  • Activity:
    0%
  • Reputation Power: 41
  • 12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.
  • Gender: Male
  • Respect: +321
  • Referrals: 2
    • View Profile
Re: Crisis Carpentry Trainer Beta 1.0 *Needs Testers Please*
« Reply #21 on: January 05, 2014, 06:06:47 PM »
+1
Carpentry tools.

When they come for me I'll be sitting at my desk
     with a gun in my hand wearing a bulletproof vest
My, my, my how the time does fly
     when you know you're gonna die by the end of the night

Offline gimlet

  • Very Super Secret
  • Global Moderator
  • *
  • *
  • Posts: 6190
  • Activity:
    3%
  • Reputation Power: 71
  • gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!
  • Gender: Male
  • Respect: +273
  • Referrals: 3
    • View Profile
Re: Crisis Carpentry Trainer Beta 1.0 *Needs Testers Please*
« Reply #22 on: January 05, 2014, 06:09:13 PM »
+1
Carp

Offline CrisisTopic starter

  • Global Moderator
  • *
  • *
  • Posts: 2998
  • Activity:
    3.4%
  • Reputation Power: 41
  • Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.
  • Gender: Male
  • Scripting well enough to break things!
  • Respect: +205
  • Referrals: 2
    • View Profile
Re: Crisis Carpentry Trainer Beta 1.0 *Needs Testers Please*
« Reply #23 on: January 05, 2014, 06:44:23 PM »
+1
If this doesn't do it, I am totally stumped on it. It is not happening to me and I am running Neo's termur LJ and then my carp trainer while surfing the web. I am on my 3rd carpenter testing this out. Hopefully this will do it or someone can look at the code and point me in the right direction. I will be posting 1.5 for you to test.

Offline 12TimesOver

  • Another Day, Another Vendetta
  • Global Moderator
  • *
  • *
  • Posts: 3694
  • Activity:
    0%
  • Reputation Power: 41
  • 12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.
  • Gender: Male
  • Respect: +321
  • Referrals: 2
    • View Profile
Re: Crisis Carpentry Trainer Beta 1.0 *Needs Testers Please*
« Reply #24 on: January 06, 2014, 05:16:38 AM »
+1
I started looking at your code but didn't have time to follow everything through last night, had some other stuff going on and you use A LOT of subs in your code :) which makes it a little bit more of a chore. I'll take a look with you sometime today though.

X
When they come for me I'll be sitting at my desk
     with a gun in my hand wearing a bulletproof vest
My, my, my how the time does fly
     when you know you're gonna die by the end of the night

Offline 12TimesOver

  • Another Day, Another Vendetta
  • Global Moderator
  • *
  • *
  • Posts: 3694
  • Activity:
    0%
  • Reputation Power: 41
  • 12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.12TimesOver is a force to reckon with.
  • Gender: Male
  • Respect: +321
  • Referrals: 2
    • View Profile
Re: Crisis Carpentry Trainer Beta 1.0 *Needs Testers Please*
« Reply #25 on: January 06, 2014, 07:08:20 AM »
+1
Ok, follow-up...

first, be careful about leaving ID's specific to your environment in the scripts. Just good practice to not link anything script-related to your UO account:
Code: [Select]
; manually set secure cotainer ID's, or leave blank (or N/A) for automated setup
set %ResourceSecure NACAPQD
set %axechopper BNRECOD

Next on the issue of discussion :)

This is the sub:
Code: [Select]
sub GumpWait
  set %_tm #systime + ( %gumptimeout * 60 )
  gosub hardwait %gumpwait
  while #contsize <> %cwin
  {
    sleep 10
    if #systime > %_tm
    {
      display Problem waiting on craft gump, open manually then press play easyuo menu
      pause
    }
  }
return #true

This sub is using the variables from your Constants sub:
Code: [Select]
  set %cwin 530_497 ; 530_437        ; Carpentry window size
  set %gumpwait 1          ; Time to wait before scanning for open gump/container
  set %gumptimeout 60      ; Maximum amount of time to wait for gump to open

so you're sub is doing:
Code: [Select]
sub GumpWait
  set %_tm #systime + 360 ;i.e. systime plus 360ms or just over 1/3 of a second
  gosub hardwait 1 ; based on your hardwait sub this makes the script sleep for 1 milisecond, not sure the point
  while #contsize <> 530_497 ; i.e. if the gump hasn't come up after 1 ms (which it will likely never do for most of us)
  {
    sleep 10 ;again, what is ths point here?
    if #systime > %_tm ;at this point we are saying if more than 371ms has gone buy (less than a half second)
    {
      display Problem waiting on craft gump, open manually then press play easyuo menu
      pause
    }
  }
return #true
So based on the above breakdown you are definitely not giving enough time, or enough variability, in your waits for the average Joe User. The above wait approach can work , as you are seeing for yourself, but it's very complicated and not easily transported from situation to situation.

Here is an example of my Gumpwait standard sub. Not a work of art by any means, I'm certainly a sub-par script writer, but this is pretty simple:

Code: [Select]
;#######################
;SUB XIIxGumpWait
;#######################
; %1 = Required: Gumpname 1
; %2 = Required only if using Gumpsize: Gumpname 2
; %3 = Optional: Gumpsize
; Returns #TRUE if gump occured before timeout, #FALSE if timeout occured
sub XIIxGumpWait
   namespace push
   namespace local nsXIIxGumpWait
   set !gName1 %1
   set !gName2 %2
   set !gSize %3
   set !_time #SCNT
   while #SCNT <= !_time + 5
      {
      if %0 > 2
         {
         if ( #CONTNAME = !gName1 && #CONTSIZE = !gSize ) || ( #CONTNAME = !gName2 && #CONTSIZE = !gSize )
            {
            namespace clear
            namespace pop
            return #TRUE
            }
         }
      else
         {
         if #CONTNAME = !gName1 || #CONTNAME = !gName2
            {
            namespace clear
            namespace pop
            return #TRUE
            }
         }
      }
   namespace clear
   namespace pop
return #FALSE
I use this standard sub for ALL gump waits and timing in any script I write. I got the idea of adding two possible gump names from TM's Gumpwait but I've actually never used it hehe. But notice that in this sub I'm simply saying "keep checking for a matching gumpname and or gumpname/gumpsize combination for 5 seconds and if it comes up, exit and return #TRUE, if not return #FALSE. Simple. No need for "hardwait", "gumpwait", "contIDwait", "carptoolwait", "tinkwait", etc, etc.

Hopefully this helps.

X
When they come for me I'll be sitting at my desk
     with a gun in my hand wearing a bulletproof vest
My, my, my how the time does fly
     when you know you're gonna die by the end of the night

Offline gimlet

  • Very Super Secret
  • Global Moderator
  • *
  • *
  • Posts: 6190
  • Activity:
    3%
  • Reputation Power: 71
  • gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!gimlet is awe-inspiring!
  • Gender: Male
  • Respect: +273
  • Referrals: 3
    • View Profile
Re: Crisis Carpentry Trainer Beta 1.0 *Needs Testers Please*
« Reply #26 on: January 06, 2014, 07:33:27 AM »
+1
Also I don't know the implication of a missing } (unmatched after the else) but you probably need to check this

Code: [Select]
sub constants

  if %runuo
  {
    set %cwin 530_437      ; Carpentry window size
    set %tinkwin 530_437   ; Tinkering window size

    set %in ItemRUO
  }
  else
  {
    ; EA OSI
  set %cwin 530_497 ; 530_437        ; Carpentry window size
  set %tinkwin 530_497 ; 530_437     ; Tinkering window size

  set %carpentry carp

 ; Materials
  set %ingots ENK
  set %boards TLK
  set %tinkertool JTL_GTL_KTL
  set %carptool YFG_ZHG_CIG_BIG_AGG_EGG_AIG_WFG_IGG_KGG_ZFG_CGG
  set %axeType LSF_OSF_NSF_BSF_MSF_CSF_ISF_MPH_JOH_UOH_RMH_LPH_ZRF_FSF
  set %garbage BTL_OJL_OIK_MDP_ZPF_DMH_GFF_BFR_RPF_VMF_WMF_UMF
  set %breakgarbage VMF_WMF_UMF_BTL_OJL_OIK_MDP_ZPF_DMH_GFF_BFR_RPF

  ; Items to make
  set %Item1 BTL ; Barrel Staves
  set %Item2 OJL ; Barrel Lid
  set %Item3 WMF ; Medium Crate
  set %Item4 UMF ; Large Crate
  set %Item5 OIK ; Wooden Shield
  set %Item6 MDP ; Fukiya
  set %Item7 ZPF ; Quarter Staff
  set %Item8 DMH ; Sheppard's Crook
  set %Item9 GFF ; Black Staff
  set %Item10 BFR ; Wild Staff

  ; max skill threshold for each item
  set %Threshold1 200
  set %Threshold2 320
  set %Threshold3 480
  set %Threshold4 530
  set %Threshold5 600
  set %Threshold6 740
  set %Threshold7 790
  set %Threshold8 820
  set %Threshold9 960
  set %Threshold10 1000

  ; CRAFT substates
  set %s0 CheckTinkerTools
  set %s1 CheckCarpTools
  set %s2 CheckBoards
  set %s3 SkillCraft
  set %s4 DumpGarbage

  ; Timing tweaks.  20 = 1 second
  set %gumpwait 1          ; Time to wait before scanning for open gump/container
  set %gumptimeout 60      ; Maximum amount of time to wait for gump to open

  set %precontposwait 10   ; Time to wait after opening gump and moving it using contpos
  set %postcontposwait 30  ; Time to wait after performing contpos

  set %postdropwait 22     ; Time to wait after each exevent drop before attempting any other action
  set %postcraftwait 1     ; Time to wait after an item is crafted before performing any other action

  set %preregmovewait 10   ; Minimum time to wait before moving all regs
  set %postregmovewait 22  ; Extra time to wait after moving all regs, (in addition to %postdropwait, above)

  set %interactiontime 10   ; Minimum measured interval between all { exevent drop, event macro } operations


  set %_lit %interactiontime * 20
  set %_lastactiont #systime - %_lit

  ; initial states
  set %initialized #false
  set *substate 0
  set *state IDLE
  set *request IDLE
return

Offline ximan

  • Jr. Member
  • **
  • Posts: 98
  • Activity:
    0%
  • Reputation Power: 1
  • ximan has no influence.
  • Respect: +16
  • Referrals: 1
    • View Profile
Re: Crisis Carpentry Trainer Beta 1.0 *Needs Testers Please*
« Reply #27 on: January 06, 2014, 11:19:03 AM »
+1
Also I don't know the implication of a missing } (unmatched after the else) but you probably need to check this [ code ]

You're right gimlet, needs a closing brace, something got dropped since I posted on euo thread:

Code: [Select]
sub constants

  if %runuo
  {
    set %cwin 530_437      ; Carpentry window size
    set %tinkwin 530_437   ; Tinkering window size

    set %texitx 30
    set %texity 410
    set %tmlx 280
    set %tmly 410
    set %ttoolsx 30
    set %ttoolsy 110
    set %ttinkx 230
    set %ttinky 130
    set %tsawx 230
    set %tsawy 210
   
    set %cexitx 30
    set %cexity 410
    set %cmlx 280
    set %cmly 410
   
    set %in ItemRUO
  }
  else
  {
    ; EA OSI
    set %cwin 530_497      ; Carpentry window size
    set %tinkwin 530_497   ; Tinkering window size

    set %texitx 27
    set %texity 450
    set %tmlx
    set %tmly

    set %ttoolsx 30
    set %ttoolsy 110
    set %ttinkx
    set %ttinky
    set %tsawx
    set %tsawy
   
    set %cexitx 30
    set %cexity 410
    set %cmlx
    set %cmly
   
    set %in Item
  }
 
  ; initial board check, otherwise set in Item subs
  set %CraftingBoards 5

; ...


Offline CrisisTopic starter

  • Global Moderator
  • *
  • *
  • Posts: 2998
  • Activity:
    3.4%
  • Reputation Power: 41
  • Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.
  • Gender: Male
  • Scripting well enough to break things!
  • Respect: +205
  • Referrals: 2
    • View Profile
Re: Crisis Carpentry Trainer Beta 1.0 *Needs Testers Please*
« Reply #28 on: January 06, 2014, 12:19:54 PM »
+1
Also I don't know the implication of a missing } (unmatched after the else) but you probably need to check this [ code ]

You're right gimlet, needs a closing brace, something got dropped since I posted on euo thread:

I didn't end up using those from the euo board. I had found the mistake and didn't use those changes though I had left the very beginning of the runuo portion in there to remind me to see if someone could give me the offset clicks for runuo. When you posted that comparison website, I found the mistake that I had made.

Offline CrisisTopic starter

  • Global Moderator
  • *
  • *
  • Posts: 2998
  • Activity:
    3.4%
  • Reputation Power: 41
  • Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.Crisis is a force to reckon with.
  • Gender: Male
  • Scripting well enough to break things!
  • Respect: +205
  • Referrals: 2
    • View Profile
Re: Crisis Carpentry Trainer Beta 1.0 *Needs Testers Please*
« Reply #29 on: January 06, 2014, 12:43:28 PM »
+1
12x I appreciate the feedback. I was looking at different gumpwaits and I had been looking at yours on your cart trainer. I truly don't understand namespace at all so I will have to look at gumpwaits and see what I can learn.

Ximan helped me last one year with that one due to issues that I was having with timing, I never realized that there was such a drastic difference with timing between people. I think it got so complicated because of my issues with timing. Comcast has since bumped up our cable speed by leaps and bounds which is probably why there is such a difference between mine and others. Ximan helped me tremendously as you all are. I am learning so much and I really appreciate everyone's patience and advice!

Tags: