REPEAT/UNTIL Loops - Do you use brackets or none?

[12TimesOver]

I go back and forth for no apparent reason other than my mood I guess. I'm going to pick one and stick with it. What do you do?

[Superslayer]

No brackets here. I do however use them in while loops if it's more than two lines.

[Scrripty]

No brackets here. I do however use them in while loops if it's more than two lines.

I do depending on how many lines also.  But one interesting thing to note:  It's a good idea to use wait 1's in your repeat loops for non or only semi time critical functions.  According to Roadkill it produces less wear and tear on your cpu and is a little more stable.

The difference between this:

Code: [Select]

repeat
until #charghost = yes
and

Code: [Select]

repeat
  wait 1
until #charghost = yes
is about 20000 iterations...   So you can see how much of a saving on your processor that is... and you're still doing a TON of iterations using that wait 1.  Be fun to write a little bit of code to test just how many iterations per second those do on a few computers to get an idea of the kind of issues it would cause based on processor speed.

[Endless Night]

No brackets here. I do however use them in while loops if it's more than two lines.

you have to use brackets for while and for loops if more than 1 line inside the loop is being exectuted.
And ive even had issues where euo didnt fuction correctly with 1 line inside the loop without brackets

So my advice if its not a repeat until... always use brackets.

[Cerveza]

I use them, always.

It helps me visually see what all is included in the repeat. Everything is indented nicely

[Scrripty]

No brackets here. I do however use them in while loops if it's more than two lines.

you have to use brackets for while and for loops if more than 1 line inside the loop is being exectuted.
And ive even had issues where euo didnt fuction correctly with 1 line inside the loop without brackets

So my advice if its not a repeat until... always use brackets.

In EUO 1.5 brackets for FOR loops are options if it's only one line of code.  Not sure about while's.

[Endless Night]

No brackets here. I do however use them in while loops if it's more than two lines.

you have to use brackets for while and for loops if more than 1 line inside the loop is being exectuted.
And ive even had issues where euo didnt fuction correctly with 1 line inside the loop without brackets

So my advice if its not a repeat until... always use brackets.

In EUO 1.5 brackets for FOR loops are options if it's only one line of code.  Not sure about while's.

I know thats what i said.. but i also said EUO glitches sometimes with one line and no brackets (for loops)

[TrailMyx]

Kinda silly to use them with a repeat/until construct.  Brackets are "implied" with the repeat/until.  So it's like having brackets for your brackets.  Redundant for sure!

[Scrripty]

No brackets here. I do however use them in while loops if it's more than two lines.

you have to use brackets for while and for loops if more than 1 line inside the loop is being exectuted.
And ive even had issues where euo didnt fuction correctly with 1 line inside the loop without brackets

So my advice if its not a repeat until... always use brackets.

In EUO 1.5 brackets for FOR loops are options if it's only one line of code.  Not sure about while's.

I know thats what i said.. but i also said EUO glitches sometimes with one line and no brackets (for loops)

Cut me some slack.  I'm sick.

[Endless Night]

lol

[manwinc]

if you do

for #findindex 1 #findcnt
gosub Whatever

It starts you off on #findindex = 2 thats the glitch. I've seen it happen a dozen times. if you don't have brackets it will skip over your first number.


I always use brackets on my repeat untils unless its only 1 line of code inbetween. I always thought it was mandatory. I wonder if thats why they use endif in vb..... to save lines?

[Superslayer]

if you do

for #findindex 1 #findcnt
gosub Whatever

It starts you off on #findindex = 2 thats the glitch. I've seen it happen a dozen times. if you don't have brackets it will skip over your first number.


I always use brackets on my repeat untils unless its only 1 line of code inbetween. I always thought it was mandatory. I wonder if thats why they use endif in vb..... to save lines?

I love the endif functions. I've used them in javascript before and wish they'd be employed in euo.

[Cerveza]

HAH! I KNEW IT!!

I knew there was some reason I ALWAYS use {} after a "repeat" AND "if". And now, you all will too....

if #finddist > 4
;  move #findx #findy 2
  event pathFind #findx #findy #findz

By allowing the "if" statement to execute the next line, it actually recognizes the ; (rem) statement as the condition. It would ALWAYS perform the "event pathFind".

if #finddist > 4
  {
;  move #findx #findy 2
  event pathFind #findx #findy #findz
  }

Changed to that, using the brackets, it works perfectly and ONLY executes the "event pathFind" if greater then 2 tiles away.

I didn't test it with Repeat, but I'd assume the same situation.

[Khameleon]

the if statment without brackets will always read the 2nd line weather the 1st line is commented out or blank....

not sure if alot of ppl realize this but you can also tell the if statement how many lines are in the statement.  if You ask me its very tough to keep track of this exspecially if you edit a script.

Code: [Select]

start:
if #Findking = -1 2
   ignoreitem #Findid
   goto start
does the same thing as

Code: [Select]

start:
if #FindKind = -1
   {
   ignoreitem #findId
   Goto Start
   }

but this will only read the next line if the statement is true.

Code: [Select]

Start:
If #FindKind = -1
Ignoreitem #findID ; if the statement is true this line will be read
goto Start ; this line will always be read since its not bracketed.


[Scrripty]

Yea the whole designating how many lines are behind an if thing is nice, I learned about it a while back, but it's not really necessary in EUO, the only times I could ever see using it are in a REALLY time constrained situation where you need to do something in as few lines as possible.  Say like scanning TONS and TONS of data where every line makes a difference in speed?  I have tried it, and it saves 2 lines of code in every if statement, but there's really not many real situations where it's necessary.  Easier to read imo with brackets also.