REPEAT/UNTIL Loops - Do you use brackets or none?

[manwinc]

I agree with Twinkle McNugget, although some scripts like my Suit Builder are hard to read even with brackets  I can't even understand it anymore.

[Paulonius]

Just a little feedback on an idea I saw in this thread posted by Twinkle McNugget and credited to Roadkill regarding putting a wait 1 into loops.  I was running a script that runs a mainloop with lots of checks that for the most part won't do anything, so it cycles really fast.  When I had two of them running it amped my CPU load from 5% to 44%.  When I dropped a "Wait 1" into the mainloop it dropped the load back down to 15%.  Something to think about when building scripts that hold a loop for any amount of time.

[Scrripty]

Just a little feedback on an idea I saw in this thread posted by Twinkle McNugget and credited to Roadkill regarding putting a wait 1 into loops.  I was running a script that runs a mainloop with lots of checks that for the most part won't do anything, so it cycles really fast.  When I had two of them running it amped my CPU load from 5% to 44%.  When I dropped a "Wait 1" into the mainloop it dropped the load back down to 15%.  Something to think about when building scripts that hold a loop for any amount of time.

UO is based on pretty big waits for actions... anything faster than like 1/10th of a second is pretty much a waste unless it's SERIOUSLY important you do it like RIGHT NOW.   Or doing TONS of calcs...  You can take it a step further Paul for great control with using like #sysTime or #sCnt/2    According to RK and my own testing it sure helps scripts not be so "laggy." Glad that helped ya.

[manwinc]

Yeah, in ALOT of my scripts I have things like.

set %Lobject_Timer #Scnt2 + 10
%Cast_Timer #Scnt2 + %Fcr_Delay

For Generic things, AKA You can't use an object yet, or you can't cast yet. And then beyond that you also set the rest of your timers.

set %EO1 #scnt + 360

etc etc

[Superslayer]

the if statment without brackets will always read the 2nd line weather the 1st line is commented out or blank....

not sure if alot of ppl realize this but you can also tell the if statement how many lines are in the statement.  if You ask me its very tough to keep track of this exspecially if you edit a script.

Code: [Select]

start:
if #Findking = -1 2
   ignoreitem #Findid
   goto start
does the same thing as

Code: [Select]

start:
if #FindKind = -1
   {
   ignoreitem #findId
   Goto Start
   }

but this will only read the next line if the statement is true.

Code: [Select]

Start:
If #FindKind = -1
Ignoreitem #findID ; if the statement is true this line will be read
goto Start ; this line will always be read since its not bracketed.


I've been using this as of late, and found that it also works with 'else' statements.  Very cool feature imo.

[Paulonius]

EN, can you throw up an example?

[Endless Night]

EN, can you throw up an example?

? Of ?

[Superslayer]

In the event Paul may have meant me,:

This is the same :

Code: [Select]

if %Alpha = %Delta
{
  do stuff
  do more stuff
  finish doing stuff
}
else
{
  don't do stuff
  don't do anything else
  finish not doing something
}

as this:

Code: [Select]

if %Alpha = %Delta 3
  do stuff
  do more stuff
  finish doing stuff
else 3
  don't do stuff
  don't do anything else
  finish not doing something


[UOMaddog]

I wish EUO would let me do my traditional Java formatting:

Code: [Select]

if this==that {
   blah blah
   yadda yadda
}

do {
  sumthin sumthin
} while fail==true
I like my brackets to start at the end of the line and then finish off the statement. It even makes 1 liners look nice. This is the standard format that Eclipse uses and I would personally love to have sex with Eclipse because it makes scripting so easy!

[Paulonius]

I did SS, thank you.  Sorry EN, not getting enough sleep.  

I mean I did mean you in that previous post, not "I did have sex with eclipse..."

[Katu]

I use em, becouse i think it makes the code look cleaner. Im used to C languages so brackets makes sense. Ofcourse with "IF's" i dont always use, if theres just one line to do. In some cases, there needs to be lots of "IF's" and set variable then return. If using brackets, it takes almost 2x lines to do it. Then i might use the number to let EUO know, how many lines to process.
Ill use brackets even with subs.

[rana70]

There are still places in the UO script Community
 .. where a script without brackets ...
even if it works ...
is considered tooooo bugy to be proven :-)

 

[BadManiac]

Always brackets and indentation everywhere. Consistency is king in programming. Brackets with if's, while's, repeat's, sub's. ALWAYS brackets!!!

[Katu]

Always brackets and indentation everywhere. Consistency is king in programming. Brackets with if's, while's, repeat's, sub's. ALWAYS brackets!!!

Agree 100%