Trailmyx's Runebook/Spellcast Subs

[Superslayer]

Thought so, but wasn't positive.

[YaLooo]

hi all

[Toptwo]

Hello Yaloo,

  You might want to consider going to this board and posting a intro, will help you get off of restricted status.

http://www.scriptuo.com/index.php?board=20.0

[Scrripty]

Code: [Select]

;   gosub TM_AddUnderscore #CHARNAME
;   set %charname #RESULT
;=================================================================


Where's the AddUnderscore sub?

[TrailMyx]

I have to remember to add that back into the subs.  But someone else pointed this out and doing a quick search from the main page revealed this:

http://www.scriptuo.com/index.php?topic=235.0;highlight=addunderscore

SMF search function is VERY good, BTW.  It's based on where you are in the board, so if you want to search the entire board, make sure you start the search from the main page.

[Paulonius]

TM,

I am working on using the travel subs in a bod fetching script.  It logs onto multiple accounts/characters and runs to get bods with them.  

I have it resetting the underscore sub with each toon, have all of the journal subs in and unless I get a fizzle, it runs fine.  If it fizzles on a recall the script doesn't pick it up and it hangs.  It does recognize a blocked location and will select the alternate rune. I think I have isolated the issue at the journal scan after the target in the spellcast sub by putting in a couple of event msg notes as follows.

Code: [Select]

 NewCastSpell_skip2:
      if !whichspell >= 0 && !whichspell <= 63 ; Magery
      {
        gosub TM_AdvJournalScan SPELLCAST VALID spell_fizzles there_is_already mana your_spirit more_reagents
      }
      else
      {
        set !cont #FALSE  ; Chivalry, Necromancy, etc
        finditem !whichtarget *
        if !whichtarget in SELF_NONE || #FINDKIND <> -1
          set !cont #TRUE

        if #MANA >= !tempmana && !cont = #TRUE ; check if target is still there
          set #RESULT #TRUE
        else
          set #RESULT #FALSE
      }
      repeat
      until #SCNT2 > !casttimeout     ; finish up cast delay
      if #RESULT = #TRUE
      {
      event exmsg #charid 3 4 Journal scan picked up a fizzle and should head to recast
        if !castretrymax > -1
        {
          set !castretry !castretry + 1 ; %castretrymax of -1 will cast until successful
          if !castretry > !castretrymax
            goto NewCastSpell_end1
        }
        goto NewCastSpell_loop1
      }
      event exmsg #charid 3 4 Journal scan was negative for fizzle, script will continue
      if #SCNT2 <= !casttimeout     ; finish up cast delay
        goto NewCastSpell_skip2
I am thinking that my data feed to the travel subs must be good as its picking up the blocked location, but if that is the case, then I am not sure why it isn't catching the fizzle unless it is just going too fast. I am going to add a wait 5 in front of the journal check and see if that makes a difference. I suspect I am missing something though...  

A wait didn't make a difference, so I am pretty sure I have something wrong with the journal scanner setup.

[Paulonius]

I did some more playing with this and I think I have confirmed that the rune-book subs are inconsistent when you fizzle on a recall.  SJ works fine because of the position check.  I noticed the problem consistenly with my BOD script and on occassion with the SUO Crafter.  

When using well developed toons this is unlikely to be in evidence because you will generally have enough magery to recall consistently.  However, because I used the sub in a script that recalls repeatedly with less developed toons I was able to observe the issue pretty extensively.  (Yes, I like to watch scripts run...)

I was runnning the script on home shard on which I ping in the 70s -- not noticeably laggy when you are running around and I don't see noticeable lag running scripts.  I played with the wait immediately prior to the journal check and it didn't seem to fix the problem, so I am not 100% sure where the issue lies.  I simply "fixed the glitch" in my BOD script by adding the SJ position check to the recall sub.  Another work around is to put enough jewelry on an under developed toon to reliably recall -- around 65 magery.

[rana70]

I have to remember to add that back into the subs.  But someone else pointed this out and doing a quick search from the main page revealed this:

http://www.scriptuo.com/index.php?topic=235.0;highlight=addunderscore

SMF search function is VERY good, BTW.  It's based on where you are in the board, so if you want to search the entire board, make sure you start the search from the main page.

Hi TM,

I know this post is an older one ... but you are confusing me a little.
I asked you a few moons ago the same question about the non existng underscore SUB
and you told me that in was outdated ... and not used anymore by the Travel SUB.

If I remember correct I figured out this must be the truth because of the fact that you
even never use the %charname var within the whole travel SUB.

btw thank you for this great travel SUB :-)

@Paulonius
I use TM's Travel SUB mostly with Recall and I havn't had issues so far even my ping is about 120
I havn't read your script but do you check the #RESULT after using the SUB correctly to make sure
the requested recall worked ?

cu

[TrailMyx]

Ah yes.  That was back before the advanced journal handler automatically modified your character name to remove spaces.  It's got it built-in now because people weren't copying all the required subs and EUO doesn't error out when a sub isn't found.

[luv2luvlong]

Been playing with ths for a while now and kept having probs with it not waiting long enough on the SJ part. Mostly when traveling to different servers. You might want to consider raising it to 30 80 or , which seems to work much better. Just my 2 cents.

[NObama]

It appears that, with a new patch, something changed in the way error messages are reported.  This results in a blocked location also reporting a fizzle, and 'fizzle' being the most recent event in the journal.  Therefore, the runebook travel sub was getting stuck in TM_NewCastSpell loop1 and/or skip2.  I commented out the 'spell_fizzles' portion of the advJournalScan syntax and it *appears* to be working now.

This is for XII's miner, btw.

More reporting as events warrant.

[TrailMyx]

why on earth would they make that change?  lol

[seeriusly]

It appears that, with a new patch, something changed in the way error messages are reported.  This results in a blocked location also reporting a fizzle, and 'fizzle' being the most recent event in the journal.  Therefore, the runebook travel sub was getting stuck in TM_NewCastSpell loop1 and/or skip2.  I commented out the 'spell_fizzles' portion of the advJournalScan syntax and it *appears* to be working now.

This is for XII's miner, btw.

More reporting as events warrant.

ahh man... what a great catch.  I've been racking my brain this morning with that.  Thankyou!

[NObama]

Just to be clear:  I don't recommend changing TM's work wholesale.  This was just the tweak I needed to run my particular cheaty script.

If you really fizzle a spell, my changes will dork with TM's error check routines.  This is just a spit-and-baling-wire approach to one specific problem.

[TrailMyx]

Probably should do something about it anyhow.  Since this is actually getting stuck in the casting routine and that retries until success, it can get into a loop that won't return failure like you'd expect.  You can just change the casting, to retry 2-3 times instead of -1.  I.e.:

Code: [Select]

gosub TM_NewCastSpell 31 !rbook -1 10 10 ; recall until successful

changes to

Code: [Select]

gosub TM_NewCastSpell 31 !rbook 2 10 10 ; retry 2 times

This way, the subs will return failure.