ScriptUO

Official ScriptUO EasyUO Scripts => Submit your Script => Inactive Submissions => Topic started by: The Reaper on May 29, 2011, 12:47:45 PM

Title: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: The Reaper on May 29, 2011, 12:47:45 PM
This script makes bucklers at your house and takes them to brit library to hand them in.

Been tested, managed to get 25k points all by itself, so I'm letting you lot loose on it.

Any feedback is much appreciated.

Will be adding a menu box to keep track of what you've used etc, but I don't really have time right now. ATM, it works, that's all that matters.

Small note, you'll be needing about 900,000 plain ingots!!!!!!!!

Updated to Version 2.0 - NOW HAS GATE SUPPORT, GO GO GIMLET!!
Updated to version 1.1 to remove 1 or 2 bugs, should now make smiths hammers instead of tinker tools when your lagging :S

Still to do:
- Add a menu interface - DONE
- Add gate travel - DONE
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: Canuker on May 29, 2011, 12:54:31 PM
I'll give it look over....sounds nifty.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: NObama on May 29, 2011, 01:17:00 PM
Someone calculated long ago that it's actually cheaper to buy the bucklers.  However, that assumes one doesn't already have an endless supply of scripted iron.  This script neatly gets around the possibility of getting caught while purchasing, too.

Thank you for the contribution!
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: gimlet on May 29, 2011, 01:27:26 PM
Nice - Does it support gate?
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: The Reaper on May 29, 2011, 02:05:04 PM
Bucklers are 50g each, Spewy's Runebook Miner makes ingots free :P Sorry 12x but your mining script don't work on my freeshard :(

And gimlet, sorry mate, nope. I really need to get TM's travel subs into my scripts for ya :S

The main problem with this process is that in 1hour I've used 30k ingots, so your looking at 30 hours of continuous scripting for one pair of glasses. Not to mention the week of scripting for the ingots.

Although, you can sell the rarer ingots ofc.

I'll look into TM's travel subs soon, I promise :P Been too busy with IRL :(
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: gimlet on May 29, 2011, 03:08:00 PM
Reply - no problem!
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: 12TimesOver on May 30, 2011, 08:02:48 AM
Yeah I ran a number of calculations through all of the various donation options based on time, weight, and average cost of resources, etc in a nice spreadsheet. Definitely costs more in both time and gold to make your own bucklers (gold being dependant on the resource prices on your particular shard of course).

What it boils down to though is that sometimes it's not just a numbers game. I can't tell you how many people I've heard ask for something like this over the years simply because they have a seemingly "endless" influx of ingots and would rather burn them up this way. Personally I would rather sell the ingots and buy the bucklers, or just buy the glasses; but everyone has a different way to play. Great submission, hopefully we'll get some testers on this ;)

BTW, TM's subs are very easy to integrate so you should have an easy home run there.

XII
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: anewbe4u on May 31, 2011, 05:08:04 AM


What it boils down to though is that sometimes it's not just a numbers game. I can't tell you how many people I've heard ask for something like this over the years simply because they have a seemingly "endless" influx of ingots and would rather burn them up this way. Personally I would rather sell the ingots and buy the bucklers, or just buy the glasses; but everyone has a different way to play. Great submission, hopefully we'll get some testers on this ;)

XII

I sell 60000 ingots for just under 1m so it makes more sense personally for me to sell them to. Like the idea of this though because not every one has a vendor nor the shard population to have them sell at a good price.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: enrod on August 11, 2011, 09:58:27 PM
I gave this script a test, and it appears that when the donator is clicked on, the button is not pressed next to the buckler. My character just starts saying the number of bucklers without pressing the blue key to activate the donation. Maybe I'm doing something wrong or do others see this as well?
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: Crome969 on August 11, 2011, 11:10:44 PM
Very interesting Script.
I didnt runned it yet, but some thing i got focused about.
I dont like the Scriptstructure, but maybe iam just wrong but it seems like you created your own Structurestyle.
I would sugesst following:
But its just a minimum suggestion.

Crome
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: drifterxe on August 20, 2011, 09:53:08 PM
I'm having the same issue with the donating part where it missclicks the buckler donate button.

Post Merge: August 20, 2011, 10:10:49 PM
Okay, i solved the problem under the "; Hands in the bucklers" part of the script.

So i changed:

old --> "click 40 270 dmc"
new--> "click 40 273 dmc"

So basically i just moved the coordinates where it's suppose to click.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: Crome969 on August 20, 2011, 11:10:19 PM
I'm having the same issue with the donating part where it missclicks the buckler donate button.

Post Merge: August 20, 2011, 10:10:49 PM
Okay, i solved the problem under the "; Hands in the bucklers" part of the script.

So i changed:

old --> "click 40 270 dmc"
new--> "click 40 273 dmc"

So basically i just moved the coordinates where it's suppose to click.
It uses static Coords?
i would prefer making
Code: [Select]
set %x #contposx + %clickx
set %y #contposy + %clicky
click %x %y dmc
and setting your coords inside gump before as clickx and clicky
why?because when your gump change location in popup it would not fail:)
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: enrod on August 21, 2011, 08:05:54 PM
the static cords don't seem to work. The only fix I found was with the coordinates found in EUO, however i'd like to learn more about these static cords to help with a vesper script atm. The script I have uses the setup you listed, however it still doesn't click the circle for donation.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: MeWonUo on August 21, 2011, 08:52:21 PM
I'm just about finished with a new whammy hybrid character, and am going to need another set of glasses. 

Looking forward to giving this a try. Thanks for posting.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: vassenceto on September 17, 2011, 01:20:52 AM
Thanks for great script man.For  me runs fine with one little problem.When teleport to library it now dont  stop casting recall or sacred (depend what i put in setup) ,any advice how to fix that? if i move he cast one more time then runs fine
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: NObama on October 27, 2011, 11:08:23 PM
Nope.  The script RULES.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: Man7dowN on April 13, 2012, 04:29:19 PM
works good
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: Loki on May 13, 2013, 10:19:00 AM
I dont see the script?
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: UOMaddog on May 13, 2013, 10:37:58 AM
I dont see the script?

Reading this post may help with your question:
http://www.scriptuo.com/index.php?topic=1750.0
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: roadrunner on May 14, 2013, 12:38:22 PM
ok, ran across this script, thought it would be cool to get it setup & working since i just began playing a sampire that uses M&S shades. i got my secure on my steps, loaded 60,000 ingots into it, got the runes all set, and i'm thinking it's going great & about to start making bucklers. instead the script starts trying to make 'baskets' to hold the bucklers. that requires a whole different set of materials, a book to be read, etc. wouldn't the script requiring a few backpacks, or even the same boards for shafts for baskets, but instead make the boards form a crate, be more simple/ faster/ better? i'm certain the author was using the fewest skills possible, so the tinker can craft the smith hammer & baskets, but a carpenter (which my smithy/ tinker is also gm carpenter) could use those same boards and bang out a small crate a lot faster in fewer steps than a basket.
just offering an alternative idea guys, but i will sit down & make the materials for this script to run as is and see what happens. :)  (always wanted a use for those sacs of poison i looted from the sliths when SA launched hehehehe!)
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: roadrunner on May 16, 2013, 06:03:13 PM
 >:(
man, i've been a member here a very short time and every script i've tried has been really great work, some even beyond my comprehension to setup they were so intricate, but This script!! man, i don't know what is going on with it but all it wants to do for me is make the tiny little PICNIC Baskets!!  at 1st, i thought ok, the author makes a basket to drop 50 bucklers into, then donates basket, no biggie. i set about getting the materials and get everything all setup, hit play. i am thinking it's going to do a popup, ask where my library rune is, house rune, etc., but no, none of that happens. it just starts demanding the materials for making the baskets and keeps right on making baskets.
i would really love to have this work as posted!!! i have a few friends, as well as myself, that would love to get some mace & shields this way.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: Bookwyrm on May 16, 2013, 06:55:37 PM
Ok. First off. Are you on a free shard or OSI?

Next. Sounds like the gumps (menus) have been changed.

Not being script literate I would say look at the script and find where it is "supposed" to be making the bucklers.

Here.

Code: [Select]
if %TR_make_first_buckler = 1
   {
   click 285 415 dmc
   }
else
    {
    click 30 170 dmc
    wait 5
    set #contPosX 0
    set #contPosY 0
    wait 5
    click 235 70 dmc
    set %TR_make_first_buckler 1
    }
gosub TR_waitfor_generic_gump

Then examine the blacksmith menu to find the right menu buttons for making bucklers. use the location finder built into EUO to find the changed coordinates. exchange bad coords for good coords. and you might just be good to go on your own.
 ;D

No idea if that works or not. Just spitballing an idea here. ;)
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: TrailMyx on May 16, 2013, 07:56:03 PM
BW is right on here.  The craft gump probably has changed since this script was written, so the button positions for the buckler is in a different spot now.  You just need to find where it moved to, and then change the coordinates that are called out by the "click" command.  It's making 1 buckler, then repeating the last item made.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: roadrunner on May 17, 2013, 02:13:27 AM
see, this is why i really think this site rocks! you guys & gals really jump right on an issue and get it figured out.
sadly Bookwyrm, i'm even less script literate than you so i'd have never managed to figure that out.
thanks also TM!
i'll certainly read thru the code but not sure i can decipher where the 'buttons' are, nor how to locate the new ones, but that's what makes a day a good day, learning something new. :D

in reference to the question: OSI shards are all i play
**UPDATE**
ok, i got in game, booted EUO, and opened blacksmith menu, and then went down right hand side of EUO looking at all those #yadayada:  but this is where i'm lost. i have no idea what lines, nor in what section, i'm trying to find so i can go change it in the script. i understand the theory, i just need a little more guidance please.
As always, thank you all for the help in advance!!
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: Bookwyrm on May 17, 2013, 02:55:32 AM
Gotta rush to work atm. Will see if I can give you a more detailed fix when I get home.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: roadrunner on May 17, 2013, 03:07:47 AM
well bless you for trying BW. i've got every section on right hand side of EUO open and i'm looking but i can't seem to find any coords that appear similar to '30  170 dmc'
i really wish i knew at least this much about the codes, and i do want to get that knowledgeable, i'm just not there yet.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: UoLugnutz on May 17, 2013, 07:48:59 AM
well bless you for trying BW. i've got every section on right hand side of EUO open and i'm looking but i can't seem to find any coords that appear similar to '30  170 dmc'
i really wish i knew at least this much about the codes, and i do want to get that knowledgeable, i'm just not there yet.

Without reading the thread let me try and point you in the right direction. dmc = Dont Move Cursor and goes hand in hand with the click command. The numbers to the left are the x/y co ords were the click will happen. So if something has changed in the gump then you need to change the x/y location. What is the easiest way to do that? Go to the main SUO page and in the search box type in TrailMyx's OffsetClick generator and run that script.

Hope this helps!
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: roadrunner on May 17, 2013, 08:02:23 AM
thank you LugNutz!  i'll certainly give it a try. :)
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: roadrunner on May 17, 2013, 11:05:19 AM
 ;D
yeah, i got a Cheesey grin because i got TM's Offset Click Generator (the longer snippet of the 2 on the page) to give me this info

double click smith hammer: 113 X coord   21  X coord  gosub offsetclick 1641 856
click shields button: 113 x coord  21 x coord  gosub ofsetclick 28  134
click buckler button: 113 x coords 21 x coords 232  68

now i'm nowhere near sure this is the correct info because i'm clueless as to how i'm supposed to run the 2 snippets together. what i did was loaded the long snippet, clicked play, loaded short snippet (into EUO) clicked play. then as i clicked on each 'item' i hit alt+F1 and copied the info.
if this is right, and i'd have to be blessed by God for it to be right on 1st try, i'm going to need some help too know exactly what sets of numbers i change. i really don't want to break a script.
if i didn't get the correct info, if someone would be kind enough to tell me how to go about getting it, i'll try.
thanks again for all the help! i think thi; s is an awesome script, and it's 1 of the only NPC we cannot donate commodity deeds of resources to on OSI shards. so i need to get it working to get myself mace & shield glasses. hence my putting in so much effort. :)
PS: i'm currently mining ore like mad using Spewy's runebook mining script to have plenty ingots on hand when this buckler script gets straight. as always, if anyone knows of a script (mining) that setup isn't way over my head, for EUO (that's only console i'm familiar with so far) i'll certainly give it a try.

ok, i used TM's FINDINFO snippet and verified on my OSI shard the following:
tinker tools (oval wooden looking type):JTL (i did edit from KTL)
smith's hammer: TLH
buckler shield: FIK

OK, now that i got right tinker tool ID it made 'axe' which is top button, like buckler, just wrong page. so we may be on right trail. but this script never did the 'setup' w/ me. like askking for library rune, where my ingot stash is, none of that. any ideas how i might can get that all setup as well? in the script it says 'remove ";" below if you ever want to edit any of the setup and i removed & saved, in various steps, all of those i saw & restarted script but it never gave me the setup gumps.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: TrailMyx on May 17, 2013, 01:21:04 PM
Note that the offset click generator gives a RELATIVE x,y position from the selected gump.  So for the x,y values to make sense, you need to click the gump you want to locate a position.  In this case, you'll want to bring up the craft gump and CLICK it to be sure it's the TOP gump and then capture the x,y coords where you hover your mouse.  If you accidentally click your backpack, it will give your cursor position relative coordinates from your backpack instead of the craft gump.

I noticed this:

Quote
gosub offsetclick 1641 856


which leads me to believe that the the gump wasn't selected.

OR, I just noticed this.  All you need to do to "select" your smith hammer is to determine the #FINDID of the hammer, transfer that to the #LOBJECTID variable and perform a "event macro 17" which will "use" whatever ID is found in #FINDID.  In this case it will open your craft gump.

For this it's easy to get the #FINDID.  Just double click your hammer and then look at what value is located in the #LOBJECTID variable.

For these kinds of things since you can use up your hammers, you are best to search your pack looking for hammers of #FINDTYPE and then grab the appropriate #FINDID.  This allows you to have a bunch of hammers in your pack, and when you use one up (discarding the #FINDID) it will select the next hammer and continue with your request until you are all out of hammers.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: roadrunner on May 17, 2013, 02:10:13 PM
thank you TM !!  it's going to take me a little studying to make sure i comprehend all that accurately but i'll try & post my results.
i'm still left wondering why the script has not gone thru the 'setup' phase when i start it & how i can get that part to 'activate' so i can set the library NPC rune, house rune and such.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: TrailMyx on May 17, 2013, 02:22:41 PM
The easiest way to decypher how a script is running is to add a "pause" command into the code and the use function keys F7 and F8 to step through the code to see where it's executing.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: Bookwyrm on May 17, 2013, 04:05:04 PM

i'm still left wondering why the script has not gone thru the 'setup' phase when i start it & how i can get that part to 'activate'

Look (or use the search function) through the early part of the script. Likely there will be a line that says something like "run setup=False" chance false to true and the setup should run.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: roadrunner on May 17, 2013, 04:16:14 PM
thank you Bookwyrm
and if you could maybe help me figure out how to adjust the buttons so it stops making axe and makes buckler, this thing might run for me! *Crosses all 10 fingers & 10 toes and crosses legs also!!*
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: Bookwyrm on May 17, 2013, 04:19:23 PM
Working on it. But I have a house full of girls running around at the moment. Gotta get them settled in a bit more. :)
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: roadrunner on May 17, 2013, 04:29:07 PM
ok, i see this at very near top of script:

==================================
; Remove the ";" below to reset the script should you wish to change any of the setup
; gosub TM_NGFS_DeleteName TheReapers_Mace_and_Shield_Donator
; halt
;==================================

and then i see this a lil farther down:

;==================================
; Skips setup if save file exists
if %TR_save = 2
   {
   goto Start
   }
; Deletes save if previously used V1.0 of script
if %TR_save = 1
   {
   gosub TR_wipe_old_save
   }

not seeing any "run setup=False" 

 i'm not going anywhere, no plans this evening, so take your time. i'm most thankful for the help!!
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: Bookwyrm on May 17, 2013, 05:26:56 PM
Ok. Ran into a major snag for debugging this. I can't set this script up to run at my keep because you can't lock down an anvil in a recall accessible spot. So... if I can't run the script I can't debug it :'(.
But to find the X,Y coords you need there are two different ways to do it.

On the right hand side of the EUO screen expand the "Other Stuff" section. There you will find #CURSORX: xxx and CURSORY: xxx. The values you see are the current location of your cursor on your monitor. It can be any number from 1 to whatever the max of your screen resolution allows so expect 1,2,3, or 4 digit numbers to be there.

Also if you look at the very bottom of the EUO screen you will see several different strings of numbers. The one that matters to you should be in the fourth little box from the left side of the window. (Hint: it will be the one that changes as you move your cursor  ;)) this is another spot to find your X,Y coords and will match what can be found in the "Other Stuff" section.

Run the script so that it opens up the crafting menu and positions it where it is supposed to be. Pause or stop the script at this point. Position your cursor of the button that you need to clik for bucklers. Write down the Coords shown for X & Y. If there is more than one level of the menu to navigate do the same until you get to make the buckler.

in the script...
Code: [Select]
; Makes bucklers
sub TR_make_bucklers
repeat
gosub TR_menu_button
if %TR_shard = free
   {
   gosub TM_AdvJournalScan world VALID_ADVANCE The_world_will_
   if #result = #true
      {
      sound
      wait 30s
      if %debug = 2
         {
         display ok World save detected.
         }
      }
   }
finditem %plain_ingots C_ , #backpackID
if #findkind = -1
   {
   gosub TR_get_ingots
   }
else
    {
    if #findstack < 40
       {
       gosub TR_get_ingots
       }
    }
finditem %tinker_tools C_ , #backpackID
if #findkind = -1
   {
   display ok You need at least one tinkers tool in your backpack to run this script, halting!
   halt
   }
if #findcnt < 2
   {
   gosub TR_make_tinkers_tool
   }
finditem %smiths_hammer C_ , #backpackID
if #findkind = -1
   {
   gosub TR_make_hammer
   }
set #lobjectID #findID
wait 5
event macro 17 0
wait 5
set #contPosX 0
set #contPosY 0
wait 5
if %TR_make_first_buckler = 1
   {
   click 285 415 dmc ;[color=pink]Change these Coords[/color]
   }
else
    {
    click 30 170 dmc ;[color=pink]Change these Coords[/color]
    wait 5
    set #contPosX 0
    set #contPosY 0
    wait 5
    click 235 70 dmc
    set %TR_make_first_buckler 1
    }
gosub TR_waitfor_generic_gump
finditem %buckler C_ , #backpackID
until #findcnt > %max_buckler_amount
set %TR_no_bucklers #findcnt
return
   
I believe that should be the right section to change. I could very well be wrong. If so I hope one of the others can point you in the right direction. It appears that there should only be two sets of coords to change.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: Bookwyrm on May 17, 2013, 05:30:45 PM
ok, i see this at very near top of script:

==================================
; Remove the ";" below to reset the script should you wish to change any of the setup
; gosub TM_NGFS_DeleteName TheReapers_Mace_and_Shield_Donator
; halt
;==================================

and then i see this a lil farther down:

;==================================
; Skips setup if save file exists
if %TR_save = 2
   {
   goto Start
   }
; Deletes save if previously used V1.0 of script
if %TR_save = 1
   {
   gosub TR_wipe_old_save
   }

not seeing any "run setup=False" 

 i'm not going anywhere, no plans this evening, so take your time. i'm most thankful for the help!!

OK right there where it says to remove the ; on the next line? Delete out the ; on the line that says " ;gosub TM_NGFS_DeleteName TheReapers_Mace_and_Shield_Donator"
and the same on the ;halt line.
run the script and it should erase your saved setup.
replace the ;'s at the beginning of the lines then run script again and you should be able to redo your setup
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: roadrunner on May 17, 2013, 05:42:59 PM
man, i thank you Bookwyrm!  i actually got all the 'buttons' mapped out & working now i'm trying to get the script to show me the inital setup portion. ii see your post on how to remove those ";" and about to test it to see if that works

if this doesn't work, what is the name of this 'file' the script saves the setup variables as? i could delete that file & it should make the script run setup that way, right?
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: roadrunner on May 17, 2013, 05:53:09 PM
ok!!!  it may not be the RIGHT way but i did get the setup menu by changing the "2" in this section to a "0"

;==================================
; Skips setup if save file exists
if %TR_save = 2
   {
   goto Start
   }
; Deletes save if previously used V1.0 of script
if %TR_save = 1
   {
   gosub TR_wipe_old_save
   }

now to see if it'll make bucklers & do the turn in, i'll keep ya posted!

thank you all, especially Bookwyrm, for all the wonderful help!!

**UPDATE**
;==================================
; Wipes out of date save
sub TR_wipe_old_save
gosub TM_NGFS_DeleteName TheReapers_Mace_and_Shield_Donator
return

remove that lead ";"  and that activates the setup menus!!

now to adjust the donation buttons because it's not working exactly right at library. that should be sorta simple after all the othher button location changes :)
**UPDATE**
the character lands at NPC and opens the donation gump but he starts yelling the amount of bucklers made but doesn't actually target them to donate. any ideas on how i'd fix this?  i can forward my 'fixed' OSI shard version that makes smith hammer & buckler shield to anybody that is willing to work on this. i'd really like to be able to have this script totally functioning again for all users. :)
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: roadrunner on May 18, 2013, 03:51:36 AM
OK guys & gals, imagine me on bended knees, hands clasped, i am seriously at the end of my knowledge on this. i need some serious HELP!
 the guy who joined SUO w/ me was who i sat down w/ last night and together we managed to map out the buttons and got the script functioning correctly for the OSI shards. imagine my surprise when i jumped into browser to post that & saw Bookwyrm's post on that exact section of code we had just finished altering. 

so the script starts, makes tinker tool, makes smith hammer, makes bucklers (50 as it's s'posed to), it recalls to library, opens the donation gump, and here is where is snags! i know over the years the donation 'formula' has changed many times but i don't remember us being able to click on item donation type 'blue button' and 'say'  "50" and the NPC take 50 bucklers from your main backpack. maybe this script was written originally for a free shard that allowed that method.

what i need: to know what part of this script to change, and to change it to either have it target each buckler in backpack to donate (click donate button/ target a buckler) ORRRrrr after it makes the 50 bucklers (since the NPC only takes the bucklers but does NOT take the bag they are in) have it put all 50 bucklers into a bag (backpack) and then recall to library, click donate bag button, select 'donate all' on that new gump popup, and viola', done, haul ass home to make 50 more.
pretty please give an old man some help here and let's get this script working! it's so close to being done and i truly want, WITH Trailmyx's permission!!, to RE-post the finished product for OSI shard users. i think (because i see players asking for these mace & shield glasses almost daily) this script would be in high demand. so i plead with you real scripters, help us get this script working, please, and as always, Thank You in advance for any & all help!!!
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: UoLugnutz on May 18, 2013, 04:56:53 AM
I dont have UO installed at work so can only show ya the direction to go. Look for the sub below.
Code: [Select]
;==================================
; Hands in the bucklers
sub TR_Hand_in
set %TR_temp_weight #weight
repeat
set #lobjectID %TR_Donation_NPC
event macro 17 0
gosub TR_waitfor_generic_gump
set #contPosX 0
set #contPosY 0
wait 5
click 40 260 dmc
wait 10
msg %TR_no_bucklers $
wait 10
until #weight < %TR_temp_weight
set %TR_Status_bucklers ( %TR_Status_bucklers + %TR_no_bucklers )
set %TR_no_bucklers 0
gosub TR_update_status
return
;==================================

Now this is looks like the donation sub were the problem is. Now think if you were to do the donation manually how it works. You click on the buckler bullet and then asked how many to donate. You enter in 50 and hit enter and all is well. You character does not say 50 on the game screen but the number is entered into the gump. The msg %TR_no_bucklers $ command is like typing 50 on your keyboard and hitting enter. So unless the buckler option is clicked anything typed in will show in game as if you were talking since the gump was not selected. This is why you are spamming 50 because the click for the buckler donation is wrong. This sub has a Repeat/Untill loop untill the weight changes as a check that something was donated. Since nothing is donated because the click for bucklers is wrong it is stuck inside that loop. If you fix the click for buckler all will be well in the world.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: roadrunner on May 18, 2013, 05:24:24 AM
ok, so what you're telling me is the script wasn't clicking the ''bullet'' (what i call 'blue dot') correctly before it started saying "50"  "50" "50"  "50", right?
and thus, i need to figure out which 'click coords' point to the donation gump, adjust the ones for the buckler bullet, and the rest should work, right?

from what you pasted, i need to at least verify "click 40 260 dmc"  is accurate, and if not, fix it.

***UPDATE!!!***
ok, after busy weekend i got around to tracking down the buckler 'button' coords & changed'em to 291  320.
that still doesn't do anything 'different'. toon still lands beside the NPC, opens donation menu, menu moves from center left of screen to far left of screen with "50" on the gump to the right of the buckler image. and the toon still yells "50" a few times, then without donating any items, recalls home to begin making more.

i also discovered 1 other 'minor' glitch. the toon makes a new Tinker Tool every time it wants to make a smith hammer. needless to say, a few trips to library & i'd have a backpack full of tools and no item count space left for bucklers.

i know you legendary scripters are well beyond this sort of thing, but as a bonafide newbie, i beg of your expertise to help me get this script usable. Thank you all for your input & advice!!
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: roadrunner on May 26, 2013, 03:48:00 AM
ok TM, i got the F7 & F8 figured out. i ran it thru the hand in sections, it's a 2 part sub : hands in the bucklers   && wait for hand in gump

Code: [Select]
; Hands in the bucklers
sub TR_Hand_in
set %TR_temp_weight #weight
repeat
set #lobjectID %TR_Donation_NPC
event macro 17 0
gosub TR_waitfor_generic_gump
set #contPosX 0
set #contPosY 0
wait 10
click 39 268 dmc
wait 10
msg %TR_no_bucklers $
wait 10
until #weight < %TR_temp_weight
set %TR_Status_bucklers ( %TR_Status_bucklers + %TR_no_bucklers )
set %TR_no_bucklers 0
gosub TR_update_status
return
;==================================
; Wait for hand-in gump
sub TR_waitfor_generic_gump
set %TR_time #scnt
repeat
if You_create_ in #sysmsg
   {
   break
   }
if #scnt > ( %TR_time + 10 )
   {
   break
   }
wait 0
until #contname = generic_gump
wait 5

the script jumps from the 1 into the other and back & forth with the return & waitfor generic gump commands.  i'm just not 'seeing' where it's actually supposed to physically 'click' (target) the bucklers so they vanish from backpack 1 by 1 to be 'donated'.  i see where it reads character weight, and how weight is to drop so script knows they are donated, i just not seeing where it would have to target the bucklers, thus it's way over my head on how i'd fix it.

***UPDATE***

Ok, in previous posts i've said the "50" the character is "saying" has now been coming up ON the donation gump. well, my little 'grab & bag side script goofed up so i was donating this batch of 50 manually and the "50" on the gump is the client reading how many are in backpack left to donate because it's counted down as i donated each one without me typing anything, no script running. just to be clear, as i targeted each buckler it went 50, 49,48,47, etc.  and i just click blue dot & target bucklers. so again, i'm very confused on this part of this script. :(

Another update is the script will, as UOLugnutz posted, continuously 'loop' at the donation NPC now. it's clicking the donation button but not targeting the bucklers, so weight doesn't lower, so it loops on & on. (i let it run for a few minutes to see just to be sure!)
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: roadrunner on May 26, 2013, 02:14:31 PM
 ;D  well, it took me contacting a friend that is a professional programmer (his real 9-5 job) and he re-wrote the hand in sub for this script & it's now fully operational hands free!!
we went the quick & easy route and incorporated UO Asssit into the script but when that breaks he said he'd write a new independent sub that is stand alone.
i'm not complaining, it makes what it's supoosed to, it donates as it's supposed to, and all i'm required to do is log it in and keep it supplied with ingots. :D

if anyone that plays OSI shards, and has UO Assist active, would like a copy of the donation sub i'm using, contact me & we'll work it out. i can't "publish" what's not mine.
i've really learned a lot messing w/ this script & it's really inspired me to learn more. maybe some work by "Roadrunner" will be coming soon!
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: Endless Night on October 08, 2013, 08:45:15 AM
Moved to inactive submissions,  when you return to uo and scriptuo pm a mod and we will move it back into the appropriate active script board.

Thanks for the submission.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: TMS on January 29, 2016, 06:52:18 AM
Not working for me.

It crafts de bucklers, recall to library but when its time to donate it just stands up still there.

Any help?
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: TrailMyx on January 29, 2016, 07:13:23 AM
I haven't seen the author for a while.  It's up to you to figure out what's going on.  Just a few "pause" commands and single-step through the code and you can figure it out yourself.
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: 12TimesOver on January 29, 2016, 07:14:59 AM
Not working for me.

It crafts de bucklers, recall to library but when its time to donate it just stands up still there.

Any help?
You are playing around with a script that has been in Inactive status for nearly 2 and a half years! You may have some luck getting someone to check it out with you but I wouldn't hold my breath. You may have better luck looking around for a different script that may still be supported.

X
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: TMS on February 01, 2016, 07:12:39 AM
Not working for me.

It crafts de bucklers, recall to library but when its time to donate it just stands up still there.

Any help?
You are playing around with a script that has been in Inactive status for nearly 2 and a half years! You may have some luck getting someone to check it out with you but I wouldn't hold my breath. You may have better luck looking around for a different script that may still be supported.

X

yep, i know, but maybe someone could help me :(
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: NObama on February 02, 2016, 07:13:49 PM
You could learn a great deal if you decided to put the time into stepping through this script in debug mode and teaching yourself to tweak it as you go!
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: Crisis on February 03, 2016, 02:46:57 AM
Check the NPC it is looking for. You may have to change the id or name. Did you do the quest line that allows you to donate? Official shard or private? There are a ton of things to look into and that should get you started. :)
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: barley90 on June 08, 2017, 01:04:50 AM
Still have problems with download
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: TrailMyx on June 08, 2017, 04:55:43 AM
Please check out the site rules regarding downloads.

http://www.scriptuo.com/index.php?board=55.0
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: leiva on August 21, 2017, 02:45:45 PM
Thank you for the contribution!
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: Weomacer on October 18, 2017, 12:38:53 PM
i can use this script for a freeshard???
Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: The Ghost on December 03, 2017, 03:10:21 PM
Ye this script work for free shard.

To get this to run again, you will need:
1)  look at all the crafting location.  alot of them have change.
2)  the way to donate have change too.  we no longer give one item at the time or a box.   we just under the amount.   So u need to modified the Hand in sub.

Other them that it work fine.  slow to craft but it is doing the job. 

PS:  I did remove those
Code: [Select]
set #contPosX 0
    set #contPosY 0
    wait 5
    click 235 70 dmc
by
gosub TG_offsetclick 235 70
Code: [Select]
;===========  offset click sub =======
sub TG_offsetclick
; %1 #CursorX
; %2 #CursorY
; %3 %4 %5 click comman  (d,dmc, f,g etc
  set !clickx ( #contposx + %1 )
  set !clicky ( #contposy + %2 )
  click !clickx !clicky %3 %4 %5
return
;=============  end sub =======

Here an example
Code: [Select]
; Makes tinker tools
sub TR_make_tinkers_tool
set #lobjectID #findID
event macro 17 0
wait 5
gosub TG_offsetclick 30 110   ; tool
wait 5
gosub TG_offsetclick  230 130  ; Tinker tool
gosub TR_waitfor_generic_gump
return

Title: Re: TheReapers Mace and Shield Donator - Get some funky glasses today!
Post by: Wysheer on May 13, 2020, 04:58:07 AM
Wow, im a noob player, and i was saving dor buying this.. 5kk. Now ive found this! Ill give a try!
Thanks!