SUO AIO Weapon Crafting Tool v1.5 WORKING IN FULL

[TrailMyx]

... be carefull using other peoples scripting in scripts you're going to release also Cor.  People don't like that a lot.

I agree.  If you pull and use a snippet from another script, please credit the author. 

[Scrripty]

Yea, I didnt forget about testing yours, as a matter of fact, THATS THE REASON I STARTED THIS, didnt have a good weapon to test with for the specific tests I wanted.

Hey Coragin?  What weapon are you trying to make to use the PVM Dexer with?  Because seriously you don't need a good weapon.  Anything that's FAST, has medium damage and lower defense is fairly decent.  If it has lower d and hit stamina leech even better.  But fast and lower defense is all you need, and you don't even need lower d if you have it on your suit.

[Coragin]

Okay, I cant find the problem...but I got almost ALL the rest fixed....

It is stuck on MAKE LAST, I know my clicks are right, I just re-went through all of them.  It is somewhere in the first make sub but I cant figure out where....lol

Can you guys look at that and see if you see something?

And I will go through the rest of the code for mis-spellings too lol.

Thank you so much Bama!

[Coragin]

I ran your script through TM's ScriptUO and came up with this:

Warning - Gosub checkreptiLSlayer - Line 594 has no matching SUBroutine
Warning - SUBROUTINE checkreptileslayer - Line 760 unused
Warning - SUBROUTINE nextpage - Line 1026 unused

So by that I'd say your spelling on checkretilslayer on line 594 is wrong for one   And those other sub nextpage isn't being called at all... be carefull using other peoples scripting in scripts you're going to release also Cor.  People don't like that a lot.

Fixed = Warning - Gosub checkreptiLSlayer - Line 594 has no matching SUBroutine
Fixed = Warning - SUBROUTINE checkreptileslayer - Line 760 unused
Cant find = Warning - SUBROUTINE nextpage - Line 1026 unused

And yes I know how to find what line I am on :p

I dont know why the click isint working to make the item though.

[Coragin]

... be carefull using other peoples scripting in scripts you're going to release also Cor.  People don't like that a lot.

I agree.  If you pull and use a snippet from another script, please credit the author. 

The only thing that isint original is the gumpwait sub, which I got it out of MAss's Relic script, and credit was given, not only to Mass but all who have been helping me.  Twinkle McNugget and EN are gonna get their own special area in all my scripts they have helped me so much.  Between posts and PM's...wow, I may be a big contributor after all. 

[Coragin]

Okay here is an example of the sub to make a bow....I am using this because well, it dont matter which one I use, whatever is the last thing I made is what gets made.

Code: [Select]

Sub FirstMake
if %Bow = #true
   gosub MakeBow

*bleep* I got it in the middle of typing this...

Code: [Select]

if %Bow = #true

Now this is where it defines a bow...

Code: [Select]

if #menures = 1
   {
   set %Bow = #true
   set %Weapon WOH               ;Bow
   set %wood TLK
   set %runic UFG
   ;goto setup1
   }
That is correct, it defines bow as true, however the rest of them....like this for example....

Code: [Select]

if #menures = 2
   {
   set %Weapon USF               ;Crossbow
   set %wood TLK
   set %crossbow = #true
   set %runic UFG
   ;goto setup1
   }
No defining of Crossbow = #true

Finally!!!  I need to change 46 lines, then upload the new version.

[Scrripty]

Well congrats.   I didn't really help you tho, just pointed you in the right direction bud.   It's fun when something starts to really make sense tho huh?  Just wait till EN starts beating on you for using too many lines in your code.   hehe

[Coragin]

Ugh nope that wasent it as far as I can tell, they actually are there, just below...

Does that matter?  And would it be Case Sensitive?

[NObama]

Don't believe it's case sensitive...

 

[Scrripty]

Don't believe it's case sensitive...

 

EUO ignores case.   Coragin there's some good reading in this thread.  Take a look when you can.

http://www.scriptuo.com/index.php?topic=2619.0

[Coragin]

GOT IT!  New file being uploaded!  Please test.

[JustAnotherFace]

I took a very quick look thru your code, cant test it out here at work, but was just scanning thru to see how it looks.  I have a couple of pointers for you, that some others were nice enough to pass along to me in the past.  These will cut down dramatically on the number of lines of code you have, as well as the number of sub-routines.

1)

Code: [Select]

menu get Arachnid                             ;slayers
if #menures = #true
   set %ArachnidSlayer #true
if #menures = #false
   set %ArachnidSlayer #false
menu get Demon
if #menures = #true
   set %DemonSlayer #true
if #menures = #false
   set %DemonSlayer #false
menu get Elemental
if #menures = #true
   set %ElementalSlayer #true
if #menures = #false
   set %ElementalSlayer #false
menu get Repond
if #menures = #true
   set %RepondSlayer #true
if #menures = #false
   set %RepondSlayer #false
menu get Reptile
if #menures = #true
   set %ReptileSlayer #true
if #menures = #false
   set %ReptileSlayer #false
menu get Undead
if #menures = #true
   set %UndeadSlayer #true
if #menures = #false
   set %UndeadSlayer #false
menu get Fire                                 ;damage types
if #menures = #true
   set %FireDmg #true
if #menures = #false
   set %FireDmg #false
menu get Cold
if #menures = #true
   set %ColdDmg #true
if #menures = #false
   set %ColdDmg #false
menu get Poison
if #menures = #true
   set %PoisonDmg #true
if #menures = #false
   set %PoisonDmg #false
menu get Energy
if #menures = #true
   set %EnergyDmg #true
if #menures = #false
   set %EnergyDmg #false
menu get Multiple
if #menures = #true
   set %Multiple #true
if #menures = #false
   set %Multiple #false
menu get SSI25
if #Menures = #true
   set %SSI25 #true
if #menures = #false
   set %SSI25 #false
menu get SSI30
if #Menures = #true
   set %SSI30 #true
if #menures = #false
   set %SSI30 #false
Ok, someone can feel free to correct me if I am wrong, but I am pretty sure that you do not need all those

Code: [Select]

if#menures = #false statements in there.  In fact you can shorten up your code a lot but simply writing it like this:

Code: [Select]

Menu get Arachnid
If #menures
   Set Arachnid #true
Menu get blahblah
If #menures
   Set blahblah #true
Menu get YouGetThePoint
If #menures
   Set YouGetThePoint #true

2)

Code: [Select]

sub CheckWeapon1
if %ArachnidSlayer = #true
   gosub CheckArachnidSlayer
if %ElementalSlayer = #true
   gosub CheckElementalSlayer
if %ReptileSlayer = #true
   gosub CheckReptileSlayer
if %UndeadSlayer = #true
   gosub CheckUndeadSlayer
if %RepondSlayer = #true
   gosub CheckRepondSlayer
if %DemonSlayer = #true
   gosub CheckDemonSlayer
This could be changed up a little and the resulting subs could also be changed to a single sub:

Code: [Select]

sub CheckWeapon1
if %ArachnidSlayer = #true
   gosub CheckSlayer arachnid
if %ElementalSlayer = #true
   gosub CheckSlayer elemental
if %ReptileSlayer = #true
   gosub CheckSlayer reptile
if %UndeadSlayer = #true
   gosub CheckSlayer undead
if %RepondSlayer = #true
   gosub CheckSlayer repond
if %DemonSlayer = #true
   gosub CheckSlayer demon
The resulting subs could all be captured in one sub like follows:

Code: [Select]

Sub CheckSlayer ; %1 property passed from above sub to check for..E.G. arachnid, demon, etc
         finditem %MadeWeapon C_ , #backpackid
         if #findcnt >= 1
            {
            event property #findid
            if %1 in #property
               {
               wait 5
               Gosub StoreWeapon
               Return
               }
            }
Return
The same can be done for you cold, fire, poison etc damage weapons as well. 

This line may give you some unexpected results:

Code: [Select]

if %elemental in #property && Fire notin #property && Water notin #property && Poison notin #property && Air notin #property && Earth notin #property && Blood notin #property && Snow notin #property && Ice notin #property
The unexpected results will come in when you make an elemental slayer that also has fire or poison damage on the bow.  In other words, if you make an Elemental superslayer with 50 phy damage and 25 fire damage and 25 poison damage, this bow will not get stored.

Again, just some real quick looks thru your code and hopefully something helpful.  Your doing a great job so far, keep up the good work!

JaF

[Coragin]

Thanks for the input and advise JaF.  I will use it eventually, but as of right now I am still learning and want to stick with what I do know and make a script that works and do changes at a later time to condense subs and the script.

Try it out when you get home, truely is a wonderful tool for burning down runics for specific things you want on a weapon, but dotn wanna keep clicking make last lol.

[Scrripty]

Thanks for the input and advise JaF.  I will use it eventually, but as of right now I am still learning and want to stick with what I do know and make a script that works and do changes at a later time to condense subs and the script.

Try it out when you get home, truely is a wonderful tool for burning down runics for specific things you want on a weapon, but dotn wanna keep clicking make last lol.

Cor, what he said is correct, you do need to work on the fire/poison elemental scanning so it doesn't throw away or burn things you want to keep...  Sounds like he knows what he's sayin... I haven't looked at it so I don't know.   I'm sure there's a script out there that uses #property to scan for 100 percent elemental damage you could look at to see how they did it.  No one wants a script that burns runics if it doesn't do exactly what you want and wastes the runic...

[JustAnotherFace]

I respect and understand your wanting to learn it in your own time!  Again, was just some pointers to help you out if you wanted to reduce your code.

One other thing I noticed is in this part of the code:

Code: [Select]

Sub Unravel
Repeat
    finditem %MadeWeapon C_ , #BackPackid
    If #findcnt = -1
       {
       Return
       }
    Event Macro 13 56
    gosub waitforgump %imain
          if ! #result
          {
          display ok Problems opening the imbue menu.  Dble Click fletcher tool and click play
          pause
          }
    Click 228 248 f
    wait 30
    set #ltargetID %MadeWeapon
    event macro 22 0
    ;gosub waitforgump %imain
          if ! #result
          {
          display ok Problems with imbue unravel menu.  Dble Click fletcher tool and click play
          pause
          }
    Click 50 250 f
    wait 30
    gosub StoreResidue
Return
You are using the repeat command with no until following.

Also, the

Code: [Select]

if #findcnt =-1 should probably be changed to

Code: [Select]

if #findcnt < 1
You should put an until after the repeat somewhere.... Actually I would change it to totally take out the if #findcnt < 1 and do it like this:

Code: [Select]

Sub Unravel
Repeat
 {
    finditem %MadeWeapon C_ , #BackPackid
    Event Macro 13 56
    gosub waitforgump %imain
          if ! #result
          {
          display ok Problems opening the imbue menu.  Dble Click fletcher tool and click play
          pause
          }
    Click 228 248 f
    wait 30
    set #ltargetID %MadeWeapon
    event macro 22 0
    ;gosub waitforgump %imain
          if ! #result
          {
          display ok Problems with imbue unravel menu.  Dble Click fletcher tool and click play
          pause
          }
    Click 50 250 f
    wait 30
    gosub StoreResidue
 }
Until #findcnt < 1
Return
Again, I am not trying to tell you what to do, just to offer advice and point you in the right direction.  Hope this helps in some way.

The documentation for the Repeat - Until command can be found here http://wiki.easyuo.com/index.php/Repeat..until

JaF