Where can I post so folks can test?

[Insideout]

Title says it all. Of course being a mod job from another script I can't really take any credit but at the same time it sure makes clipping all the plants easier lol

[Tidus]

It would eventually be put in Script Debug.  However since you stated that it is a mod of someone else's script you need to ask them for permission.  It is okay to take some subs of someone's script and put it to use in your own script, but if you only made small edits to an existing script you need permission to post it.  Once you have that permission you would then be able to submit it in Script Debug.  Alot of people are not so open to modding and posting of their script if it is meant to only suit your needs and not the needs of others.  However if it is small fixes on the person's script, would it not be better to submit the script to that person and ask them to just put in the edits?

[Insideout]

Well I thought of that as i was modding the script. I haven't heard back from the Author nor has the Author been active for  over the years which put me in a pickle I guess. So what do I do in that case

[Tidus]

Link the original script you are modding so i can see where it came from and the Author.

[Endless Night]

Is the original script on these boards.
If so post your modded version in their script thread.

The question really is how extensive is your modding.  If its just changing a few click positions that would not be considered a mod.  If were talking you changed 80% of the code have made attempts to contact author, credit them in the script header and in what ever thread you make to post it then thats cool.   (And continue to credit them long after all the original code is gone)

Tell us the case, post link to original script if you have it and we will advise.   

The place to post, if you believe its sufficiently modded etc  will be script debug or script submissions depending on the readiness state of it.


thanks for asking.

[Insideout]

Okay original script came from EUO

http://www.easyuo.com/forum/viewtopic.php?p=352262#352262


Then here is what I have done which is just basically change ID's and sub names with the exception of  the dragstack that someone added in another thread for me

Code: [Select]

set %clipper JFF
set %plant QLI_OLI_BCF_VWE_BWE_UAF_JWE_IWE_EXE_UWE_ICF_BXE_YVE_CCF_NWE_MWE_DXE_TCF_NXE_BKP_ZJP_MKP_AKP_CKP_OKP_NKP_LKP_TXE_ZBF_AIF_GWE_VWE_WTE_ZBF_BWE_BCF_CCF_SVE_IWE_MWE_YVE_REK_QVE_BFK_WTE_FWE_NXE_CYE_JDF_WWE_ISN
set %clipping KKY


finditem %clipper JFF, #BACKPACKID
if #FINDKIND = -1
{
  finditem %clipper JFF , #CHARID
  if #FINDKIND = -1
  {
    display OK No clippers found in backpack !
    halt
  }
}
set %clipper #FINDID
display OK Click on the container holding the plants
set #TARGCURS 1
while #TARGCURS = 1
{
}
set %secureID #LTARGETID
set #LOBJECTID %secureID
event macro 17 0
wait 2s

getmoreplant:
finditem %plant  C_ , %secureID
if #FINDKIND = -1
{
  display OK Completed!
  halt
}
set %dragStack 1
exevent drag #FINDID %dragStack 1
exevent dropc #BACKPACKID
wait 2s

retryUseClipper:
finditem %plant  C_ , #BACKPACKID
if #FINDKIND = -1
{
  goto getmoreplant
}
set #LOBJECTID %clipper
set #LTARGETID #FINDID
event macro 17 0
target 2s
event macro 22 0
wait 2s
finditem %clipping  C_ , #BACKPACKID
if #FINDKIND = -1
{
  goto retryUseClipper
}
exevent drag #FINDID #FINDSTACK
exevent dropc %secureID
wait 2s

goto getmoreplant

[Tidus]

So the original script was for converting logs to boards and you made this into a clipper maker?   This is totally different than it's original intent. It to me would be considered a new work. So you need to give credit where credit is due in the header of the script.  Just give as much credit that is due.  I would suggest not doing your displays in the script the same as the person. 

I personally do not like how the script is set up. No subs and only gotos.  Do a bit more rewriting where you can, and then put into script debug.

[Endless Night]

Added code blocks to your above post.   When posting code please wrap it in code blocks  [ code ] [ / code ]  (minis the spaces)

I also updated your script to be cleaner... check it out .. test it to make sure it works as i didnt test it at all.   With your changes and my changes you can safely post this as a new script in script debug or script submissions.   Just remeber to still credit and include a link to the original script, as the basis for your script and learning.

good luck

Code: [Select]

set %clipper JFF
set %plant QLI_OLI_BCF_VWE_BWE_UAF_JWE_IWE_EXE_UWE_ICF_BXE_YVE_CCF_NWE_MWE_DXE_TCF_NXE_BKP_ZJP_MKP_AKP_CKP_OKP_NKP_LKP_TXE_ZBF_AIF_GWE_VWE_WTE_ZBF_BWE_BCF_CCF_SVE_IWE_MWE_YVE_REK_QVE_BFK_WTE_FWE_NXE_CYE_JDF_WWE_ISN
set %clipping KKY

finditem %clipper JFF, #BACKPACKID
if #FINDCnt = 0
  {
  finditem %clipper JFF , #CHARID
  if #FINDcnt = 0
    {
    display OK No clippers found in backpack !
    halt
    }
  }
set %clipper #FINDID
display OK Click on the container holding the plants
set #TARGCURS 1
while #TARGCURS = 1
{
}
set %secureID #LTARGETID
set #LOBJECTID %secureID
event macro 17 0     ; open bag
wait 2s

; plants
Repeat
  finditem %plant  C_ , %secureID
  set %PlantCount #Findcnt
  if #FINDCnt > 0
    {
    ; move plant to backpack
    exevent drag #FINDID 1
    exevent dropc #BACKPACKID
    wait 2s
    ; UseClipper
    set #LOBJECTID %clipper
    set #LTARGETID #FINDID
    event macro 17 0
    target 2s
    event macro 22 0
    wait 2s
    ; Move ALL clippings to secure
    finditem %clipping  C_ , #BACKPACKID
    if #FINDCnt > 0
      {
      for #findindex 1 #findcnt
        {
        exevent drag #FINDID #FINDSTACK
        exevent dropc %secureID
        wait 2s
        }
      }
    }
Until %PlantCount = 0
display OK Completed!
halt


[Endless Night]

Just noticed an additional error...   you have these to erroneous lines

Code: [Select]

finditem %clipper JFF, #BACKPACKID
finditem %clipper JFF , #CHARID
this should  be either

Code: [Select]

finditem %clipper c_ , #BACKPACKID
finditem %clipper C_ , #CHARID
or

Code: [Select]

finditem JFF  c_ , #BACKPACKID
finditem JFF  C_ , #CHARID

[Insideout]

Yeah the charID will need to go. As the original had the Axe in the pack or on the person.

[The Ghost]

if you are just looking to click  try this.

This from here  http://www.scriptuo.com/index.php?topic=10887.0

Code: [Select]

set %planttypes OLI_BCF_VWE_BWE_UAF_JWE_IWE_EXE_UWE_ICF_BXE_YVE_CCF_NWE_MWE_DXE_TCF_NXE_BKP_ZJP_MKP_AKP_CKP_OKP_NKP_LKP_TXE_ZBF_AIF_GWE_VWE_WTE_ZBF_BWE_BCF_CCF_SVE_IWE_MWE_YVE_REK_QVE_BFK_WTE_FWE_NXE_CYE_JDF_
set %clippers JFF_KFF
repeat
  finditem %planttypes G_5
  if #findcnt >= 1
      gosub Clipping
until #findcnt = 0
Halt