ScriptUO
Official ScriptUO EasyUO Scripts => Script Library => Crafting => Topic started by: Neo on September 07, 2011, 05:56:02 PM
-
;===================================================================================
; Script Name: neo's Bod Swapper Public Edition
; Author: neo
; Version: 1.0
; Client Tested With: 7.0.18.0
; EUO version tested with: 1.50 202
; Shard OSI / FS: OSI
; Revision Date: 09/22/2011
; Public Release: 09/06/2011
; Purpose: Swaps filled bods at NPC. Will recall home to drop off stuff.
; Only for Smith BODS!
;-----------------------------------------------------------------------------------
; Special Thanks: - TM for his NGFS and Recall subs.
; - 12timesover for his XIIxMaxWeight sub
; - MeWonUo who's the co-author of our private edition :)
; - Newsman for debugging v0.2 with me for people with low ping!
;-----------------------------------------------------------------------------------
; Url: http://www.scriptuo.com/index.php?topic=8460.0
;------------------------------------------------------------------------------------
; Version 1.0 Lots of changes:
; - Changed recall subs. You can now choose whatever runes for all 4
; runes you wish to use
; - Redid menu, and the way setup works
; - Saving will now work properly
; - If an NPC can't be found within 2 tiles, it will search for an NPC up
; to 7 tiles away, and then walk over to them to do the swapping.
; Won't open doors though, so make sure there aren't any doors
; between you and the NPC. And it won't pathfind either, so have a
; clear path to the NPC! Thank you TM for this suggestion! :)
; - Will now finish putting away your stuff after the last bod is swapped.
; - Removed gloves from 'return item' list. Turns out you can't return
; gloves, and I had forgotten about it! :)
; - Added gargoyle pickaxes to 'return item' list
;-------------------------------------------------------------------------------------
; Version 0.4 - Changed #findrep back to 7, which is fixed in EUO 1.50 202
;-------------------------------------------------------------------------------------
; Version 0.3 - Made the script a little slower to prevent issues to people with
; low ping.
; - A few minor fixes
;-------------------------------------------------------------------------------------
; Version 0.2 - Fixed not finding NPC issue with new EUO/Client version
; - Added option to chose your travel method
;-------------------------------------------------------------------------------------
; Instructions: - You must setup your containers at home for each kind of reward. You
; can chose some rewards that you don't want to keep to be returned to
; the NPC. If a container for your mining stuff (ie pickaxes, prospect, etc.)
; gets full, those items will be added to the return list, and start being
; returned to the NPC.
; - You must write the rune numbers of both runes for each location in the edit box
; in the menu.
; 2 runes for smith, 2 runes for home. They MUST be consecutive runes
; in your book, i.e. 7 & 8 for your home runes, or 3 & 4 for you smithy runes
; Remember to mark runes close enough to the NPCs
; - You can save/load your setup, so that you don't have to set your containers and rune books
; every time you run the script
; - After everything is set, you must recall to the smithy and hit the start button ONLY WHEN
; YOU'RE AT THE SMITHY! If you hit start being somewhere else, the script won't work
;---------------------------------------------------------------------------------------------------------
; This is a variation of a personal script I wrote for personal use, so I decided to modify it a bit
; and post this public version. Hope to get some feedback so I can keep fixing
; and improving this until it's stable enough for everyone to run it flawlessly.
;-----------------------------------------------------------------------------------------------------
Hey guys... I wanted to share with you the script I use to swap bods at the NPC. This is for smith bods ONLY.
I had to modify it from my private version a bit for a public release, but it should still be pretty useful, if you don't like that whole packy swap thing...
Remember to read the instructions before using. Please tell me any issues you find too, so that I can keep improving this for everyone's use!
cheers
neo
-
Frneo I will give this a go next time I turn in BODs instead of Penny's BOD Swapper.
Right now all my accounts are busy collecting BODs.
-
Sounds good man...
You'll notice it has a lot of room for improvement, especially aesthetically speaking...
But for now I would like to get people's opinion on how to improve the main functionality of it, and then I can start making it prettier hehe...
Thanks for giving it a whirl!
neo
-
Frneo... Sorry I haven't gotten back to you on the Lumberjacking script yet but I am planning on hacking that one out on 2 different characters this weekend (gargoyle and human) using a different account and completely different runebooks/setup to make sure I test it all. Will post results when finished.
As for this script I will give it a shot tonight and get back with you. Working smithy bods has been exactly one of the things I have been doing this week. I look forward to testing this one out!
-
Tested and not functioning with euo 200. I believe the problem is with the euo version or a change in euo. Two bod swap scripts, this and penny's can not recognize the blacksmith npcs.
Can you take a look?
Pennys has me select the npc and the script rejects the npc i've always used while yours just tells me there is no npc found.
-
Tested and not functioning with euo 200. I believe the problem is with the euo version or a change in euo. Two bod swap scripts, this and penny's can not recognize the blacksmith npcs.
Can you take a look?
Pennys has me select the npc and the script rejects the npc i've always used while yours just tells me there is no npc found.
They changed #findrep with the new client/euo, that was the issue...
Should be all fixed now, tell me if you find any issues though...
-
Okay issues that I'm noticing with the script.
It pulls too many bods out and then doesn't necessarily turn the bods in.
It keeps getting hung up trying to hand in the unfilled bods it collected. it'll get a new bod and try to hand it in, all while it keeps pulling filled bods from the bod book.
From an efficiency standpoint it appears to try and recall after every reward it gets. Perhaps you can have it collect several a time, and then turn them back to the house. This would save a ton of transit time and be a real competitor with penny's bod swap.
-
It also doesn't save your setting for what item to return and the runebook settings.
-
From an efficiency standpoint it appears to try and recall after every reward it gets. Perhaps you can have it collect several a time, and then turn them back to the house. This would save a ton of transit time and be a real competitor with penny's bod swap.
.
How many items do you have in your backpack? It's coded to recall when you have 110 items in your pack.
You could change this line to a number greater than 110
if %property > 110
-
Okay issues that I'm noticing with the script.
It pulls too many bods out and then doesn't necessarily turn the bods in.
It keeps getting hung up trying to hand in the unfilled bods it collected. it'll get a new bod and try to hand it in, all while it keeps pulling filled bods from the bod book.
From an efficiency standpoint it appears to try and recall after every reward it gets. Perhaps you can have it collect several a time, and then turn them back to the house. This would save a ton of transit time and be a real competitor with penny's bod swap.
Well, I really don't know why that's happening to you...
First, the script is only supposed to recall home to dropoff stuff IF you're close to maxweight or if you have more than 110 items in your backpack. Could you check to see if you're working with a backpack with more than 110 items.
The other issue you mentioned of it just dropping several bods into the backpack, from all the testing I did, would only happen if you get the "backpack is full" error...
Could you check those things for me and get back to me please?
Thank you...
neo
-
It also doesn't save your setting for what item to return and the runebook settings.
I left the "item to return" out of the saved variables on purpose, so that people wouldn't return stuff by accident, after loading up the saved config...
The runebook settings were supposed to be loaded up, but I guess I know what may be causing it to not load properly... I'm gonna try and get the new version out with that fixed in a few...
-
Okay, it's not trying to recall back every time now that my item count is lower
However, it still tries to pull multiple bods out. The longer its on the more bods that spill out into the bag.
I believe the issue is that right away when it starts, it pull 2 filled bods out.
It begins confusing item ids as more bods come out, compounding the problem.
I ran a test and paused it to remove that extra bod so it starts with just 1 bod in pack. Perhaps the issue is its trying to pick things up too quickly?
Also, The problem causes it to throw filled bods into the empty book.
-
Okay, it's not trying to recall back every time now that my item count is lower
However, it still tries to pull multiple bods out. The longer its on the more bods that spill out into the bag.
I believe the issue is that right away when it starts, it pull 2 filled bods out.
It begins confusing item ids as more bods come out, compounding the problem.
I ran a test and paused it to remove that extra bod so it starts with just 1 bod in pack. Perhaps the issue is its trying to pick things up too quickly?
You can't have any bods in your pack before starting...
That will definitely break the script, at least for now...
You must start the script having 0 bods in your pack, just the bod books...
-
Okay, it's not trying to recall back every time now that my item count is lower
However, it still tries to pull multiple bods out. The longer its on the more bods that spill out into the bag.
I believe the issue is that right away when it starts, it pull 2 filled bods out.
It begins confusing item ids as more bods come out, compounding the problem.
I ran a test and paused it to remove that extra bod so it starts with just 1 bod in pack. Perhaps the issue is its trying to pick things up too quickly?
You can't have any bods in your pack before starting...
That will definitely break the script, at least for now...
You must start the script having 0 bods in your pack, just the bod books...
I am. The script is pulling too many bods from the book of filled box and then everything breaks down. it's not always the first time it pulls a bod upon more testing, it's just usually the first bod.
-
Okay, it's not trying to recall back every time now that my item count is lower
However, it still tries to pull multiple bods out. The longer its on the more bods that spill out into the bag.
I believe the issue is that right away when it starts, it pull 2 filled bods out.
It begins confusing item ids as more bods come out, compounding the problem.
I ran a test and paused it to remove that extra bod so it starts with just 1 bod in pack. Perhaps the issue is its trying to pick things up too quickly?
You can't have any bods in your pack before starting...
That will definitely break the script, at least for now...
You must start the script having 0 bods in your pack, just the bod books...
I am. The script is pulling too many bods from the book of filled box and then everything breaks down. it's not always the first time it pulls a bod upon more testing, it's just usually the first bod.
That's really odd. This never happened here... I could think of 3 possible causes for this from the top of my head:
- You're not close enough to the npc to whom the script is trying to move the filled bod to
- You're backpack is full
- You have a bod inside your backpack before starting...
If you're sure none of the above is your case, I'll have to try and recreate your situation here to see what may be causing that issue for you...
Thanks for all the replies...
neo
-
I believe we were able to get it working. my low ping was the problem :p
-
V 0.3 is up, hopefully fixing issues for people with low ping...
Thank you Newsman for helping me debug v0.2!
neo
-
It is my recommendation that this script be approved and sent along to the script library.
-
I haven't tested this yet, but apparently they fixed #findrep back to 7 in euo version 202...
I'll have some time to test it tonight, and update this if needed...
-
Added v0.4
Changed #findrep back to 7
-
Hey Frneo,
I tried v0.3 this morning and set things up to dump/swap bods at the smithing shop in Tram Brit. It was unable to find any NPCs in this spot. I was standing right next to the NPC and tried the NCP outside as well. I then moved to Luna Smith shop and the script worked perfectly.
When I came back to leave you a comment I noticed that you had put up v0.4. Testing it I got the exact same results. I love the menu and setup is a breeze. Nice work. It would be sweet if we could work out the NPC not being found in Brit because I don't treasure the idea of swapping bods at luna.
Otherwise... Very nice script!
-
Hey Frneo,
I tried v0.3 this morning and set things up to dump/swap bods at the smithing shop in Tram Brit. It was unable to find any NPCs in this spot. I was standing right next to the NPC and tried the NCP outside as well. I then moved to Luna Smith shop and the script worked perfectly.
When I came back to leave you a comment I noticed that you had put up v0.4. Testing it I got the exact same results. I love the menu and setup is a breeze. Nice work. It would be sweet if we could work out the NPC not being found in Brit because I don't treasure the idea of swapping bods at luna.
Otherwise... Very nice script!
Hey man, thanks for the feedback!
Which version of EUO are you using?
It was supposed to find NPC's no matter where you want...
I'll take a look at this tonight, and post a fix/answer as soon as I figure this one out ok?
Cheers...
neo
-
Using EUO Version 201
I just downloaded 202 and am going to fill the bods I have to retest it.
I also noticed that you made reference to updating to v0.4 and changed #findrep back to 7; however, v0.4 still shows 255 from what I see.
Anywho... I will let you know how my test of version 202 goes tonight.
-
Using EUO Version 201
I just downloaded 202 and am going to fill the bods I have to retest it.
I also noticed that you made reference to updating to v0.4 and changed #findrep back to 7; however, v0.4 still shows 255 from what I see.
Anywho... I will let you know how my test of version 202 goes tonight.
Hey man, thx for telling me this...
I really uploaded the wrong v0.4...
It's been known to happen to me more than once heh...
I reuploaded v0.4 with the proper #findrep now...
Thx
neo
-
Okay.. Just downloaded the updated v0.4 with #findrep 7. Reacted the same way. It was unable to recognize the NPCs at Brit Smith shop but worked perfectly at Luna.
-
Guys, you really should stand within 2 tiles from the NPC, otherwise this won't work...
That was Goliath's issue... He was 3 tiles away...
Thanks for helping me find the problem though, Goliath...
Hope it works well for you now...
cheers
neo
-
Hey frneo, do you have a proximity check and a corrective pathfind in there somewhere? I didn't look at the code, but that should help especially with vendors that end to wander a bit.
-
Yep... new position worked. Practically on top of him :)
-
Hey frneo, do you have a proximity check and a corrective pathfind in there somewhere? I didn't look at the code, but that should help especially with vendors that end to wander a bit.
No, I just though NPC's stood still all the time...
But that's a great idea, I could use a proximity check with pathfinding...
Thanks for the suggestion!
I'm gonna try and get that done for the next version...
-
That's the fun thing about publicly releasing scripts is to make them bulletproof!
-
Just tried this out for the first time. Only issue: I had 1 tailor bod in the book and I set my filter to blacksmith bods. So when it finished turning in all of my blacksmith bods, I still had 1 bod left in the book and the script got caught in a loop trying to turn in a bod that it couldn't remove. I removed the tailor bod and was able to restart with another book of filled bods with no problem.
Thanks!
-
How is this an issue?
This is for smith bods ONLY.
Seems like it's an issue with your use of the script and not the script itself.
-
How is this an issue?
This is for smith bods ONLY.
Seems like it's an issue with your use of the script and not the script itself.
You always crack me up Cerv! ;)
On another note though, it would be nice if there were a simple check at some point so that the script knows there are no more Blacksmith BOD's. For example, I have tons of books with a couple hundred of each - what a PITA if I have to empty all my tailor BOD's from a given book when only two or three lines of code could halt the script when all the Blacksmith BOD's were used up. For example, if you remove a BOD then there is no BOD in the pack it's likely that you've reached the end of the BOD's that have been filtered.
Just a thought!
X
-
Well, I never thought about that actually, since I never have tailor bods on my toon....
I wrote a check that uses strings from the bod book property, to check the amount of bods left, and stop only when there are 0 bods left in the book...
From the top of my head, I could maybe add a #findcol check or sth to the bods dropped, and make it ignore them if #findcol is not the correct one... I'll take a look at this later today though...
Thanks guys for the feedback...
EDIT: I'd have to add a timeout to the bod dropping thing if I want to use filters on the books... Probably easier to make the user put a new book for tailor bods... I dunno, just a thought too...
-
Agreed Cerv, not really an issue, the script did what it was supposed to do and I didn't set it up correctly.
If I may put another plug in for the script, setup was super easy! Being able to save the configuration is awesome!
Thanks again!
-
Quick question about gargoyle pick axes...do you usually keep them? I want to return them to the vendor but I don't see an option.
-
Quick question about gargoyle pick axes...do you usually keep them? I want to return them to the vendor but I don't see an option.
I usually keep gargoyle pick axes... And once my gargoyle pickaxe container gets full, the script starts returning them automatically... Like I said, initially this was just a modified version of my personal bod swapper, so I probably forgot to add this to the options.... Thank you for telling me about this... I'll surely add this to my to do list...
cheers
neo
-
Lots of changes, version 1.0 out! :)
-
Hey,
I'm getting no NPC found when I click start. I do the setup, recall to the Blacksmith and click start. Choose my bod books and then it pops up. Are they any particular smiths I should use?
-
Ignore me, seems my Easyuo was out of date! Sorry :-*
Using this now, it works a treat! Thank you :)
-
Giving this a try right now, seeing as since returning to the game, Bodswap 2.3 isn't working.
Was giving my head a scratch when I first ran in, problem was I wasn't IN the building with the smith, couldn't pass the BOD through the building lol. Maybe I can with COT.
2nd, I had to add some more properties to find the smith, the one I'm using is an "Armoursmith".
Other than my own ignorance, works like a charm! I'll be trying your BOD filler next!
Edit: The items I checked to return, they stayed in my pack and nothing was done with them. I'm trying to relearn the commands for the code so I can understand what's going on, but my brain is on vacation, lol.
-
Awesome script Neo, its so quick! been using our bod filler for a while and just got round to using this one. Great work.
-
First run attempt .. couple notes...
(1) Needing to start the script at the bod shop is a pain especially on first run as you need to setup bags which are not at the bod shop.
So first run always fails.
(2) Load config. After loading you dont know if it really loaded as non of the menu options get set.
(3) Return items label is confusing... I had thought this meant return to house with .. instead it means drop on vendor... I inadvertently had it return all items to vendor... instead of keeping all items. But in this it failed as it didn't return garg pixaxes or sturdy tools.
(4) Load /save - if create a config where everthing is returned and save it... then load it .. uncheck everything save it... then load their all checked. instead of being unchecked.
(5) If start the script with rewards allready in backpack due to stopping and starting from above the script does not capture the journal message "you do not have enough room in your backpack for the bulk requests reward" and gets stuck in a loop of dropping bods in bag and not processing them or emtpying bag.
(6) Recalling home... got stuck in loop of no charges left on that item... ie was clicking in wrong place and not recalling. (I got past this by pausing script and manual recall)
(7) Script ended with char infront of house but didnt drop anything into bags. It wold be nice if it emptied backpack prior to ending script. Also would be nice if a short pathfind into house was done so bags didn't have to be on porch.
(sry i'm a bit of a script crasher- some of above maybe user error lol)
-
First run attempt .. couple notes...
(1) Needing to start the script at the bod shop is a pain especially on first run as you need to setup bags which are not at the bod shop.
So first run always fails.
(2) Load config. After loading you dont know if it really loaded as non of the menu options get set.
(3) Script ended with char infront of house but didnt drop anything into bags... maybe couldnt reach.??, maybe my error thier. But a small pathfind into house would be nice.
(4) Return items label is confusing... I had thought this meant return to house with .. instead it means drop on vendor... I inadvertently had it return all items to vendor... instead of keeping all items. But in this it failed as it didn't return garg pixaxes or sturdy tools.
(5) Load /save - if create a config where everthing is returned and save it... then load it .. uncheck everything save it... then load their all checked. instead of being unchecked.
(6) If start the script with rewards allready in backpack due to stopping and starting from above the script does not capture the journal message "you do not have enough room in your backpack for the bulk requests reward" and gets stuck in a loop of dropping bods in bag and not processing them or emtpying bag.
(sry i'm a bit of a script crasher)
Awesome feedback, it's exactly the kind of stuff the helps out A LOT when trying to improve a script...
I've been a little busy these last few days to work on my scripts, but I hope to have a new version up soon, with a lot of improvements, and I will take every comment here into consideration while writing it...
Thank you everyone for the input so far...
Cheers!
-
Awesome feedback, it's exactly the kind of stuff the helps out A LOT when trying to improve a script...
I've been a little busy these last few days to work on my scripts, but I hope to have a new version up soon, with a lot of improvements, and I will take every comment here into consideration while writing it...
Thank you everyone for the input so far...
Cheers!
editted read it again.. done for now i think .. out of filled bods...
-
2 additional errors
(1) script does not recall as finds wrong click position.
(2) the bag overload error means that you cannot process a book that contains more than 50 or so bods if you keep all rewards. The script needs to unload when item count in back pack nears physical maximum of 125 items.
-
Great feedback... Thank you!
I actually started this morning writing v2.0, from scratch, hopefully fixing all these issues and adding some cool new features... I'm a little short on time these days though, but I'll try and get it up and running as soon as possible!
Cheers!
-
New features, it needs to be able to take bod books from bags when the first bod book is finished.
-
this is a great script please update it when you get a chance so i can move it into the approved script library thanks.
-
Thank you EN... I'm slowly working on the next version, I still haven't had the time to finish it though, but I'll definitely update this as soon as possible.
Cheers!
-
When u finished this one, any chance of a Tailoring one, i just cant get Penny's to work anymore :P
Nel :)
-
hiho,
can anyone tell me how i must change positions for getting bods because of the bribing menue point?
-
My Crafter uses Chivalry and when it came to the point to 'Sacred Journey' it attempted to recall to the House and was stuck in a loop, even though I selected Sacred Journey from the drop-down. I went ahead and manually SJ'ed and the script then continued on dropping things into the containers.
-
2 additional errors
(1) script does not recall as finds wrong click position.
(2) the bag overload error means that you cannot process a book that contains more than 50 or so bods if you keep all rewards. The script needs to unload when item count in back pack nears physical maximum of 125 items.
I am experiencing the same errors as EN. Seems to only recall when it finished filling all of the bods. If it gets close to overloading the pack then it just empties out all of the bods into the pack and gets stuck in a loop.
In future versions, I would like to see it pull another bod book out of a secure so that I don't keep having to restart the script with each new book.
-
Hey, Neo - Did you ever get a tailor version running? What is everyone using to swap tailor BODs these days?
-
Hey, Neo - Did you ever get a tailor version running? What is everyone using to swap tailor BODs these days?
To my knowledge, the only public script for swapping tailor bods out there is still Penny's.
-
Penny's does still work, i think somebody posted a full working script a few pages back from the end and that works really well.
Nel.
-
Hey, Neo - Did you ever get a tailor version running? What is everyone using to swap tailor BODs these days?
I haven't.
I was thinking of coding that in here so this guy would do both tailor and smith bods, now that my filler also supports both...
Could also try and fix some of the issues that were posted here by EN.
I'll try and work on that today!
-
That is Awesome to hear, Neo. We desperatley need a Bod Swapper for Tailoring...would be great if it took into account bribing too, but that may have to be done with a sorting script...
-
Awesome script neo, we really appreciate the time your putting into this.
And i'm glad ur back working on it and a tailor one. Thanks again!!
-
Man Neo you are all over the place, everytime I go to use a script i need, it is one of yours lol. Anyways, I do love the script, and is time consuming when I'm not getting prospecting tools. You've heard the errors, it wont recall till its done with all bods. It just gets stuck trying to hand them to the NPC when he says your bag cant hold anymore items, even though its not full just almost overweight. I fill about 80 goin for gargoyle pickaxes, and then turn it it. I already have plenty of prospector tools. I'll keep checkin to see if the problem gets fixed. I'll post this on your other script board as well but ur elemental mining one is beastttt.
-
Man Neo you are all over the place, everytime I go to use a script i need, it is one of yours lol. Anyways, I do love the script, and is time consuming when I'm not getting prospecting tools. You've heard the errors, it wont recall till its done with all bods. It just gets stuck trying to hand them to the NPC when he says your bag cant hold anymore items, even though its not full just almost overweight. I fill about 80 goin for gargoyle pickaxes, and then turn it it. I already have plenty of prospector tools. I'll keep checkin to see if the problem gets fixed. I'll post this on your other script board as well but ur elemental mining one is beastttt.
Yeah, I've been meaning to update this guy for a while. Never seem to find the time to do so though...
I'll try and get it done when I can, although I think this is one of the projects I'll be porting over to Stealth...
Cheers!
-
Congratulations your Script has been moved to Script library
(If you feel the script is in the wrong section please send me a pm.)
Thank you for your submission.
-
How can I download it? Im new to scriptuo, cant find any download links....
-
How can I download it? Im new to scriptuo, cant find any download links....
Please create an introduction!
You may want to read this thread
http://www.scriptuo.com/index.php?topic=1683.0
(http://www.scriptuo.com/index.php?topic=1683.0)
-
This link was created just for you!
http://www.scriptuo.com/index.php?topic=12571.0
-
Anyone know if this is still operable?