Crisis Craft and Fill Spellbook Filler Version 1.3b

[Crisis]

Code: [Select]

;===================================================================
;===================================================================
; Script Name: Crisis Craft and Fill Spellbook Filler
; Author: Crisis
; Version: 1.3b
; Client Tested with: 7.0.45.0
; EUO version tested with: 1.5 (version 285)
; Shard OSI / FS: OSI
; Release Date: 04/22/2015
; Revision Date: 04/30/2015
; Purpose:
;     .Craft spellbooks, craft spell scrolls, and fill the spellbook.
;     .Magery, Necromancy, and Mysticism
;
; Revisions:
;     1.1
;     .Fixed buttons so they don't disappear when you start to craft
;     .Adjusted Status to show the spellscroll number and name of spellscroll being crafted
;     .Clears resources out of pack into secure upon completion of spellbook though I may add that into a button in the future
;     .Cleaned up code
;     1.2
;     .Changed Scroll_Secure to automatically be set as players backpack
;     .Added a Storage_Secure so completed spellbooks can be moved out of the backapck
;     .Added event sysmessage to remove extra clicks when setting secures and spellbooks
;     1.3
;     .Adjusted resource amounts and added a pause if you run out of resources
;
; Requirements:
;     . You need to have a secure with regs, iron ingots, and blank scrolls inside it and within reach
;     . You need to have at least one tinker tool and one scribe pen in your backpack
;
; Future Updates:
;     . will integrate this into my quick and painless spellbook filler
;
; Special Thanks:
;     . Manwinc for use of his crafting subs
;     . TrailMyx for use of his Meditate Sub
;     . The Ghost for testing and suggestions
;
; Copyright: 2015 Crisis
;===================================================================
;===================================================================
REVISED! 04/30/2015
1.1 Fixed buttons so they don't disappear when you start to craft
      Adjusted Status to show the spellscroll number and name of spellscroll being crafted
      Clears resources out of pack into secure upon completion of spellbook though I may add that into a button in the future
      Cleaned up code
1.2
     Changed Scroll_Secure to automatically be set as players backpack
     Added a Storage_Secure so completed spellbooks can be moved out of the backapck
     Added event sysmessage to remove extra clicks when setting secures and spellbooks
1.3
     Adjusted resource amounts and added a pause if you run out of resouces

This script works with Magery, Necromancy, and Mysticism.

Choose one of the three magics, it will craft a spellbook, crafts the spells, and then fill the spellbook. Comes complete with neon menu  

[gimlet]

Used the old version (mage only) a few days ago and it worked perfectly.
Will try this one this weekend!
Thanks
Crisis!

[Endless Night]

I am liking the look of that menu....

[Crisis]

Revised and solved the debug issues. Can this please be moved to the submit scripts section?

UPDATED Version 1.1

Take it for a test spin!

[TrailMyx]

What was the problem?  I looked at it and couldn't find it...

[Crisis]

What was the problem?  I looked at it and couldn't find it...

I am not sure why it only did it with the mysticism scrolls but I changed this line in the sub CraftMystScroll15 from

Code: [Select]

Finditem %scroll15 C_ , #backpackid
to

Code: [Select]

Finditem IKR C_ , #backpackid
I don't know why that would affect myst scrolls and not mage scrolls but the mage ones worked okay doing it the first way but not the myst.

[TrailMyx]

What was the problem?  I looked at it and couldn't find it...

I am not sure why it only did it with the mysticism scrolls but I changed this line in the sub CraftMystScroll15 from

Code: [Select]

Finditem %scroll15 C_ , #backpackid
to

Code: [Select]

Finditem IKR C_ , #backpackid
I don't know why that would affect myst scrolls and not mage scrolls but the mage ones worked okay doing it the first way but not the myst.

Oh crap!  What a nightmare to debug!  There is ZERO reason why that shouldn't have worked...

[Endless Night]

Revised and solved the debug issues. Can this please be moved to the submit scripts section?

UPDATED Version 1.1

Take it for a test spin!

Moved.

[Crisis]

What was the problem?  I looked at it and couldn't find it...

I am not sure why it only did it with the mysticism scrolls but I changed this line in the sub CraftMystScroll15 from

Code: [Select]

Finditem %scroll15 C_ , #backpackid
to

Code: [Select]

Finditem IKR C_ , #backpackid
I don't know why that would affect myst scrolls and not mage scrolls but the mage ones worked okay doing it the first way but not the myst.

Oh crap!  What a nightmare to debug!  There is ZERO reason why that shouldn't have worked...

Yeah, I tried renaming the set %scroll15 IKR and the spot it called it, retyping both, copy and pasting both to make sure that how the scroll was set was the same id as the scroll in the bag where it should have stopped because it could find it. The only other thing that came to me was the the set %scroll15 IKR was in a sub and not the beginning but it worked for other scrolls, just not the 2 myst scrolls. I finally decided to just call the id itself and it worked.

I can say that I added a couple of gray hairs while trying to troubleshoot it over the past couple of days. I am very excited that I was able to figure it out. There is hope for me yet to become a decent scripter! This summer I will be looking at learning python so I can play with stealth!

[Crisis]

Has anyone tried the new version, 1.1?

[Endless Night]

Has anyone tried the new version, 1.1?

Bump..  Calling all new members  this is the perfect time to get involved give this new script a test run and post some feedback

[The Ghost]

Crisis,   Let be a leader and test that puppy. I don't  really need any spellbook, but I will to this for you.     

[Crisis]

Thanks Ghost!! You the man!! 

[The Ghost]

I test this by making one of each book.  

Let said that It work like advertise.  Few think That I will chance but that only me been fussy.

First
Requirements:
-  equipment your spellbook   < ------ let add this warning so your scroll don't stay in you backpack.   It been said  in some poste but let add it.

Second.
Line 449  so you can remove that display box.  just don't like that extra click.

Code: [Select]

change
display Select your Resource Secure..
for
 event sysmessage Select your Resource Secure...
.
Third   ;
line 483 I will go that route.  <----------    This is remove few click and still display the ID.  

Code: [Select]

change
display Select your backpack...
    set #targcurs 1
    while #targcurs = 1
      wait 5
    set %Scroll_Secure #ltargetid
    set #lobjectid %Scroll_Secure
    event macro 17 0

for
 gosub newstatus lime black 10 Choose Secure
     set %Scroll_Secure #BACKPACKID
     event macro 17 0


  Fourth
Line 2438    
When you are out of resource,  Can you just do a pause and return so we don't have to setup again.  just a thought.

[Crisis]

Updated to Version 1.2
     Changed Scroll_Secure to automatically be set as players backpack
     Added a Storage_Secure so completed spellbooks can be moved out of the backapck
     Added event sysmessage to remove extra clicks when setting secures and spellbooks

 Fourth
Line 2438    
When you are out of resource,  Can you just do a pause and return so we don't have to setup again.  just a thought.

That is manwinc's sub so I will have to check with him before making any changes to it for my script

Thanks for testing it The Ghost, let me know how the new changes work for you and if you have any issues with it.