Hey guys, I'm working on releasing the new version of my crafter, and I just came across this issue. If i set an option to save Elemental Slayer, it's saving anything with elemental slayer in the property, even though I set a check for other elementals notin #property... Am I doing sth wrong? I really can't find a way out of this... If anyone can help, I'd greatly appreciate it... Thank you!


if ( %prop . %checkindex = Elemental , #spc , Slayer && Elemental , #spc , Slayer in #property )
           {
           event property #findid
           wait 5
           if ( air notin #property && blood notin #property && earth notin #property && fire , #spc , elemental notin #property && poison , #spc , elemental notin #property && snow notin #property && water notin #property )
              {
              menu Font Color Black
              menu Font BGColor Window
              menu list add savedlist %prop . %checkindex
              set %totalcnt %totalcnt + 1
              menu delete EUOLabel11
              menu Text EUOLabel11 280 204 Weapons Saved: %totalcnt
              gosub keep %currentweapon
              ignoreitem #findid
              return
              }
           }


;===================================================================================
; Script Name: frneo's Weapon Crafter with TM's Advanced CLAw support
; Author: frneo
; Version: 5.0.1
; Client Tested With: 7.0.16.3
; EUO version tested with: 1.50 199
; Shard OSI / FS: OSI
; Revision Date: 08/31/2011
; Public Release: 08/04/2011
; Purpose: Makes weapons and checks whatever property the user wants to check for
;          in it. Elemental Damage, Slayers and anything else the user wants
;          to add. Weapons with the determined criteria will be saved, and the rest
;          will be unraveled.
;-------------------------------------------------------------------------------------
; Now supports TM's Advanced CLAw!
; Thank you TM for letting me use the CLAw with this.
;-----------------------------------------------------------------------------------
; Url:     http://www.scriptuo.com/index.php?topic=8105
;===================================================================================
; Version 5.0.1      - Fixed pause button
;                    - Removed wait time from gumpwait sub. Should make the script run
;                      even faster now!
;------------------------------------------------------------------------------------
; Version 5.0.0      Now supports TM's Advanced CLAw! Thank you TM for letting me use it!
;                    You can download the claw here:
;                    http://www.scriptuo.com/index.php/index.php?topic=17.0
;                    If you choose to use the CLAw with this, you must thank TM for it in
;                    the above topic! :)
;--------------------------------------------------------------------------------------
; Version 4.1.8      - A few minor fixes
;-------------------------------------------------------------------------------------
; Version 4.1.7      - Fixed some minor code that could cause issues.
;                    - Also removed some unnecessary code.
;-------------------------------------------------------------------------------------
; Version 4.1.6      - Previous version would cause an issue with the weapon view button
;                      not displaying the whole property of the weapon. Should be fixed
;                      now.
;--------------------------------------------------------------------------------------
; Version 4.1.5      - Added timeout to "event property safe check".
;                    - Changed the way the event property safe check works.
;                    - New cool way to check for properties! :)
;----------------------------------------------------------------------------------
; Version 4.1.4      - Added event property safe check. Thank you EN for this tip.
;---------------------------------------------------------------------------------
; Version 4.1.3      - Added colored material option to menu
;                    - Added dmc to click sub (Thank you EN for both suggestions)
;                    - Will now check if save file exists for current character
;                    - Minor change to the way the unravel sub works
;                    Keep in mind that this version does not automatically check for
;                    color of the material, you must set it yourself before starting
;                    the script. Also, only keep the desired color for material
;                    inside the resource container.
;-----------------------------------------------------------------------------------
; Version 4.1.2      Fixed gumpwait sub. Apparently I wrote it wrong the first time
;                    round, and kept using the wrong version in all my scripts.
;                    I never noticed it before because it didn't really change the
;                    functioning of the script. So, nothing too serious, but still
;                    deserved a fix.
;---------------------------------------------------------------------------------
; Version 4.1.1      Minor drop wait time fix.
;--------------------------------------------------------------------------------
; Version 4.1        - Added pause/resume button. While paused you can edit the
;                    criteria you choose, and also save/load your user config.
;                    - Added View Selected Weapon Button. This button will display
;                    the properties of the weapon you select in the menu, and give
;                    you a choice to move the selected weapon to your backpack.
;                    - Will now pause the script if you run out of ingots/boards
;                    or tools, so that you can get more and resume. Remember
;                    to reopen your containers if you go get more.
;=================================================================================
; Version 4.0a       Fixed minor issue with removing property from list.
;--------------------------------------------------------------------------------
; Version 4.0        Major changes:
;                    - Will now allow user to set any amount of properties to look
;                    for in a weapon. As far as I'm concerned, there are no limits
;                    to the amount of properties the user can set.
;                    - Menus rebuilt, inspired by TM's advanced claw! Thank you
;                    for sharing the claw with us TM! :)
;                    - Check code re-written entirely for this
;                    - Now uses TM_NGFS to save user setup. Thank you again TM
;                    for sharing your awesome code with us!
;                    - Lag check
;---------------------------------------------------------------------------------
; Version 3.0        Major changes:
;                    - Allows user to input own custom property minimum to look
;                      for in weapon
;                    - Allows user to input own custom Slayer to look for in weapon
;                    - Allows user to choose the material he's going to use to craft
;                      stuff, i.e. boards or ingots.
;                    - Allows user to use whatever runic tool type he chooses,
;                      as long as the material to be used is either ingots or
;                      boards.
;                    - I thought of a new way to check for properties, the entire code
;                      was re-written in a more compact and efficient manner.
;                    Minor changes:
;                    - Changed amount of weapons to make before unraveling down to ten
;                      I figured this would be safer. If one wishes to make
;                      more weapons at a time, info about how to do that
;                      can be found in the script topic at SUO.
;---------------------------------------------------------------------------------
; Version 2.2        Increased amount of weapon to make before unraveling to 20
;                    I don't think this will cause a weight issue. Should run even
;                    faster now!
;--------------------------------------------------------------------------------
; Version 2.1b       Removed all goto's as a birthday gift for Cerveza! :)
;--------------------------------------------------------------------------------
; Version 2.1a       Minor fix: Fixed issue that would prevent Elemental Slayers
;                    with Fire or Poison Damage to be saved.
;--------------------------------------------------------------------------------
; Version 2.1        Some changes to make the script run faster:
;                    - Will craft weapons directly IN unravel bag now, weapons
;                      will no longer have to be dragged one by one.
;                      Thank you MeWonUo for the tip! :)
;                    - Changed the way crafting subs work. Will craft weapons
;                      faster now.
;                    - Removed the trash barrel option. After burning
;                      more than 40 hammers using this, and not needing the
;                      trash barrel, I guess it was about time to remove it
;
;                      I want to thank everyone who's giving me feedback
;                      so I can keep improving this! Cheers!
;--------------------------------------------------------------------------------
; Version 2.0        Menus rebuilt. Most of the code was rewritten for stability.
;                    Added option for user to set minimum damage wanted
;                    for each damage type. Added option for user to set
;                    minimum Swing Speed Increase to look for in each weapon.
;                    Added individual counters for all Damage Types and for
;                    each different slayer.
;--------------------------------------------------------------------------------
; Thank you Cerveza and Canuker for the input/tips. Version 2.0 was based on your
; comments! I appreciate it.
; Also thank you Ultima for the kind words, it's really nice to work hard on things
; when other people seem to value them. Thank you guys!
;================================================================================
; Version 1.1a       Fixed an issue with lag causing unravel to break.
;--------------------------------------------------------------------------------
; Version 1.1        Rewrote the check sub, for some reason it was trashing
;                    some weapons that should have been saved. Should be
;                    fixed now. I used a similar structure to JaF's in
;                    his Slayer Book Maker, so thank you JaF for the great
;                    code you shared with us! :)
;--------------------------------------------------------------------------------
; Version 1.0        Added Menu. Added selection of weapons you want to keep.
;                    Selection includes: Swing Speed Increase, Slayers and
;                    Elemental Damage 70% or above.
;--------------------------------------------------------------------------------
; Version 0.1a       Fixed issue with unravel
;--------------------------------------------------------------------------------
; Version 0.1        Currently only works with Dull Copper Runic Hammers, but
;                    other crafting options could be added easily with this
;                    setup structure. Future versions will have community
;                    suggestions added. If there are any suggestions that is! :)
;                    I also plan on adding menu customization for weapons people
;                    want, in future versions...
;================================================================================
;================================================================================
; Thank you goes to:
;
;
; TM for your clickoffset generator, saved me loads of time, thank you:)
; TM for his NGFS used from v4.0 on.
; TM for letting me use his Advanced CLAw :)
;
; Coragin for posting SUO Elemental Weapon Maker. Alas, I tried it out
; with no success, I guess it was a little outdated. However, it inspired me
; to write this! :) So thanks for that!
;=================================================================================
; Instructions:
; You must have a secure next to you with the Runic Tools and material to craft your stuff
; Also, you must have a container near you to put the weapons you crafted in
; You must have a bag INSIDE your backpack, where the trash weapons will be sent
; to for unraveling.
;
; You must be near a forge and anvil if Smithing,
; and also have a Soulforge near you, so you can unravel.
; Last, you must have 1 Tool and enough material to make your first weapon
; in you backpack.
; Once all these conditions are met, hit play, and follow the screen instructions
; If this works for you, or not, please tell me, I want to keep updating this
; according to what people think of it.
;===========================================================================

Pic shows the View Weapon button in action:


V5.0.1 with TM's CLAw in action!


Menu was inspired by claw's menu, thank you TM for sharing it with us!

Have in mind I haven't put many safe checks for what you write in your custom properties. So, if you write a property wrong, or a value that shouldn't be where you wrote it, the script won't function properly!

Input the number of the minimum value you want, without the '%' i.e. if you want 90% poison, you write 90 in the box.

That said, enjoy!

Version 5.0 has TM's Advanced CLAw support.

If you want to use it, remember to start it up on another tab BEFORE running the crafter... The crafter will use the settings on the CLAw to see what to keep and what to unravel...

Thank you TM for letting me use this!

neo

Hi guys. I wanted to share with you something that has made my life A LOT easier when training up some skills. You all remember the satyr trick right?

If you don't know it, this is what I'm talking about:
Taken from uoguide.com
    Go into Twisted Weald, find a satyr and pull up its gump.
    Attack it by double clicking its gump in war mode and it will attempt to use discordance on you.
    Let it follow you around until you have been discorded. You will know this because you will see all of your skills drop.
    Then quickly get through the moongate to leave Twisted Weald.
    When attacking it I recommend you get to the exit as quickly as possible as it will try to provoke other creatures in the area onto you. With lowered skills you definitely don't want a Cu Sidhe attacking you; even a Pixie can be hard to kill if you're young. If they do target you, they must either be killed or you must leave the server and come back.
    Once you leave via the moongate the satyr will loose interest in attacking you. However, you are still discorded and you can re-enter without fear of it attacking you; this will NOT however stop critters that may have been provoked onto you from attacking you. This is when an invisibility spell or a pixie swatter with weapon skill comes in handy.
    Now as long as you stay close to the satyr you will stay discorded until it respawns. Making use of the Alt-Left Click combination to follow the satry around is helpful.

It takes a while to get the hang of it and may several tries before getting it down.

Unlike other debuffs, no icon indicator will appear in the buff/debuff gump while a character is Discorded.
Well, there's a way to "enhance" this trick, getting the satyr stuck, so that you can just stay put, and never have to follow him around anymore.
You will need a friend or second account to pull this off (it can be done solo, but it's easier to have someone there)

So, the first thing you should do is have a friend (or a second account) stand exactly at (1) in the pic below. Now have your toon (2) attack the satyr.


Once the Satyr starts attacking you, you should run to the spot shown in the picture below. Also be sure you're not in war mode as to not attack the satyr again.


Once the satyr gets to the spot just North of you (shown below) you should invis yourself (or have your friend invis you).



As soon as you're invisible, the satyr will forget to attack you (as long as you don't attack him again). Now you should quickly run past the satyr and stand right North of him, like shown in the picture below. Your friend (or second account) just has to stay put at the same spot since the beginning.


After a little while (a few seconds) the Satyr will want to move. Since he is blocked from the West (by your friend) and from the North (by you), and also, there's a rock blocking him from the East, he will have no choice but to move 1 square to the South. Once he does this, you should also move 1 square to the south. See pic below.


Ok, now you're done! The Satyr will be stuck there, and as long as you don't move, he won't be able to get out of that exact spot. Your friend (or second account) is free to go, as you will be blocking the Satyr's passage by yourself now.


Now you can perform the Satyr trick until you get discorded, invis yourself, and stand there training up your skill without having to follow the Satyr around.

I don't know if many of you know about this, I've just recently found out about this by accident when I started playing again after all these years away from UO.

Hope you find this useful.

If anything isn't clear enough, please ask here, and I'll try my best to make it clearer.