It has been a long time since I ran this, but doesn't have a time and count setting? I thought the default ran for about 2 hours. I never got very good at getting an appropriate count to run, so I would try to set a ridiculously high count and give it the time that I wanted it to run.

Is your home set as the default for it's rune book? If it isn't the same rune book as the bank runes, then the default wouldn't change as the script runs (TM's travel routines set the default on the rune book, then will travel (recall/gate travel/sacred journey) by targeting the book).

If your house has the chance to spawn aggressive things, then setting up a safe logout location would be the wiser choice than leaving it unset.

The script needs an update to the menu logic. There are new rules in EUO for menu processing a few years ago. While most of the original menu commands work, the rules are more strict now.

The button to "Setup ship key" is not updating #MENUBUTTON when selected. This usually happens because the button was defined more than once. You can recreate some of the menu elements (you used to be able to create the same named item over and over), but most now require one of two methods:
1) delete old; create new
2) create all and use the 'menu setprop [element_name] visible [#true/#false]'

I tend to favor the second method. Both methods seem to work, but when going back to maintain code, the second method design is more obvious when debugging. If the code forgets to hide ('visible #false') a button, you still see it on the menu and you get clear feedback. If you forget the delete an element and create a new one with the same name, you can cover the former one, but the new one that is seen won't actually work. The other benefit is that each of your elements (whether visible or hidden) are forced to have unique identifying names.

If you want to try to tackle fixing the menu code, there is a pinned thread about menu code under Tutorials that shows how to code equivalent menu commands that have been updated. That may help. Here is the direct link http://www.scriptuo.com/index.php?topic=15596.msg122126#msg122126

C2 has a lobster/crab fishing script. It works and has simple setup, so I would recommend giving it a shot. I never played with the version that uses bait. http://www.scriptuo.com/index.php?topic=6423.msg54298#msg54298

I posted one over on easyuo (which was an update of Hitechs/player111's code) - but it is for a different goal than any other crabbing script (more bobs leads to more creatures in the trap and supposed to give more rare ones - at the expense of losing lots of traps). As mine is downloaded, there is very little setup required for an individual setup (runes, secures, etc), but the internal settings will maximize lobster/crab return per hour, but at the cost of losing about 20% of the traps put out. Many players have criticized that decision, but I was trying to get more rare creatures and figured the cost of losing traps was worth it. If you really want your eyes to bleed, here is the link: http://www.easyuo.com/forum/viewtopic.php?f=3&t=53947&start=0#p435566

Hi Piller,
That code looks correct to add the stack that is in your backpack to the count, then update the menu and move it to the %resource_container. It doesn't look like there is anything wrong with this code snippet.

I would look at the potential failures.
Is it possible that %resource_container is not set to the ID of a container?
Could %resource_container be out of reach - more than 2 tiles from your character?
Is %resource_container hidden in another container level (a bag in a bag, for instance)?
Is this block of code even being executed?
Is this block of code being executed the first time while %resource_container is not valid for one of the above reasons, but later it is fine? The ignoreitem will not allow the stack to be found going forward when more are collected - as the stack of green thorns would have the same initial #findid.

I am not familiar with Razor Enhanced and it's ability to interact with gumps. This is designed, of course, to run with easyuo, which you can still run with Razor/Razor Enhanced, but you have to use the OSI client. Easyuo doesn't work with the 64 bit client - CUO.

Here is a snippet from the fishing code:

Did the %fishingpole variable get corrupted? is it set to a different item id than the fishing pole you think it is using?

The variable %gem is used to concatenation names for counting the quantity and updating the menu. Using it for granite would be fine here.
One thing to think about is if you want the menu to keep a display of the granite mined. The menu needs some fields added. You may wish to separate the quantity by granite color.

I haven't looked at this script in years, so I don't know the smelt/unload routines. What I do know is that at GM mining and fighting ore elementals means you would also collect the ML large gems and crystalline blackrock. These items are not able to be smelted either and must be unloaded.

The only thing that can be smelted is the ore, and the smallest of ore pieces need 2 or more to be valid for smelting.

So there must be some logic about what is smelted or not already there which you should be able to find and take advantage of when making your modification.

Do you have more than one thing running that could do drag-drop exevents? That could interfere with the game thinking you are carrying something.

I think that delay is between 'exevent drag' actions. I have had some timing issues where I actually was trying to move items as fast as possible. The 'exevent drag/drop' functions need about 1 second between actions. Lots of code examples show different ways to implement it, from no wait between the drag/drop and then a full second after or including a variety of waiting times ("drag; wait 5; drop; wait 15" vs "drag; wait 10; drop; wait 10"). Whichever you pick to implement is simply superstition.

What is important is to complete the transaction and not have something not dropped (so the game thinks it is STILL in your hand).

I did a lot of testing and discovered that if I tried to drag something and got a denial message, I could issue a new 'exevent drop' and try to drag again. My ping times usually ran in the 50-100ms range when I did this testing. I could do drag/drop operations in as little as .85 seconds and as slow as 1.2 seconds. The average was about 1.05 seconds. That is 1 EUO timeslice above 1 second. So that 1 second rule of thumb is pretty good.

If you are having a slow time to your server, you might be able to:
1) slow down the drag/drop slightly (wait 20 = 1 second) or you can issue the statement "exevent dropc [container]" just before the "exevent drag" statement. If it turns out there is nothing in your hand, then the game doesn't even complain. It would send an extra packet or so to the server, but it increases the success rate of drag/drop significantly.

Increasing the wait time for drag/drops here while fishing is not the end of the world. After all, it takes like 6-8 seconds between casts. You can get a lot of things done in that window before casting again.

The item types that changed in game were the MIB's and the sea serpent steaks. Make sure both of those are correct.