Author Topic: Shear Sheep, kill and repeat  (Read 19404 times)

0 Members and 1 Guest are viewing this topic.

Offline RamsesTopic starter

  • Jr. Member
  • **
  • Posts: 42
  • Activity:
    0%
  • Reputation Power: 0
  • Ramses has no influence.
  • Respect: +11
  • Referrals: 1
    • View Profile
Re: Shear Sheep, kill and repeat
« Reply #15 on: July 21, 2008, 06:43:07 PM »
0
Yes, you are telling me that I am making it more difficult for you to help me. Along with making it more difficult for anyone else to modify the script to suit their needs better.

I will work on pulling the nested subs out.  :)  THanks TM.

Offline RamsesTopic starter

  • Jr. Member
  • **
  • Posts: 42
  • Activity:
    0%
  • Reputation Power: 0
  • Ramses has no influence.
  • Respect: +11
  • Referrals: 1
    • View Profile
Re: Shear Sheep, kill and repeat
« Reply #16 on: July 22, 2008, 03:19:06 PM »
0
OK..
Right now the script is working with one problem.

currently the script is only using the first two runes in both of my books. One (first book) has three runes in it, the second book has four runes in it. The script uses only the first two runes in both books.

I made some changes, but still have not gotten the nested subs out of (sub find_sheep)..

Offline TrailMyx

  • Officially retired from UO
  • Administrator
  • *
  • *
  • Posts: 13301
  • Activity:
    0%
  • Reputation Power: 154
  • TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!
  • Gender: Male
  • Viper!
  • Respect: +1349
  • Referrals: 33
    • View Profile
    • ScriptUO
Re: Shear Sheep, kill and repeat
« Reply #17 on: July 23, 2008, 04:08:56 PM »
0
I see that you got rid of the goto main_loop, so that was the thing that was really errant.  I'll take a look at the rune think this evening for you.

I think the way you have it formatted now is pretty clear, so I wouldn't waste much time worrying about anything more.
Please read the ScriptUO site RULES
Come play RIFT with me!

Offline RamsesTopic starter

  • Jr. Member
  • **
  • Posts: 42
  • Activity:
    0%
  • Reputation Power: 0
  • Ramses has no influence.
  • Respect: +11
  • Referrals: 1
    • View Profile
Re: Shear Sheep, kill and repeat
« Reply #18 on: July 23, 2008, 04:10:42 PM »
0
Hi TM,

I ran my script inside of "ScriptUO" so that I could use the syntax checker. Here is what I recieved:
=======================
Method count: 55
Command count: 55
*** Pass 1 - Label accounting:
*** Warning - GOSUB tm_addunderscore - Line 820 has no matching SUBroutine
*** Warning - SUBROUTINE tm_travelfromnamedrunebook - Line 478 unused
*** Warning - SUBROUTINE tm_randomrunebooktravel - Line 524 unused
*** Warning - SUBROUTINE tm_travelfromobject - Line 549 unused
Subroutine labels = 22
Tag labels = 27
55 Code block(s).
4 Warnings(s) encountered.
*** Pass 2 - Execution [SYNTAXCHECK]
0 Error(s) encountered.
========================================
The warnings do not appear to be real issues. I do have a question about the tm_addunderscore sub-routine...did I not do this correctly? Still cannot seem to get past the first two runes in each runebook. :( grrrrrr....

Offline TrailMyx

  • Officially retired from UO
  • Administrator
  • *
  • *
  • Posts: 13301
  • Activity:
    0%
  • Reputation Power: 154
  • TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!
  • Gender: Male
  • Viper!
  • Respect: +1349
  • Referrals: 33
    • View Profile
    • ScriptUO
Re: Shear Sheep, kill and repeat
« Reply #19 on: July 23, 2008, 04:29:36 PM »
0
You just need to locate the "tm_addunderscore" sub and include it in your code.  Otherwise if you are a "Lord Soandso", it won't work correctly because the #JOURNAL stuff is looking for "Lord_Soandso"

I'm looking at why you are missing the rest of the runes now.
Please read the ScriptUO site RULES
Come play RIFT with me!

Offline TrailMyx

  • Officially retired from UO
  • Administrator
  • *
  • *
  • Posts: 13301
  • Activity:
    0%
  • Reputation Power: 154
  • TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!
  • Gender: Male
  • Viper!
  • Respect: +1349
  • Referrals: 33
    • View Profile
    • ScriptUO
Re: Shear Sheep, kill and repeat
« Reply #20 on: July 23, 2008, 04:33:41 PM »
0
Do me a favor run your script until it doesn't work, pause it and do a Tools/Vardump.  If you can cut/paste that and *PM* me.  Don't post it because it has specific character information in it.  If I can see what all your variables are, perhaps I can see what's going wonky for you.
Please read the ScriptUO site RULES
Come play RIFT with me!

Offline RamsesTopic starter

  • Jr. Member
  • **
  • Posts: 42
  • Activity:
    0%
  • Reputation Power: 0
  • Ramses has no influence.
  • Respect: +11
  • Referrals: 1
    • View Profile
Re: Shear Sheep, kill and repeat
« Reply #21 on: July 24, 2008, 08:33:54 AM »
0
OOOO!!!

I assumed the "tm_addunderscore" was part of your runebook subs. I guess I need to go and find that sub routine then.  LOL..

THanks TM.

Offline TrailMyx

  • Officially retired from UO
  • Administrator
  • *
  • *
  • Posts: 13301
  • Activity:
    0%
  • Reputation Power: 154
  • TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!
  • Gender: Male
  • Viper!
  • Respect: +1349
  • Referrals: 33
    • View Profile
    • ScriptUO
Re: Shear Sheep, kill and repeat
« Reply #22 on: July 24, 2008, 08:54:40 AM »
0
I looked pretty carefully at your runebook increment stuff and it looks pretty good once I understood what your methodology was.  Short of actually trying to shear sheep, I'm not quite sure what could be wrong with the incrementing..  I'll have a bit more time to look at it this evening......
Please read the ScriptUO site RULES
Come play RIFT with me!

Offline TrailMyx

  • Officially retired from UO
  • Administrator
  • *
  • *
  • Posts: 13301
  • Activity:
    0%
  • Reputation Power: 154
  • TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!TrailMyx is awe-inspiring!
  • Gender: Male
  • Viper!
  • Respect: +1349
  • Referrals: 33
    • View Profile
    • ScriptUO
Re: Shear Sheep, kill and repeat
« Reply #23 on: July 24, 2008, 06:06:11 PM »
0
Ok, I think I know what your problem is.  First, I think your script is working exactly right now.  But I think you don't realize what the naming of the runebooks means.  The way j4bber made the naming convention is that you have the "name" followed by the number of the runes in a runebook.  So if you have a runebook  to sheep with 9 runes in it, you'll want to name your runebook "sheep 9".  You can have multiple books named the same thing.

In your vardump, what told me what's up is this:

Code: [Select]
%_NUMRUNES1: 1
%_NUMRUNES2: 2

So you have runebooks named "sheep 1" and "sheep 2" don't you..... ;)

So it's doing exactly what you told it.  heh.
Please read the ScriptUO site RULES
Come play RIFT with me!

Offline RamsesTopic starter

  • Jr. Member
  • **
  • Posts: 42
  • Activity:
    0%
  • Reputation Power: 0
  • Ramses has no influence.
  • Respect: +11
  • Referrals: 1
    • View Profile
Re: Shear Sheep, kill and repeat
« Reply #24 on: July 25, 2008, 04:07:56 AM »
0
LOL!~!!!

Thanks TM! You are correct, that is how I named my sheep books. I did not realize that would cause an issue. Inside the script I am looking for the quantity of runes in each book "%z" and I guess this area must not be working properly or I am not transfering the information properly?

Thank you, I shall continue to work on this. However, I think I can actually release a working version now...

Thanks for all the help, TM. (This damn thing was tougher than I expected.)

Tags: