Quote from: JackWalters on July 03, 2023, 11:47:23 PM

Quote from: altiric on July 03, 2023, 09:23:38 AM

Heh there actually should have been a cast function in there. You are the first person to point out it's missing/broken. I'll add it in if I ever do an update. Right now there seems to be no interest, so no reason too. Your fix should work fine, may need to add a slight delay after Orion.Cast since my cast function adds the delays based on fcr, etc.

Thank you for your answer. You are right, must be delay because script activate Whirwind attack very fast. And also tried to activate this attack with busido abilities but it no possible.  So modification in progress. If you can give me some advices i will be appreciate. Thank you in advance.

Code: [Select]

function cast(spell, target){
    var fcr = (6 - Player.FCR()) / 4 * 1000 + 250;
        Orion.CancelWaitTarget();
        if(Orion.HaveTarget())
            Orion.CancelTarget();
        if(Player.Frozen())
            return;

        if(target)
            Orion.CastTarget(spell, target);
        else
            Orion.Cast(spell);
       
        Orion.Wait(500);
        while(Player.Frozen() && !Player.Paralyzed())
            Orion.Wait(10);

        Orion.Wait(fcr);
}
Adding that to the script should solve a lot of issues. If you find anymore, feel free to post them here. Seems more people are getting interested, i may do an update to make sure everything is tweaked correctly and add some other features i have handy if it keeps up

Did Altric update his script with the newest changes posted in this thread? Because when I run it I get errors. So I'm guessing the casting code needs to added. Do I need to change the items JackWalters mention about using Orion.Cast and the numbers instead of how Altiric has it?

Where exactly should the above cast code be added to Altiric's originally script he posted? I added it after the function equipSlayer(graphic){ and before function loadTags(graphic){
function equipSlayer(graphic){
    var tags = loadTags(graphic);
    if(!tags.slayer) return;
    var weapon = Orion.FindTypeEx('0x0F4B', any, backpack).filter(function(weap){
        return Orion.Contains(weap.Properties(), tags.slayer +" Slayer");
    })[0];
    if(!weapon) return;
    Orion.SetTimer('weaponSwap');
    Orion.Print(color.purple.norm, tags.slayer +" slayer equipped");
    Orion.Wait('moveitemdelay');
    Orion.Equip(weapon.Serial());
}

function cast(spell, target){
    var fcr = (6 - Player.FCR()) / 4 * 1000 + 250;
        Orion.CancelWaitTarget();
        if(Orion.HaveTarget())
            Orion.CancelTarget();
        if(Player.Frozen())
            return;

        if(target)
            Orion.CastTarget(spell, target);
        else
            Orion.Cast(spell);
       
        Orion.Wait(500);
        while(Player.Frozen() && !Player.Paralyzed())
            Orion.Wait(10);

        Orion.Wait(fcr);
}

function loadTags(graphic){
    var tags = Orion.GetFindList('mobTypes').Items()
        .filter(function(type){
            return type.Graphic() == graphic;
        }).map(function(tag){
            var comments = tag.Comment().split('|');
            return {
                name    : comments[0] ? comments[0].toString() : "missing",
                slayer  : comments[1] ? comments[1].toString() : false,
                ignore  : comments[2] ? Boolean(comments[1]) : false
            }
    });
    return tags || false;
}

When I run this script it runs over to players green pets and even players in different forms such as Wraith. How do I get it to ignore player's pets and players in different forms? Those pets and players turn green to me. I get the following error. Line 114 ReferenceError: Can't find variable: ability

For the new Shrouded Sails event it it isn't attacking the pirates in the Void Pool either. How do I resolve that?

I will check it out

Looking through the code, the slayer wep swap will never work... Is there a way to do this pragmatically?  or would you have to manually create a Mob Graphics -> Slayer Type mapping somewhere?

Yeah thats what Im wondering as well. Im pretty sure he did a python version..  Ill find it and post so we can compare..
  He did have this seperate. Would this be pasted at a particular spot, or called upon during the script?\

https://github.com/matsamilla/UO-Steam/blob/master/Sailing/Profile%20Macro%20List

  if anyone is still needing the homepage address.

https://razorenhanced.net/