JaF's Slayer Book Maker 3.6.3 Updated 10-9-11 --Now has Donate to Library

[Neo]

It was nothing, I'm glad I could help!

I was also thinking about the possibility of both locations being blocked when you try to recall, it would break the script...

I'm thinking about a way to fix that, should it happen... As soon as I figure it out, I'll post it here...

EDIT: Ok, I thought of a simple way to prevent that from happening, the donatesub should be changed to this

Code: [Select]

;Donation SUB Begin
sub frneodonate
menu delete status
menu text status 40 245 Donating at Library
if #contname = generic_gump && #contsize = 530_497
set %closex #contposx + 30
set %closey #contposy + 455
click %closex %closey f
libraryrecall:
gosub TM_TravelFromRunebook RE 1 2 %librarybook
donateloop:
finditem %npc
if #findcnt < 1
   {
   goto libraryrecall
   }
set #lobjectid #findid
event macro 17
gosub donationgumpwait generic_gump 345_359
set %donatex #contposx + 40
set %donatey #contposy + 165
click %donatex %donatey f
set #ltargetid %trash
while #targcurs <> 1
wait
event macro 22
gosub donationgumpwait generic_gump 500_360
set %donatex #contposx + 355
set %donatey #contposy + 340
click %donatex %donatey f
wait 10
finditem * C_ , %trash
homerecall:
gosub TM_TravelFromRunebook RE 1 2 %homebook
finditem %resource
if #findcnt < 1
   {
   goto homerecall
   }
set #lobjectid %resource
event macro 17 0
wait 20
return
This fixes the last issue I could think of for now... It will now keep attempting to recall, changing between both runes, until it succeeds...

Sorry for not putting this in the code in the first place JaF, sometimes I read the code over and over and miss these little issues that could arise...

But now I guess it's pretty safe to run without breaking...


Ah, one more thing!

Thank you TM for your subs, this wouldn't have worked without them!

Cheers!

[JustAnotherFace]

Ok, uploaded the revised donate code from Frneo.  New version that includes donate is 3.6.1 and is located on the first page of this thread.

Thanks again Frneo for your code!

JaF

[SolidSnake]

Wow..nice transformation

[gimlet]

One of my favorite scripts just got better!

[_C2_]

been wanting to see this for a while and i was also sick of having to turn of the mark books with name option because i have the cave of the discarded overflowing ... every tile in all of the areas full of spell books.  i will giveit a shot.  the trick may be reentering the home.  ill look at it asap

[Xanderyum]

What I am running into is this: If i select magery and keep super slayers and donate books it wont cycle through the rest of the set up! The script will just start trying to make spellbooks. and as long as i have scrolls and scribe pens in my backpack it works.  Can I use all those options at the same time? keeping super slayers and donating the rest? I didn't even get an option to clcik on rune books??

I am running on the newest Easyuo, OSI shard and up to date client? let me know if you have any other questions. thanks.

[Guadah]

I'm about to give this a run also.  Kind of wish it had Bank support since that is where I store all of my Scrolls... however that could be kind of dangerous unless you use a isolated bank to recall in and out of.

Edit:
Same issues here as Xanderyum.  I select what I want to keep, hit play and It skips the section where I need to select my runebooks & secure containers.

[Neo]

I just downloaded the version here at the topic, and it isn't working for me either...

I don't know what's the cause of this...

Maybe when I sent the code to JaF, it cut off some of the code because of it's size, I dunno...

Anyway, this is the correct version, I'll upload it here, I hope there's no problem in doing that since it's clear that JaF wanted this version out for everyone. So, as soon as JaF adds this to his main post, I'll remove it.

Sorry about the inconvenience guys...

Cheers.

neo

[TrailMyx]

I appreciate the fixes for JaF's code, but please post the snippets to fix the code, and not the script as a whole.  It's up to JaF to maintain the script as a whole.  It's his script, so please respect his domain.  Poke him, flame him, but be sure he updates his script..  In the mean time, it's OK to post the line numbers and required changes and let everyone edit the original work.

[Neo]

I appreciate the fixes for JaF's code, but please post the snippets to fix the code, and not the script as a whole.  It's up to JaF to maintain the script as a whole.  It's his script, so please respect his domain.  Poke him, flame him, but be sure he updates his script..  In the mean time, it's OK to post the line numbers and required changes and let everyone edit the original work.

Sorry about that... I figured it wouldn't be a problem since this code is the exact version that I sent JaF, which was supposed to be the one in his main post... I didn't mean to break site rules or anything... I'll try and send it to him again, so he can upload the correct version in his post...

Sorry for the trouble...

neo

EDIT: I sent it again via PM to him, and the code was not being sent complete, probably because it's too big. That's probably why the code that he uploaded isn't working properly... I sent the whole code to him via e-mail this time, so I guess he'll upload it once he sees it!

[TrailMyx]

No worries at all, frneo.  Jaf takes extended breaks, and we respect his work.  If his break takes longer than normal, then we might "help" his script a bit. 

At least here at ScriptUO, we look out for the script author and their work.   I'll work hard to make sure your scripts are equally protected.  We do have standards to uphold. 

[Neo]

I decided to post the code because I felt kind of responsible for it not working, since it was me who didn't check to see if I had sent him the whole code in the first place...

I do appreciate the way things are dealt with here at SUO, and the way both staff and users work towards protecting the best interest of the site as a whole...

That's one of the reasons I chose SUO to be my home for scripting!

Cheers

neo

[JustAnotherFace]

Neo,

Please check your PM and send me the code to the new email address.

Thanks,

JaF

[Neo]

Neo,

Please check your PM and send me the code to the new email address.

Thanks,

JaF

Sent it JaF...

[JustAnotherFace]

Ok guys... Version 3.6.2 uploaded to the main page.  This includes the latest version of Neo's code that he mentioned a couple of posts up that got "cropped" out by the board PM function.  Hopefully this is the full version this time. 

Neo, could you please download the newest version and verify that it is indeed all included this time?

Thanks

JaF