TrailMyx's Full Auto Fisherman

[TrailMyx]

That looks broken.  In the CheckWeight sub, add

Code: easyuo

1.       menu get EUOCheckBox11
2.       set %enablebankrun #MENURES
3.  

right before the

Code: easyuo

1.       if %enablebankrun = #true
2.       {
3.  

Basically, the %enablebankrun variable is never read again after initialization.

[Dan123The123Man]

Ok im not sure if I put it in the right place here:

Code: [Select]

sub CheckWeight
  if #WEIGHT >= #MAXWEIGHT - 20 || #WEIGHT >= 425
  {
    menu get EUOCheckBox13
    if #MENURES = #TRUE
      gosub cutfish
    if #WEIGHT >= #MAXWEIGHT - 20 || #WEIGHT >= 425 ; still overweight?
     menu get EUOCheckBox11                ;  Is this where it goes to make it so if "enablebank" is unchecked it wont goto bank?
     set %enablebankrun #MENURES    ;  Is this where it goes to make it so if "enablebank" is unchecked it wont goto bank?
    {
      if %enabletrash = #TRUE
      {
        gosub TM_RandomRunebookTravel %travelmethod %trashrune1 %trashrune1 %runebook
        gosub TransferItems NULL CWI_AWI_NVI_OVI_PVI_QVI_ZVI_TVI -1 #BACKPACKID %trashcan
      }
      if %enablebankrun = #true
      {
        gosub DonateItems
        gosub BankItems
        gosub TM_TravelFromObject %travelmethod %boatkey
        if #RESULT = #TRUE
        {
          display ok Error in TM_TravelFromObject
          stop
        }
        wait 20
        gosub TM_StandCorrectly
      }
    }
  }
return
I was wondering though if I only want it to loot ancient SOS and discard the waterstained SOS do I put "MIB" in the CLAw looter and and only "ASOS" in the Fishing script menu? Or do I want MIB and ASOS checked on the fishing script menu? If it only collects "ASOS" (Ancient SOS) does it automatically just throw the waterstained on serpent corpse? And when does it open the MIB to see if its ancient or not? I tried playing with it and all I could ever get it to do is loot MIBs but never open them or discard the waterstained SOS... I think I had the wrong buttons in the fishing menu checked... I had claw looter to loot MIBs but fishing menu I had MIBs and ASOS checkmarked.

Also is there any way this could be added into the script to insure the ancient SOS incase the character were to die (good if enablebank is disabled or if you sail into a bunch of pirates)? The place I had it at was in the "Sub LootSerp" under the "if #pitchshoes = #true" I had gosub ScanInsure but im not sure if thats the best place for it.

Code: [Select]

sub ScanInsure
   ; set !lpc #lpc
  ;  set #lpc 1
   finditem  * c_ , #backpackid
   ; set #lpc 10
   for #findindex 1 #findcnt
   {
       if #Findcol = 1153  ;    ; 2301 = Doom   1157 = Minax   1153 = White for Ancient SOS
      {
         Event sysmessage Looking for Items
         event property #findid
           if ( Minax in #property && insured notin #property || ancient in #property && insured notin #property ) ; <--- chage this or add more like: || blahblahblah in #property &&
               gosub InsureItem
            Else
                Ignoreitem #Findid 7
   }
   }
  ;  set #lpc !lpc
  set %insuretimer #SCNT + 180  ; ( 180 sec )   < ---  add in sec the time you want between each scan
return

sub InsureItem
exevent popup #charid
wait 10

click 61 111 ;  ---  Location of Item Insure
set #ltargetid #findid
set #ltargetkind 1
target
event macro 22 0
wait 10
key esc
return

[Gaderian]

No, you can't break up a if statement from it's block, so you need to do this:

Code: easyuo

1. sub CheckWeight
2.   if #WEIGHT >= #MAXWEIGHT - 20 || #WEIGHT >= 425
3.   {
4.     menu get EUOCheckBox13
5.     if #MENURES = #TRUE
6.       gosub cutfish
7.     if #WEIGHT >= #MAXWEIGHT - 20 || #WEIGHT >= 425 ; still overweight?
8.     {
9.       if %enabletrash = #TRUE
10.       {
11.         gosub TM_RandomRunebookTravel %travelmethod %trashrune1 %trashrune1 %runebook
12.         gosub TransferItems NULL CWI_AWI_NVI_OVI_PVI_QVI_ZVI_TVI -1 #BACKPACKID %trashcan
13.       }
14.      menu get EUOCheckBox11                ;  THIS is where it goes to make it so if "enablebank" is unchecked it wont goto bank.
15.      set %enablebankrun #MENURES    ;  THIS is this where it goes to make it so if "enablebank" is unchecked it wont goto bank.
16.       if %enablebankrun = #true
17.       {
18.         gosub DonateItems
19.         gosub BankItems
20.         gosub TM_TravelFromObject %travelmethod %boatkey
21.         if #RESULT = #TRUE
22.         {
23.           display ok Error in TM_TravelFromObject
24.           stop
25.         }
26.         wait 20
27.         gosub TM_StandCorrectly
28.       }
29.     }
30.   }
31. return

Gaderian

[Dan123The123Man]

I have just ASOS checked under "Loot" in the Full-Auto Fisherman menu and "MIB" in the active loot for CLAw looter but its not checking for ancient SOS. I have like 20 MIBs in my bag. When does it open them up to check for Ancient SOS?

[The Ghost]

The check is to kept track of what you loop.   So when the menu tell you that ASOS = 3.  look for 3 ASOS in your bank and trash the rest for points.   You should be able to run this for 12hr before your bank is full.  maybe event more.

[Dan123The123Man]

right I know its a very good script; however, i'm trying to run it not using the bank which I think with their help it stopped making them goto the bank with the "enable bank" not checked, but now I cant figure out why its not opening the messages in a bottle if all I have checked is "ASOS" not "MIB". Isnt that how you determine whether you only want it to keep ancient SOS or messages in a bottle, the "MIB" or "ASOS" buttons? I looked back on page 63 and someone at the top was trying to figure out how to open MIBs to, is this script not supposed to open the MIBs for you if you have ASOS checked?

[The Ghost]

ensure you have change the ID of the  msg in bottle.  it have change last year.   This script were build for bank support. so I never mess with it.

[Gaderian]

It would not be difficult to replace the bank run with a house drop - but that is not what I would do these days.

If after doing what TG suggests, following the initial post modifications, the ASOS still doesn't work, then you will probably have to step through the logic and see how it evaluates. You could probably toss a regular SOS and an ASOS on the serpent corpse to see if it will pull the ASOS and leave the SOS behind. That would determine if it is the looting logic or the evaluate logic that doesn't seem to be working for you.

That post on page 63, stated that the issue was trying to open the MIB while on the serpent's corpse. In general, that doesn't make sense as an issue. I have a script that opens MIB's in containers that are not my #backpack, so that shouldn't be the issue.

You would have the ASOS chioce checked (but do not need the MIB choice checked) in order to only loot ASOS.

Gaderian

[TrailMyx]

Almost Dan.  You need to move those 2 statements above the IF statement.  You wrote:

Code: easyuo

1.     if #WEIGHT >= #MAXWEIGHT - 20 || #WEIGHT >= 425 ; still overweight?
2.      menu get EUOCheckBox11                ;  Is this where it goes to make it so if "enablebank" is unchecked it wont goto bank?
3.      set %enablebankrun #MENURES    ;  Is this where it goes to make it so if "enablebank" is unchecked it wont goto bank?
4.     {
5.  

but should be

Code: easyuo

1.      menu get EUOCheckBox11                ;  goes here
2.      set %enablebankrun #MENURES    ;  and here
3.     if #WEIGHT >= #MAXWEIGHT - 20 || #WEIGHT >= 425 ; still overweight?
4.     {
5.  

[Oracle]

I have been using this Script for years. Fishing is very boring, but fighting Scalis is not. I love selling the ASOS and white nets.

Something must have changed, as it is not equipping the bow when a Sea Serpent is fished up. It drops the fishing pole into the backpack and my Fisherman just stands there. The findtype is QPO - an animated composite bow of sorcery.  If I equip the bow manually it proceeds to kill the Serpent, but the Fisherman just stands there after the Serpent's death followed by "You must wait to perform another action" error over and over.  It also seems to me that you cannot have more than one bow of the same kind in your pack as the script errors and states that it can not find my archery weapon. Archery+Chivalry is selected.

ORACLE

[Gaderian]

Isn't the guided setup needed to select your weapon?
If you have that correct, then you may have a right/left hand weapon to arm/disarm it.

I don't play this with archery... so I rarely have even tested out the archery.

Gaderian

[Oracle]

I have used the guided setup, but it will not pick up the weapon from the backpack. Also if I am watching and arm it manually it won't put it back in the backpack...he just stands there -- after the kill, he doesn't loot the corpse, etc.

[Gaderian]

Hi Oracle,
Ok, so I just tested a snippet of this code. It turns out the composite bow (type QPO) is a left handed weapon when it comes to equipping it. Here is the change you need to make for several lines where it references PPO in the routines SetupWeapon, DisarmWeapon and ArmWeapon:

Code: easyuo

1. sub ArmWeapon
2.   if #RHANDID <> %1
3.   {
4.     finditem %1 C_ , #BACKPACKID
5.     if #FINDKIND <> -1
6.     {
7.       set #RHANDID %1
8.     }
9.     else
10.     {
11.       display ok I cannot find this weapon
12.       return
13.     }
14.   }
15. ArmWeapon_loop1:
16.   finditem %1 C_ , #CHARID
17.   if #FINDKIND = -1
18.   {
19. ArmWeapon_loop2:
20.     finditem %fishingpole C_ , #CHARID
21.     if #FINDKIND <> -1 ; must de-equip fishing pole
22.     {
23.       exevent drag %fishingpole 1
24.       wait 10
25.       exevent dropc #BACKPACKID
26.       wait 30
27.       goto ArmWeapon_loop2
28.     }
29.     finditem %1 C_ , #BACKPACKID
30.     if #FINDKIND <> -1
31.     {
32.       if #FINDTYPE in PPO_QPO
33.         event macro 24 1 ; disarm weapon to setup - left
34.       else
35.         event macro 24 2 ; disarm weapon to setup - right
36.       wait 30
37.       goto ArmWeapon_loop1
38.     }
39.     else
40.     {
41.       display ok I can't locate your archery weapon
42.       stop
43.     }
44.   }
45. return
46. ;-------------------------------------------------------------------------------
47. sub DisarmWeapon
48. DisarmWeapon_loop1:
49.   finditem %1 C_ , #CHARID
50.   if #FINDKIND <> -1
51.   {
52.     if #FINDTYPE in PPO_QPO
53.       event macro 24 1 ; disarm weapon to setup - left
54.     else
55.       event macro 24 2 ; disarm weapon to setup - right
56.     wait 30
57.     goto DisarmWeapon_loop1
58.   }
59. return
60. ;-------------------------------------------------------------------------------
61. sub SetupWeapon
62.   finditem %1 C_ , #CHARID
63.   if #FINDKIND = -1
64.   {
65.     finditem %1 C_ , #BACKPACKID
66.     if #FINDKIND <> -1
67.     {
68.       if #FINDTYPE in PPO_QPO
69.         set #LHANDID %1
70.       else
71.         set #RHANDID %1
72.     }
73.     else
74.     {
75.       display ok I can't locate your archery weapon
76.       stop
77.     }
78.   }
79.   else
80.   {
81.     gosub DisarmWeapon
82.   }
83.   if #FINDTYPE in %crossbowtypes
84.   {
85.     menu Font BGColor BtnFace
86.     menu delete EUOLabel32
87.     menu Text EUOLabel32 176 196 Bolts
88.     set %ammotype LNK ; LNK - crossbow bolts
89.   }
90.   else
91.   {
92.     menu Font BGColor BtnFace
93.     menu delete EUOLabel32
94.     menu Text EUOLabel32 176 196 Arrows
95.   }
96. return
97.  

The only lines that change in those routines are where it referenced if #FINDTYPE in PPO gets changed to if #FINDTYPE in PPO_QPO.

Make those changes and give it another try. (You might need to go through the guided setup again... I am not sure.)

Gaderian

[Oracle]

Gaderian!

That was it. I did not think of a bow as being a left-hand object would n=make a difference. I simply assumed that during setup clicking on the bow would initialize it in the script when running it. It sure messed up the timing of the script. I hated babysitting it and manually arming and earning the bow.

Thank you for all of your help. Now need to see if there is a 120 Fishing around. The art of Fishing seems to have died in Sosaria.

[Gaderian]

Happy to help. It also may help the next person, too.

There is a method to arm/disarm without the right/left hand stuff using the event macro 64-66 commands which would make the script more generalized, but that is a little more effort than adding your weapon's type to each of the statements.

Gaderian