ScriptUO

Official ScriptUO EasyUO Scripts => Script Library => Crafting => Topic started by: Crisis on April 22, 2015, 05:58:49 PM

Title: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: Crisis on April 22, 2015, 05:58:49 PM
Code: [Select]
;===================================================================
;===================================================================
; Script Name: Crisis Craft and Fill Spellbook Filler
; Author: Crisis
; Version: 1.3b
; Client Tested with: 7.0.45.0
; EUO version tested with: 1.5 (version 285)
; Shard OSI / FS: OSI
; Release Date: 04/22/2015
; Revision Date: 04/30/2015
; Purpose:
;     .Craft spellbooks, craft spell scrolls, and fill the spellbook.
;     .Magery, Necromancy, and Mysticism
;
; Revisions:
;     1.1
;     .Fixed buttons so they don't disappear when you start to craft
;     .Adjusted Status to show the spellscroll number and name of spellscroll being crafted
;     .Clears resources out of pack into secure upon completion of spellbook though I may add that into a button in the future
;     .Cleaned up code
;     1.2
;     .Changed Scroll_Secure to automatically be set as players backpack
;     .Added a Storage_Secure so completed spellbooks can be moved out of the backapck
;     .Added event sysmessage to remove extra clicks when setting secures and spellbooks
;     1.3
;     .Adjusted resource amounts and added a pause if you run out of resources
;
; Requirements:
;     . You need to have a secure with regs, iron ingots, and blank scrolls inside it and within reach
;     . You need to have at least one tinker tool and one scribe pen in your backpack
;
; Future Updates:
;     . will integrate this into my quick and painless spellbook filler
;
; Special Thanks:
;     . Manwinc for use of his crafting subs
;     . TrailMyx for use of his Meditate Sub
;     . The Ghost for testing and suggestions
;
; Copyright: 2015 Crisis
;===================================================================
;===================================================================

REVISED! 04/30/2015
1.1 Fixed buttons so they don't disappear when you start to craft
      Adjusted Status to show the spellscroll number and name of spellscroll being crafted
      Clears resources out of pack into secure upon completion of spellbook though I may add that into a button in the future
      Cleaned up code
1.2
     Changed Scroll_Secure to automatically be set as players backpack
     Added a Storage_Secure so completed spellbooks can be moved out of the backapck
     Added event sysmessage to remove extra clicks when setting secures and spellbooks
1.3
     Adjusted resource amounts and added a pause if you run out of resouces

This script works with Magery, Necromancy, and Mysticism.

Choose one of the three magics, it will craft a spellbook, crafts the spells, and then fill the spellbook. Comes complete with neon menu  :P

(http://thedemigod.com/pics/craftnfill.png)


Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.0
Post by: gimlet on April 22, 2015, 07:41:31 PM
Used the old version (mage only) a few days ago and it worked perfectly.
Will try this one this weekend!
Thanks
Crisis!
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.0
Post by: Endless Night on April 23, 2015, 05:18:18 AM
I am liking the look of that menu....
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.1
Post by: Crisis on April 23, 2015, 07:24:09 PM
Revised and solved the debug issues. Can this please be moved to the submit scripts section?

UPDATED Version 1.1

Take it for a test spin!
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.1
Post by: TrailMyx on April 23, 2015, 07:29:37 PM
What was the problem?  I looked at it and couldn't find it...
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.1
Post by: Crisis on April 23, 2015, 07:56:52 PM
What was the problem?  I looked at it and couldn't find it...

I am not sure why it only did it with the mysticism scrolls but I changed this line in the sub CraftMystScroll15 from

Code: [Select]
Finditem %scroll15 C_ , #backpackid
to

Code: [Select]
Finditem IKR C_ , #backpackid
I don't know why that would affect myst scrolls and not mage scrolls but the mage ones worked okay doing it the first way but not the myst.
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.1
Post by: TrailMyx on April 23, 2015, 08:25:23 PM
What was the problem?  I looked at it and couldn't find it...

I am not sure why it only did it with the mysticism scrolls but I changed this line in the sub CraftMystScroll15 from

Code: [Select]
Finditem %scroll15 C_ , #backpackid
to

Code: [Select]
Finditem IKR C_ , #backpackid
I don't know why that would affect myst scrolls and not mage scrolls but the mage ones worked okay doing it the first way but not the myst.

Oh crap!  What a nightmare to debug!  There is ZERO reason why that shouldn't have worked...
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.1
Post by: Endless Night on April 23, 2015, 08:59:43 PM
Revised and solved the debug issues. Can this please be moved to the submit scripts section?

UPDATED Version 1.1

Take it for a test spin!

Moved.
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.1
Post by: Crisis on April 24, 2015, 02:37:55 AM
What was the problem?  I looked at it and couldn't find it...

I am not sure why it only did it with the mysticism scrolls but I changed this line in the sub CraftMystScroll15 from

Code: [Select]
Finditem %scroll15 C_ , #backpackid
to

Code: [Select]
Finditem IKR C_ , #backpackid
I don't know why that would affect myst scrolls and not mage scrolls but the mage ones worked okay doing it the first way but not the myst.

Oh crap!  What a nightmare to debug!  There is ZERO reason why that shouldn't have worked...

Yeah, I tried renaming the set %scroll15 IKR and the spot it called it, retyping both, copy and pasting both to make sure that how the scroll was set was the same id as the scroll in the bag where it should have stopped because it could find it. The only other thing that came to me was the the set %scroll15 IKR was in a sub and not the beginning but it worked for other scrolls, just not the 2 myst scrolls. I finally decided to just call the id itself and it worked.

I can say that I added a couple of gray hairs while trying to troubleshoot it over the past couple of days. I am very excited that I was able to figure it out. There is hope for me yet to become a decent scripter! This summer I will be looking at learning python so I can play with stealth!
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.1
Post by: Crisis on April 25, 2015, 12:15:01 PM
Has anyone tried the new version, 1.1?
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.1
Post by: Endless Night on April 29, 2015, 04:33:43 AM
Has anyone tried the new version, 1.1?

Bump..  Calling all new members  this is the perfect time to get involved give this new script a test run and post some feedback :)
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.1
Post by: The Ghost on April 29, 2015, 07:41:35 AM
Crisis,   Let be a leader and test that puppy. I don't  really need any spellbook, but I will to this for you.     
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.1
Post by: Crisis on April 29, 2015, 04:50:26 PM
Thanks Ghost!! You the man!!  ;D
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.1
Post by: The Ghost on April 29, 2015, 04:59:02 PM
I test this by making one of each book.  

Let said that It work like advertise.  Few think That I will chance but that only me been fussy.

First
Requirements:
-  equipment your spellbook   < ------ let add this warning so your scroll don't stay in you backpack.   It been said  in some poste but let add it.

Second.
Line 449  so you can remove that display box.  just don't like that extra click.
Code: [Select]
change
display Select your Resource Secure..
for
 event sysmessage Select your Resource Secure...
.

Third   ;
line 483 I will go that route.  <----------    This is remove few click and still display the ID.  
Code: [Select]
change
display Select your backpack...
    set #targcurs 1
    while #targcurs = 1
      wait 5
    set %Scroll_Secure #ltargetid
    set #lobjectid %Scroll_Secure
    event macro 17 0

for
 gosub newstatus lime black 10 Choose Secure
     set %Scroll_Secure #BACKPACKID
     event macro 17 0


  Fourth
Line 2438    
When you are out of resource,  Can you just do a pause and return so we don't have to setup again.  just a thought.
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.1
Post by: Crisis on April 29, 2015, 08:14:13 PM
Updated to Version 1.2
     Changed Scroll_Secure to automatically be set as players backpack
     Added a Storage_Secure so completed spellbooks can be moved out of the backapck
     Added event sysmessage to remove extra clicks when setting secures and spellbooks


 Fourth
Line 2438    
When you are out of resource,  Can you just do a pause and return so we don't have to setup again.  just a thought.

That is manwinc's sub so I will have to check with him before making any changes to it for my script

Thanks for testing it The Ghost, let me know how the new changes work for you and if you have any issues with it.  ;D
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.2
Post by: The Ghost on April 30, 2015, 03:57:20 PM
That enough testing for me.  I like the new storage bag and the removal of the display.   The  Necro and Myst work great for me.   I had a few failure with the Margery one.   It didn't work great for me.  The first try I didn't notice an old spellbook.  Second time note sure why but it get stuck making Meteor swarm ( 35 time) before I stop it.   third time not sure what happen but wasn't lucking, got lot of scroll in my pack and  fail.  The six time I pay close attention and once again notice that he wasn't able to make the Polymorph. had to manually do it and I did fill up the book. 

So  recap.   I have 6 books in storage, only one fill at 64. other a various level.  had a mixte of low level scroll and   over 84 Meteor swarm scroll.    Ver 1.1 work before for me. 


I'm sure you didn't touch any of the sub, so I can't see why it fail on my side after u did ur how testing.   Except for the glitch at  line 861. it great. 
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.2
Post by: Crisis on April 30, 2015, 04:51:42 PM
Anyone else up for testing, it is working for me so I am not able to repeat it getting stuck at meteor swarm.  :'(

EDIT: Added a new version, 1.3 with small adjustments

1.3
     Adjusted resource amounts and added a pause if you run out of resources
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3
Post by: The Ghost on April 30, 2015, 05:11:19 PM
I just try Ver 1.1  to make magery and it work flassles for me.  This is weird.   Wonder if it is a code C-18. 
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: Crisis on April 30, 2015, 06:03:22 PM
Ok I took version 1.1 and redid the changes to make sure a mistake was not made. I uploaded it as version 1.3b so give it a try!
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: The Ghost on April 30, 2015, 06:25:51 PM
Right on.  Ver 1.3a work like a charme

Great work
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: Crisis on May 01, 2015, 02:57:35 AM
Thanks for all of the testing Ghost! Is there anyone else who can test this to make sure this version is solid? I have made 10 full spellbooks from each category so it is stable for me as well.
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: Crisis on June 01, 2015, 08:05:42 PM
Anyone else try this by chance? Feedback?  8)
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: gimlet on June 02, 2015, 04:59:07 AM
Crisis - can you run this just to fill books without any inscription?
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: The Ghost on June 02, 2015, 07:29:33 AM
Gimlet,  Crisis was way ahead of you. You can try this build http://www.scriptuo.com/index.php?topic=12440.0   
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: gimlet on June 02, 2015, 10:08:52 AM
Thanks - I have all the scrolls already!
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: Crisis on June 02, 2015, 01:30:13 PM
Thanks Ghost! The one Ghost linked should work great for ya Gim. On a side note, I am currently working on an all inclusive scribe script that will train, fill empty books from containers, craft and fill books, craft spell scrolls and other items.
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: Cush on June 25, 2015, 01:09:07 PM
I will give this a run for you and provide some feed back in the next day for ya!
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: Crisis on June 25, 2015, 06:08:52 PM
Thank you  ;D
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: Cush on June 26, 2015, 01:34:58 PM
Ok I ran this most of today. Here are some items for you.

I have run about 75 Magery Books

I found that I have to start with my backpack completely empty of resources otherwise it hickups at some point and starts making additional scrolls or says I am out of one of the ingredients without refilling.

In the backpack at start I just have the pen, tinker's tools, a few ingots. Runs pretty smooth from there.

Every once in awhile I get a spellbook completed short one or two scrolls but they are in my backpack and did not end up in the book.

I also run into a situation from time to time in the higher level spells where the script does not go into meditation mode and I get the you do not have enough mana error. This is pretty hit and miss.

It would be nice to be able to set the script to do a series of books. Since I would be using it to stock books for sale on my vendors. It would be much more convenient to be able to say make 20 books

I will make another 50 or so and move onto the next type
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: Endless Night on October 17, 2015, 10:12:11 AM
Congratulations your Script has been moved to Script library
(If you feel the script is in the wrong section please send me a pm.)

Thank you for your submission.
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: Oracle on July 14, 2017, 10:08:34 AM
Hi Crisis,

I thought I would give this a go.  I have been using JAF's Slayer Book Maker trying to make some Super Slayers, with little success there, but I have some spellbooks that have decent mods and I want to fill them.  Is there a way to have your script fill existing spellbooks that you have already crafted>  Yours crafts a spellnook first then fills it, correct?
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: Crisis on July 14, 2017, 02:36:16 PM
http://www.scriptuo.com/index.php?topic=12440.0

I knew you would be asking so I wrote this in 2015  :P

It was on the next page. I am currently working on an all in one scribe script. I will hopefully have it ready for testing soon.
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: TrailMyx on July 14, 2017, 07:47:17 PM
The special projects section is on fire with its scripting goodness.  Heh
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: formerlyrara on March 10, 2021, 10:32:31 AM
Well want to say thanks, you ruined me again! was toying around with another scribe (Kalis) works great for mage spells, needed mystic and necro (no one does necro), and gave this a shot. WORKS like a champ. Once in a blue moon it screws up at end haven't nailed it down with the spellbook filling, it leaves it out but thats fine to hand fill it. it has happened 3 out of 20 times, so might be a timing issue. But yes old script, works like advertised still and saves me a lot of time!!
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: Crisis on March 10, 2021, 08:28:00 PM
I have not used this script in over a year but will check it out this weekend and see if anything needs adjusting. Thanks for the feedback!
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: Tidus on December 22, 2021, 08:46:39 PM
Did some tweaks to it.  Noticed that you had a few areas where it was checking if need meditate or craft.  Rather than mediate THEN craft.  So i fixed that. Also changed a few at the end that were having issues with making last. It would go a bit too early and fail a mana check and not be able to craft next scroll. so then it would be stuck in a make last loop. I changed it so that it wasn't doing make last, but the whole category and spell choice over again.
Title: Re: Crisis Craft and Fill Spellbook Filler Version 1.3b
Post by: stryder on March 19, 2022, 05:10:29 AM
Great script!! I have to learn from this... that is for another day though.

It saved me time from having to click through all those gumps manually  :)