ScriptUO

Official ScriptUO EasyUO Scripts => Site Scripter Libraries => _C2_ Script Library => Topic started by: _C2_ on May 01, 2009, 03:39:51 PM

Title: C2's BOD Collector Script
Post by: _C2_ on May 01, 2009, 03:39:51 PM
I do not support Freeshard directly but have left old versions up for its use- You may post how you tweaked for your own freeshard if you like but i do not play freeshards sorry

;=======================================;
; Script Name: C2
; Author: I-Farm Multi-Shard BOD Collector
; Version: 1.4c  (Version 1.0c has old timer system for free shards)
; Shard OSI/FS: OSI
; Revision Date: 19-May-2008
; Purpose: BOD Farming Smith & Tailor
; Credit: TM journal subs/
; Endless explaining #lshard
;========================================
This script will farm Smith and Tailor bods at the same time or one or the other as you choose at intervals of every hour, two hours or six hours depending on your skill level.


;===============================================================
The script will also allow you to mark collect both smith and tailor even if certain characters in the collection process only have one of the skills. I have the script check your skill level and only collect each bod type if you have the skill to & you have checked the box for that bod type. Why have I done this? To give you more control! I don't want as many Tbods myself so on my main accts I am certainly not going to give my mains tailor skill. Now i can have my mains get a smith bod & the farming acct get both because it won't get stuck trying to collect for a character without skill!

Handles conn loss, shard not being available (retries every 60 seconds to see if it is back), connection loss, and errors on connection pages (takes a short wait and closes error then restarts process)! I wrote the login subs from scratch as they are 100% non OCR dependent and you can pvp while the bod collector client does it's thing underneath. or you can surf the web.
;==========================================
Directions/ Info:
;Script collects bods in luna- i like to be hidden but your call (Location to log at bottom of post in thumbnails)
;script collects every six or 18 hours - your choice
;script allows for you to log up to all seven char. slots
;script allow for CHOICE to decide which slots to log or not
;script allows you to collect both tailor and smith or
;one or the other (choices on menu) (If both checked it will choose due to skill level to get bod)
;script set timer for next collection after the cycle is completed and gives a minute timer and the actual time of next collect.
;will handle extra loose bods in pack while sorting
;YOU MUST name books by bod type! smith or tailor as name... you can name the book smith and tailor if you want them mixed together in one book.The script sorts by a bod type. book named smith- book named tailor
;Use .1 skill of tailor and smith if you want to farm bods
;to fill every hour
;good idea to hide the character in the log in and out spot so peeps don't mess with ya
;==================================
How to set up acct info & shards:

simply fill in the below info and u can add more accts and shards if u wish. I fyour shard has two names connect the two names with an underscore "_". Lake superior would look like this lake_superior. lake_austin or napa_valley etc.

Code: [Select]
;-------------Edit Shards Here-----------
;shard name - if 2 names use _ Ex. Lake_Austin
set %S1 atlantic
set %S2 great_lakes
set %S3
set %S4
set %S5
;--------Accts. and Passwords------------
set %A1 winuoftw <----my pretend acct
set %PW1 freebods <------pretend pass
set %A2
set %PW2
set %A3
set %PW3
set %A4
set %PW4
set %A5
set %PW5
;====================================
Now the final set that gives you the best control over how many accts , slots, shards you collect from is this...


The key is understanding this:
;%1=Char Slot # %2=location %3=acct, %4=pass, %5=shard
everytime you want a new character to login u make this line below that has the above info for that particular collector in it...
gosub login (char slot) (luna) (%acct#) (%pass#) (shard)

examples look like this: remember u already set up the values for %a1, #a2 etc & %pw1, %pw2... & %s1 up top
gosub login 4 luna %A1 %PW1 %S1
-- this gets 4th character from acct #1, password #1, and shard #1

gosub login 2 luna %A2 %PW2 %S2
--this gets the 2nd character from acct #2 with pass #2 on the shard listed up top as %S2.

here is how i would set up characters 1-5 on a trial acct!
Code: [Select]
gosub login 1 luna %A1 %PW1 %S1
gosub login 2 luna %A1 %PW1 %S1
gosub login 3 luna %A1 %PW1 %S1
gosub login 4 luna %A1 %PW1 %S1
gosub login 5 luna %A1 %PW1 %S1
Edit that info here on the script:
Code: [Select]
;----------Add gosub login lines below-----------------------
main_bod_loop:
;%1=Char Slot # %2=location %3=acct, %4=pass, %5=shard
;gosub login 1 luna %A1 %PW1 %S1 ;example
;gosub login 2 luna %A1 %PW1 %S1 ;example
;add line
;add line
;add line
;add line
;add line
;add line
;------------End or Shards--------------
***Luna just needs to be there as a place holder for now. I have that there as a variable if I start to make this script collect at different locations. If I do that, I will want a variable in there to tell the script what strategy to use to collect with. For now, LUNA is the only place as login and outs are fast and efficient.
Title: Re: C2's BOD Collector Script
Post by: Kane12 on May 03, 2009, 01:01:20 PM
This script was fairly easy to set up once I figured out to take the ";" out of the sub lines after I added the account, password, and shard information (yea I'm a noob).

I did have one question which I PM'd ya on C2, that I think might help others if they run into the same problem and avoid another question if it was to surface.

I have everything set up and the script logs on and prompts the gump menu to take the said script from both the tailor and smithy but for some reason it hangs up after the menu appears and fails to "click or accept" the bod from the menu and the script then moves on to log out and log onto another character after a bit (60 seconds between tries I believe is the default set up and it tries 2-5 times per bod type - tailor/smithy).

With this 60 second delay, I adjusted the delay down after this problem to 10 seconds to move things along. The script responds the same.

Was wondering if there is anything that can be done to tweak or adjust the script to better recognize the menu gump to take the bod before moving on instead of timing out. This happens about 85% of the time and happens randomly.

I am running windows XP, working with 4 accounts (with 15 or so chars total), and only running on one shard (Pacific). I dont seem to experience very much lag or latency that I can tell when logging in that I initially thought might affect it.

Didnt know if this portion of the script reflected a specific location for the curser to function in (and maybe affect the monitor size) or if there was anything else I can do to tweak things in the script.

Regardless of this delay, I'm very thankful for all your time and commitment to setting this up. I work 60+ hours a week and this gives me a chance to better utilize my accounts to collect bods.

Any input or recommendations would be greatly appreciated.

Thanks
Title: Re: C2's BOD Collector Script
Post by: _C2_ on May 03, 2009, 01:27:55 PM
try 1.0c and does it ever get the bod?  if never is the answer then it is a wrong click position.  if sometimes it is a weird timing issue or getting hung up in the journal scan.  but then again it wouldn't move on to loggin out if it was hung in the journal.


just found out that i posted an old version maybe this will be better.  I haven't used this in about a year and pearls use to use it a ton.
Title: Re: C2's BOD Collector Script
Post by: Kane12 on May 03, 2009, 07:32:20 PM
Thanks. Tryin this one out also and will provide feedback.

There is a difference between the mouse pointer location between small and large bods.....wondering if that might be causing some confusion.

Will let ya know what this one does.

Thanks and appreciate it
Title: Re: C2's BOD Collector Script
Post by: _C2_ on May 03, 2009, 07:41:19 PM
I think you just figured it out.  i have only run this to get .1 skill characters as did my two testers that were running this non stop.  so in testing it always clicked smalls because that is all i could get.... hrm.. now how to fix it?  larges are several different sizes and you cannot to a enter key to accept.  I am open to ideas on this one but pretty sure i just need to find all the gump sizes and just make if x gump click here... etc.


Got it!
Title: Re: C2's BOD Collector Script
Post by: _C2_ on May 03, 2009, 07:53:40 PM
You had it right Kane!  Thank you for your excellent feedback to help me target the error.  I have added the different sizes of gumps for different sizes of bulk orders.  Let me know if you find this works better.  it should be perfect now!

+1 karma for helping me target a fix!  :o
Title: Re: C2's BOD Collector Script
Post by: Kane12 on May 03, 2009, 09:12:26 PM
Good deal!!!

Will run this again tomorrow with the fixes and test again.

Thanks!

Post Merge: May 05, 2009, 12:32:47 AM
Perfecto!!

I ran two runs now at 3pm today and 9pm and no hangups at all.

I had asked wife to "click" the start button this morning at 9am to start while I was working but after 3 chars it paused for a sec and she didnt think it was doin anything and started over.

The only suggestion I would make for the script that would help others using it like me every 6 hours would be an option to do a one time skip over chars then continue with normal runs on next 6 hour time frame. It was a pain to have to wait 6 hours to restart the script as it hangs up on chars that have already collected their bods (60 second delay between trying again and seems to keep trying over and over - did it for over 1.5 hours to my wife when she inadvertantly stopped and restarted) and didnt make it past the 1st character...trying to collect.

I guess another suggestion would be to have it only retry two or three times and have it move on to the other bod type and do the same then log and move to next char. I expect this would be a better option that above (thinking out loud).

Thanks again.....your changes and adjustments to the gump menu sizes to accomodate for the different menu sizes worked like a charm.

I have 22 characters all GM (except 4 legendary) that I will run this with each day....so should be worth the time and payoff. Really appreciate your hard work and expertise C2.


Post Merge: May 04, 2009, 10:37:27 PM
Sorry missed on thing....on timer. Seems the minutes are not displayed correctly. My menu currently shows 3456 minutes remaining when that would be alot of time (57.6 hours). It says next pick up at 3:10am which is 4 hours away from now which would be 240 minutes roughly.

Maybe the timer is set for something other than minutes....just wasnt sure.

Thanks again
Title: Re: C2's BOD Collector Script
Post by: REEFHAWK on October 01, 2009, 01:38:24 PM
First thing, this is an awesome script.  a friend actually found it and sent me a copy and I have been using it for several months.  It is such a time saver.  

However since the publish of SA, as with many scripts, I am having a problem.  between my friend and I we have been able to get many of them working once again.  We can not figure this one out.  What is happening;  I hit begin, it logs character in, then acts like it used to when I had my character somewhere other than Luna, and it log that character out and the logs next one in.  

So, i did F7 to see where it was getting to:  

sub gump_locations ; %1 = xpos  %2 = ypos  %3 type of click
    set %clickx #CONTPOSX + %1
    set %clicky #CONTPOSY + %2
    click %clickx %clicky %3
return

wait 2s
sub find_vendor  ;%1 tailor or smith
ignoreitem #charid
still_searching:

it just keeps going over the following lines:

finditem HS_IS
if #findkind = -1
  return
  if #findrep <> 7
    {
    ignoreitem #findid
    goto still_searching

and just keeps going back to these lines over and over with me hitting F7.  

I play EA Catskills.  All my characters that are bod collectors are Legendary Blacksmith and Legendary Tailors.

Hoping for a little help in getting this one back up.  It is such a time saver.  Thanks
Title: Re: C2's BOD Collector Script
Post by: Larppa on January 08, 2010, 04:24:28 PM
Freeshard note, i had issue with the distance to npcs from that specific luna corner so i modified the script a bit:
Code: [Select]
    if weaver in #property || tailor in #property
       {
       Set %bodguy #findid
       move #findx #findy 2
       ignoreitem reset
       return


and

Code: [Select]
if blacksmith in #property || armourer in #property
             {
             Set %bodguy #findid
              move #findx #findy 2
             ignoreitem reset
             return
             }

this can be handy for others playing on freeshards (or suffering from range issues).

Btw, thanks for awesome script  ;D
Title: Re: C2's BOD Collector Script
Post by: bendel on January 10, 2010, 05:33:02 AM
Hello, i have a little for entering on the shard.

The name of the shard is like  : My - Shard


then i tried  1) set %S1 My - Shard
             or     2) set %S1 My_-_Shard

And when i'm in the screeen selection, the script return instantly on the first screen (login:pass)

Any ideas to resolve ?
Title: Re: C2's BOD Collector Script
Post by: Khameleon on January 10, 2010, 04:56:18 PM
try something like this

set %S1 My , #Spc , - , #Spc , Shard
Title: Re: C2's BOD Collector Script
Post by: bendel on January 10, 2010, 09:15:09 PM
Thanks worked ;)

Title: Re: C2's BOD Collector Script
Post by: Khameleon on January 11, 2010, 02:36:22 PM
I R Weasel!
Title: Re: C2's BOD Collector Script
Post by: Iraq- on February 27, 2010, 09:51:07 AM
I am having an issue with this script, and I know where it's running into problems for me...

I'm playing a freeserver where the line to get the BOD from the tailor is the 4th option down (instead of the 2nd line down like it is on OSI)..

When I run this script, it does everything correctly besides clicking the vendor buy option rather than claim bod reward..

Where would I change which line the collect sub chooses from the drop menu?

Thanks,
-Iraq-


Edit:
Nevermind guys, I did some critical thinking and figured it out.

If anyone else is having this issue, here's the solution:

Change line 185:

From:

gosub bod_gump 30 40 ; for menu pop up spot

To:

gosub bod_gump 30 80 ; for menu pop up spot

... Since the 2nd number is %y in the drop down menu. 20 is the 1st option of the 5 options, 40 is the 2nd, 60 is the 3rd, 80 is the 4th, and 100 is the 5th.
Simple stuff, enjoy.
-Iraq-


Post Merge: February 27, 2010, 10:12:07 AM
I had another thought while running this and i figured i'd share it here.


I ran this script once, it got about half way through my account, but then I crashed and had to start it over. Upon doing so it went to the first character, and is now sitting there trying each minute to get a BOD (which it will continue to do for the next hour since I just got one not 5 minutes ago). Wouldn't it be awesome if there was a "Skip this character, move on to the next character" button on the mini timer window?

I'm not a scripter, but i can see it going something like
sub next_character
 --> if button is clicked
 --> log out character
 --> move to next character on the list..
 --> proceed as usual.
end sub
Title: Re: C2's BOD Collector Script
Post by: Paulonius on March 04, 2010, 11:56:46 AM
I am currently running a hacked up version of Razael's. I would have used yours for template if I had known about it C2!! When a toon can't recall to a location it simply logs out wherever the toon is and runs a three minute timer.  That was his solution, not mine, but I kinda like it.  If you have enough accounts to cycle you can adjust the timer downward.  My current setup takes just under a minute to collect and dump for each toon, so four accounts would be no timer if they are set up to run sequentially by account rather than toons on an account.

I also have the script using a rune book to go to smiths and tailors, and then dumping the books into bod books in secures at my house so that I have them all in one book.  I don't like having to log on all of my bod runner toons to consolidate the bods they picked up. 
Title: Re: C2's BOD Collector Script
Post by: Cheatsauce on March 26, 2010, 02:46:42 PM
I had the old version and it killed me when it stopped working.  That script is one of the most useful I have ever seen and it made me cry when I coudln't get it to work anymore.  Glad there is a newer version!
Title: Re: C2's BOD Collector Script
Post by: _C2_ on March 26, 2010, 06:52:48 PM
I had the old version and it killed me when it stopped working.  That script is one of the most useful I have ever seen and it made me cry when I coudln't get it to work anymore.  Glad there is a newer version!

Yes, the gumps are all fixed.  as soon as you fulfill the site requirements it will be free to download!  ;D
Title: Re: C2's BOD Collector Script
Post by: Hoby on June 02, 2010, 04:18:36 AM
hey c2 I set up all the information for one account but when I start it the timer starts but it never logs in and gets bods.  Can you please take a look at this.
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 02, 2010, 05:16:36 AM
hey c2 I set up all the information for one account but when I start it the timer starts but it never logs in and gets bods.  Can you please take a look at this.

let's get on ICQ tonight and talk through it.  I am not aware of it breaking with the last pub; however i sometimes get a cannot log in error page when my miner relogs every morning and it just sits on that page (prob changed gump).  not sure what that is about but sounds like you get no action at all which leaves me to believe that you missed something in set-up.  We can figure this out.  I don't have an acct that i can use anymore on this.
Title: Re: C2's BOD Collector Script
Post by: Hoby on June 02, 2010, 07:12:24 AM
alright, ill go through the setup again and give it another try.  thanks.
Title: Re: C2's BOD Collector Script
Post by: Hoby on June 02, 2010, 04:10:54 PM
Fixed the original problem, now im having a issues collecting the bods.  It gets to the bod gump but doenst click get bod.  It did this on 6 out of seven chars.  But the seventh char did click to get the bod. 
Title: Re: C2's BOD Collector Script
Post by: Hoby on June 02, 2010, 08:20:07 PM
After talking with c2 and adding a wait it seems to have fixed my issues.  Will run it tonight to make sure.

edit:  Waited till all chars were on the same bod schedule and ran it for several loops, even with the wait added its still doing the same thing.  I get the bod gump but it never clicks ok to get the bod.  It did it for all the characters on the account.
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 03, 2010, 05:29:06 AM
alright I will make guys to test with to see if they moved the click point on the BOD.  It is possible.  You playing on a default resolution meaning your computer its self has not been altered in the control panel.  I had a computer where i actually changed the resolutions in the main screen once and this stuff was always a little off due to that.  Although that would cause a lot of scripts to give you hell.

The only other thing I can think of is that you said it has already tried to get the bod before the backpack opens.  WHen the backpack finally pops open, it becomes the main gump.  this would cause the bod collection gump to not show in the EUO variables.  If you are comfortable with trying a change before i get home tonight, you could simply try a wait 2s after the log in sub to let the backpack open fully before getting the bod.  That was the only other issue that I thought it could be besides a gump size change.  With .1 skill that should be the same size normal bod every time so I really doubt it is a gump size change.

It must be that the backpack is popping up or paperdoll as the log in process and taking over the bod collection gump.  We will get the timing improved but it is awful weird to see these timing issues.  I wonder if the last patch changed some of the timings to mess with folks.
Title: Re: C2's BOD Collector Script
Post by: Hoby on June 09, 2010, 12:04:45 AM
I tried it again, its definately got to be the timing.  It had the bod gump up already before the paperdoll and backpack were even opened.  im gonna mess with the timing some more and let you know. 
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 09, 2010, 05:19:47 AM
I tried it again, its definately got to be the timing.  It had the bod gump up already before the paperdoll and backpack were even opened.  im gonna mess with the timing some more and let you know. 
fin the log in sub.  at the bottom of the sub is post log in.  make sure to add a big wait prior to searching for the NPC or just wut wait 40-60 ish before it calls post log in stuff and you will be fine.
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 09, 2010, 06:26:33 AM
Hoby add it here at the bottom of sub login:

Code: [Select]
gosub charclick
set %safety_timer_wait #scnt + 7
    repeat
    if #contsize = 203_121
       {
       key enter
       goto mainloop
       }
    until #charname <> N/A || #scnt > %safety_timer_wait
wait 40                                                                           ;<--------try diff waits to match your system
gosub postlog
gosub boddrop
end:
gosub logout
return
Title: Re: C2's BOD Collector Script
Post by: Hoby on June 09, 2010, 10:01:57 AM
haha, thanks, disregard pm then.
Title: Re: C2's BOD Collector Script
Post by: Hoby on June 09, 2010, 10:10:42 AM
hey, should it be wait 40s or just wait 40
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 09, 2010, 10:18:25 AM
hey, should it be wait 40s or just wait 40

40 = 2 seconds or 2s in easy uo language.  40s/ 40 seconds is way too long.

your timing should be around 2-5 seconds for that change max... I would guess
Title: Re: C2's BOD Collector Script
Post by: Hoby on June 09, 2010, 10:42:18 AM
Thanks abunch c2, those waits worked.  Just ran through all seven chars and it got a bod for each one.  I put a wait 40 in those two areas.  As soon as the backpack opens it opens the bod gump and selects ok.  Will let it run through a few more cycles.  Thanks again.
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 09, 2010, 11:56:25 AM
Thanks abunch c2, those waits worked.  Just ran through all seven chars and it got a bod for each one.  I put a wait 40 in those two areas.  As soon as the backpack opens it opens the bod gump and selects ok.  Will let it run through a few more cycles.  Thanks again.

Excellent.  as soon as i can I will implement a better way to do it.  If the script was to wait for the backpack gump (the last to open 100% of the time at log in, that would be a better way that a plain wait.  then I will update the code again.  The old wait could be taken out in the other part of the script.  it is this second wait that is working.
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 09, 2010, 06:50:04 PM
updated with waits that helped Hoby.  Hoby if you find any glitches try this one otherwise enjoy what you did to fix it.
Title: Re: C2's BOD Collector Script
Post by: Hoby on June 09, 2010, 10:17:52 PM
thx c2 for the help!
Title: Re: C2's BOD Collector Script
Post by: asdman on June 23, 2010, 08:52:52 PM
Hmm, cant get it to work on a freeshard that has a name like "Shard - Something", tried everything :(
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 23, 2010, 09:47:57 PM
Hmm, cant get it to work on a freeshard that has a name like "Shard - Something", tried everything :(

log in subs don't support free shard.  they use last shard numbers and stuff that I am clueless about free shard #'s if they even exist
Title: Re: C2's BOD Collector Script
Post by: dubyabuddha on July 28, 2010, 01:53:10 PM
has anyone got this to work with a free server yet? specifically demise? been racking my brain for an hour trying to tweak this
Title: Re: C2's BOD Collector Script
Post by: Scrripty on July 28, 2010, 01:54:38 PM
I don't think anyone here plays free shards but you... :)  Most of us don't I'm sure.
Title: Re: C2's BOD Collector Script
Post by: Masscre on August 02, 2010, 10:28:29 AM
I am having the same issues as hoby was having c2. No complaints just letting you know about it.  I am going to play with the timing also as you stated to him. Everything works good but clicking on the bod to accept it is hit and miss. Some times it hits it and is collected and other times it is not hit and not collected.  With the same selected character I may or may not get a bod. Some I am sure I am on the verge of a timing issue and if my DSL holds its mouth corectly it may collect it :)

I will post back up anything that might have worked for me. For anyone later wanting to use this with similar problems.
Title: Re: C2's BOD Collector Script
Post by: Paulonius on August 02, 2010, 10:39:48 AM
I use the following three subs in the BOD Runner to get BODs on the exchange and it seems to work reliably. I will take a look at what C2 is doing and maybe I will be able to see something or at least learn something.

Code: [Select]
;==========================================================
Sub Get_A_New_BOD
Set %Vendor_Absent False
Set %Find_Vendor_Attempts 0
Set %BODTimerInEffect No
Begin_Get_BOD:
Exevent Popup %BODVendor
Wait 15
If #ContName <> normal_gump
   {
   Gosub WaitForGump %BlacksmithNPCGump
   If ! #Result
      {
      Set %Find_Vendor_Attempts %Find_Vendor_Attempts + 1
      If %Find_Vendor_Attempts = 4
         {
         Set %Vendor_Absent True
         Return #False
         }
      Wait 10
      Finditem %BODVendor G_8
      Set %MoveTimeout #SCnt + 3
      Repeat
         {
         Event Pathfind #findx #findy #findz 2
         Wait 10
         }
      Until #CharPosX = #FindX && #CharPosY = #FindY || %MoveTimeout <= #SCnt
      wait 45
      goto Begin_Get_BOD
      }
   }
Gosub OffsetClick 60 40
Wait 10
Gosub TM_AdvJournalScan EXCHANGE Advance You_can_get_an_order_now
If #Result = #True && #ContName = Generic_Gump
   {
   Gosub Vendor_BOD_Gump_Accept
   If #Result = #True
      {
      Set %BODSReceived %BODSReceived + 1
      Return #True
      }
   }
Gosub TM_AdvJournalScan EXCHANGE Advance An_offer_may_be_available
If #Result = #True
   {
   Set %BODTimerInEffect Yes
   Return #False
   }
Gosub Wait_For_New_BOD_Gump
Gosub Vendor_BOD_Gump_Accept
If #Result = #True
   {
   Set %BODSReceived  %BODSReceived + 1
   Return #True
   }
Gosub TM_AdvJournalScan EXCHANGE Advance the_bulk_order_deed_has_been_placed
If #Result = #True
   {
   Set %BODSReceived  %BODSReceived + 1
   Return #True
   }
Return #False


Code: [Select]
;==========================================================
Sub Vendor_BOD_Gump_Accept
if #contsize = 460_207
   {
   gosub offsetClick 110 180
   Return #True
   }
if #contsize = 460_231
   {
   gosub offsetClick 110 200
   Return #True
   }
if #contsize = 460_279
   {
   gosub offsetClick 110 250
   Return #True
   }
if #contsize = 460_303
   {
   gosub offsetClick 110 270
   Return #True
   }
if #contsize = 460_327
   {
   gosub offsetClick 110 300
   Return #True
   }
if #contsize = 460_351
   {
   gosub offsetClick 110 320
   Return #True
   }
if #contsize = 460_375
   {
   gosub offsetClick 110 350
   Return #True
   }
if #contsize = 460_399
   {
   gosub offsetClick 110 370
   Return #True
   }
Return #False

Code: [Select]
;==========================================================
Sub Wait_For_New_BOD_Gump
Set %VGumpWait #SCNT + 5
Repeat
  {
if #contname = generic_gump &&  ( #contsize = 460_207 )
+ || ( #contsize = 460_231 ) || ( #contsize = 460_279 )
+ || ( #contsize = 460_351 ) || ( #contsize = 460_375 )
+ || ( #contsize = 460_399 ) || ( #contsize = 460_303 )
+ || ( #contsize = 460_327 )
Return #True
Wait 5
}
Until %VGumpWait < #SCNT
Return #False
Title: Re: C2's BOD Collector Script
Post by: Ultima on August 02, 2010, 10:54:48 AM
I am having the same issues as hoby was having c2. No complaints just letting you know about it.  I am going to play with the timing also as you stated to him. Everything works good but clicking on the bod to accept it is hit and miss. Some times it hits it and is collected and other times it is not hit and not collected.  With the same selected character I may or may not get a bod. Some I am sure I am on the verge of a timing issue and if my DSL holds its mouth corectly it may collect it :)

I will post back up anything that might have worked for me. For anyone later wanting to use this with similar problems.

That makes 3 of us! ???

Certain shards I do better than others. I've adjusted tried adjusting the timing but still no dice. It's like you said hit and miss.

I know C2 mentioned once the backpack opens that becomes the gump. Some shards I'll go 6 for 6 and others I'll go 1 for 6.

Fortunately the shards I really need them on it's working for the most part. I was gonna cross shard trade with Hoby but have a hard time successfully retrieving on that shard. I'm lingering around 150 BOD's where I should easily have 500 on each character on that shard.
Title: Re: C2's BOD Collector Script
Post by: _C2_ on August 02, 2010, 12:05:30 PM
Well geeze guys lol.  they changed something with the timing for sure.  I will make sure that I put an updated version up with that change.  I may not of uploaded the timing fix.
Title: Re: C2's BOD Collector Script
Post by: NObama on August 22, 2010, 03:30:37 PM
Any updates?  I have finally depleted my BOD store and need to start pulling fresh ones to cycle.
Title: Re: C2's BOD Collector Script
Post by: _C2_ on August 22, 2010, 03:54:17 PM
i believe the posted 1.1b should handle the delayed gumps
Title: Re: C2's BOD Collector Script
Post by: NObama on August 22, 2010, 04:54:38 PM
Having an issue with the 'Ok' button on BOD offers in 1.1b.  At least 50% of the time, it misses the click.  I'm going to add a 'wait 15' to see if that helps...but I'm out of toons to test with for another 60 mins.

Also - it occurs to me that if might be more efficient to do the following, instead of waiting 60secs when you get 'an offer may be available'

- Check for BOD
- If "an offer may be available"
- Goto next toon
- If last toon, wait until master countdown timer says it's time for another cycle

Obviously, there is no pathfind or TM runebook travel built in...but that was easy to add.

Title: Re: C2's BOD Collector Script
Post by: _C2_ on August 22, 2010, 06:51:33 PM
let me know.  i was considering searching for backpack until it is open and then once it opens ... get bod gump.  the problem that i was seeing was that timing for opening packs had changed a lot.  the script was grabbing bod bump and then backpack was opening and then it would not click yes it would click a spot on your backpack.  i don't have time to set up a bod collecting acct and try it all nowadays but will certainly make edits as per suggestion and give credit for fixes.  i havent collected bods in over 3 years. let meknow what u find.  the wat 60 was intended to allow packs time to open up naturally before the script tries to get a bod only to be messed up by pack gumps opening up late.
Title: Re: C2's BOD Collector Script
Post by: NObama on August 22, 2010, 06:58:24 PM
let me know.  i was considering searching for backpack until it is open and then once it opens ... get bod gump.  the problem that i was seeing was that timing for opening packs had changed a lot.  the script was grabbing bod bump and then backpack was opening and then it would not click yes it would click a spot on your backpack.  i don't have time to set up a bod collecting acct and try it all nowadays but will certainly make edits as per suggestion and give credit for fixes.  i havent collected bods in over 3 years. let meknow what u find.  the wat 60 was intended to allow packs time to open up naturally before the script tries to get a bod only to be messed up by pack gumps opening up late.

My wait 15 seems to have solved *most* of the issue.  Even with an 18 ping, I still get the occasional late gump event and my BOD yes/no offer gets stuck behind my vet reward gump.

I'm thinking it might be best to auto close all the gumps on log in, then open the backpack, then proceed to find the blacksmith.  I'll play around with it after I see how many BODs I pull over the next day.  If I'm getting a decent amount, I'll leave good enough alone.

 
Title: Re: C2's BOD Collector Script
Post by: _C2_ on August 23, 2010, 05:41:08 AM
i remember i use to use a script by raziel that auto closes vet rewards.  i did not program a procedure for vet rewards.  one issue with tose is that they can come up instantly or 20 030 seconds affter being logged.  these late backpacks etc are weird server lag that never use to happen.  show me where you stuck that .  i assume u put it after event macro 8 7 in postlog sub
Title: Re: C2's BOD Collector Script
Post by: NObama on August 23, 2010, 06:40:32 PM
I ended up doing two things, the second of which was my bazooka to kill a fly but it works 100% now, so...

1 - Wait 15 after "gosub bod_gump 30 40 ; for menu pop up spot"
2 - Grabbed one of my few self-scripted snippets and stuck it in:

Code: [Select]
;--------------------------------------------------------------
Sub Gump_Setup

event macro 31 0
wait 15
event macro 8 7
wait 15
contpos 1500 500
wait 15
;click 16 16
;wait 15
return

The commented lines were removed because, once I started closing all the gumps, I no longer felt the need to minimize the toolbar.  Not always the case...

Works beautifully now.  Collected 80-ish BODs before EUO dumped on me while I was at work.
Title: Re: C2's BOD Collector Script
Post by: NObama on August 24, 2010, 04:40:25 PM
Update:  Works flawlessly now.  Collected 23 out of 23 attempts on 8 or 9 chars in the last day.  I'm set for this weekend.
Title: Re: C2's BOD Collector Script
Post by: Paulonius on August 26, 2010, 05:05:41 AM
I am still using a modified version of Raziel's collector that I have hacked to shreds.  I am just too lazy to switch format.

There is definitely a new and sort of weird lag on log in.  I see a lot of failures if the script doesn't wait long enough even after the backpack is open because it doesn't find anything in the backpack and can't locate the book.  It seems like item properties take a bit to load.
Title: Re: C2's BOD Collector Script
Post by: Masscre on August 26, 2010, 05:25:53 AM
Its either part of the new operating system they installed a few months ago or new part of the anti scripting code or could even be .... yep you guessed it EA fubared again !!
Title: Re: C2's BOD Collector Script
Post by: Paulonius on August 26, 2010, 10:07:20 AM
I would guess that it was their hardware transfer and the upgraded systems involved.  I doubt that they did it on purpose and it started around the same time.
Title: Re: C2's BOD Collector Script
Post by: Masscre on August 26, 2010, 02:37:07 PM
I would guess that it was their hardware transfer and the upgraded systems involved.  I doubt that they did it on purpose and it started around the same time.

That was my original thought process.  I was just making a bad joke with the rest :)
Title: Re: C2's BOD Collector Script
Post by: _C2_ on August 26, 2010, 03:15:30 PM
posted update that hopefully works well.  used nobama's close all gumps and adjusted postlog waits to respond to varying gump openings.  thx for all input to help as i dont run this anymore and need all of you users to guide me.  hope it works well now
Title: Re: C2's BOD Collector Script
Post by: NObama on August 26, 2010, 04:41:36 PM
posted update that hopefully works well.  used nobama's close all gumps and adjusted postlog waits to respond to varying gump openings.  thx for all input to help as i dont run this anymore and need all of you users to guide me.  hope it works well now

Gosh - I just realized I was really non-specific about where I called that Gump_Setup.  I put it here, inside sub find_vendor:

Code: [Select]
sub find_vendor  ;%1 tailor or smith
ignoreitem #charid
event pathfind 979 514
wait 60
gosub Gump_Setup  <----------------------------****

Yes, it's sloppy.  It also works.

=P
Title: Re: C2's BOD Collector Script
Post by: _C2_ on August 26, 2010, 05:10:25 PM
i figured out that you were closing all gumps beofore you opened the bod guys gump...
i think my new version should work.  smart to close all as last minute as possible tehn go for the bod.  leaves very littel room for a gump to pop up.  ;D
Title: Re: C2's BOD Collector Script
Post by: NObama on August 26, 2010, 05:24:09 PM
i figured out that you were closing all gumps beofore you opened the bod guys gump...
i think my new version should work.  smart to close all as last minute as possible tehn go for the bod.  leaves very littel room for a gump to pop up.  ;D

Amazing.  C2 was able to reverse engineer my coding.  That's like Einstein figuring out how to take apart duplo legos.

(Get it?  C2 is Einstein.  NObama codes like a toddler.)

 8)
Title: Re: C2's BOD Collector Script
Post by: _C2_ on August 26, 2010, 08:40:51 PM
LOL - i sure do appreciate you tinkering with it. 
Title: Re: C2's BOD Collector Script
Post by: Ultima on August 27, 2010, 10:26:38 AM
A month ago Nobama was crying about how he was in crisis as he had no storage space for all his BOD's... now he's back to collecting.

You see why I hinted at cross shard exchange of SBOD's?

It would save quit a bit of time...no reason if your running this script not to be collecting on other shards where you can help your friends. ;)

I really hate dedicating an account to collecting SBOD's. I would much rather be doing something else...

I'm not currently running this script but I hope it works for Multi-Shard collecting as that's where I was having issues. It would work fine on 2 or 3 shards then on the 4th shard it would go 0-7.

I'm gonna burn through my current stock of SBOD's and transfer some over from other shards I've collected. I try and solicit from people selling as often as possible as well.

When I do start back up I'll give a shout out and see if the idea of exchanging BOD's like is done with Holiday Gifts sounds good to anyone. Hopefully it works flawlessly when doing 4-5 shards...I'll be sure to post my results when I start running it again.
Title: Re: C2's BOD Collector Script
Post by: NObama on August 27, 2010, 09:32:04 PM
A month ago Nobama was crying about how he was in crisis as he had no storage space for all his BOD's... now he's back to collecting.

You see why I hinted at cross shard exchange of SBOD's?

It would save quit a bit of time...no reason if your running this script not to be collecting on other shards where you can help your friends. ;)

I really hate dedicating an account to collecting SBOD's. I would much rather be doing something else...

I'm not currently running this script but I hope it works for Multi-Shard collecting as that's where I was having issues. It would work fine on 2 or 3 shards then on the 4th shard it would go 0-7.

I'm gonna burn through my current stock of SBOD's and transfer some over from other shards I've collected. I try and solicit from people selling as often as possible as well.

When I do start back up I'll give a shout out and see if the idea of exchanging BOD's like is done with Holiday Gifts sounds good to anyone. Hopefully it works flawlessly when doing 4-5 shards...I'll be sure to post my results when I start running it again.

Works flawlessly across shards.  Give me a holler and I'll get you 500 or so on the shard of your choice...for a future favor, of course =P
Title: Re: C2's BOD Collector Script
Post by: dubyabuddha on September 06, 2010, 09:26:42 PM
i tweaked it for my free shard, took a while to figure it out though works perfectly
Title: Re: C2's BOD Collector Script
Post by: maximus on November 09, 2010, 11:49:29 AM
one of the best scripts I have ever seen.... works great !!!!!!!!!!!!


sometime it hangs up when I have 50+ skills on a char and there is one hour to wait... but once it runs it is AWSOME !!!!!!!
--> am running it with 19 chars on a shard with 3 accounts and it makes my life so damn easy

Genius !!

Title: Re: C2's BOD Collector Script
Post by: _C2_ on November 09, 2010, 05:08:39 PM
one of the best scripts I have ever seen.... works great !!!!!!!!!!!!


sometime it hangs up when I have 50+ skills on a char and there is one hour to wait... but once it runs it is AWSOME !!!!!!!
--> am running it with 19 chars on a shard with 3 accounts and it makes my life so damn easy

Genius !!



thx, for the kind words... if you see that there is aparticular type of bod order that is botching it let me know.  we may be able to fix that little hickup
Title: Re: C2's BOD Collector Script
Post by: Paradise on January 01, 2011, 12:35:11 PM
Hi C2.. I love this script!  Thank you so much for it.  I am having a problem getting it to put the BODs in the books.  I have labeled the books tailor and smith, but it never puts them in the books.  Am I missing something or doing something wrong?

Thanks again!
-Para
Title: Re: C2's BOD Collector Script
Post by: Masscre on January 01, 2011, 06:01:07 PM
The BOD book placer part of the script has been disabled or broken since the last update.
Title: Re: C2's BOD Collector Script
Post by: _C2_ on January 01, 2011, 06:23:12 PM
first i have heard of this and since i havent collected bods in about 3 years i depend on hel to debug.  the sub to drop the bods should be working and was not removed or turned off.   I am looking through the code and see no reason for it to be not dropping unless the bag is getting closed before it goes to log out.  can someone watch to see if after it collects or while it collects thta the backpack is still open.  i have  afeeling that might be it fromn the gump fixes that were made.  the sub is playing but maybe there is nothing to find because the backpack is closed.  I'll add an extra pack opening at the end during the bod drop to se eif that fixes it.. but please watch thta section to give details.  1.2b will have an extra pack open
Title: Re: C2's BOD Collector Script
Post by: Paradise on January 02, 2011, 12:41:47 PM
Thank you for looking into this C2.  I was watching the script, and you are right, the script opens the backpack, then closes it, then gets the bods from the NPCs, then logs out.

I'll check out 1.2b and let you know how it goes =)
Title: Re: C2's BOD Collector Script
Post by: Paradise on January 02, 2011, 12:53:32 PM
You're a genius  ;D It seems to be working now! Thanks!  Please let me know if there is anything I can ever help you with!
Title: Re: C2's BOD Collector Script
Post by: _C2_ on January 02, 2011, 05:05:14 PM
You're a genius  ;D It seems to be working now! Thanks!  Please let me know if there is anything I can ever help you with!

outstanding... another case of the classic fix something break something syndrome
Title: Re: C2's BOD Collector Script
Post by: Newsman on January 08, 2011, 07:38:04 AM
Do people still collect bods in this fashion?  I was under the impression that the system had changed to allow you to receive a bod every time you turn in a bod.  In other words, once you have tons of junk bods, you can turn them in for good bods.

Is this for getting that initial stash of bods and just "re-upping" when necessary?
Title: Re: C2's BOD Collector Script
Post by: _C2_ on January 08, 2011, 05:14:15 PM
Do people still collect bods in this fashion?  I was under the impression that the system had changed to allow you to receive a bod every time you turn in a bod.  In other words, once you have tons of junk bods, you can turn them in for good bods.

Is this for getting that initial stash of bods and just "re-upping" when necessary?

it is for an initial stash or for folks that only fill iron and once they turn in each time their iron get lower and lower.  all personal preference.  I dont do this anymore at all.
Title: Re: C2's BOD Collector Script
Post by: Newsman on January 16, 2011, 09:26:34 PM
c2  Do, you recall a script from winuo that removed bods from 1 bod book. filled the bod. then filled another book? I vaguely recall the script being written by you but I really only recall the letter C lol.
Title: Re: C2's BOD Collector Script
Post by: MeWonUo on January 16, 2011, 10:23:07 PM
c2  Do, you recall a script from winuo that removed bods from 1 bod book. filled the bod. then filled another book? I vaguely recall the script being written by you but I really only recall the letter C lol.

There is one on this site here in the 'submit your script' section.  Paulonius wrote a great little tool that works hand in hand with s7's bod filler. 
Title: Re: C2's BOD Collector Script
Post by: _C2_ on January 17, 2011, 07:37:48 AM
c2  Do, you recall a script from winuo that removed bods from 1 bod book. filled the bod. then filled another book? I vaguely recall the script being written by you but I really only recall the letter C lol.
yes, it dropped five  bods and called snickers, put five away and redropped five and called snickers....

it was from a current elite member here.  i dont have it but paulonius' version should be solid and do the job
Title: Re: C2's BOD Collector Script
Post by: Newsman on January 17, 2011, 10:17:08 AM
Ah Thanks Gentlemen.
Title: Re: C2's BOD Collector Script
Post by: waggler on January 31, 2011, 09:45:28 AM
is there anything i can do to adjust  wait times?  the script worked great for me  for a few days  then bugged out constantly  wouldnt even do 1 account cycle..  hangs up logging out. mostly.  does not seem to click the log out.
Title: Re: C2's BOD Collector Script
Post by: Peppar on February 20, 2011, 09:39:27 AM
Thanks for a great script :) Works 110% on freeshards also.

To use it on freeshards just add this (Will use Demise here).

For the server you add :

set %S1 Demise

Then you need to find this code :

sub setshard
if %shardname = Atlantic


and change it with :

sub setshard
if %shardname = Demise


And now it works, cant be much easyer ;)

Title: Re: C2's BOD Collector Script
Post by: Ultima on March 02, 2011, 10:49:57 AM
Looks like this is operating at 100% since the last time I used it. Whatever changes you made C2 this looks to be working nicely. Clears all the gumps before attempting to collect the BODs which I think what was causing some players to miss certain BODs here and there.

I will be running this quite a bit over the next month on multiple accounts on multiple shards.

Now that it's functioning at 100% Xshard Exchange looks to be doable.

If anyone is interested in Exchanging BODs depending on your shard PM me and we can see if we can work something out for a cross shard exchange.

Title: Re: C2's BOD Collector Script
Post by: _C2_ on March 02, 2011, 12:46:48 PM
Looks like this is operating at 100% since the last time I used it. Whatever changes you made C2 this looks to be working nicely. Clears all the gumps before attempting to collect the BODs which I think what was causing some players to miss certain BODs here and there.

I will be running this quite a bit over the next month on multiple accounts on multiple shards.

Now that it's functioning at 100% Xshard Exchange looks to be doable.

If anyone is interested in Exchanging BODs depending on your shard PM me and we can see if we can work something out for a cross shard exchange.



Thank Nobama for providing the feedback and script behaviors to make a fix without using the script.
Title: Re: C2's BOD Collector Script
Post by: NObama on March 02, 2011, 04:44:15 PM
Wait - what did I do?  Am I in trouble again?

 :P

Ultima - Q me and remind me and I'll dedicate a day or two of three accounts to collect for you.  I think I owe you the next favor in our on-going exchange.
Title: Re: C2's BOD Collector Script
Post by: alonzo104 on March 24, 2011, 02:44:06 PM
Hello C2 this script is amazing, as most of yours are.  However, occasionally I'm running into an issue I cannot seem to pinpoint.  I'm using this script on the EA servers, and 90% of the time it runs fine.  However sometimes the script seems to get stuck when clicking the logout button.  The cancel or ok box appears to log you out, but it doesn't click on the "ok / accept" button to log the character out.  So the script essentially pauses w/ the logout gump open and doesn't move.  I've tried assisting the script by clicking the OK - causes the char to log out - but it then just sits on the login screen.  So I tried the other way, clicking cancel to see if it would catch itself up, it doesn't appear to work that way either, character just sits idle.  I've tried adjusting the wait times to see if that was an issue, but that didn't fix it either. 

I'm using W7, and when UO runs I have it run in basic mode, turn off all of windows extra fancyness which I know can sometimes cause the client to lockup and cause the script to miss its command.

If there is any other information I can supply you with please let me know.  Thanks again for the great script, but I'd like to help make it PERFECT!! heh
Title: Re: C2's BOD Collector Script
Post by: _C2_ on March 24, 2011, 03:59:03 PM
Hello C2 this script is amazing, as most of yours are.  However, occasionally I'm running into an issue I cannot seem to pinpoint.  I'm using this script on the EA servers, and 90% of the time it runs fine.  However sometimes the script seems to get stuck when clicking the logout button.  The cancel or ok box appears to log you out, but it doesn't click on the "ok / accept" button to log the character out.  So the script essentially pauses w/ the logout gump open and doesn't move.  I've tried assisting the script by clicking the OK - causes the char to log out - but it then just sits on the login screen.  So I tried the other way, clicking cancel to see if it would catch itself up, it doesn't appear to work that way either, character just sits idle.  I've tried adjusting the wait times to see if that was an issue, but that didn't fix it either. 

I'm using W7, and when UO runs I have it run in basic mode, turn off all of windows extra fancyness which I know can sometimes cause the client to lockup and cause the script to miss its command.

If there is any other information I can supply you with please let me know.  Thanks again for the great script, but I'd like to help make it PERFECT!! heh

hehe, well i haven't used this script in about three years.  I appreciate your feedback that includes where the issue happens.  i tried to put an extra check in for the yes/no gump clearing.  let me know if it works.  this should handle a miss due to lag or whatever might be hitting it.  it will look for up to 15 more seconds if needed in case it misses.  try version c
Title: Re: C2's BOD Collector Script
Post by: alonzo104 on March 26, 2011, 09:09:39 AM
Hello C2 this script is amazing, as most of yours are.  However, occasionally I'm running into an issue I cannot seem to pinpoint.  I'm using this script on the EA servers, and 90% of the time it runs fine.  However sometimes the script seems to get stuck when clicking the logout button.  The cancel or ok box appears to log you out, but it doesn't click on the "ok / accept" button to log the character out.  So the script essentially pauses w/ the logout gump open and doesn't move.  I've tried assisting the script by clicking the OK - causes the char to log out - but it then just sits on the login screen.  So I tried the other way, clicking cancel to see if it would catch itself up, it doesn't appear to work that way either, character just sits idle.  I've tried adjusting the wait times to see if that was an issue, but that didn't fix it either. 

I'm using W7, and when UO runs I have it run in basic mode, turn off all of windows extra fancyness which I know can sometimes cause the client to lockup and cause the script to miss its command.

If there is any other information I can supply you with please let me know.  Thanks again for the great script, but I'd like to help make it PERFECT!! heh

hehe, well i haven't used this script in about three years.  I appreciate your feedback that includes where the issue happens.  i tried to put an extra check in for the yes/no gump clearing.  let me know if it works.  this should handle a miss due to lag or whatever might be hitting it.  it will look for up to 15 more seconds if needed in case it misses.  try version c

Thanks for the quick response.  I will set this up later this evening and see if it corrects the issues.  I will report back here soon.  Thanks C2!
Title: Re: C2's BOD Collector Script
Post by: brute89 on April 04, 2011, 09:47:15 PM
Great script C2, I've been using it for a couple of days and I love it. It's so much faster than the recall gatherers and much more reliable. However, I've been having two issues that seem to keep popping up. One in eight sets of runs seem to get the issue of not logging out and character will just sit there trying to get his bods again for one hour. The second issue is that every so often the eighth of ninth character will get stuck at connecting and it will never display the you cannot connect window. When this happens I have to restart UO and the script, I'm thinking it may be an issue of logging to quickly on so many characters. I'm running fourteen characters per run, it may be something my OSI clone server set up. Thank you very much for your script, I'm really enjoying it.
Title: Re: C2's BOD Collector Script
Post by: Paulonius on April 08, 2011, 07:05:20 AM
I am getting a hang at log out.  I am trying to isolate what is happening, but I believe it is trying to log out.  The yes/no gump is up and the script is in a wait looking for the username/password page.  I suspect that it is something opening after the Yes/No gump, but before the script clicks log out, but I am not sure. 

Odd thing is that it consistently stops on the same toon until I move gumps.  I suspect that it is a late opening gump from the desktop and that adding a gump position to the re-open routine might fix it if a wait doesn't, but I am not sure yet. 

I am throwing a wait 40 at the beginning of the logout sub to see if it will solve the problem. 
Title: Re: C2's BOD Collector Script
Post by: _C2_ on April 08, 2011, 10:13:30 AM
I am getting a hang at log out.  I am trying to isolate what is happening, but I believe it is trying to log out.  The yes/no gump is up and the script is in a wait looking for the username/password page.  I suspect that it is something opening after the Yes/No gump, but before the script clicks log out, but I am not sure. 

Odd thing is that it consistently stops on the same toon until I move gumps.  I suspect that it is a late opening gump from the desktop and that adding a gump position to the re-open routine might fix it if a wait doesn't, but I am not sure yet. 

I am throwing a wait 40 at the beginning of the logout sub to see if it will solve the problem. 

Did they change the gump recently?  That log out sub has worked for ever.  We are talking years without a problem.  I am going to need help figuring this one out because i no longer use this script and that makes three people all of the sudden having issues.
Title: Re: C2's BOD Collector Script
Post by: Paulonius on April 08, 2011, 02:07:00 PM
I don't think its a gump change because it works for lots of toons, then starts hanging on one.  I am watching it to see what is happening, but I suspect its something popping after the logout gump is called and before it gets clicked.  I have not seen it since I put a 2 second wait at the front end of the logout sub, but I will report back.
Title: Re: C2's BOD Collector Script
Post by: NObama on April 09, 2011, 01:20:27 AM
I put in a command to close all gumps just before logging out, so I don't get the random gump pop ups at the wrong time.  I also added a 2 second delay.

Title: Re: C2's BOD Collector Script
Post by: Paulonius on April 09, 2011, 02:02:09 PM
the two second delay on the log out sub seems to be fixing the problem for me.

I will run it some more and report back.
Title: Re: C2's BOD Collector Script
Post by: _C2_ on April 09, 2011, 04:26:44 PM
interesting.  i didnt think any gumps can pop up and cover the yes no gump.  let me know where to stick that wait
Title: Re: C2's BOD Collector Script
Post by: Paulonius on April 09, 2011, 07:04:47 PM
The only think I can think of would be a long delayed vet rewards gump, or perhaps a BOD name gump if the cursor is over the game gump.  Since I dropped the two second delay in it has been running without a problem for a day and a half, wich is significantly longer than I was able to run before.  I am going to start adding in a bunch of additional shard toons to do a cross with Ultima and I will report back after my stress test.

As an aside, I am thinking that the script loses time by resetting the clock on the cycle at the last toon.  I wonder if you tested it resetting the clock on the cycle by the first toon instead.  I may make that change and see how it runs, unless you let me know that its a bad idea for some reason....
Title: Re: C2's BOD Collector Script
Post by: _C2_ on April 09, 2011, 07:33:10 PM
As an aside, I am thinking that the script loses time by resetting the clock on the cycle at the last toon.  I wonder if you tested it resetting the clock on the cycle by the first toon instead.  I may make that change and see how it runs, unless you let me know that its a bad idea for some reason....

I moved that line all over when i use to collect bods.  After teh first guy seemed to leave a lot of characters standing around waiting at time but i never use it after the very last guy.  it is just in there last as to not confuse nonwriters.
Title: Re: C2's BOD Collector Script
Post by: gimlet on May 30, 2011, 05:35:30 AM
C2 - Just wondering a few things about this script.
I assume it will work on siege?
Can i stand downstairs in luna or do i need to be in the exact spot on your picture?
I want to remain logged in on one character (pick up tail and smith BODs every hour)
how do i set it that way?

Thanks for any input!
Title: Re: C2's BOD Collector Script
Post by: NObama on May 30, 2011, 08:04:17 AM
Well...SOMEone is all about Seige lately!

Come back to the light!
Title: Re: C2's BOD Collector Script
Post by: _C2_ on May 30, 2011, 09:03:13 AM

C2 - Just wondering a few things about this script.
I assume it will work on siege.  Bod guys have the same gumps etc... don't they?
  I have never played siege but assume it would.  Luna is the same design.
Can i stand downstairs in luna or do i need to be in the exact spot on your picture? 
  by design, no.  you cannot instant log downstairs but it looks like that is not your intent below.You can actually find better locations if you do not need to insta log for the next guy as on siege.  Just let him/her time out.
 
I want to remain logged in on one character (pick up tail and smith BODs every hour)
You could if you did alterations... meaning taking out the log out section and adding a backpack opening timer to keep you logged in.
how do i set it that way?
That really will just take ; off subs you no longer need.  I imagine it is a very easy process with the main focus being on removing the logout subs and adjusting the wait for next bod sub/timer.  You may need something to keep you from timing out in between bods if you want to stay logged in.

Title: Re: C2's BOD Collector Script
Post by: gimlet on May 30, 2011, 09:06:50 AM
Thanks ill give it a shot!
Title: Re: C2's BOD Collector Script
Post by: gimlet on May 30, 2011, 09:09:24 AM
Just thought id ask if i should start the script being able to collect or start uncollected?
Title: Re: C2's BOD Collector Script
Post by: NObama on May 30, 2011, 09:31:16 AM
Just thought id ask if i should start the script being able to collect or start uncollected?


Either way.  It waits if you can't get a BOD yet.
Title: Re: C2's BOD Collector Script
Post by: gimlet on May 30, 2011, 10:10:11 AM
K thanks - if i dont time out in an hour does it print out my account and pw to the screen?
Title: Re: C2's BOD Collector Script
Post by: gimlet on May 30, 2011, 10:20:34 AM
never mind - i watched with another guy! worked great!
Title: Re: C2's BOD Collector Script
Post by: _C2_ on May 30, 2011, 10:21:03 AM
K thanks - if i dont time out in an hour does it print out my account and pw to the screen?


that would not happen if you are commenting out the log out and back in subs.  
Title: Re: C2's BOD Collector Script
Post by: Maprala on July 04, 2011, 07:45:42 PM
Thank you!!! Great Script!!!
Title: Re: C2's BOD Collector Script
Post by: Ultima on September 07, 2011, 08:46:22 PM
C2 I think something has changed since the EUO update.

I was collecting BODs yesterday on multiple accounts but since patching now I'm not unable to collect BODs. Doesn't seem to be able to find the blacksmith.

Script opens backpacks and paperdolls then logs.

Title: Re: C2's BOD Collector Script
Post by: _C2_ on September 08, 2011, 04:01:41 PM
C2 I think something has changed since the EUO update.

I was collecting BODs yesterday on multiple accounts but since patching now I'm not unable to collect BODs. Doesn't seem to be able to find the blacksmith.

Script opens backpacks and paperdolls then logs.



 my question is did they change the names or are they moved to a further location and now out of range?
Title: Re: C2's BOD Collector Script
Post by: MeWonUo on September 08, 2011, 04:04:29 PM
They just changed the #findrep from 7 to 255. 
Title: Re: C2's BOD Collector Script
Post by: Goliath on September 11, 2011, 06:07:40 AM
Great script!  I ran this last night when I went to bed using 3 account and 4 characters.  Each had 7 bods when I got up this morning.  Love it!!  I was hoping that I would be able to incorporate my 120 smith into the mix, but when the script logged him in and it said he wasn't able to get another bod for 206 minutes it would stop.  After taking him out of the rotation it worked perfectly.
Title: Re: C2's BOD Collector Script
Post by: _C2_ on September 11, 2011, 12:27:38 PM
Yeah, at 120 it is quite a different timer.  I could certainly add individual times but that is too much work and will confuse a lot of folks.
Title: Re: C2's BOD Collector Script
Post by: _C2_ on September 11, 2011, 01:48:15 PM
Just wanted to tell you guys that #findrep is back to 7 in version 202... Apparently that was an issue in 200/201...

cheers

neo
Sweet because in had not changed it yet.  Now I will take that off today's must do list
Title: Re: C2's BOD Collector Script
Post by: gimlet on September 18, 2011, 05:19:18 PM
If this has been already suggested - sorry.

I was currently logging in 8 toons for BODS (each login takes less than a min - about 45 secs) I am thing about changing the wait time to 60 mins - (45 secs/60)(#of characters)

Should save about 5 or 6 mins per cycle (i would get an exact number and add in a small safety margin).

What do you guys think?
Title: Re: C2's BOD Collector Script
Post by: Newsman on September 19, 2011, 02:56:00 AM
If this has been already suggested - sorry.

I was currently logging in 8 toons for BODS (each login takes less than a min - about 45 secs) I am thing about changing the wait time to 60 mins - (45 secs/60)(#of characters)

Should save about 5 or 6 mins per cycle (i would get an exact number and add in a small safety margin).

What do you guys think?

How many additional bods per character do you estimate that will earn you each day?
Title: Re: C2's BOD Collector Script
Post by: gimlet on September 19, 2011, 05:53:29 AM
at only 5 mins - in 12 hours you can do 13 instead of 12

Title: Re: C2's BOD Collector Script
Post by: Paulonius on November 04, 2011, 02:25:03 PM
C2,

When you are running this script with 20-30 toons accross multiple accounts you lose a lot of time by waiting to reset the timer until you cycle through all of your toons. My current setup cycles 36 toons and takes about 40 minutes. 

I looked at the code and noticed that you have the "gosub time_set_4next line after all of the gosub's for each toon.  I am going to experiment with moving that up until after the 2nd toon gosub and will report back what happens.  Unless something screws up, I expect it to increase the number of BODs I get in a day. 
Title: Re: C2's BOD Collector Script
Post by: _C2_ on November 04, 2011, 02:26:56 PM
C2,

When you are running this script with 20-30 toons accross multiple accounts you lose a lot of time by waiting to reset the timer until you cycle through all of your toons. My current setup cycles 36 toons and takes about 40 minutes.  

I looked at the code and noticed that you have the "gosub time_set_4next line after all of the gosub's for each toon.  I am going to experiment with moving that up until after the 2nd toon gosub and will report back what happens.  Unless something screws up, I expect it to increase the number of BODs I get in a day.  

i use to run it after the second or third guy to do just what yo are talking about.  for teh masses though, it was easier to leave as is to prevent mass confusion.
Title: Re: C2's BOD Collector Script
Post by: Paulonius on November 04, 2011, 02:36:48 PM
Cool, then I am probably reading it right.  I am watching it run and I timed some of the toons.  When its not lagging it bangs through them in about 30 seconds.  Its actually going a lot faster than I thought, but I ought to pick up an extra run in every three or four this way. 

I have run it for multiple shards and many toons and it really runs great. 
Title: Re: C2's BOD Collector Script
Post by: Paulonius on November 04, 2011, 02:55:55 PM
It took 22 minutes to cycle through all of my guys just getting smith deeds.  When the menue reset the "Next run in" timer on the menue rest to 60 minutes, but the Next Run Time deducted 21 minutes and rest for 40 minutes from the end of the run. I won't be able to wait around to see which is triggering the run.  I am guessing its running of the right timer. I will try to watch tomorrow, or I will look over the code to confirm when I have time.
Title: Re: C2's BOD Collector Script
Post by: _C2_ on January 30, 2012, 08:59:41 PM
oh that sux!  with these changes, it looks like i need to make some timer adjustments soon.
Title: Re: C2's BOD Collector Script
Post by: The Ghost on February 10, 2012, 08:49:57 PM
It 6 hours to get news BOD, so if you use ur 6hr times and only get 3 BOD that should work.   I just return from Holiday and reading about all the change. 
Title: Re: C2's BOD Collector Script
Post by: _C2_ on February 11, 2012, 05:45:53 AM
Yeah, I won't be able to fuss with this anytime soon.  I'll be out of town for a bit but I am wondering:
Do you ust the content menu once and all three bods fall in you pack or do you have to click collect three times if you wait the 18 hours to get thm all in one shot?

Does someone want to post the ne timers and how receiving the bods may differ
Title: Re: C2's BOD Collector Script
Post by: D on February 11, 2012, 06:26:47 AM
You get a new bod Every 6 hours to a max of 3 bods in 18 hours, after 18 hours you need to ask and select to receive the 3 separate new bods one at a time.

Lol its made me put 0.1 blacksmith on all my characters lol.
Title: Re: C2's BOD Collector Script
Post by: NObama on February 12, 2012, 06:17:34 AM
It's not any different at all.  At most, you'd want a new feature (checkbox?) when the script starts to indicate yes/no whether it has been 18 hours since your last collection attempt.  If yes, then the script collects BODs three times instead of once.

Alternatively, if your script users only intend to run it every 18 hours themselves, they can just search for the line:

gosub collectsmith

and add two duplicate lines below it.  I just tested it myself and it works fine.  

 ;)

EDIT:  What we really need is a Bribery script to scan a whole book of BODs and bribe NPCs to upgrade the ones that we want.  Hmm....idea brewing...
Title: Re: C2's BOD Collector Script
Post by: slyone on February 19, 2012, 01:55:02 PM
I just used this for 15 shards worth of characters.  It worked great.  Took about an hour. Thank you so much!!


Alternatively, if your script users only intend to run it every 18 hours themselves, they can just search for the line:

gosub collectsmith

and add two duplicate lines below it.  I just tested it myself and it works fine. 

Thanks NObama for the edit!!  That works great too.

EDIT:  What we really need is a Bribery script to scan a whole book of BODs and bribe NPCs to upgrade the ones that we want.  Hmm....idea brewing...

I see your idea brewing.  The Bulk Order Bribery script I posted is pretty manual in nature, I like your idea of a more intelligent bribery script.
Title: Re: C2's BOD Collector Script
Post by: Mythix on June 03, 2012, 02:20:43 PM
I can not get a specific bulk.

It is a large chain HQ, does not seem to have been recognized by Gump
After, maybe, I think so too or not (6 parts) of large leather NQ.


I had this problem, too.  I found a typo in the code that will probably fix it. 
Code: [Select]
ggosub bod_gump 110 300  ; <---------------change this to gosub (remove the extra "g")

I haven't gotten another chain LBOD to see if it fixes the problem, but I am willing to bet that this is the case.

Awesome script C2!  I just dl and tried it out, and it's great.  Many thanks. ;D
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 06, 2012, 05:48:25 PM
I can not get a specific bulk.

It is a large chain HQ, does not seem to have been recognized by Gump
After, maybe, I think so too or not (6 parts) of large leather NQ.


I had this problem, too.  I found a typo in the code that will probably fix it. 
Code: [Select]
ggosub bod_gump 110 300  ; <---------------change this to gosub (remove the extra "g")

I haven't gotten another chain LBOD to see if it fixes the problem, but I am willing to bet that this is the case.

Awesome script C2!  I just dl and tried it out, and it's great.  Many thanks. ;D


fixing now!  thx for feedback.  it is amazing that went so long as a typo.  it goes to show the trend of only getting .1 skill on characters and just mass filling iron under the old system.  i will have 1.2d up soon
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 06, 2012, 06:43:23 PM
okay made some updates...

got rid of the typo for a particular large bod that said ggosub so it would miss one particular bod size

got rid of one and two hour options

added an 18 hour option

added the multiple collection if you do select 18 hours

added a gump to get rid of the rewards gump

gave script uo props for being the host on the menu.  man this script was old!

removed the clock for next collection time until i have time to tweak it for the massive 18 hour timer adjustment.  the minutes until the next collection timer is still there!

thx everyone for the feedback and patience!!!  i haven't been playing these days.
Title: Re: C2's BOD Collector Script
Post by: Mythix on June 16, 2012, 08:26:11 PM
I would like to respectfully request that you keep the old version up, for us freesharders.  (Except without the typo hehe  ;D )
Thank you for considering.
I'm sure there are folks out there that would appreciate it!

Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 17, 2012, 08:40:16 AM
I would like to respectfully request that you keep the old version up, for us freesharders.  (Except without the typo hehe  ;D )
Thank you for considering.
I'm sure there are folks out there that would appreciate it!



i didnt take it down but let me fix that typo and repost it as freeshard version

Request completed!
Title: Re: C2's BOD Collector Script
Post by: The Ghost on June 17, 2012, 07:44:32 PM
Thx for the Update, 
Title: Re: C2's BOD Collector Script
Post by: Mythix on June 17, 2012, 09:29:55 PM

i didnt take it down but let me fix that typo and repost it as freeshard version

Request completed!


Thanks!!!
I really gotta say how awesome this script is again lol. I've really learned a lot about scripting by picking it apart and adding/removing things.  It's been a lot of fun to mess around with. 
I've now got a fully functional bodgatherer (gathers smith, tailor, and taming) and when bpcount > 50 items, it recalls home(using TMs recall subs), and grabs my bag of bod books and puts them in a book for me to sort later.  I've got so many bods now, I don't know what to do with them all!    :o

 
Title: Re: C2's BOD Collector Script
Post by: Crank13 on November 28, 2012, 11:36:53 AM
playing with this script i seem to continue to have the same problem over and over of crashing, im using 7.0.20 client version on freeshard.
i have uninstalled and reinstalled uo.

I have not augmented the script aside from the login info as instructed.

im unsure where to begin with troubleshooting to find a fix for this, anyone have ideas?
Title: Re: C2's BOD Collector Script
Post by: Endless Night on November 28, 2012, 12:03:04 PM
playing with this script i seem to continue to have the same problem over and over of crashing, im using 7.0.20 client version on freeshard.
i have uninstalled and reinstalled uo.

I have not augmented the script aside from the login info as instructed.

im unsure where to begin with troubleshooting to find a fix for this, anyone have ideas?

Crashing is generally from Drag Drop going to Fast .. add a wait 15  exeevent drag wait 15 exevent drop wait 15... if that solves your problem then you know it was that and can shorten the waits until it is stable and fast.

Title: Re: C2's BOD Collector Script
Post by: Uoaddict on March 05, 2013, 12:49:34 AM
Hi c2, i playing in freeshard with ML and client 7.0.29.2, macros not detected it!:( why?... no login nothing :S
Title: Re: C2's BOD Collector Script
Post by: _C2_ on March 05, 2013, 09:11:56 AM
Hi c2, i playing in freeshard with ML and client 7.0.29.2, macros not detected it!:( why?... no login nothing :S

It doesn't search for freeshard names.  I only has OSI names to set #lshard and search for the shard to login.  So if you put your freesharders on the setup line it will not recognize it in the subs themselves
Title: Re: C2's BOD Collector Script
Post by: accacc on October 06, 2013, 10:36:21 PM
How can I get this script?
Title: Re: C2's BOD Collector Script
Post by: dxrom on October 07, 2013, 01:50:22 AM
How can I get this script?

http://www.scriptuo.com/index.php?board=20.0

Nice name... It happen to mean "Account Account" ?

I'm sure you'll fit right in. [/sarcasm]
Title: Re: C2's BOD Collector Script
Post by: Hoby on November 23, 2013, 10:11:09 PM
Quote
okay made some updates...

got rid of the typo for a particular large bod that said ggosub so it would miss one particular bod size

got rid of one and two hour options

added an 18 hour option

added the multiple collection if you do select 18 hours

added a gump to get rid of the rewards gump

gave script uo props for being the host on the menu.  man this script was old!

removed the clock for next collection time until i have time to tweak it for the massive 18 hour timer adjustment.  the minutes until the next collection timer is still there!

thx everyone for the feedback and patience!!!  i haven't been playing these days.

I downloaded the last one ifarm.typo but i dont see any of these options when i run it.

I started looking throught the revisions and see that ver 1.2d has the latest updates to it.  I will try that one.  Thanks!
Title: Re: C2's BOD Collector Script
Post by: Pearls on April 28, 2014, 02:18:10 AM
Been catching up on changes since i left. One of the things i noticed is the changes to the trial accounts.
Apparently we aren't able to collect BODS on trial accounts anymore... That used to rock with this script :(
Title: Re: C2's BOD Collector Script
Post by: _C2_ on April 30, 2014, 04:46:07 PM
Been catching up on changes since i left. One of the things i noticed is the changes to the trial accounts.
Apparently we aren't able to collect BODS on trial accounts anymore... That used to rock with this script :(
correct, big change
Title: Re: C2's BOD Collector Script
Post by: REEFHAWK on May 22, 2014, 06:44:52 AM
I have been using your script for a long time and have collected thousands of bods with it.  I have not had any problems with it since back in 2009.  Thanks so much for an awesome script. 
However, with the patch yesterday and the EUO update, I do have a problem.  When it is time for a bod run, the script logs in my account name on the correct line, then, it backspaces over account name and types in my password on the account line instead of dropping down to the line for the Password.  I have not had any problems with my other scripts that I use a lot that I log in my account, just this one that has to log my account in.  Thanks in advance for any help.
Title: Re: C2's BOD Collector Script
Post by: gimlet on May 22, 2014, 07:57:00 AM
I have been using your script for a long time and have collected thousands of bods with it.  I have not had any problems with it since back in 2009.  Thanks so much for an awesome script. 
However, with the patch yesterday and the EUO update, I do have a problem.  When it is time for a bod run, the script logs in my account name on the correct line, then, it backspaces over account name and types in my password on the account line instead of dropping down to the line for the Password.  I have not had any problems with my other scripts that I use a lot that I log in my account, just this one that has to log my account in.  Thanks in advance for any help.

I have a similar problem on a different script. It looks like it is not tabing to the next line after entering pw. This is an EUO problem and needs to be reported to the higher powers.
Title: Re: C2's BOD Collector Script
Post by: manwinc on May 22, 2014, 09:09:00 AM
Is it Breaking the Tab Keystroke or the Click Command Gimlet. I haven't had any problems using my Logger Inner script here recently.
Title: Re: C2's BOD Collector Script
Post by: manwinc on May 22, 2014, 09:21:33 AM
Code: [Select]
    if #Result = Login_Screen
    {
    set #lshard !Shard
    Gosub Click_Offset 530 364
    For !Number 1 20
    {
    Key Back
    }
    Msg !Account
    wait 20
    gosub click_Offset 531 405
        for !number 1 15
        {
          key Back
        }
      Msg !Pass
      Gosub Click_Offset 617 448
      Gosub Cont_Timer 20 Contsize 408_288
    }

The Snippet from my login stuff, still working.
Title: Re: C2's BOD Collector Script
Post by: REEFHAWK on May 22, 2014, 10:15:42 AM
When it is time to start running the bod collector, the script types in my account name on the Account Name line, then it is suppose to tab down to the Password line.  However, what it does is: backspaces over my account name and then types in my password.  since there is no typing on the Password line, the script just sits there. Thanks in advance for any help. 
Title: Re: C2's BOD Collector Script
Post by: Pearls on May 22, 2014, 10:18:05 AM
Manwinc's lumberjacker stopped working for me. Script gets stuck at bank. Not sure what changed.
Title: Re: C2's BOD Collector Script
Post by: manwinc on May 22, 2014, 11:49:09 AM
As soon as I stop staring at pearls Avatar I'll figure that out.

Are you guys using the most recent one posted on Euo? Or Neo's Version?
Title: Re: C2's BOD Collector Script
Post by: REEFHAWK on May 22, 2014, 12:48:10 PM
I am using C2's BOD Collector Script.  Thanks for the responses and trying to help. 
Title: Re: C2's BOD Collector Script
Post by: gimlet on May 22, 2014, 01:53:55 PM
Is it Breaking the Tab Keystroke or the Click Command Gimlet. I haven't had any problems using my Logger Inner script here recently.

It is your sub!

Have you tried to run it today with the new EUO version.
( BTW Neo's EUO hack works fine )
Title: Re: C2's BOD Collector Script
Post by: manwinc on May 22, 2014, 05:31:48 PM
Neo's version was working great for me. Only thing odd I noticed was I needed to double up my MC Clicks, but I was also writing something new, so it was probably already a problem in EUO itself.
Title: Re: C2's BOD Collector Script
Post by: REEFHAWK on May 28, 2014, 01:03:52 PM
Just curious if anyone else is having a problem gathering Bods with C2's Bod Collector Script?  Ever since the patch last week, I have not been able to collect bods.  I even downloaded the new EUO build 264 and I continue to have the same problem.  I am having problems getting the script to log my characters in.

When it is time to start running the bod collector, the script types in my account name on the Account Name line, then it is suppose to tab down to the Password line.  However, what it does is: the cursor does not tab down to the Password line and the cursor stays on the Account Name Line and the script backspaces over my account name and then types in my password.  since there is no typing of the Password on the Password line, the script just sits there.

I would appreciate any help with how I to put a line of script in so after it types my account name; the script would type in my Account Name and then tab down to the Password Line.

I play on Catskills and my characters are Legendary Blacksmiths and Tailors 
 
Thanks in advance for any help.    :)
Title: Re: C2's BOD Collector Script
Post by: 12TimesOver on May 29, 2014, 05:07:28 AM
REEFHAWK - it seems that there were some changes in the login menu that may be causing you issues. Check out C2's Auto Logger script thread, there is discussion there - http://www.scriptuo.com/index.php?topic=803.0

XII
Title: Re: C2's BOD Collector Script
Post by: _C2_ on May 29, 2014, 05:15:57 AM
Just curious if anyone else is having a problem gathering Bods with C2's Bod Collector Script?  Ever since the patch last week, I have not been able to collect bods.  I even downloaded the new EUO build 264 and I continue to have the same problem.  I am having problems getting the script to log my characters in.

When it is time to start running the bod collector, the script types in my account name on the Account Name line, then it is suppose to tab down to the Password line.  However, what it does is: the cursor does not tab down to the Password line and the cursor stays on the Account Name Line and the script backspaces over my account name and then types in my password.  since there is no typing of the Password on the Password line, the script just sits there.

I would appreciate any help with how I to put a line of script in so after it types my account name; the script would type in my Account Name and then tab down to the Password Line.

I play on Catskills and my characters are Legendary Blacksmiths and Tailors 
 
Thanks in advance for any help.    :)

Easyuo 1.5 version 264 corrected a couple issues but some are still borked up. mouse clicks on teh login screen seem to no longer execute correctly on the main menu page anymore. they work everywhere else though. so odd. I have updated my login subs to accomodate for that in the thread that 12xs links above. I will try to get this script updated right now. this is the last chance I have for about 5 days. reference the link for trouble shooting if the upcoming update does not work.
Title: Re: C2's BOD Collector Script
Post by: REEFHAWK on May 29, 2014, 04:50:17 PM
I have tried the above untested version of C2's BOD Collector Script which C2 posted a little earlier in an attempt to fix the log in problem.  I tried it with EUO ver 265 and then with EUO ver 264.  The following is what happens when I hit begin:

When I hit begin, in the Account Name line the script types "Luna", without the Parentheses, instead of my Account Name.  Then it Tabs down to the Password Line, and it appears to type in my Account Name, cant really tell, but the asterisks equal the same number of letters as in my Account Name.  It waits a few seconds then attempts to Login, and I get notification "your account cannot login for one of the following reason, and there is a list" but the Account Name and Passwords are incorrect. 

I know C2 said he would not be on for a few days, hope someone can help.

thanks in advance for any help.
Title: Re: C2's BOD Collector Script
Post by: _C2_ on May 29, 2014, 05:50:04 PM
Did you reenter your acct lines above. I may have a couple minutes to put the script together and test it before I leave tomorrow. Quite fascinating because the only stuff I changed were in the sub login for the acct login. It doesn't even say luna in the login subs. The login subs alone work.  So odd
Title: Re: C2's BOD Collector Script
Post by: REEFHAWK on May 29, 2014, 07:00:01 PM
I downloaded the BOD Collector Script from above.  Set my Shard to %S1 Catskills.  then typed My %A1 Account Name and my %A1 Password. Then entered my gosub login 1 luna %A1 %PW1 %S1.

I looked through the script and could not find luna anywhere that was not commented out except in the gosub login lines. I thought it very weird also.

I just tried to use the script one more time just in case and it did the same thing once more:  on the Account Name line typed luna and it looks like it typed my Account Name in the Password line, just going by the number of characters represented on that line.
 
Thanks so much for responding and trying to help with the script and for the use of your scripts over the years. 
Title: Re: C2's BOD Collector Script
Post by: _C2_ on May 30, 2014, 08:54:18 AM
okay,,, the container stuff is really jacked up on these new easyuo versions.  Have not tried 265 yet but got it going for now. When I return from vacation, I can work on making the container size adjustments that will speed up a few of the click points again. the changed or breaks in the actual easyuo program borked this script hard.

Try the new fix
Title: Re: C2's BOD Collector Script
Post by: Hoby on May 30, 2014, 09:16:10 AM
Thanks!  I'll check it out after I get off work tonight.  Appreciate you updating it! 
Title: Re: C2's BOD Collector Script
Post by: REEFHAWK on May 30, 2014, 10:46:28 AM
First off, C2 thank you very much for giving us a working BOD Collector.  I just downloaded the C2's Ifarm 1.3 Login Hack for EUO Changes.  It worked for me to collect BODs.  I can't tell you thanks enough. 

The following is not a complaint, but just an explanation of what went on while I was collecting BODs just a few minutes ago:

The Script typed in my Account Name, tabbed down and typed in my Password, then continued to the Character List.  The script set on the Character List for several seconds, but then selected the correct character and Logged him in.  As soon as the character was logged in, the Script closed the Paper doll and then the characters backpack. Then the Script selected Both BODs, the tailor and the smith, then opened the characters backpack and put both BODs in the appropriate BOD Book.  Then it opened the Characters Paperdoll and then logged out and went to the next character and repeated the above.

With all that said, I want to thank you for taking the time before leaving on your vacation to fix this Script for us.  I am now back to Collecting BODs. thanks
Title: Re: C2's BOD Collector Script
Post by: _C2_ on May 30, 2014, 01:20:24 PM
First off, C2 thank you very much for giving us a working BOD Collector.  I just downloaded the C2's Ifarm 1.3 Login Hack for EUO Changes.  It worked for me to collect BODs.  I can't tell you thanks enough. 

The following is not a complaint, but just an explanation of what went on while I was collecting BODs just a few minutes ago:

The Script typed in my Account Name, tabbed down and typed in my Password, then continued to the Character List.  The script set on the Character List for several seconds, but then selected the correct character and Logged him in.  As soon as the character was logged in, the Script closed the Paper doll and then the characters backpack. Then the Script selected Both BODs, the tailor and the smith, then opened the characters backpack and put both BODs in the appropriate BOD Book.  Then it opened the Characters Paperdoll and then logged out and went to the next character and repeated the above.

With all that said, I want to thank you for taking the time before leaving on your vacation to fix this Script for us.  I am now back to Collecting BODs. thanks

Fantastic. When I return, I will adjust for the new changes to container size so it works smoother. The character choice menu is a perfect example of the change to reading container size. That wait is because of the variables in the EUO program showing differently. Thank goodness I built safety timers in to move the script forward after a certain time. The waits are to support against lag but now they are all getting triggered because they don't look the same in the new EUO 1.5 builds variables anymore...

Anyway, stoked you can run it again. I have not collected bods in well over five or six years so testing this can be tricky.
Title: Re: C2's BOD Collector Script
Post by: Hoby on May 31, 2014, 08:46:57 PM
Been running the updated one you posted and its working pretty much like it should except it never clicks to accept the bod, the bod gump pops up and you have the option to get the bod but it doesnt it goes on to the next one.  It cycles through all six bods (tailor and smith) but never gets them then goes to the next character and does the same thing.
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 01, 2014, 07:38:41 AM
Been running the updated one you posted and its working pretty much like it should except it never clicks to accept the bod, the bod gump pops up and you have the option to get the bod but it doesnt it goes on to the next one.  It cycles through all six bods (tailor and smith) but never gets them then goes to the next character and does the same thing.

I have a feeling that is the container size issue. they have container size as two separate values now in the EUO variables. I noticed it was skipping a character click at one point due to this. I'll get it back up soon next week.
Title: Re: C2's BOD Collector Script
Post by: REEFHAWK on June 01, 2014, 11:02:05 AM
Thanks so much for your script.
I was wondering, up until last week I had been using version 1.0, and what it does, after the script collects BODs, it puts the time for the next BOD run in the EUO box.  Then I close EUO, and after playing UO for a while, especially in the evening, I will open EUO, then the BOD Collector script and hit play. when the EUO box opens and shows when the next BOD run is, the time for the next BOD run is the time that was there prior to closing EUO. 

I was wondering if it would be to much trouble to have the new version keep track of he time this way.  What happens now, is you let the Script perform the BOD run and it puts the time for the next BOD run when it has completed the run.  However, if you close EUO, the time for the next BOD run is left blank. 

thanks for listening.  Hope you have a great vacation.   
Title: Re: C2's BOD Collector Script
Post by: Hoby on June 01, 2014, 04:42:15 PM
Thanks c2. 
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 07, 2014, 07:33:14 AM
Been running the updated one you posted and its working pretty much like it should except it never clicks to accept the bod, the bod gump pops up and you have the option to get the bod but it doesnt it goes on to the next one.  It cycles through all six bods (tailor and smith) but never gets them then goes to the next character and does the same thing.

Will you try this new version 267 and then give feedback again? It seems to be working for one other but not you. are you using the get 3 at once mode or one at a time mode? the gump size stuff has not changed and still works correctly outside the main menu
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 07, 2014, 07:50:20 AM
updated timing on gumps... only the main menu gumps were impacted by the change.
version attached here and on main post
Title: Re: C2's BOD Collector Script
Post by: REEFHAWK on June 07, 2014, 10:56:27 AM
I just downloaded the new Collector Script and will use EUO 267 for my next bod run at 5:52 EST.  will post shortly after and let you know how it went.  Thanks so much for working on this for us.   
Title: Re: C2's BOD Collector Script
Post by: REEFHAWK on June 07, 2014, 02:51:40 PM
I just tried the new BOD Collector Script with EUO Ver. 267.  When I hit the Begin button, all that happened was it gave me a time 6 hours from now.  So, then I tried it with EUO Ver. 264, and the same thing happened again.  It did not type in the Account Name or the Password.  The script just gave me a time of 6 hours from now for the next run.  Thanks so much for working on this. 
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 07, 2014, 08:22:25 PM
Did you transfer all your character login lines? That is what it would do if there were no lines put in to log characters in with.
Title: Re: C2's BOD Collector Script
Post by: REEFHAWK on June 07, 2014, 09:22:54 PM
you were right, I forgot to add my account and character info.  I added that info and started my BOD run.  the Script is typing my account name and password and then logging into my shard is back to being fast. However, as soon as the character is logged in, it closes the Paperdoll and backpack.  Then collects both bods (smith and tailor, only one of each type of bod}, then opens backpack and puts the collected bods in the appropriate BOD Book.  then opens the paperdoll and then logs out and moves on to the next character.  the speed at which it works is back to prior to the last patch.  yea. 

Sorry about forgetting to put my information in and then posting.

Thanks for all the help and support.
Title: Re: C2's BOD Collector Script
Post by: Nico on June 08, 2014, 08:29:45 AM
login/charchange works good for me now , but the bodcollecting itself mess up a bit, chars do open the meny to get bods,but never pick to get one, and then sorts backpack and logs out,  gonna try work it with f8 now

Post Merge: June 08, 2014, 08:38:46 AM
think it is a lagg issue, soled with adding a paus in the sub:
sub collect
wait 18 ;%1 smith or tailor
repeat
if #contname = trade_gump
   gosub gump_locations 100 50 r
event macro 31
wait 15
exevent popup %bodguy
wait 10
gosub bod_gump 30 40 ; for menu pop up spot
wait 10
gosub TM_AdvJournalScan bodmessage NONE an_offer_may_be_available
if #result = #true
   {
   gosub TM_AdvJournalSync bodmessage
   wait 60s

btw, im missing that additional time option in easyuo client, where did it go?
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 08, 2014, 09:44:32 AM
you were right, I forgot to add my account and character info.  I added that info and started my BOD run.  the Script is typing my account name and password and then logging into my shard is back to being fast. However, as soon as the character is logged in, it closes the Paperdoll and backpack.  Then collects both bods (smith and tailor, only one of each type of bod}, then opens backpack and puts the collected bods in the appropriate BOD Book.  then opens the paperdoll and then logs out and moves on to the next character.  the speed at which it works is back to prior to the last patch.  yea. 

Sorry about forgetting to put my information in and then posting.

Thanks for all the help and support.

The closing of all those gumps is intentional and helps deal with lagged vet reward gumps and such. that is by design.
Title: Re: C2's BOD Collector Script
Post by: REEFHAWK on June 08, 2014, 01:36:38 PM
Thanks for the quick response and glad to hear opening and closing of the backpack and the paperdoll is intended. 
I run 2 accounts on an older computer {had no problems,  both accounts have 7 characters each) and 2 accounts on a new computer, The only problem I have had is on this newer computer, on account 2, character #1 is not a BS or Tailor and is not included in the login script area.  what happens is Account one gathers the bods with no problem, but when it tries to login character 2 on Account 2, the Script types in my Account name and Password. Then it acts like it is going to the Shard page, but the UO page goes blank. Since you can gather up to 3 bods, I tried once again with both accounts and the same thing happened again, the UO page went blank.  So, I deleted all of Account 1 info and hit begin with Account 2, only has characters 2-6 collecting BODs.  The script ran with no problem.  not sure what is wrong, but on my next bod run, I will put BS and Tailor on my character #1 and run the Script once again and let you know how it went

Thanks so much for fixing the problems with this Script, I know you mentioned you had not gathered BODs in quite some time, so I really thank you for taking the time to get it up and running once again.
Title: Re: C2's BOD Collector Script
Post by: REEFHAWK on June 09, 2014, 04:48:48 AM
I ran the Script again with Account 1 having no problems and Account 2 now having characters 1 - 6, having the same problem with the UO screen going blank.  This time on Account 2, Characters 1 - 3 did just fine collecting BODs.  Then with character #4 it typed in the Account Name and Password, then when the script tabs to go to the Shard selection, the UO screen attempts to go to the Shard selection screen and that is when the UO screen goes blank. 

The crazy thing is, on my other computer, which I bought in 2003 and is a lot slower, the Script runs just fine with 2 Accounts and the new Gaming computer, just a few months old is the one having problems.
 
I was wondering if you could tell me where to put a wait just after the Script types the Password and just before the Script goes to the Shard selection screen.

Thanks once again for all your support.
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 09, 2014, 08:54:33 AM
I ran the Script again with Account 1 having no problems and Account 2 now having characters 1 - 6, having the same problem with the UO screen going blank.  This time on Account 2, Characters 1 - 3 did just fine collecting BODs.  Then with character #4 it typed in the Account Name and Password, then when the script tabs to go to the Shard selection, the UO screen attempts to go to the Shard selection screen and that is when the UO screen goes blank. 

The crazy thing is, on my other computer, which I bought in 2003 and is a lot slower, the Script runs just fine with 2 Accounts and the new Gaming computer, just a few months old is the one having problems.
 
I was wondering if you could tell me where to put a wait just after the Script types the Password and just before the Script goes to the Shard selection screen.

Thanks once again for all your support.

i added a couple of waits to the login procedure. see if that helps. not sure if your computer is going so fast that it makes uo freeze up or what but that is plain bizarre. 1.4b
Title: Re: C2's BOD Collector Script
Post by: REEFHAWK on June 09, 2014, 12:09:44 PM
Thanks so much for working with me to get the Script working on my computer.  I downloaded 1.4b, put all my info in.  hit begin and it ran through both Accounts on my Gaming Computer with no problems.

Once again, thank you.
Title: Re: C2's BOD Collector Script
Post by: Cush on June 10, 2014, 06:50:56 AM
Hi C2,

I was having the same problem. I will download it and give it a whirl this morning. I have 5 accounts in there and was making it partway through the second.
Title: Re: C2's BOD Collector Script
Post by: Hoby on June 10, 2014, 02:48:35 PM
So I tried the latest version with the latest euo and still having issues.  The bod gump flashes on the screen then but it doesnt get the bod.  SOmetimes 1 out of 6 bods, im doing tailor and smith.  Let it run through all my accounts and it did the same thing.  The bod gump flashes but not usually till the very last one does it click the gump to get the actual bod.  Thanks.
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 10, 2014, 08:24:47 PM
So I tried the latest version with the latest euo and still having issues.  The bod gump flashes on the screen then but it doesnt get the bod.  SOmetimes 1 out of 6 bods, im doing tailor and smith.  Let it run through all my accounts and it did the same thing.  The bod gump flashes but not usually till the very last one does it click the gump to get the actual bod.  Thanks.

Okay,
  I'll look closer at the bod gump stuff tomorrow morning. So weird... not of the sizes had appeared to change but i will walk slowly through it and see. Did you happen to try the waits that are up a few posts just to see what would happen? They are inserted in red and worked for that user. I am wondering if they would work for you. that would give me some good insight.
Title: Re: C2's BOD Collector Script
Post by: Cush on June 11, 2014, 06:16:19 AM
Hi,

I have had the newest 1.4b version running for the last day or so and it seems to be working fine now that you tweaked it a bit.

I am on osi
Have 5 accounts set up in there
6 or so slots per account
Set to collect every 6 hours
 

Title: Re: C2's BOD Collector Script
Post by: Hoby on June 11, 2014, 08:11:43 AM
c2 I added those wait times and its working now.  Thanks!
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 11, 2014, 10:55:56 AM
c2 I added those wait times and its working now.  Thanks!

Thx for checking that out. I'll check the gumps out and add some waits as needed to simulate the best possible situation. It is so hard to work on this without bod collectors myself.
Title: Re: C2's BOD Collector Script
Post by: Nico on June 11, 2014, 11:12:51 AM
make some chars on a shard you dont usually play ,1 tailor/smith is enough
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 11, 2014, 11:25:02 AM
Added the waits to ensure bod is clicked for collection
Title: Re: C2's BOD Collector Script
Post by: Cush on June 11, 2014, 02:12:04 PM
Thank You.

I am humming right a long on b I will try c
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 12, 2014, 12:05:28 PM
Thank You.

I am humming right a long on b I will try c

Excellent! Glad folks still use this tool!
Title: Re: C2's BOD Collector Script
Post by: Scorpio on July 19, 2014, 08:59:10 AM
I fixed this script for the free shard I play on and thought i would put it out there in case other freeshard players want to use this, very simple fix. I havent read the whole thread so if someone else explained this, then my bad :P

The script is set for Osi and has a sub to check for OSI shards, if you do not edit this part you will be stuck in a login loop where you logg in, see server list and go back to logg in screen. To fix this I simply changes position 0,1,2 shard names to the three on my free shard i play on.

For example osi setup looks like this: sub setshard
if %shardname = Atlantic
   {
   set #lshard 0
   set %lshardnumber 0
   }
if %shardname = Lake_Superior
   {
   set #lshard 1
   set %lshardnumber 1
   }
if %shardname = Pacific
   {
   set #lshard 2
   set %lshardnumber 2
   }





Mine now looks like this:sub setshard
if %shardname = Wakened_USA_MO
   {
   set #lshard 0
   set %lshardnumber 0
   }
if %shardname = Wakened_EU_FR
   {
   set #lshard 1
   set %lshardnumber 1
   }
if %shardname = Wakened_UO_CO


Hope this helps :) I play on a ML server and newest EUO 267, and works flawlessly once i got past the login loop :P Great script C2, thanks :)

P.S. The waits you put in are huge help for free server world saves :)
Title: Re: C2's BOD Collector Script
Post by: Cush on July 21, 2014, 09:39:50 AM
C has been running smoothly going through about 6 accounts I put into the script every 6 hours. Been running non stop since June 11th.

No issues Thanks!!
Title: Re: C2's BOD Collector Script
Post by: _C2_ on July 22, 2014, 02:41:43 PM
C has been running smoothly going through about 6 accounts I put into the script every 6 hours. Been running non stop since June 11th.

No issues Thanks!!

Dang!!! Sweet.
Title: Re: C2's BOD Collector Script
Post by: REEFHAWK on September 30, 2014, 08:19:28 AM
I would like to say thanks once again for letting us use your scripts.  I just used your Bod Collector and was able to gather all of my 17th Anniversary gifts on all shards.  I have my characters either in an Inn or at Luna upstairs.  Thanks so much.
Title: Re: C2's BOD Collector Script
Post by: primo on December 21, 2014, 12:01:56 AM
Hi guys and C2,

Just wondering if there is still a place I can get this script as I do not see any links or code.
Title: Re: C2's BOD Collector Script
Post by: Pearls on December 21, 2014, 02:02:46 AM
Hi guys and C2,

Just wondering if there is still a place I can get this script as I do not see any links or code.

http://www.scriptuo.com/index.php?topic=1750.0
Title: Re: C2's BOD Collector Script
Post by: NObama on December 21, 2014, 04:17:45 AM
Hi guys and C2,

Just wondering if there is still a place I can get this script as I do not see any links or code.

Welcome.  Merry Christmas, and please check out the link abovE!
Title: Re: C2's BOD Collector Script
Post by: Crisis on December 21, 2014, 06:50:46 AM
I keep forgetting about this script, I will have to give it a whirl.
Title: Re: C2's BOD Collector Script
Post by: primo on December 21, 2014, 12:40:13 PM
Hi guys and C2,

Just wondering if there is still a place I can get this script as I do not see any links or code.

http://www.scriptuo.com/index.php?topic=1750.0

My bad - should have read the forum first.
Thanks
Title: Re: C2's BOD Collector Script
Post by: NoSkill on January 05, 2015, 09:41:04 AM
I keep forgetting about this script, I will have to give it a whirl.

Hey Crisis, i am wondering if you were able to get this script up and running. This is my dream script since 2005 when bods first came out and for me to get this running would be  amazing. This is all i want to spend my time on is bod running and collecting.

If anyone has some suggestions on getting this running please let me know. Im having issues on chr selection and bod collection, the cord for the menus are correct. I am on a free shard and am trying both versions of C2's Bod Collector. The specific shard is Uogamers:Hybrid

Thank You,
NoSkill
Title: Re: C2's BOD Collector Script
Post by: jumanji0101 on January 06, 2015, 06:46:05 AM
Hey very good Script , im today registirion, why i dont see donwload ? 
Title: Re: C2's BOD Collector Script
Post by: TrailMyx on January 06, 2015, 09:07:09 AM
Hey very good Script , im today registirion, why i dont see donwload ? 

Because of those pesky rules!

http://www.scriptuo.com/index.php?topic=12571.0
Title: Re: C2's BOD Collector Script
Post by: _C2_ on January 06, 2015, 06:48:54 PM
I keep forgetting about this script, I will have to give it a whirl.

Hey Crisis, i am wondering if you were able to get this script up and running. This is my dream script since 2005 when bods first came out and for me to get this running would be  amazing. This is all i want to spend my time on is bod running and collecting.

If anyone has some suggestions on getting this running please let me know. Im having issues on chr selection and bod collection, the cord for the menus are correct. I am on a free shard and am trying both versions of C2's Bod Collector. The specific shard is Uogamers:Hybrid

Thank You,
NoSkill

This script is only maintained for OSI. Hopefully, there is a free shard player that knows the changes that need to be made for that particular free shard.
Title: Re: C2's BOD Collector Script
Post by: jumanji0101 on January 07, 2015, 09:43:55 AM
I keep forgetting about this script, I will have to give it a whirl.

Hey Crisis, i am wondering if you were able to get this script up and running. This is my dream script since 2005 when bods first came out and for me to get this running would be  amazing. This is all i want to spend my time on is bod running and collecting.

If anyone has some suggestions on getting this running please let me know. Im having issues on chr selection and bod collection, the cord for the menus are correct. I am on a free shard and am trying both versions of C2's Bod Collector. The specific shard is Uogamers:Hybrid

Thank You,
NoSkill

This script is only maintained for OSI. Hopefully, there is a free shard player that knows the changes that need to be made for that particular free shard.

I'm playing until free shard , I have a similar one for these scripts are software(Raziel-MultiShard,bod collector) raziel script -I had tried in the Turkish server,but other uogamers hybrid and server created did not work. I tried so hard but did not.Tried but did not see the npc(Dont Target npc),NPC codes may be different :( for example I played Thomas server writes to Anna in [blacksmith] but I played freeShard writes Anna the blacksmith or Anna the armouer . I don't know how we're going to solve=) I'm going to work on your script tonight maybe I will .
you guys are great programmers I'm thinking of you to fix this issue=)
Title: Re: C2's BOD Collector Script
Post by: NoSkill on January 09, 2015, 05:41:22 PM
I keep forgetting about this script, I will have to give it a whirl.

Hey Crisis, i am wondering if you were able to get this script up and running. This is my dream script since 2005 when bods first came out and for me to get this running would be  amazing. This is all i want to spend my time on is bod running and collecting.

If anyone has some suggestions on getting this running please let me know. Im having issues on chr selection and bod collection, the cord for the menus are correct. I am on a free shard and am trying both versions of C2's Bod Collector. The specific shard is Uogamers:Hybrid

Thank You,
NoSkill

This script is only maintained for OSI. Hopefully, there is a free shard player that knows the changes that need to be made for that particular free shard.

Hey C2, I understand that this script is not maintained for OSI. I'm trying my best to make changes, but I'm not sure of the changes I need to make. I have ran this thing quite a few different ways. One of my biggest hangups was trying to run everything in Ubuntu, unfortunately I had to do away with it today. Now that I have a Windows operating system, I have tried to edit your script but still I'm not successful. Any suggestions that you have would be greatly appreciated.

I guess the main thing for me to do is keep trying and maybe someone will come forward and possibly help me.

Thank you,
NoSkill

Post Merge: January 10, 2015, 04:53:45 AM
I need to give my vendor a permanent ID, this would fix my issues.

Any suggestions?
Title: Re: C2's BOD Collector Script
Post by: lamar on June 07, 2015, 08:57:13 AM
awesome script really, but i runed into an issue today, when i added a shard

Quote
set %S1 catskills
set %S2 atlantic
set %S3 chesapeake
set %S4 legends
set %S5 great_lakes
set %S6 lake_superior

gosub login 1 luna %A5 %PW5 %S6
gosub login 2 luna %A5 %PW5 %S6
gosub login 3 luna %A5 %PW5 %S6
gosub login 4 luna %A5 %PW5 %S6
gosub login 5 luna %A5 %PW5 %S6
gosub login 6 luna %A5 %PW5 %S6
gosub login 7 luna %A5 %PW5 %S6

it wont login to LS, it just goes back to login screen, anyone else have this issue?
Title: Re: C2's BOD Collector Script
Post by: The Ghost on June 07, 2015, 01:01:49 PM
Have you try to just run LS to see if that work.     Maybe you need t0 set %A6
set %PW6 .
Title: Re: C2's BOD Collector Script
Post by: _C2_ on June 07, 2015, 02:29:49 PM
Have you try to just run LS to see if that work.     Maybe you need t0 set %A6
set %PW6 .
[/quote

correct... you should not be adding that. it is in the code to find it already
Title: Re: C2's BOD Collector Script
Post by: The Ghost on August 12, 2015, 02:00:16 PM
C2, I got around and using this again for LS.   I had to add this at the beginning.  if you dont add those it will not log into the game. That came out from build 253.
Code: [Select]
ignorecont reset
ignorecont UULC
ignorecont YCLD
ignorecont GXJC
ignorecont UGQB
ignorecont GVKC
ignorecont SVP
ignorecont SXQ
ignorecont IGHC
ignorecont QCPD
ignorecont MSMC
Title: Re: C2's BOD Collector Script
Post by: _C2_ on August 17, 2015, 06:10:06 PM
Awesome Ghost. I hope to have time this weekend to get on and add this to the set-up of the script. Thank you!
Title: Re: C2's BOD Collector Script
Post by: The Ghost on September 15, 2015, 02:15:22 PM
With build 288 and 289, this script since to be broken.  I'm slowly looking at this.  At a quick look, it look like the #CONTSIZE X_Y  have been broken,  the do not match anymore. 

Title: Re: C2's BOD Collector Script
Post by: demitoast on November 01, 2015, 02:55:23 AM
Very nice script, as a player who play on a free shard. I had to adapt this a little.

Now, I run in a problem that might just be temporary...

1. Shard I play is currently running an event and the tailor/blacksmith are no longer in their human form.
I think that is the issue, because when I run it. It will log each char, close everything, open backpack a little. Close it again and simply log off.
Where could I change the ID of the smith/tailor ? Or is it a totaly unrelated issue ?

2. We can gather bods every hour here. I would like to lower it to 1.

I changed

menu get everysixhours
if #menures = #true
   set %menuhours 6
set %hr %hr + %menuhours

for

menu get everysixhours
if #menures = #true
   set %menuhours 1

and changed

menu get everysixhours
if #menures = #true
   {
   set %menu_timer_interval 3600
   set %menutrack 3600
   }

Tbh, Im not really good at all that. Usualy can get arround with some small modification. But is that what I needed to do ?
Title: Re: C2's BOD Collector Script
Post by: The Ghost on November 01, 2015, 04:08:49 AM
this is a simple fix

look at around line 284 for this sub
Code: [Select]
sub find_vendor  ;%1 tailor or smith
ignoreitem #charid
still_searching:
finditem HS_IS  < --------------  this is where you need to enter the new ID
if #findkind = -1
  return
  if #findrep <> 7
Title: Re: C2's BOD Collector Script
Post by: demitoast on November 06, 2015, 02:40:15 PM
Thank you, work great.


 Im also curious of a bug I sometime run into.

It is not the biggest issue since I managed to have a fix arround that problem. But still curious as I had this kind of problem in the past with login script.(in worse tho)

When I press play,

1. sometime the login totaly fail. It erase the current name, write proper  account, delete it, write my password in account name field.

2. When I already played and decide to start it. It will do it in the password field instead.

Now, what I think is that is 'fail' to click. What is even more weird is that it's not always the case. But usualy is persistent to the current boot. If I reboot my computer. There are chance it will just start working properly again.

On a even weirder note... I checked the pixel click and they are very well placed to have no chance of being outside the text field. I fixed the issue by changing of  using 'key tab' to switch between text fields as a test. It does not fail to log in and somehow it will not fail to select proper characters.

I  tried with both version of clicking

Code: [Select]
gosub setshard

  click %MainMenuNameX %MainMenuNameY f
   gosub sendstring %acct

   lclick %clickx %clicky f
   click %MainPassNameX %MainPassNameY f
   wait 10
gosub sendstring %pass

   click %NextScreenArrowX %NextScreenArrowY f
   wait 5
 ;  }
and
Code: [Select]
if #contname = MainMenu_gump
   {
   set %clickx #contposx + 521
   set %clicky #contposy + 356
   click %clickx %clicky f
   gosub sendstring %acct
set %clickx #contposx + 521
  set %clicky #contposy + 396
   click %clickx %clicky f
   wait 10
gosub sendstring %pass
   set %clickx #contposx + 618
   set %clicky #contposy + 445
   click %clickx %clicky f ; the green arrow
   wait 5
   }

It seem to be an issue that come and go like a bad relationship.
Like I said, it's not the biggest problem as I got a work arround. But, Im still wondering what is going on. Anyone else ran into this kind of problem on easyuo ?
Title: Re: C2's BOD Collector Script
Post by: Hoby on January 02, 2016, 08:45:01 AM
i am having the same issue as #1 in the above post.  It fills in the account name then deletes it and replaces it with the password.  I manually entered account name and password for the first character it logs in but doesn't get the bods, looks like a click problem.  The gump comes up for npc to get the bod but it doesn't click on it to get the bod.  It does it three times then logs out like it did get them.  A few things I have tried, closing and restating uo, closing and restarting EUO, and rebooting computer all together,  same thing happens each time.
Title: Re: C2's BOD Collector Script
Post by: jamisoncrzy on January 04, 2016, 05:17:10 PM
I tried to use this but once it selects a character it hits the delete button instead of enter or the green arrow. Trying to fix it now but not having much luck.
Title: Re: C2's BOD Collector Script
Post by: _C2_ on January 07, 2016, 02:38:45 PM
ill try to get to it guys. This is an easy uo change or lack of update where the login script can no longer read the gump the same way as it has in the past.
Title: Re: C2's BOD Collector Script
Post by: jamisoncrzy on January 11, 2016, 08:53:39 PM
ill try to get to it guys. This is an easy uo change or lack of update where the login script can no longer read the gump the same way as it has in the past.

Awesome thanks.
Title: Re: C2's BOD Collector Script
Post by: declo on November 17, 2016, 11:32:42 AM
Any chance the script will be modified for all the new BODs?
Title: Re: C2's BOD Collector Script
Post by: axtonz on November 18, 2016, 05:37:10 AM
OMG i am hoping the same thing. this new update has screwed up the bod system
Title: Re: C2's BOD Collector Script
Post by: demitoast on March 07, 2017, 01:10:53 AM
How would I go to change the 'every 6 hours' to every  1 hour or every 60 min ?
Title: Re: C2's BOD Collector Script
Post by: The Ghost on March 07, 2017, 05:12:27 AM
get an older copy of this build,  it was first build for every hrs.   

if you can't   I will look at changing
 set %menuhours 6 
    for set %menuhours 1

Code: [Select]
sub next_collect_time
set %timesaved #time
str left %timesaved 2
set %hr #StrRes
str mid %timesaved 3 2
set %min #StrRes
menu get maxhours
if #menures = #true
   set %menuhours 18 ; <-------------------   18 hrs
menu get everysixhours
if #menures = #true
   set %menuhours 6 ; < ----------------- 6 Hrs     
Title: Re: C2's BOD Collector Script
Post by: valen2.0 on March 07, 2017, 11:19:25 AM
you say port to another NPC, Do you mean right away? or after the time limit passes? Cus I thought you cant get more than 3 bods before that timer triggers and if you went to separate npc of the same kind(blacksmith to blacksmith)
Title: Re: C2's BOD Collector Script
Post by: qza on January 21, 2018, 05:23:37 AM
get an older copy of this build,  it was first build for every hrs.   

if you can't   I will look at changing
 set %menuhours 6 
    for set %menuhours 1

Code: [Select]
sub next_collect_time
set %timesaved #time
str left %timesaved 2
set %hr #StrRes
str mid %timesaved 3 2
set %min #StrRes
menu get maxhours
if #menures = #true
   set %menuhours 18 ; <-------------------   18 hrs
menu get everysixhours
if #menures = #true
   set %menuhours 6 ; < ----------------- 6 Hrs     
So its gona look like that ?

sub next_collect_time
set %timesaved #time
str left %timesaved 2
set %hr #StrRes
str mid %timesaved 3 2
set %min #StrRes
menu get maxhours
if #menures = #true
   set %menuhours 6 ;
menu get everyhours
if #menures = #true
   set %menuhours 1 ; 
Title: Re: C2's BOD Collector Script
Post by: Temogim on June 19, 2019, 07:59:22 AM
Hi everyone, does anyone know how I can access the files below?

________________
There are 5 attachment(s) in this post. You must register and post an acceptable introduction to download
C2's IFarm 1.2d public.txt
C2's IFarm 1.4c public (EUO Version 267 or higher).txt
C2's_IFarm_1.2c_public typo fix.txt
ifarm.jpg
upstairs luna bods.jpg
Title: Re: C2's BOD Collector Script
Post by: Crisis on June 19, 2019, 04:15:38 PM
Hi everyone, does anyone know how I can access the files below?

________________
There are 5 attachment(s) in this post. You must register and post an acceptable introduction to download
C2's IFarm 1.2d public.txt
C2's IFarm 1.4c public (EUO Version 267 or higher).txt
C2's_IFarm_1.2c_public typo fix.txt
ifarm.jpg
upstairs luna bods.jpg

You answered your own question. Reread what you posted and enlightenment you shall find!  :angel:
Title: Re: C2's BOD Collector Script
Post by: lamar on January 02, 2020, 09:51:25 AM
decided to run this script again, as I was in need of some bods,  script still works, but i had to edit the X Y clicks for login, new ones is(atleast for me):

Code: [Select]
set %MainMenuNameX 409
set %MainMenuNameY 303
set %MainPassNameX 414
set %MainPassNameY 357
set %NextScreenArrowX 333
set %NextScreenArrowy 380

Title: Re: C2's BOD Collector Script
Post by: Crisis on July 09, 2020, 09:26:51 AM
nicee

It will be even better after you go to the New Member Introduction section and make a good introduction so you can actually download the script!. 8)
Title: Re: C2's BOD Collector Script
Post by: yuckfou on December 28, 2020, 12:03:06 AM
Introduction, Hi I R YUCK FOU and i play UO
Title: Re: C2's BOD Collector Script
Post by: Crisis on December 28, 2020, 08:07:34 AM
WOW! That was an introduction!  :laugh:
Title: Re: C2's BOD Collector Script
Post by: Murdok on April 17, 2021, 10:25:12 AM
Does anyone know if this script still works??
Title: Re: C2's BOD Collector Script
Post by: Hitechs on July 02, 2021, 05:39:51 PM
guess if i want scribe bods, i will need a collector too,

thanks for sharing an example of what's required .
Title: Re: C2's BOD Collector Script
Post by: TrackStar on October 23, 2021, 02:18:22 PM
Unless I missed changes in the chat this only works for tailoring and blacksmithing?
Title: Re: C2's BOD Collector Script
Post by: Gaderian on October 23, 2021, 05:04:22 PM
You are correct, as written it only recognizes those 2 trades and Bulk Order Books. Making that change would not be difficult to add in the other Luna based vendors for other bods (alchemy, fletching, carpentry, tinkering). Further modifications for inscription and cooking would be a modest effort, because it includes travel to other vendors.
Title: Re: C2's BOD Collector Script
Post by: docaw on March 25, 2024, 12:20:15 PM
Is this still working? below are my first 2 logins and the script just sits there after hitting play.  says next collection in 6 hours but thought it should run through once immediately.  I have all the variables for account A1 and pw PW1 set

;gosub login 1 luna %A1 %PW1 legends
;gosub login 2 luna %A1 %PW1 legends