Why the *bleep* isn't this working...

[NObama]

This makes me want to scream.  It was working, then it stopped.  Argh.

Code: [Select]

  display ok Now, target the container$ with unfilled deeds in your pack
  set #TARGCURS 1
  repeat
  until #TARGCURS = 0
  set %deedbag #LTARGETID
  finditem EWH C_ , %deedbag ; Deeds
  if #FINDKIND = -1
  {
    display ok No Commodity deeds.$Please get some.
    halt
  }

Keep getting -1 on #findkind...why? WHY!

And before you ask, YES there are deeds in there and YES the item type is EWH.

[_C2_]

if the container is not preopened... it will tell you no deeds becasue u never last object it t open it

[Dixie Wrecked]

Tested code and it worked fine (looked fine, but never trust my own eyes!).  The only other thing that I can think of right now besides having an unopened container is not having EUO set to the right client, which is something I do all the time, especially when I have all 4 accounts scripting at once.

[NObama]

if the container is not preopened... it will tell you no deeds becasue u never last object it t open it

Give the man a prize.  Thanks C2.

[Scrripty]

It's also more proper to use if #findcnt > 0 instead of #findkind.

[NObama]

It's also more proper to use if #findcnt > 0 instead of #findkind.

Okay.  Why?

[manwinc]

Well think about it logically. 

Finditems in a container
Okay if the kind returns its not in a container then great. What?

Or better yet
If the number of that item in the container is 0

I never understoodwhat the point of findkind is.

[_C2_]

It is more of a preference between scripters.  I don't think that there is any particular reason that it is better.  I use them interchangably depending on if there is a remote chance that  I will find more than one.  in your case... there will never be more than one secure.  If you were looking for many items and started by using findkind... you next step might be if findcnt.  then findindex.  

You code is fine either way.  maddog uses findcnt religiously as does endless i believe.  tm uses findkind a lot.  both are stable especially in your case.  findcnt > 0 is basically the same thing as findkind <> -1 except that now you start with the count

[Scrripty]

Cheffe - "#Findkind is not the preferred method to check whether an item was found or not because it is harder for humans to debug. Please use #FINDCNT instead, whenever possible." 

[Dixie Wrecked]

Cheffe - "#Findkind is not the preferred method to check whether an item was found or not because it is harder for humans to debug. Please use #FINDCNT instead, whenever possible." 

Hmmmm...so if I can get some monkeys to do my coding for me, I can have them use #FINDKIND?  One more reason I need a monkey army!!!

[Masscre]

Cheffe - "#Findkind is not the preferred method to check whether an item was found or not because it is harder for humans to debug. Please use #FINDCNT instead, whenever possible." 

Hmmmm...so if I can get some monkeys to do my coding for me, I can have them use #FINDKIND?  One more reason I need a monkey army!!!

This is prolly true since Monkeys use a different way of debugging !! So us humans better not use #FindKind !!

[manwinc]

Army of Monkeys!!!!!!!!!!!!

ARMY OF HELL MONKEYS!!!!!!!!!!!BUAHAHAHAHAHAHAHAHAHAHAHAHAHAH

They are actually in the works!

[TrailMyx]

Try to open the bag before you search.  As for findcnt vs. Findkind? Potato, potato. 6 or 1/2 dozen. Tomato, tomato.  Just because Cheffe says so, doesn't make it gospel. Use whatever works and whatever your comfortable using.

Edit:
Ah, I see you got the right suggestion below.  Darn phone surfin

[Scrripty]

Try to open the bag before you search.  As for findcnt vs. Findkind? Potato, potato. 6 or 1/2 dozen. Tomato, tomato.  Just because Cheffe says so, doesn't make it gospel. Use whatever works and whatever your comfortable using.

Edit:
Ah, I see you got the right suggestion below.  Darn phone surfin

I'll choose to use things the way they're designed and at the developers request over a users suggestion every time.   It's much simpler to use #findcnt, easier for a noob to understand.  Use #findcnt.  It's the future.  It's less letters also.  So a tad faster overall.  I win.

[NObama]

I switched to #findcnt halfway through the script, just to confuse everybody.

So there.

 

Script is done.  I will never commoditify anything by hand ever again.  I will, however, continue to invent new words as the whim takes me.  Post it as soon as TM grants me my own script section. 

(going to be a lonely script until I LEARN HOW TO DO ARRAYS)