ScriptUO
Official ScriptUO EasyUO Scripts => Script Library => Crafting => Topic started by: Paulonius on January 21, 2010, 07:03:33 AM
-
I was not having luck with CEO's smith trainer, so I wrote one yesterday. I have only worked up one smith with it so far, so it could use some tire kicking. I set it up to run through the most efficient ingot/skill use possible. It stays between 50 and 60% success for the entire range until it hits about 110. I left it running with boomerangs all the way to 120 as the items that increase difficulty from there increase the ingots per attempt by five times and don't seem worth making. The code is in there to make decorative plate kabutos' though if you want to tinker with it.
Setup:
1. Be standing within range of a forge and anvil
2. Have a tinker kit in your backpack
3. Be able to reach a secure with your ingots in it
4. Have only iron ingots on the top layer of the secure as there is no check for other ingots
5. Don't have any of the item types that the script makes in your pack
Recommend you GM mining before training blacksmith to maximize recovery on smelting.
Don't have a newbie dagger in your pack.
Update 1 March 2011 - Version .30 (In Testing)
Added code to account for multiple ingot stacks/ types in secure
Added code to apply Siege Perilous RoT timer waits when the script is run in Siege
Modification to account for menu change from High Seas (Thanks SW!)
Script makes the following in this order:
Dagger
Mace
Cutlass
Scimitar
Broadsword
Kryss
Katana
Shuriken
Wakizashi
Plate Gorget
Circlet
Royal Circlet
Boomerang
Testing Notes:
I am seeing some hangups where the script makes the wrong item for a while and then they sit in your pack. I am going to put in a failsafe for this and a couple of other issues and put in a menu for tracking when I have time to look at this again next month.
I have been unable to reproduce Ultima's tinker kit error. not sure what happened there.
I just ran it from 40 to 100 smithy on a gargoyle with 100 mining and a 120 blacksmithing skill cap: 18,000 ingots and 2.5 hours.
The total for 40 to 120 smithy on that gargoyle was: 41,250 ingots and approximately 12 hours.
-
Updated the craft gumps for publish 65
-
Paul. Do a FINDITEM for daggers at the start of the script and ignore any in pack. So people don't get upset that you killed their newbie dagger. :)
-
I thought about that. I seem to remember not being able to smelt a blessed item recently and wanted to test it before I decided what to do with a blessed dagger. Seemed more generally applicable to have folks take it out of their bag until I sort that out. I suppose I could have it inventory your bag and ignore everything that you don't need for the script.
-
I thought about that. I seem to remember not being able to smelt a blessed item recently and wanted to test it before I decided what to do with a blessed dagger. Seemed more generally applicable to have folks take it out of their bag until I sort that out. I suppose I could have it inventory your bag and ignore everything that you don't need for the script.
Finditem * C_ , #backpackid
For #findindex 1 #findcnt
{
ignoreitem #findid
}
:)
-
It's a good ideas. I think I am going to start doing a backpack "cleanup" in my craft scripts that ignores the junk in your pack it doesn't need, or removes it if it will operate better without it in there.
-
Paul wanted to test this out as I need to 120 some chars on other accounts. I got stuck where it asked me to double click the tinker kit and hit play. Couldn't get past that part not sure if anyone else has tested this and had similar issues or if I'm overlooking something.
-
Did you use the round tinker kit or the metal pronged one? I have problems with some scripts if I don't use the round tinker kits. I'm not sure if this is your problem though.
-
I was using the round ones you reciece when crafting your own tinker tools via the tinkering menu.
Has anyone else given this script a go and gotten past the part I got stuck on?
-
Ultima,
I just finished some testing on this and could not reproduce the problem you are having. Have you been able to reproduce it? If you can and it is paused, you should be able to see where it is in the script by pulling up the script window. If you happen to be able to, it might help me to know what sub you were in when it happened. I suspect a lag issue and wonder if increasing the variable %gumpwait might help. If you look near the bottom of the script, %gumpwait is set at 1. Try bumping it to 3 or 4 and see if it helps. You are not likely to notice the difference.
Sorry I can't be more helpful. If you can get me more information I will keep looking at the issue.
-
Paul,
Next time I work smithing on a character I'll give it another go. Might be awhile until I shoot over to another shard.
Last time I 120'D SMithing which was last week it was done via the BOD Runner :P
-
running this right now. started at 50 skill and will report back on how it works. So far so good and up to 71.4 in a short time. zero hitches.
-
Watch out! Paul is turning into a scripting kinda guy!!
Makes one all warm and fuzzy. heh.
-
This is most likely the best blacksmith trainer I've ever used... Nice job Paul. :)
-
And I just went 50-99.0 using TurboSmith :(
I'll switch over once I stock up some ingots.
-
I just finished 120.0 skill from 50.0.
Very nice script and way more stable than the CEO drag drops. Great chart and continued movement through items to craft while saving ore. Man it is nice that you incorporated the new lower cost ingot items like boomerangs.
A few notes that I encountered along the way that could be addressed:
I had to 60 k stacks of ingots in the bag and when one of the two stacks, the one being dragged off of, go down to 238 ingots, it halted due to not reading the other stack in the pack. findindex might help with dragging resources when one stack gets low enough to set off the not enough resources.
once you reach 120.0 smith it stops and tells you you are done. when I clicked okay... it started crafting again. Not a big deal but a nice polishing step.
I did have it make a dragon barding deed at 87.0 skill and it glitch trying to make the deed a few restarts and it went away. it was supposed to make those head pieces at 87.0 and did once i restarted a few times. weird and not sure if it is a issue.
I say pretty darn close to moving into our approved library :)
-
Thanks for the Feedback C2, very helpful.
I think I have a fix for the ingot stack issue that I built for another script and will incorporate into this one on the next update.
I am having the same mis-fire issue on the tinker script and I need to find a good solution to it.
I will put these on my to do list. I also need to come up with a menu for my crafting scripts.
-
Thanks for the Feedback C2, very helpful.
I think I have a fix for the ingot stack issue that I built for another script and will incorporate into this one on the next update.
I am having the same mis-fire issue on the tinker script and I need to find a good solution to it.
I will put these on my to do list. I also need to come up with a menu for my crafting scripts.
I had zero of the issues that c2 mentioned. I hit play, targetted a pack, was 120, and celebrated good times. :) I love nice and simple scripts that do what they say.
-
I think i had the ingot stack issue because i had zero mining, SO I USED MORE INGOTS AND GO T INTO THE SECOND STACK PLUS SOME BAD LUCK OF THE REMAINDER OF THE STACK BEING JUST BELOW (oops damn caps) the too few resources amount. Good to hear others did not get the miss fire. Is that item at 87.0 skill the only item on the second page that is crafted. most seem to be on page one of the crafting list.
-
I think I made 120 last night. I was discon'd this morning with a "Congratulations, reached limit" message... couldn't log back in to ensure it was Legendary, I'll do that tonight and let you know how many ingots from 96-120.
-
96 - 120: 42792 Ingots with 0 Mining Skill
Not sure how long it took, overnighted it and it was finished in the morning.
-
Wow, that's not very many ingots all things considered...
-
From 100 to 120 on my ATL Gargoyle without mining 43,500 ingots. Not one hangup.
I'm not sure how long it took. I was gone all day.
-
That's one helluva script that can "fire and forget". Great stuff!
-
It really is. It was gaining pretty fast in the higher ranges. I watched it for a few when I was using it, and couldn't believe the speed of gains in the 100+ ranges..
-
Thanks for the positive feedback guys, much appreciated. Its a pretty simple script. The only thing that you could call an innovation over the existing library was taking a fresh look at the skill curve and ingot consumption. I have some refinements and failsafes to add in my next update, but I am pretty bogged down with work and other projects. Going to calendar the next update for the first week of August.
-
Using this again on a new smith, found a problem.
I have 3 stacks of ingots in the secure... 2 x 60,000 and the last stack was the one the script was using. When the last stack got down to 300 or so the script stopped and said I didn't have enough ingots.... even though there was 120,000 in the resource container.
Needs to look for other stacks when it finds the stack it's using is too small.
-
It really is. It was gaining pretty fast in the higher ranges. I watched it for a few when I was using it, and couldn't believe the speed of gains in the 100+ ranges..
I have to second that... ... i had an unfinished 80 something blacksmith and its tearings it way through it in the high 110s at present... Had a slight problem of it making the wrong thing pre boomerangs on one occasion... but i might be running a older version than is posted here..
Great script Paulonius
-
Its due for an update... I just need to get my stuff more organized.
-
great script. Used it last night. Started with 0 blacksmithy. Bought it up to 40 then did the quest to get to 50. From 50 to 120 overnight with less than 50k ingots. Had no issues at all. Awesome script, simply set up. thanks for the great work.
-
Update 27 Sep 2010 - Version .20 (In Testing)
Added code to account for multiple ingot stacks in secure
Added code to apply Siege Perilous RoT timer waits when the script is run o Siege
-
unfortunately, i'm seeming to have a similiar issue like C2 did with a misfire. However, i didn't craft anything.. at around 97 skill it started crafting light cannon balls instead of the royal circlets.. Trying a few restarts now to see if i can't get it to fix itself. Great script otherwise, keep up the good work ^_^
-Edit
***Okay.. figured out what the problem is.. with the addition of High Seas, theres a new cannon menu. [duh.. totally a slap your forehead moment on my part] So under the item thirteen sub for boomerangs, the "Set %YClick1 230" line needs to be changed to "Set %YClick1 250" Runs smoothly from then on.*
-
I modified version .30 and reposted it with an improved check for misfires and some modifications to the Siege rule set timer.
-
Used the new version .30, worked great to about 103 got a lil buggy were it needed to be reset a few times. I let it go for a few just to see what would happen and it almost seems a cpl of the gain inbetween went into a RoT mode for a few tenth's. Im at 104 now ill keep the results updated.
-
It should never got into ROT unless you are on Siege. I will take another look at it.
-
It should never got into ROT unless you are on Siege. I will take another look at it.
Honestly it may have just been a little buggy and needed to be reset due to lag or just natural crap causes that happen. Its working great right now im at 119.7 should be done within the hour.
-
Alright time to test this one out.
Started: 3:30pm EST OSI Shard w/ 106k Ingots in the chest. I'm GM Tinker, and 80mining not sure if that has any impact on anything but might as well put everything out there for the testing.
Totals:
Time: 11hrs 41minutes
Ingots used: 48,482
Skill Level: Started @ 32 Finishing at 120.
No hangups or issues. Ran smooth the entire time. A+ on this one man.
-
80 mining will hurt your return on smelting. Maybe put on some ring gloves to raise it. GM is better
-
80 mining will hurt your return on smelting. Maybe put on some ring gloves to raise it. GM is better
yea I put gloves and pickaxe(from quest) to gm it during the training. I couldn't stand to click the mountain wall 2000 more times.
-
Hello all im having alittle problems with this script i m guessing the menu change and bomerangs are not the same...... Because....
Im at 102 BS... and the version .30 started making bacinets... When it finish it didnt melt the item and the tool kept spawning Need more ingots for that.........
Ive try the older ones to get any luck...
but they made cannon balls....
Anyone having this problem???
or know what to twig to make the right stuff?
-
This is a great script, fast AND economical :) The only thing that could make it better is a skill tracker menu but apart from that its perfect :D
-
Hello all im having alittle problems with this script i m guessing the menu change and bomerangs are not the same...... Because....
Im at 102 BS... and the version .30 started making bacinets... When it finish it didnt melt the item and the tool kept spawning Need more ingots for that.........
Ive try the older ones to get any luck...
but they made cannon balls....
Anyone having this problem???
or know what to twig to make the right stuff?
im in the same boat that you are.
the script has run like a dream, im up to 98.6 and it switched over to Plate Helms and seems to be stuck there.
im gonna crawl into the script tonight and see if there was a menu change recently.
im assuming it will just be a matter of changing the item 12 settings for royal circlet.
anyone know off hand?
**EDIT** k, so i went in and stopped the script and made a royal circlet by hand and hit run again and it seems to be running smooth once more.
** 2nd EDIT** all right, so it ran smooth to 100.1 then switched over to boomerangs like it was suppose too, now its purring along just fine. im assuming that there was just a ghost in the machine there and a lag spike hit and messed up the script for a moment, as it seems to be running flawlessly once more.
-
I've noticed that at around 72-76 blacksmithy it doesn't smelt the items it makes and the bag becomes full.
-
I had similar issues with it filling up the backpack until I reached 100 or so and it started making boomerangs. I just used this script yesterday to 120 my Crafter.
Once it started the boomerangs which is the home stretch it worked fine. It's a very fast trainer, much faster than CEO's despite the hiccups.
-
I am starting to get a bit more active again and should be able to look at this in the near future. Thanks for the comments.
-
Is it work with a human and 90 mining?
-
Is it work with a human and 90 mining?
I used it twice with a human and 0 mining. I took it from 25 to 120 blacksmithy and it worked fine so a human with 90 mining should be fine. :D
-
Thanks:)! Just checking.
-
Very good script other than that stack issue. I tried a workaround for this but not too sure whether it works perfectly or not. Appreciate feedback on this modification.
Change the LoadMaterials sub with this one and also add another sub.sub LoadMaterials
finditem %Ingots C_ , #backpackid
if #findstack < ( 100 * %itemingots )
{
set %quantityinpack ( ( %itemingots * 100 ) - #findstack ) ; 2000 - 20 = 1980
lp1:
gosub CountIngot
set %cnt1 0
if %sumIngot < %quantityinpack
{
display You need to place more ingots in your Resource Secure and restart the script.
halt
}
else
{
lp2:
finditem %Ingots C_ , %ResourceSecure
if #findstack < %quantityinpack
{
set %cnt1 %cnt1 + 1
if %cnt1 > %IngotStackCount
{
exevent drag #findid #findstack
wait 10
exevent dropc %ResourceSecure
wait 20
goto lp1
}
ignoreitem #findid
goto lp2
}
else
{
ignoreitem reset
exevent drag #findid %quantityinpack
wait 10
exevent dropc #backpackid
wait 20
}
}
finditem %Tinkertools C_ , #backpackid
if #findcnt < 2
{
gosub MakeTinkerKit
gosub skillcheck
}
Return
and the new sub is this:
sub CountIngot
finditem %Ingots C_ , %ResourceSecure
set %IngotStackCount #FINDCNT
for %i 1 %IngotStackCount
{
finditem %Ingots C_ , %ResourceSecure
set %ingotstack . %i #FINDID
set %sumIngot %sumIngot + #FINDSTACK
ignoreitem %ingotstack . %i
}
ignoreitem reset
return
I didn't test it throughly but it should work in theory.
-
I know Paulonius love to get statso here the result.
Started at 50 smithing with Gm mining and 90 tinkering. and eat 115 scroll
stated at 09h00 with 34k ingots and finish at around 21h00 with 1585 ingots left. The gain was fast at first and slow down after GM. I did had to restart the script at GM since it was making bascinet. It was the only problem that I encounter.
-
Started a new guy again, and it been a nightmare. It work fine until katana. then I stop smelting then, restart make the shuriken and at 75 get stuck. wont smelt again. supose to make Wakizaki and them make broadsword. weird. I did eat a 120 at the start. I restart multiple time. still the same.
-
I actually moded this script to work for RebirthUO. So if anyone is interested I can post it for ya. Basically all I did was verify and slightly change click locations and item types.
-
Just wanted to say its working good for me as of 3-16-2020. I love the easy setup and love the no extra glitz.. it just does the work and gets it done.. thank you for the script. I'm human with 0 mining,, went from 0-91.7 so far with 0 issues.
-
0-120 smith in 8 hours, used 45K ingots. Twice it started making the wrong item, but restart fixed it. Thank you for all your work. MUCH easier to use than CEO's.
-
ran it up to 115 last night no problems at all
-
Finally got a 120 scroll
115-120 no problems @ all around 8k ignots