Help with an abandoned script?

[darian]

There is a script over on EUO that is Abandon-ware. Extreme Potion Keg Crafting by Mr. X, its the only one that still works, only cause someone updated it recently, but in the last month it has really gone downhill. i have posted a couple times to see if that person could try to fix it, it has gone from taking approx 45 seconds per keg to sometimes almost 3 minutes per keg. and even sent a few Pm's all to no avail. the updated version of it is located here http://www.easyuo.com/forum/viewtopic.php?t=11340&postdays=0&postorder=asc&start=225. If someone could maybe look at it that would be so awesome. Again, Thank you all..

[UOMaddog]

Thanks for following the correct protocol regarding scripts that aren't your own! It's nice to see people following the rules!

As for your question, I remember making a UOAssit macro to make a keg and then using uoloop to make a ton of them. Not the greatest solution, but it worked! Maybe C2 can add this to his Alchemy script or Keg Emptier!

[darian]

ya, thats what i had to end up doing. i would love to see that script fixed, lol, thanks for the quick response though.

[Masscre]

No promisses but If I have time at work tommorrow i will have a look at it ?!

[darian]

That would be GREAT!!  I just cant figure out why it suddenly got so blasted slow

[12TimesOver]

LOL, funny to see that one show up. That was the first script I ever put in some serious testing on when it was in development, went back and forth with Mr X dozens of times and got a good feel for the work that can go into something that seems so simple. I used it a lot. I actually d-loaded it again recently thinking I might have a go at cleaning it up and resurrecting it a bit for nostalgia's sake.

Anyway, not sure that I'm actually volunteering or anything, but it would be great to see it come alive.

X

[_C2_]

Thanks for following the correct protocol regarding scripts that aren't your own! It's nice to see people following the rules!

As for your question, I remember making a UOAssit macro to make a keg and then using uoloop to make a ton of them. Not the greatest solution, but it worked! Maybe C2 can add this to his Alchemy script or Keg Emptier!

Ah, nope!  That was designed to be bottles only.  Not to mention the freeze on my coding ATM.

[Masscre]

Looked over it some today and going to have another look at it later.  Just some info what issues are you have with it and please list all so I know what to look for. thanks.

[darian]

Only having one issue that I know of.. It makes the kegs just goes super slow, like i said, last month it was making them about 45 sec per keg, now its like 3 minutes per keg.. Kaliofls re worked it once a few months back to make it work again and it was working awesome, his working copy is located on page 16.

[12TimesOver]

Only having one issue that I know of.. It makes the kegs just goes super slow, like i said, last month it was making them about 45 sec per keg, now its like 3 minutes per keg.. Kaliofls re worked it once a few months back to make it work again and it was working awesome, his working copy is located on page 16.

It's likely something related to the gumpwaits and gump timeouts as the gump size changed again an dmost people use the size in their gumpwait subs. I haven't looked at the script yet, I'm just guessing.

X

[luv2luvlong]

The best way for you to figure out if this is the case is to use scriptuo.
Open the file w/SUO, in the right hand pane check out the gosubs for gump waits and see if the size (if there are any) of the gumps have changed by comparing them to the container size in EUO (assuming of course you have the crafting gump as the top most gump on your screen). If they are different change to the new size and it should speed up the process.

Remember ScriptUO is your friend for fixing these types of problems.

[12TimesOver]

Already ahead of you

Code: [Select]

;================================================================================
; Waits for the crafting gump to close.
; %1 = timeout to use.
;================================================================================
Sub WaitForCraftingGumpToClose

namespace Push
namespace Local WaitForCraftingGumpToClose , _ , #time , #random

set !timeout %1
gosub WaitForSysVars contSize <> 530_507 contName <> generic_gump !timeout

namespace Clear
namespace Pop

Return

;================================================================================
; Waits for the crafting gump to open.
; %1 = timeout to use.
;================================================================================
Sub WaitForCraftingGumpToOpen

namespace Push
namespace Local WaitForCraftingGumpToOpen , _ , #time , #random

set !timeout %1
set !waitUntil #sCnt2 + !timeout
gosub WaitForSysVars contSize = 530_507 contName = generic_gump sCnt2 > !waitUntil

namespace Clear
namespace Pop

Return

What are the new gump sizes (I'm at work and have none of my stuff)? Are these correct?

X

[luv2luvlong]

Sorry that was more for darian, I try to teach someone to fish rather than fishing for them. But as soon as my script as finished its current cycle  i'll check for ya, if someone dosen't beat me to it.

[12TimesOver]

LOL, I was desperate to throw a line in so whadya gonna do?!?!

[luv2luvlong]

current  size 530_497
 
and there you go


edit
carp and tink