ScriptUO

Official ScriptUO EasyUO Scripts => Site Scripter Libraries => _C2_ Script Library => Topic started by: _C2_ on April 30, 2009, 06:07:47 PM

Title: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on April 30, 2009, 06:07:47 PM
I wrote this due to guildies really needing a stable potion maker that didn't freeze up or space out on them after making a few 1000' pots. The result is a potion maker that you can make an insane amount of pots with while u are afk. Take a nap and run this baby- fill a vendor or whatever you want!
Screen shots of menus down below!

Sorry non-osi- I know kegs are better for you (found out after the fact)

What it does!
*Makes every single potion in the game!
* If you run out of regs/resources, the script will jump to the next item and leave you a different message at the end of the order that says you had one or more items uncompleted due to resource shortage but it will not halt and make you wake up with the rest of your stuff unmade when you come back to the comp.
*has gump waits so lag WILL NOT leave you in an endless loop for hours
*makes pots in bottles since they are stackable and are only one slot now. So easy to pull of a stack!
*makes smoke bombss

You can run it without tinker by making your resource bag full of tools... change this line:
;========================================================================================================
;To control tinker skill use:
set %tinker #true    ;#false for no tinker skill
;========================================================================================================
It looks in secure for tinker tools so craft a bag of tinker tools and lock it down.  then put bottles and supplies in.  Much faster and easy to maintain.

What it needs:
Code: [Select]
;Directions:
;Have one bag with all of the supplies needed to craft on the top level.
;ingots, morters (if not tinkering), empty bottles, regs, items for special poisons and at least one tinker tools in your pack.
;Have a second bag in the secure to drop finished potions.
;hit play
;check boxes for each type you want !!!AND!!! then enter how many of each you want!
;Tips:
;A nice alchemy tally with a high Alchemy Bonus Would be sweet!
Fixes:
6/14/08 - adjusted naming to deal with iron ingots only showing as ingots. picks up ingots correctly now
2/23/09 - fixed tool crafting subs/ upgraded and fixed a few other bugs
11/17/09 modified ingot selection/ignore process as to suggestion
;10/17 fixed new gump categories
10/18 fixed a mistake on grater cure position
6/6/12 - untested fix for not checking for secondary stacks of regs added

Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Khameleon on May 04, 2009, 03:16:24 PM
hey, C2, did I ever give you my Smoke Bomb Add-on?
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on May 04, 2009, 03:57:28 PM
hey, C2, did I ever give you my Smoke Bomb Add-on?

no you didn't but i did add to smoke bombs to the cooking script.  i would still like to see what you did and add it in and give u credit for it on the script
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on September 28, 2009, 03:03:12 PM
updated for SA menu changes... Happy crafting!
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Khameleon on September 28, 2009, 03:10:52 PM
LOL I just made the changes myself went to post the update, and look at you.. beat me to it.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Khameleon on September 28, 2009, 04:33:11 PM
its trying to make a jointing plane instead of Mortars... its clicking wooden items instead of tools.. I believe changing the 30 to a 40 should fix this problem.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: TrailMyx on September 28, 2009, 04:43:26 PM
The selection index (left side) has a new selection, so everything goes down by 1.  Easy change when using Machine's craftItem sub.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Khameleon on September 28, 2009, 04:56:08 PM
line 645 changed to
gosub click 30 130 generic_gump   ; selects tools for new crafting
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on September 28, 2009, 07:31:30 PM
line 645 changed to
gosub click 30 130 generic_gump   ; selects tools for new crafting

thx - thought i got it all - fixed same version
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Bagenholt on September 29, 2009, 09:17:33 AM
Hello ^^

  Is there by any chance tools can be used inside bags instead of being only in your main pack? I don't have tinkering on my alchemist since I just stone alchemy on and off my archer. So, currently I just make a large amount in a bag and transfer it over to my alchemist and then move each tool into that chars main pack. The script is am amazing help as is but I thought this addition would streamline the pot making process for others that don't have a dedicated crafter for alchemy.

Thank you for such an excellent script! I didn't expect it to be that much faster than the new options 'make max' in the crafting gumps but, wow really fast than when I was making pots unaided.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on September 29, 2009, 10:43:17 AM
Hello ^^

  Is there by any chance tools can be used inside bags instead of being only in your main pack? I don't have tinkering on my alchemist since I just stone alchemy on and off my archer. So, currently I just make a large amount in a bag and transfer it over to my alchemist and then move each tool into that chars main pack. The script is am amazing help as is but I thought this addition would streamline the pot making process for others that don't have a dedicated crafter for alchemy.

Thank you for such an excellent script! I didn't expect it to be that much faster than the new options 'make max' in the crafting gumps but, wow really fast than when I was making pots unaided.

That option to drag tools is in the header/set-up at the top of the script I believe.  I don't think I took it out ever.  It was a drag tool out of resource feature

Just looked over the code and I could modify it slightly to drag from any open container.  Right now it drags from your secure only.  Your best strategy until i post a new version will be to craft a full bag of tools and lock it down.  then put bottles and regs in it as your secure.  I will adjust this feature in the next few days though.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Wilk on September 30, 2009, 07:03:21 AM
Nice. New version worked like a charm.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on September 30, 2009, 07:19:21 AM
I have been loking at the code for the drag option and did notice a way it could be more efficient.
I could modify it slightly to drag from any open container.  Right now it drags from your secure only.  Your best strategy until i post a new version will be to craft a full bag of tools and lock it down.  then put bottles and regs in it as your secure.  I will adjust this feature in the next few days though.

fo now change tinker to false at the top of the script and make  special secure.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Bagenholt on September 30, 2009, 03:51:20 PM
Ah awesome I'll try it out. To be honest I didn't look at any of the code *blush*
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: danger mouse on October 19, 2009, 04:55:15 AM
this is the fastest and best potion script ive ever used thanx c2
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: gen2000 on October 24, 2009, 08:21:21 AM
I'm testing out your script and..

I had to change this..
Code: [Select]
sub set_ingots
finditem ENK C_ , %secure
for #findindex 1 #findcnt
{
Event property #findid
if copper || shadow || bronze || agapite || gold || verite || valorite in #property
   ignoreitem #findid   
if ingots in #property && shadow notin #property
   set %ingots #findid
}
return
It would ignore my valorite ingots last.
It would then set my valorite ingots to %ingots because they were still #findid.


To this..
Code: [Select]
set %ingots ENK ;I just added this with all the other varibles..

sub set_ingots
finditem %ingots C_ , %secure
for #findindex 1 #findcnt
{
Event property #findid
if copper || shadow || bronze || agapite || gold || verite || valorite in #property
   ignoreitem #findid
}
return
This will ignore all colored ingots and only leave iron..


I also added.
menu HideEUO ;Before the menu (Drives me crazy when a menu pops up behind euo and I have to minimize to see it.) ha!
menu Hide ;Before container setup (I would also have to minimize the menu so I could click on the "ok" to target containers)

Besides that it works flawlessly, great script!

Thanks,
Genesis

Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on October 24, 2009, 09:23:17 AM
Excellent good finds.  this has been out for ages and no one found that.  once i saw you first thing about ingots i immediatly saw why it happened.  i never run it with more than iron.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Khameleon on October 25, 2009, 05:35:04 AM
same here, I only keep iron ingots in resource bag as well :)
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: msb9380 on November 10, 2009, 03:51:22 PM
Just started running this script as of today, and so far so good. Very fast and efficient way to handle making potions. Well done sir.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Oracle on November 30, 2009, 12:58:54 PM
Another great script C2!  Use this script about once a week now because of all the greater poison and greater cure potions that my plants madly drink up...

Would you please, when you get time add the option to add this to kegs, as Gardening uses kegs and not bottles?  Right now I just dump the bottles into the kegs, so it is no big deal...just a request.

Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on November 30, 2009, 01:25:04 PM
Another great script C2!  Use this script about once a week now because of all the greater poison and greater cure potions that my plants madly drink up...

Would you please, when you get time add the option to add this to kegs, as Gardening uses kegs and not bottles?  Right now I just dump the bottles into the kegs, so it is no big deal...just a request.


I won't be adding  kegs but there is an updated hort-o-matic2 version in the second to last page of the comments that is updated to handle potion stacks.  It recognizes my stacks so i don't have to do kegs.  it is worth grabbing.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Oracle on November 30, 2009, 01:41:09 PM
Found it, C2!  I wont worry about using Kegs from now on since that works, plus my wrist is spared seperating all those seeds from the stack of seeds into 120 seperate seeds!

Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on November 30, 2009, 02:21:12 PM
Found it, C2!  I wont worry about using Kegs from now on since that works, plus my wrist is spared seperating all those seeds from the stack of seeds into 120 seperate seeds!



Yeah , nice improvements on that one right!
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: darian on December 04, 2009, 02:36:46 PM
this is awesome!! makes pots faster than any other. Great job!!
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Oracle on December 19, 2009, 04:50:26 PM
C2,

Was running this today and when the menu said to make 1000 Greater Explosion Potions the script started to mess up.  Looks like the gump positions changed?   I also tried making the Greater Explosions as the only ption and it did the same thing.

Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on December 19, 2009, 05:09:58 PM
C2,

Was running this today and when the menu said to make 1000 Greater Explosion Potions the script started to mess up.  Looks like the gump positions changed?   I also tried making the Greater Explosions as the only ption and it did the same thing.



is there  a new potion on the page?  what did it make for u instead?  was it the smae item both times that was made?
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: jesterboo on February 13, 2010, 02:23:17 PM
awesome script, just one of many of them i was looking for. works flawlessly
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: darian on March 04, 2010, 09:44:53 PM
C2, I use it dailly to fill my vendors with no trouble on any potions. I make 2500 each, every night. works flawlessly for me.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Pyargy on March 05, 2010, 02:59:49 PM
Tried this for the first time today and although I have few issues I was able to produce 1000 each of GH, GC and TR.

Some of the issues I had were, the script would grab the correct reagent but then it would try to make the wrong postions and say I was out of that reagent and just loop.  Restarting script seemed to right itself and work the second time around.

I was using the tinkering feature to make Morters, but when Tinker kit broke script haulted with no more tinker kits. I was expecting it to just make more tinker kits, but no biggie I just made sure I had a bag full before restarting script.

When I did restart script something a bit odd happened as it started making the last postion instead of starting at the begining again so it grabbed the correct reagent but then started making the last potion it was making before script haulted for not having tinker kits.  Again a simple restart right itself and it finished my order.

Thanks for another quality script.  Nice to know whe can still get scripts that just seem to work with out trying to futz with outdated ones.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Hoby on April 02, 2010, 03:55:47 AM
Hey c2 does the gump need to be updated again, thought someone said the gump size changed again since last patch.  Only way i can get it to work is to make the first one then it will make last.  thanks.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on April 02, 2010, 04:45:19 AM
Hey c2 does the gump need to be updated again, thought someone said the gump size changed again since last patch.  Only way i can get it to work is to make the first one then it will make last.  thanks.

yes gump changed but it does not effect this script.  i could not find any old gump sizes that would affect it even in the tinkering part... gump sizes and names are for osi

i have seen it make incorrect stuff after a stop restart.   not sure how that is happening but it is rare and tends to happen with weird stops and restarts.

I will investigate the tool issue.  it should of made more early on during tool check loops unless all your tools were really low on use count and it did not complete a cycle before it looked at them.  it doesnt count uses but still really weird.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: sozy336s on August 12, 2010, 05:47:06 AM
Great job on the script gmed in less than 1 day!
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Magier on August 15, 2010, 11:55:09 PM
Man this thing rocks, i just wish UO hadn't made it so you can't put egg bombs in stacks anymore  :(

made tons n tons of pots with this n no problems yet!  awesome job!
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Khameleon on August 16, 2010, 01:03:30 AM
My smoke bombs still stack? are you on a Production shard?
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on August 16, 2010, 12:02:13 PM
Man this thing rocks, i just wish UO hadn't made it so you can't put egg bombs in stacks anymore  :(

made tons n tons of pots with this n no problems yet!  awesome job!

egg bombs don't stack but smoke bombs do stack with this script.  it is cooking that makes egg bombs that don't stack for whatever brilliant EA idea that was.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Khameleon on August 16, 2010, 02:18:31 PM
Oh. Sorry i never made em with my cook.  Whats the dufferance?
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on August 16, 2010, 03:25:42 PM
Oh. Sorry i never made em with my cook.  Whats the dufferance?

thye work the same... look the same... have different names.  oh yeah and the biggy!!!!  they don't stack when made by a cook and are named egg bombs.  so silly why would they let that continue to go on for over a year.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Outlaw Josey Wales on August 16, 2010, 03:49:19 PM
Oh. Sorry i never made em with my cook.  Whats the dufferance?

thye work the same... look the same... have different names.  oh yeah and the biggy!!!!  they don't stack when made by a cook and are named egg bombs.  so silly why would they let that continue to go on for over a year.
Good Question but in the grand scale of things mythic just likes to piss us off by doing little things like that
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Magier on August 17, 2010, 10:01:06 PM
the other big difference with egg bombs is they take an egg and flour so the cost is WAY lower, thats why i loved them when i made them.

Powder of fort, power crystals and a ton of other items on OSi shards need to stack but dont
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Magier on August 27, 2010, 07:33:01 AM
I've been using this script for a quite a while now and love it,  thanks so much for putting it up.

I am finding one small problem tho, when i start it up in the morning if i haven't reset UO or euo it tends to try to make the last potion i was making ie like greater heals are what i want to make but i was making greater refresh it trys to make the refreshes.  if i close out and restart the script completely it doesn't do that.

also would it be hard to put in a pause in the script itself or it just easier to use the pause in the EUO program itself?  i sometimes get glitches if i pause thru euo
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Khameleon on August 27, 2010, 08:18:06 AM
If you puase it in eou. When you restart you need everything to be exact when you restart it. Bags open. Also open the last menu and make sure that window is most top. Click the window then you should be ok.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on August 27, 2010, 09:28:11 AM
the restart could be all the containers as Kham said or it could be a easy up bug or client bug.  It is not a scrpit issue.  I have seend other scripts get off too and closing everythign and reopening is teh only way.  I am 99.9% sure that the code is in there for a pause button but the button on the menu may of gotten covered by the smoke bomb line.  interesting, ill have to peek at that
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Khameleon on August 27, 2010, 11:05:18 AM
Ya i thought i moved the pause button on my version but i dont think it was moved on the last release. While your in there take a look at the finished smoke bombs.  Its not in the right location.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Magier on August 31, 2010, 06:45:43 AM
Thanks so much for the help, you guys are awesome and always fast about helping!
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Adenocard on October 03, 2010, 12:13:39 PM
Man I love this script so much, I have made a little side business with potion making from it.  Thanks again so much for this ,,
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on October 05, 2010, 05:27:46 PM
i went into the old versions and there is no evidence there was ever a pause button.  ugg.  messing with it now
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on October 05, 2010, 05:44:11 PM
2.1 should have the functioning pause button now.  it will check in the making sub each pass to see if it needs to be paused.  untested
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Khameleon on October 05, 2010, 05:52:54 PM
while your digging around in there, can you make it not halt if you run out of regs and move on to the next potion? or pause if you run out of bottles so you can restock then resume?
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on October 05, 2010, 06:23:39 PM
while your digging around in there, can you make it not halt if you run out of regs and move on to the next potion? or pause if you run out of bottles so you can restock then resume?

errr... i already finished for the night lol.  i thought it moved on.  i will look at that too but not tonight.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Magier on October 05, 2010, 08:17:54 PM
i went thru and tested the thing and it runs just fine but when you use the pause button and click to resume the button just disappears, so it does work but only once :)

Thanks for getting this added you rock
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Tidus on October 06, 2010, 12:17:26 AM
C2, in your pause routine i think you have a small error
Code: [Select]
sub menubutton
if #menubutton = pause
    {
    gosub pause
    menu delete resume
    menu Font Color Green
    menu Font BGColor White
    menu button Pause pause 430 5 75 25 Pause
    }
return

I believe you need to changemenu button Pause pause 430 5 75 25 Pauseto menu button pause 430 5 75 25 Pause
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Magier on October 06, 2010, 12:54:24 AM
that fix did make it so the pause button works, thanks for all the help guys
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Khameleon on October 06, 2010, 01:16:19 AM
ya, I get it.. toss it in the new feature when I feel like it list :)
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on October 06, 2010, 05:34:25 AM
ha darn typo.  fixed typo.  i will look at kham's request later tonight after work if I still have juice.  it will be a really late one tonight.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: blazehammer on October 15, 2010, 09:28:22 AM
well folk  the tool to make potions have changed  but  we can still use it  to make potions  when it make the first one pause script and make the first potion and it will will the rest that you want have to do that for each potion you want to fill so takes some patience just thought i would let every one know.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on October 15, 2010, 09:39:38 AM
it sounds like you are trying to say that the make last works but the main potion locations on the gumps have changed some
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on October 15, 2010, 01:53:25 PM
new gump categories added... enjoy it while it lasts LOL. 
2.2 post high seas.  should work fine i just swaped out locations
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: agirl on October 15, 2010, 04:57:48 PM
Thank You C2!! As always, you are the best and keep me in business!!!
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Adenocard on October 16, 2010, 03:09:52 AM
Hey C2, I noticed that when you go to make greater cure potions its not doing so, its hitting the cure potion instead not sure why but now I have 8k cure instead of greater cure lol... Think its just a change in location in the menu but i thought i would pass on the information.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on October 16, 2010, 08:03:26 AM
Hey C2, I noticed that when you go to make greater cure potions its not doing so, its hitting the cure potion instead not sure why but now I have 8k cure instead of greater cure lol... Think its just a change in location in the menu but i thought i would pass on the information.

fixed, i listed it as the seventh location instead of the 8th pot in that section.  my bad.  sorry about the reg loss but fixed now
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Adenocard on October 16, 2010, 11:11:07 AM
Ah I'm not worried about reg, I just script that too lol... Just wanted to be helpful is all
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Khameleon on October 18, 2010, 07:34:10 PM
C2: I love how easy it is to add items to your potion factory here..
this next tweak is a little more work since it doesn't require bottles.. but I think I'll have something for you in the next week or so. :)
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on October 18, 2010, 07:39:46 PM
C2: I love how easy it is to add items to your potion factory here..
this next tweak is a little more work since it doesn't require bottles.. but I think I'll have something for you in the next week or so. :)

hehe, we could make it C2's and Khameleon's Potions and more maker.  The sub is pretty generic.  i could of made it all one sub with variables but I don't think I had learned them yet.  It is a beginning scripters dream as far as being easy to follow for sure!
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: snoogans on October 19, 2010, 08:20:46 PM
I'm having trouble with the scripts since the High Seas expansion.  I'm assuming it's just some targeting that has to be fixed.  Is there any way a script newb could do this?  What do I look for?
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Khameleon on October 20, 2010, 01:40:51 AM
you can look in two places.. about 5 posts up "called reading the thread" and it will say that C2 has put in some nice expansion updates at
the second place... the begining of the script where he has already posted the Post High sea's updates....
thank you for visiting and have a nice day :)

on a second note C' I have a working Black Powder, and Potash so far :)
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Khameleon on October 22, 2010, 01:55:50 AM
LOL I Shut down the factory... I'll have to see what I did to break the rest of the potions :P
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Magier on October 27, 2010, 01:34:36 AM
On the Potash and Black Powder subject, are either of you 2 gonna be trying to mesh it in with this script?

those 2 items are a major pain to make.

Thanks for all the help you guys do for us on these scripts it helps all who use them.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on October 27, 2010, 05:44:23 AM
On the Potash and Black Powder subject, are either of you 2 gonna be trying to mesh it in with this script?

those 2 items are a major pain to make.

Thanks for all the help you guys do for us on these scripts it helps all who use them.

Kham hinted at it above in posts but then said he got it going with all the pots not working.  I personally am waiting to see what easy uo does with the converter before i work on the script.  if it plays still, I will make some changes and/or convert it.  outside of things like the last gump change ... I am in a holding pattern and reading open easy uo stuff
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Khameleon on October 29, 2010, 12:15:19 PM
sorry guys my modem broke on my last week I just got a new one up and running today... if EUO does update I will continue to work on this.. so please stay updated...
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Magier on November 01, 2010, 06:20:34 AM
Ouch gotta love when our technology we have to have breaks and you just dont have it no more.  esp if your renting the modem or router from your isp and they take there sweet a$$ time to get you a replacement out or are jerks about replacing it.

hope everything stays working good for ya
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: gimlet on November 01, 2010, 10:22:12 AM
I need to train in Alchemy - is this a good script to do this?
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on November 01, 2010, 11:06:02 AM
I need to train in Alchemy - is this a good script to do this?

i have a few times.  it does not have a skill gain chart so you pick one pot at a time and have it make several thousand.
rinse and repeat.  I like it but not like a 24/7 skill trainer
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: gimlet on November 01, 2010, 11:13:03 AM
Thanks - I normally don't do much unattended training but like a script that doesn't require my full attention.
I plan to use this starting at 50 - so I'll give it a try - thanks again.

0 - 30: Train at NPC Alchemist.
30 - 45: Agility Potion.
45 - 55: Total Refreshment Potion.
55 - 65: Greater Agility Potion.
65 - 75: Greater Strength Potion.
75 - 85: Greater Heal Potion.
85 - 98: Greater Cure Potion.
98 - 100: Deadly Poison Potion.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Khameleon on November 01, 2010, 02:39:35 PM
the script works great for training, its also the most profiting skill to train. as C said.. there is no skill gain table installed into the script as long as you know what to make and when you win....
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: gimlet on November 01, 2010, 03:18:36 PM
Great - It is very fast and no problems so far - thanks!
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: gimlet on November 02, 2010, 06:17:10 PM
I GM'ed Alchemy using your program makin the following

Started at 50
50 - 55: Total Refreshment Potion.  made 200
55 - 65: Greater Agility Potion.       made 100 then switched to GS
65 - 75: Greater Strength Potion.    made 837
75 - 85: Greater Heal Potion.          made 800
85 - 98: Greater Cure Potion.          made 2028
98 - 100: Deadly Poison Potion.       made 388

Thanks!

One word of advice - always keep plenty of reagents in your secure so you can pick exactly how many you want to make and have no fear of running out.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Magier on November 03, 2010, 10:06:51 AM
thanks for the info on what it took you to GM man
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Darkfallplayer on April 28, 2011, 09:22:09 AM
awesome script mate
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: vikesrock on July 26, 2011, 06:50:51 PM
Great script.  Thank you for your time and effort on this.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: SolidSnake on July 31, 2011, 05:22:22 AM
So many folks using this and most forget (myself included) to come post about it.

C..this is absolutely one of the best and most stable scripts running out there.

Never breaks, always 100% accurate and usefull beyond description.

Thank you for your time and effort to create effective perfection.

Personally, I couldn't even think of anything I could even recommend to be added to it.

This is a 5 star script.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Neo on July 31, 2011, 05:45:44 AM
I tried this out for the first time yesterday. I wanted to make potions for my plants... I'm currently growing 1500 plants, so you could imagine what I'd have to go through to make the potions without this script right? :) This is great stuff, worked like a charm...

Great job C2...

Thank you for sharing it with us!
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: gimlet on July 31, 2011, 07:16:55 AM
And of course it works great for kegs also no matter what the title says!!
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on July 31, 2011, 08:42:11 AM
Thx for the kind words everyone!  I wrote this for a guild mate that was bummed out when our old friend Roke's script stopped working back in the day.  It was because of all the requests from friends that made this one happen long ago.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: NObama on August 07, 2011, 10:15:00 AM
Brilliant.  I'm running it right next to the toon running 12X's poison trainer!  93.5 since about 2002...finally going to GM.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: NecroFox on August 29, 2011, 08:59:04 PM
TYVM C2 great script love it
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Goliath on August 30, 2011, 04:59:19 AM
Yes... This is a beaut!  I wanted to work up poisoning but didn't have an alchemist and faced the problem of getting the normal poison to train.  I did have alchemy on a stone but it was only at 70.1.  I got me a good talisman and put this script to work.  I have been making poisons in 1000 increments and then using the Guadah's Multi-Skill Trainer to work the poisoning on another character.  The tag team affect is working flawlessly.

Currently poisoning is at 88.3 and my alchemy has also worked up to 93.1 and climbing:)

I figure I will for sure GM alchemy with this script just from making the poison potions needed to train poisoning.  A double whammy in my mind:)
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Hollywood_Shono on September 23, 2011, 11:12:20 AM
Can this be updated with the new Alchemy Menu... it seems a lot of the pot locations have changed so its not making the correct ones.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on September 23, 2011, 02:24:41 PM
Can this be updated with the new Alchemy Menu... it seems a lot of the pot locations have changed so its not making the correct ones.

when did this new change on OSI take place?  this last patch?  i had updated for the last change.  if there is a new one again in this last patch, i will certainly update
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on September 23, 2011, 07:21:58 PM
yep, 2.2c still works and has the correct menu.  i think you opened an old version or something.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Hollywood_Shono on September 24, 2011, 10:42:48 AM
Yeah sorry I got  it to work something was screwed up on my side. I apologise!
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on September 24, 2011, 04:17:05 PM
Yeah sorry I got  it to work something was screwed up on my side. I apologise!

Just glad they didn't mess with he menu again.  I set it up so it is fast to adjust for future changes but still not too much fun to adjust.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on February 15, 2012, 10:09:22 AM
What was the change you made?  Freeshard or osi.  I hadn't seen any changes to the menu on osi.  Maybe I missed one.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: dxrom on February 15, 2012, 01:41:38 PM
Theres only one issue that I have ever had with this script, and that is that when the stack of regs it is using to make pots runs out, it doesn't search for another stack, it just ends the script and says all potions were finished, despite 300k more of that reg being in the resource container.

Other then that, this is THE script I always use for stuff likethis :>
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on February 15, 2012, 01:58:07 PM
it is on a freeshard Runuo Demise.  im not 100 percent on what fixed it,  what i did was change the x and y coords on the "make last" line.  i also added more letters (like ABC etc) for tinkering tool ids.  im not sure what happened but after that it worked.  oh i think i changed my screen size to 800x600 from 640x480.  not sure if that had a factor in it.  the only problem im having now is with making new mortars.  it keeps making clock parts instead.  i have to find where the script chooses to go down two spots(on the left selection menu) and then clicks and change it to go down three spots.  any idea where i can look?  as you can probably tell im no hot shot with scripts xD.
[/quote

Yeah, freeshards can use different size context menus and even locations.  Glad you figured it out.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Dan123The123Man on March 16, 2012, 09:13:44 AM
I was wondering if their is any chance we could get this script to work with OpenEUO seeing as how EasyUO is and has been down like all week? I would really like to use thi script, but I can't atm and don't know when EasyUO will be updated to work with the current client. OpenEUO seems to work though but not with the script.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on March 16, 2012, 03:27:42 PM
I'm not fluent in open easyuo.   :(
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Magier on April 24, 2012, 03:11:15 PM
Ive been using this thing for a long time and it's by far one of the smoothest running potion creators I've seen, THANKS for all you do for us.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on April 24, 2012, 08:59:55 PM
Ive been using this thing for a long time and it's by far one of the smoothest running potion creators I've seen, THANKS for all you do for us.

Very appreciated  :D
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on June 06, 2012, 05:39:08 PM
Theres only one issue that I have ever had with this script, and that is that when the stack of regs it is using to make pots runs out, it doesn't search for another stack, it just ends the script and says all potions were finished, despite 300k more of that reg being in the resource container.

Other then that, this is THE script I always use for stuff likethis :>

i just added an untested fix for your issue.  it should, in theory, check for regs, if it is not enough drag what is left in that stack, and then take another look for a second... third etc stack.  we will see.  thx for using my script
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: cata on July 23, 2012, 03:57:37 AM
Im running it for alchemy training , works perfect  ;D .
Thanks for this wonderfull script
Greetings Juan

Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: tandj99 on October 10, 2012, 07:05:34 AM
I tried using this today on my laptop for the first time and it is right after a patch. Does anyone know if the gumps value changed. For some reason it pulls the regs and bottles but doesnt make anything.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Insideout on March 15, 2013, 09:10:17 AM
Love it. Nice easy and to the point awesome script
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: noobus on April 02, 2013, 04:02:30 PM
have only used this for poison pots to train poisoning but it works flawlessly so far...will use it to keep stocked up on gheal gcure and str


edit: ok i lied, it skipped right over lesser poison and made normal poison.  but it registered the lesser poison as being "done" after it made 500, then continued making normal poisons.  I paused, clicked greater poison, resumed and now its working on those...will update tomorrow, about to leave for work

it was supposed to make 500 lesser, normal, and greater...this is on OSI shard ATL with updated client and easyuo and i downloaded the 2.2d version of your script
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: bungalobenny on April 21, 2013, 10:20:29 AM
Hey guys, do you know if this is being updated for the recent patch? I havent had any problems with this script and love it but it looks like the menu options changed in game? I am trying to make greater strength and it is making greater agility.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: bodfather on April 21, 2013, 10:49:06 AM
Hey guys, do you know if this is being updated for the recent patch? I havent had any problems with this script and love it but it looks like the menu options changed in game? I am trying to make greater strength and it is making greater agility.

I just tested it and all seems to be working properly. Greater str works as intended.

I even tested to see if there was a change between total refresh and greater refresh and it works smoothly.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Hoby on April 21, 2013, 01:24:16 PM
ok, sorry, this is off the topic but bodfather, your avatar is hilarious, the ice cream one. made lmao!
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: bungalobenny on April 23, 2013, 02:38:15 PM
Hey guys, do you know if this is being updated for the recent patch? I havent had any problems with this script and love it but it looks like the menu options changed in game? I am trying to make greater strength and it is making greater agility.

I just tested it and all seems to be working properly. Greater str works as intended.

I even tested to see if there was a change between total refresh and greater refresh and it works smoothly.

Is your client updated? I just ran it again and selected 5000 greater strength pots and it is making greater agility
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Khameleon on April 23, 2013, 03:27:00 PM
did they make changes to the order of potions? other wise everything should work as it used to.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: bodfather on April 23, 2013, 06:05:48 PM
Hey guys, do you know if this is being updated for the recent patch? I havent had any problems with this script and love it but it looks like the menu options changed in game? I am trying to make greater strength and it is making greater agility.

I just tested it and all seems to be working properly. Greater str works as intended.

I even tested to see if there was a change between total refresh and greater refresh and it works smoothly.

Is your client updated? I just ran it again and selected 5000 greater strength pots and it is making greater agility

I'm fully updated and I tested 100 greater str which it never switched to agility. To me everything looks normal.

I have had click problems when changing screen resolution before so maybe that's it?
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: boom on December 28, 2013, 11:42:22 PM
Hey,

This is an amazing script but there is just one little problem.  After it makes one item it stops on the line "   repeat
   until #CONTNAME = %name || #SCNT > %GumpTimer" and then does nothing....  PLease help!
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Crisis on December 29, 2013, 06:02:45 AM
Hey,

This is an amazing script but there is just one little problem.  After it makes one item it stops on the line "   repeat
   until #CONTNAME = %name || #SCNT > %GumpTimer" and then does nothing....  PLease help!

I just downloaded this one yesterday and it has been working great for me. I am using it to make potions for plants and for taking me from 45 to gm alchemy which I am almost there (97.() I am using version 2.2d, which version are you using?

EDIT: Took me to GM quick and I was able to make potions without kegs which is sweet as hell.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on December 29, 2013, 06:50:35 AM
Hey,

This is an amazing script but there is just one little problem.  After it makes one item it stops on the line "   repeat
   until #CONTNAME = %name || #SCNT > %GumpTimer" and then does nothing....  PLease help!

Freeshard?  It does not support all freeshards.  It has the container size for the current OSI UO client only. 
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: bodfather on December 29, 2013, 08:16:11 AM
  I looked up Boom's intro and he's on OSI shards so it's something else.

Boom have you updated to EUO247?

Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Insideout on December 29, 2013, 04:48:24 PM
I've used this one for a while heck ran 6k of GP GH GC just today. Thanks for the awesome script btw C@
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: boom on December 30, 2013, 12:28:26 PM
Hey guys,

Thanks for all your replies.  I will try it again shortly and see if it is working.  Maybe it was just a simple lag issue and nothing wrong with the script.

Post Merge: December 31, 2013, 02:14:53 AM
I would like to think everyone for their replies.  The problem was I did not have th updated verison of EUO.  I'm an idoit...
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: wezbb on April 14, 2015, 08:21:28 AM
dont seem to work for me it makes one then stops but its putting 1k of ginseng in my pack
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Crisis on April 14, 2015, 02:58:27 PM
dont seem to work for me it makes one then stops but its putting 1k of ginseng in my pack


Freeshard or OSI? I have been using and abusing this script lately as there has been a run on my potion vendors. It has been working great. Make sure that you are using the most current EUO 1.5.1.285, and 2.2d which is the most current version of this script.

The script does call for 1000 of each reg it needs

Code: [Select]
sub setup_values
set %bottles WUF
set %tool RQF
set %regdrag 1000
set %bottledrag 50

How many are you trying to make? Which potion is hanging up or is it all of them? If you are on a free shard make sure that all of the potion findtype match OSI in the sub check_menu. It could be hanging up because it is looking for a specific potion to be made but the findtype is different on the freeshard from OSI.

Code: [Select]
Main_List:
sub checkmenu
    menu get lp
    set %tomake #menures
    If %tomake > 0
      {
      set %continue #false
      set %reg1 WZF                                         ;Sets reagent as nightshade
      set %regcount 1                                        ;Requires one nightshade per potion
      set %made AVF                                        ;Potion made is lesser poison
      set %finishcount 0                                     ; Sets the count that you want made, IE 100
      gosub get_it %reg1 1000                          ; Grabs 1000 of %reg1 which is listed for this one as WZF (nightshade)
      gosub figurebottles
      gosub adv_it %setupx %toxicy
      gosub click_it %potx %pot1y
      gosub make_potion
      gosub dump %dumplist
      }
      gosub menudone 12 36 EUOLabel2

This one here is looking for lesser poison potions and the %made is AVF so if you are on a freeshard the finished potion might be listed differently.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Zurg on April 14, 2015, 04:47:52 PM
are you useing Kegs or Bottles
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Zurg on April 14, 2015, 05:02:51 PM
Just though of something are you running uo assit or razor because something that mess some scripts up when playing them.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: wezbb on April 15, 2015, 05:02:51 AM
ive tryed to use this on demise but it makes one potion n stops u know why?
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Crisis on April 15, 2015, 01:30:17 PM
Check the things in my previous post. Freeshards are generally different than OSI and scripts need to be adjusted to account for that.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: _C2_ on April 17, 2015, 09:08:31 AM
ive tryed to use this on demise but it makes one potion n stops u know why?

Freeshard - some gump locations such as make last are in a different spot. You will need to adjust gumps for free shards. I do not work on free shard versions of my scripts... too many to keep up with and I never play them. I completely approve others altering my code for their free shard needs!  :D
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: codexvalor on June 08, 2016, 10:48:57 AM
Is there anyone that would be willing to help me make this work on uo demise? I'm assuming I need to change the make last location but I'm not sure how to figure that out. Sorry to be such a newb.
Thanks
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Wyst on March 26, 2017, 06:32:51 PM
out of curiosity, is there a way to update this to reflect more of the regular potion.. example, including - Normal Strength, Normal Cure, Normal Refresh?
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: valen2.0 on March 26, 2017, 06:40:17 PM
If you mean the interface yes however you would have to completely restructure it if that's what you mean. And I don't know many people who yes strength and dex (normal ones). Especially cus they are easily and frequently looted from low level mobs. However yes it could be modified to be able to make them and whatnot.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Wyst on March 27, 2017, 03:41:40 PM
well.. I was just looking to see options of adding the potions that aren't usually made but had the option to make them. i know most get them from low level mobs, however for those of us (like me) who don't normally hunt would be a nice way to stock pile them to use in BODS. even if there is a way to change some to get the other pots if you know what they are without changing the entire interface.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: valen2.0 on March 27, 2017, 03:57:47 PM
Yes,

you would just need to modify where the clicks are for say getting rid of the low level poison. to what the clicks would need to be for say your regular str potion.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: Wyst on March 27, 2017, 04:36:49 PM
thats cool, I guess I'll just have to play around with it and see if I can figure it out.
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: valen2.0 on March 27, 2017, 04:52:26 PM
A great reference is what ghost was recently helping me with.

http://www.scriptuo.com/index.php?topic=14288.msg116559#new
Title: Re: C2's Potion Factory (Makes mass bottles - no kegs)
Post by: valen2.0 on March 27, 2017, 04:53:00 PM
Also are you OSI or freeshard?