Sub in a Sub???

[xxcaptainxx]

can you have a sub within a sub???  i think so but i would hate to waste a lot of time trying to code an uncodeable   thanks all

[talkmill]

I'm not a pro at this at all but did some tests. Some pro please correct me if i'm wrong but it seems like:

Code: [Select]

sub test1
sub test2
return
return
work the same way as:

Code: [Select]

sub test1
return

sub test2
return
What exactly is it you are trying to acomplish?

[xxcaptainxx]

Well in one of my subs i want to check if i have a certain resource and then if i don't i want to run another sub to restock it

[TrailMyx]

Sub in a sub is bad form.  I never do it; it makes code difficult to read and harder to debug but can work if you implement it correctly.  I would stay away from that kind of programming practice is I was you.

With that said, even some coding pros (Kal In Ex) use subs in subs.  I guess if you know what you are doing then you can do anything...

[talkmill]

Do you meen something like this?

Code: [Select]

sub stockresources
gosub checkresources
if #return < %wantedresources
  gosub restockresources
return
if thats the case i would say calling other subs from other subs should be done if it helps understandability/abstraction. Otherwise not
But then again i'm much more used to other programming languages then easyuo so i probably should be quiet (have a hard time doing that though  )

[TrailMyx]

Well, you can certainly justify using them.  Suppose a routine has a specific function used all over the script, but is mainly used in a specific subroutine.  Why not?

I guess I know from experience writing ScriptUO that when you hit a SUB tag, it does NOTHING.  It's just a tag marking a location for the GOSUBS to go.  So there's no overhead from a SUB; the overhead comes from the GOSUB since you have to setup the %0, %1, %2, %etc variables and perform the stack interaction and execution pointer jump.

However for me, I just would never do that.  I like code to have a specific flow to it.  Sub'n'subing just makes me think back to the good'ol days of coding BASIC using line numbers (MSBASIC, BASICA, ApplesoftBASIC, etc)  I'm not a fan of spaghetti coding, and this really smells like fresh pasta.  lol.  Thankfully, I'm allergic to pasta now.

[Tidus]

i like to use the #result feature.  If it needs to go to a certain spot and it does it every time under the circumstance i use #true.  and make  an if statement in my main repeat sub so that it says if it returned true it goes here. otherwise it just continues on.

[xxcaptainxx]

would one of you wise ones look at my heal and warn int he debug it is hurting my brain

[TrailMyx]

You should try and implement some of the suggestions from CS, it'll work better that way.  Be sure to update your first post since I'm sure you have changed it some and add the recommendations.  Just be sure to balance your braces " { } ".

Ultimately, the best way to handle bandies is to do journal scanning; so I understand that looking at the Healing Commander here at ScriptUO can cause you some headaches.  I remember A-hardy had a journal-based bandage scanner; I'm not sure where that is now but it probably won't make your head hurt as much.

[Bobkyou]

Would excessive use of subs in subs potentially cause a memory leak?  I don't know how easyuo is coded, but I would imagine it keeps track of each time gosub is called, and would need to see a return for each gosub to release the memory space.

[TrailMyx]

Would excessive use of subs in subs potentially cause a memory leak?  I don't know how easyuo is coded, but I would imagine it keeps track of each time gosub is called, and would need to see a return for each gosub to release the memory space.

I can't remember exactly where I read on EasyUO about this, but I believe I remember mention of safeguards in EasyUO that prevents you from doing this too much.  I'll look and see if I can dredge up the thread.

[TrailMyx]

Oh duh, right out of the EasyUO Wiki.

http://wiki.easyuo.com/index.php/Gosub

   You must not jump out of a sub! Use return to properly terminate a sub routine. To prevent a stack overflow, EUO only supports 1000 consecutive GoSubs without returning. Remember this when using recursion! When the GoSub stack is about to get 1001 levels, the very first level in the bottom of the stack is deleted to make room.

Right now in ScriptUO, it's unlimited.  At least until you use all your memory and crash your computer.  I will put similar restrictions on it.

[Endless Night]

I can not think of a single circumstance that would justifiy coding a sub in a sub..  Makes no sense at all..
_{Sub A
  display ok a
  sub b
    display ok b
   return
return}

Below Produces the same result as above.. without the funny coding practices.

<sub>Sub A
  display ok a
  gosub B
Return

Sub b
  display ok b
return</sub>

[TrailMyx]

I can not think of a single circumstance that would justifiy coding a sub in a sub..  Makes no sense at all..

ROFL, yeh, the only time I ever encounter it is when a new coder is learning the ropes and doesn't really understand the concept of a gosub vs. a goto.  If it's not clear to anyone, just let us know and we can explain the concept for ya'll.

[Bobkyou]

Well recursion would call subs from subs, and recursion can do in a very small amount of code what would take many lines to accomplish.  However since gosubs are more cpu intensive than other activities, recursion ( I believe ) would become very slow in easyuo very fast.  Never actually run tests with it in easy uo, just remembering little programs I played with back in the day.