Author Topic: frneo's Weapon Crafter v5.0.1 08/31/11 now has TM's Advanced CLAw Support  (Read 49858 times)

0 Members and 1 Guest are viewing this topic.

Offline NeoTopic starter

  • Prime Program
  • Elite
  • *
  • *
  • Posts: 821
  • Activity:
    0%
  • Reputation Power: 13
  • Neo barely matters.Neo barely matters.
  • Respect: +155
  • Referrals: 3
    • View Profile
Code: [Select]
;===================================================================================
; Script Name: frneo's Weapon Crafter with TM's Advanced CLAw support
; Author: frneo
; Version: 5.0.1
; Client Tested With: 7.0.16.3
; EUO version tested with: 1.50 199
; Shard OSI / FS: OSI
; Revision Date: 08/31/2011
; Public Release: 08/04/2011
; Purpose: Makes weapons and checks whatever property the user wants to check for
;          in it. Elemental Damage, Slayers and anything else the user wants
;          to add. Weapons with the determined criteria will be saved, and the rest
;          will be unraveled.
;-------------------------------------------------------------------------------------
; Now supports TM's Advanced CLAw!
; Thank you TM for letting me use the CLAw with this.
;-----------------------------------------------------------------------------------
; Url:     http://www.scriptuo.com/index.php?topic=8105
;===================================================================================
; Version 5.0.1      - Fixed pause button
;                    - Removed wait time from gumpwait sub. Should make the script run
;                      even faster now!
;------------------------------------------------------------------------------------
; Version 5.0.0      Now supports TM's Advanced CLAw! Thank you TM for letting me use it!
;                    You can download the claw here:
;                    http://www.scriptuo.com/index.php/index.php?topic=17.0
;                    If you choose to use the CLAw with this, you must thank TM for it in
;                    the above topic! :)
;--------------------------------------------------------------------------------------
; Version 4.1.8      - A few minor fixes
;-------------------------------------------------------------------------------------
; Version 4.1.7      - Fixed some minor code that could cause issues.
;                    - Also removed some unnecessary code.
;-------------------------------------------------------------------------------------
; Version 4.1.6      - Previous version would cause an issue with the weapon view button
;                      not displaying the whole property of the weapon. Should be fixed
;                      now.
;--------------------------------------------------------------------------------------
; Version 4.1.5      - Added timeout to "event property safe check".
;                    - Changed the way the event property safe check works.
;                    - New cool way to check for properties! :)
;----------------------------------------------------------------------------------
; Version 4.1.4      - Added event property safe check. Thank you EN for this tip.
;---------------------------------------------------------------------------------
; Version 4.1.3      - Added colored material option to menu
;                    - Added dmc to click sub (Thank you EN for both suggestions)
;                    - Will now check if save file exists for current character
;                    - Minor change to the way the unravel sub works
;                    Keep in mind that this version does not automatically check for
;                    color of the material, you must set it yourself before starting
;                    the script. Also, only keep the desired color for material
;                    inside the resource container.
;-----------------------------------------------------------------------------------
; Version 4.1.2      Fixed gumpwait sub. Apparently I wrote it wrong the first time
;                    round, and kept using the wrong version in all my scripts.
;                    I never noticed it before because it didn't really change the
;                    functioning of the script. So, nothing too serious, but still
;                    deserved a fix.
;---------------------------------------------------------------------------------
; Version 4.1.1      Minor drop wait time fix.
;--------------------------------------------------------------------------------
; Version 4.1        - Added pause/resume button. While paused you can edit the
;                    criteria you choose, and also save/load your user config.
;                    - Added View Selected Weapon Button. This button will display
;                    the properties of the weapon you select in the menu, and give
;                    you a choice to move the selected weapon to your backpack.
;                    - Will now pause the script if you run out of ingots/boards
;                    or tools, so that you can get more and resume. Remember
;                    to reopen your containers if you go get more.
;=================================================================================
; Version 4.0a       Fixed minor issue with removing property from list.
;--------------------------------------------------------------------------------
; Version 4.0        Major changes:
;                    - Will now allow user to set any amount of properties to look
;                    for in a weapon. As far as I'm concerned, there are no limits
;                    to the amount of properties the user can set.
;                    - Menus rebuilt, inspired by TM's advanced claw! Thank you
;                    for sharing the claw with us TM! :)
;                    - Check code re-written entirely for this
;                    - Now uses TM_NGFS to save user setup. Thank you again TM
;                    for sharing your awesome code with us!
;                    - Lag check
;---------------------------------------------------------------------------------
; Version 3.0        Major changes:
;                    - Allows user to input own custom property minimum to look
;                      for in weapon
;                    - Allows user to input own custom Slayer to look for in weapon
;                    - Allows user to choose the material he's going to use to craft
;                      stuff, i.e. boards or ingots.
;                    - Allows user to use whatever runic tool type he chooses,
;                      as long as the material to be used is either ingots or
;                      boards.
;                    - I thought of a new way to check for properties, the entire code
;                      was re-written in a more compact and efficient manner.
;                    Minor changes:
;                    - Changed amount of weapons to make before unraveling down to ten
;                      I figured this would be safer. If one wishes to make
;                      more weapons at a time, info about how to do that
;                      can be found in the script topic at SUO.
;---------------------------------------------------------------------------------
; Version 2.2        Increased amount of weapon to make before unraveling to 20
;                    I don't think this will cause a weight issue. Should run even
;                    faster now!
;--------------------------------------------------------------------------------
; Version 2.1b       Removed all goto's as a birthday gift for Cerveza! :)
;--------------------------------------------------------------------------------
; Version 2.1a       Minor fix: Fixed issue that would prevent Elemental Slayers
;                    with Fire or Poison Damage to be saved.
;--------------------------------------------------------------------------------
; Version 2.1        Some changes to make the script run faster:
;                    - Will craft weapons directly IN unravel bag now, weapons
;                      will no longer have to be dragged one by one.
;                      Thank you MeWonUo for the tip! :)
;                    - Changed the way crafting subs work. Will craft weapons
;                      faster now.
;                    - Removed the trash barrel option. After burning
;                      more than 40 hammers using this, and not needing the
;                      trash barrel, I guess it was about time to remove it
;
;                      I want to thank everyone who's giving me feedback
;                      so I can keep improving this! Cheers!
;--------------------------------------------------------------------------------
; Version 2.0        Menus rebuilt. Most of the code was rewritten for stability.
;                    Added option for user to set minimum damage wanted
;                    for each damage type. Added option for user to set
;                    minimum Swing Speed Increase to look for in each weapon.
;                    Added individual counters for all Damage Types and for
;                    each different slayer.
;--------------------------------------------------------------------------------
; Thank you Cerveza and Canuker for the input/tips. Version 2.0 was based on your
; comments! I appreciate it.
; Also thank you Ultima for the kind words, it's really nice to work hard on things
; when other people seem to value them. Thank you guys!
;================================================================================
; Version 1.1a       Fixed an issue with lag causing unravel to break.
;--------------------------------------------------------------------------------
; Version 1.1        Rewrote the check sub, for some reason it was trashing
;                    some weapons that should have been saved. Should be
;                    fixed now. I used a similar structure to JaF's in
;                    his Slayer Book Maker, so thank you JaF for the great
;                    code you shared with us! :)
;--------------------------------------------------------------------------------
; Version 1.0        Added Menu. Added selection of weapons you want to keep.
;                    Selection includes: Swing Speed Increase, Slayers and
;                    Elemental Damage 70% or above.
;--------------------------------------------------------------------------------
; Version 0.1a       Fixed issue with unravel
;--------------------------------------------------------------------------------
; Version 0.1        Currently only works with Dull Copper Runic Hammers, but
;                    other crafting options could be added easily with this
;                    setup structure. Future versions will have community
;                    suggestions added. If there are any suggestions that is! :)
;                    I also plan on adding menu customization for weapons people
;                    want, in future versions...
;================================================================================
;================================================================================
; Thank you goes to:
;
;
; TM for your clickoffset generator, saved me loads of time, thank you:)
; TM for his NGFS used from v4.0 on.
; TM for letting me use his Advanced CLAw :)
;
; Coragin for posting SUO Elemental Weapon Maker. Alas, I tried it out
; with no success, I guess it was a little outdated. However, it inspired me
; to write this! :) So thanks for that!
;=================================================================================
; Instructions:
; You must have a secure next to you with the Runic Tools and material to craft your stuff
; Also, you must have a container near you to put the weapons you crafted in
; You must have a bag INSIDE your backpack, where the trash weapons will be sent
; to for unraveling.
;
; You must be near a forge and anvil if Smithing,
; and also have a Soulforge near you, so you can unravel.
; Last, you must have 1 Tool and enough material to make your first weapon
; in you backpack.
; Once all these conditions are met, hit play, and follow the screen instructions
; If this works for you, or not, please tell me, I want to keep updating this
; according to what people think of it.
;===========================================================================

Pic shows the View Weapon button in action:


V5.0.1 with TM's CLAw in action! :)


Menu was inspired by claw's menu, thank you TM for sharing it with us!

Have in mind I haven't put many safe checks for what you write in your custom properties. So, if you write a property wrong, or a value that shouldn't be where you wrote it, the script won't function properly!

Input the number of the minimum value you want, without the '%' i.e. if you want 90% poison, you write 90 in the box.

That said, enjoy! :)

Version 5.0 has TM's Advanced CLAw support.

If you want to use it, remember to start it up on another tab BEFORE running the crafter... The crafter will use the settings on the CLAw to see what to keep and what to unravel...

Thank you TM for letting me use this!

neo


There are 3 attachment(s) in this post. You must register and post an acceptable introduction to download
weapon_crafter_4.1.8_suo.txt
weapon_crafter_5.0.0_suo.txt
weapon_crafter_5.0.1_suo_clawsupport.txt
« Last Edit: August 31, 2011, 08:16:21 PM by frneo »
Never refuse an invitation.
Never resist the unfamiliar.
Never fail to be polite.
And never outstay your welcome.

Offline Canuker

  • Sr. Member
  • *
  • Posts: 479
  • Activity:
    0%
  • Reputation Power: 7
  • Canuker has no influence.
  • Respect: +37
  • Referrals: 2
    • View Profile
Re: frneo's 100% Elemental Weapon Maker
« Reply #1 on: August 04, 2011, 03:52:45 PM »
0
I shall have to check this out...thanks for sharing:)
Nope!  I'm doing what all the real PvPers do:  Scripting everything except the running away part!  I'm real good at that already...

Offline Ultima

  • Insane Scripter
  • *
  • Posts: 1580
  • Activity:
    0%
  • Reputation Power: 26
  • Ultima is on the verge of being accepted.Ultima is on the verge of being accepted.Ultima is on the verge of being accepted.Ultima is on the verge of being accepted.Ultima is on the verge of being accepted.
  • Gender: Male
  • Respect: +160
  • Referrals: 4
    • View Profile
Re: frneo's Weapon Crafter Updated 08/04/11
« Reply #2 on: August 04, 2011, 04:45:59 PM »
0
Very nice Frneo! Scripts like this are near and dear to my heart. ;)

I just burned up the last of my runic hammers today and I'm all out of BODs so I can't say for sure when I'll get a chance to test it but I can assure you I will.

I typically use shadow, copper and dull copper hammers when crafting elementals. I believe the ID is the same so it shouldn't be a problem.

Great submission! :)

Offline Canuker

  • Sr. Member
  • *
  • Posts: 479
  • Activity:
    0%
  • Reputation Power: 7
  • Canuker has no influence.
  • Respect: +37
  • Referrals: 2
    • View Profile
Re: frneo's Weapon Crafter Updated 08/04/11
« Reply #3 on: August 04, 2011, 06:03:54 PM »
0
Wow, I just loaded up version 1 and was thinking I need to make a menu for this but blammo here it is...nice jedi mind reading.
Nope!  I'm doing what all the real PvPers do:  Scripting everything except the running away part!  I'm real good at that already...

Offline NeoTopic starter

  • Prime Program
  • Elite
  • *
  • *
  • Posts: 821
  • Activity:
    0%
  • Reputation Power: 13
  • Neo barely matters.Neo barely matters.
  • Respect: +155
  • Referrals: 3
    • View Profile
Re: frneo's Weapon Crafter v1.1 uploaded 08/05/11
« Reply #4 on: August 04, 2011, 08:36:08 PM »
0
Thanks for trying this out guys... Version 1.1a is up and fixes some issues I came across...

I also appreciate the feedback, so I can keep working on this!

Cheers!

:)

EDIT: Ok, been testing this for the last 20 minutes or so, so far working flawlessly for me...

« Last Edit: August 04, 2011, 09:40:12 PM by frneo »
Never refuse an invitation.
Never resist the unfamiliar.
Never fail to be polite.
And never outstay your welcome.

Offline NeoTopic starter

  • Prime Program
  • Elite
  • *
  • *
  • Posts: 821
  • Activity:
    0%
  • Reputation Power: 13
  • Neo barely matters.Neo barely matters.
  • Respect: +155
  • Referrals: 3
    • View Profile
Re: frneo's Weapon Crafter Updated 08/04/11
« Reply #5 on: August 04, 2011, 11:20:37 PM »
0
Very nice Frneo! Scripts like this are near and dear to my heart. ;)

I just burned up the last of my runic hammers today and I'm all out of BODs so I can't say for sure when I'll get a chance to test it but I can assure you I will.

I typically use shadow, copper and dull copper hammers when crafting elementals. I believe the ID is the same so it shouldn't be a problem.

Great submission! :)
After you use the first tool, it will remember the type and search for it in your resource container. Since all the hammers have the same type, I guess it will use whatever hammer it finds inside your secure.

[]s
Never refuse an invitation.
Never resist the unfamiliar.
Never fail to be polite.
And never outstay your welcome.

Offline Canuker

  • Sr. Member
  • *
  • Posts: 479
  • Activity:
    0%
  • Reputation Power: 7
  • Canuker has no influence.
  • Respect: +37
  • Referrals: 2
    • View Profile
Re: frneo's Weapon Crafter v1.1 uploaded 08/05/11
« Reply #6 on: August 05, 2011, 05:36:40 AM »
0
I busted out a few hammers last night with the first version of this and it worked like a charm.  I cannot wait to "hammer" out a bag tonight.  Thanks again for the lines.
Nope!  I'm doing what all the real PvPers do:  Scripting everything except the running away part!  I'm real good at that already...

Offline Cerveza

  • Hacksimus Maximus
  • Scripthack
  • *
  • Posts: 5857
  • Activity:
    0%
  • Reputation Power: 80
  • Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!
  • Gender: Male
  • So... Hows that Hopey-Changey thing working out?
  • Respect: +403
  • Referrals: 11
    • View Profile
Re: frneo's Weapon Crafter v1.1 uploaded 08/05/11
« Reply #7 on: August 05, 2011, 06:01:57 AM »
0
Can't you enhance 40 fire onto stuff? So wouldn't 60 fire be the minimum you would want instead of 70?

Personally, I keep stuff that will enhance to 90. That gives enough elemental damage in my book.

Also, not sure if you want to include this... Saving a weapon that is 70% in an elemental damage doesn't always mean it can be enhanced to more. Take this example:

70 Fire Damage
20 Cold Damage
10 Energy Damage

That can't be enhanced any more at all. The "other" damage type has to be physical to make the weapon able to increase the elemental damage.
XXXXXXXXXX________________________________________] 20%
I've forgotten more about this game then most people will ever know.
Thank you for controlling your children. Their manners reflect your love for them.
Give a man a fish and you feed him for a day. Don't teach a man to fish, and you feed yourself. He's a grown man. Fishing's not that hard.

Offline Canuker

  • Sr. Member
  • *
  • Posts: 479
  • Activity:
    0%
  • Reputation Power: 7
  • Canuker has no influence.
  • Respect: +37
  • Referrals: 2
    • View Profile
Re: frneo's Weapon Crafter v1.1 uploaded 08/05/11
« Reply #8 on: August 05, 2011, 06:35:18 AM »
0
http://www.scriptuo.com/index.php?topic=7890.0

I have a few weapons for my main sampire that I use which have damage spread over two types.  After I made the list in the link I found that these were almost as good as 100%.
Nope!  I'm doing what all the real PvPers do:  Scripting everything except the running away part!  I'm real good at that already...

Offline NeoTopic starter

  • Prime Program
  • Elite
  • *
  • *
  • Posts: 821
  • Activity:
    0%
  • Reputation Power: 13
  • Neo barely matters.Neo barely matters.
  • Respect: +155
  • Referrals: 3
    • View Profile
Re: frneo's Weapon Crafter v1.1 uploaded 08/05/11
« Reply #9 on: August 05, 2011, 07:13:58 AM »
0
http://www.scriptuo.com/index.php?topic=7890.0

I have a few weapons for my main sampire that I use which have damage spread over two types.  After I made the list in the link I found that these were almost as good as 100%.
That's a nice list... It's good reference to what weapons one should craft for each champ... Thks for sharing!

Can't you enhance 40 fire onto stuff? So wouldn't 60 fire be the minimum you would want instead of 70?

Personally, I keep stuff that will enhance to 90. That gives enough elemental damage in my book.

Also, not sure if you want to include this... Saving a weapon that is 70% in an elemental damage doesn't always mean it can be enhanced to more. Take this example:

70 Fire Damage
20 Cold Damage
10 Energy Damage

That can't be enhanced any more at all. The "other" damage type has to be physical to make the weapon able to increase the elemental damage.
You're right... I should rewrite this so that it saves weapons with 60 fire and the rest to physical, and else trash... I gotta do some research about the other elements too to see a better way to add a save weapon check to the code...

If this goes well, I'll put in an option to save "weapons that can be enhanced to 100% elemental" to the menu, once I know all the correct values needed...

And then just keep a regular option of saving generic elemental damage => X%, maybe 50%?

Thank you for the input  Cerveza...

For instance, yesterday Ultima and NObama told me that poison weapons can't be enhanced to 100, I didn't know about that...

So, if one wants 100% elemental weapons, would this be the way to go?:

100% fire: 60% fire or above, rest physical -> enhance with bronze.
100% cold: 70% cold or above, rest physical -> enhance with agapite
100% energy: 80% energy or above, rest physical -> enhance with copper
100% poison: you have to craft 100% poison, else it can't be enhanced further?

If anyone can confirm this, it would be greatly appreciated...

Cheers!
Never refuse an invitation.
Never resist the unfamiliar.
Never fail to be polite.
And never outstay your welcome.

Offline Cerveza

  • Hacksimus Maximus
  • Scripthack
  • *
  • Posts: 5857
  • Activity:
    0%
  • Reputation Power: 80
  • Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!Cerveza is awe-inspiring!
  • Gender: Male
  • So... Hows that Hopey-Changey thing working out?
  • Respect: +403
  • Referrals: 11
    • View Profile
Re: frneo's Weapon Crafter v1.1 uploaded 08/05/11
« Reply #10 on: August 05, 2011, 07:33:12 AM »
0
It might be best to keep it as simple as possible. Having to recycle some weapons is much better then making the script overly complicated.

I would like to make my own determination on what to keep though. As I said before, I like to keep 50 Fire weapons to enhance to 90. I find that 90 elemental damage is almost impossible to differentiate from 100.

Maybe a user's input?

Keep these
[   ] Fire
[   ] Cold
[   ] Poison
[   ] Energy

The user puts in the minimum to keep in each one. For my purposes it would read something like:
[50] Fire
[60] Cold
[100] Poison
[70] Energy

That would allow enhancing to 90% provided the "off element" is physical. It would also allow me some more "hybrid" types. Like Canuker stated above... A 50 Fire / 50 Poison might be pretty awesome.
XXXXXXXXXX________________________________________] 20%
I've forgotten more about this game then most people will ever know.
Thank you for controlling your children. Their manners reflect your love for them.
Give a man a fish and you feed him for a day. Don't teach a man to fish, and you feed yourself. He's a grown man. Fishing's not that hard.

Offline Canuker

  • Sr. Member
  • *
  • Posts: 479
  • Activity:
    0%
  • Reputation Power: 7
  • Canuker has no influence.
  • Respect: +37
  • Referrals: 2
    • View Profile
Re: frneo's Weapon Crafter v1.1 uploaded 08/05/11
« Reply #11 on: August 05, 2011, 07:55:51 AM »
0
A few of the guys in my guild run only poison or cold damage weapons on their dexxers simply because after using a scanner script at those burning counts at the bank they found on average this would hit for a extra few points....
Nope!  I'm doing what all the real PvPers do:  Scripting everything except the running away part!  I'm real good at that already...

Offline NeoTopic starter

  • Prime Program
  • Elite
  • *
  • *
  • Posts: 821
  • Activity:
    0%
  • Reputation Power: 13
  • Neo barely matters.Neo barely matters.
  • Respect: +155
  • Referrals: 3
    • View Profile
Re: frneo's Weapon Crafter v2.0 out 08/07/11
« Reply #12 on: August 06, 2011, 10:43:03 PM »
0
Ok guys, followed your tips and suggestions and just finished adding them. Version 2.0 is out! :)

Please continue giving me feedback about it so I can keep improving it!

Hope you enjoy!

Cheers.
« Last Edit: August 06, 2011, 11:01:45 PM by frneo »
Never refuse an invitation.
Never resist the unfamiliar.
Never fail to be polite.
And never outstay your welcome.

Offline xwardox

  • Jr. Member
  • **
  • Posts: 23
  • Activity:
    0%
  • Reputation Power: 1
  • xwardox has no influence.
  • Respect: +10
  • Referrals: 0
    • View Profile
Re: frneo's Weapon Crafter v2.0 out 08/07/11
« Reply #13 on: August 07, 2011, 10:41:21 AM »
0
anyway to set this up to just grab whatever runic hammer you have in a bag? reason i ask is because i have mostly shadow and copper hammers all in a bag, also my imbuner is on a different chr due to being full on my smith, anyway to setup the unravel bag to be in a secure and not have to unravel?

Offline NeoTopic starter

  • Prime Program
  • Elite
  • *
  • *
  • Posts: 821
  • Activity:
    0%
  • Reputation Power: 13
  • Neo barely matters.Neo barely matters.
  • Respect: +155
  • Referrals: 3
    • View Profile
Re: frneo's Weapon Crafter v2.0 out 08/07/11
« Reply #14 on: August 07, 2011, 11:59:25 AM »
0
anyway to set this up to just grab whatever runic hammer you have in a bag? reason i ask is because i have mostly shadow and copper hammers all in a bag, also my imbuner is on a different chr due to being full on my smith, anyway to setup the unravel bag to be in a secure and not have to unravel?

You just use whatever runic hammer you want to craft the first weapon during setup, it will automatically setup the item type for runic hammers, and then it will grab whatever runic hammers you have in your secure... All runic hammers are the same type, so you will have no problem...

Last night I made around 1000 weapons, using dull copper and shadow iron hammers in my secure, so I guess there will be no problem there...

Also, I'm not sure, but i think you don't have to have imbuing skill to unravel, give it a try...

If it doesn't work I could think about releasing an update to choose if you want to unravel or not....
Never refuse an invitation.
Never resist the unfamiliar.
Never fail to be polite.
And never outstay your welcome.

Tags: