Building a Sub: Find and tag all NPCs in the local area

[NObama]

Globally ignoring yourself can be a bad idea

Tell me about it.  Chicks did it to me for years.

 

[Endless Night]

NObama's Emerging Rules of Coding:

1. Whatever you write, Endless Night can do it better and with at least 12.5% fewer lines.
 

LOL ...  your projects are defaintly getting more ambitious

[NObama]

Can someone point me to a tutorial on arrays or a good example of a script that effectively uses an array?  There is no discussion of them on EUO's wiki as far as I've been able to find.

I really need the array to help me ignore the NPCs that are yellow that don't actually sell anything...

[Endless Night]

Tm i belive has some array subs on these boards some place

Arrays and how to make them in EUO

1 dimensional array  Var[x= 1.....]
set %MYArray . !CountX  !Value
 
2 dimensional array  var[x,y]
set %MYArrayVarNAme %MyArray , !CountX , _ , !CountY
set % . %MyArrayVarName !Value
(eg %Myarray1_1 )

3 dimensional array  var[x,y,z]
set %MYArrayVarNAme %MyArray , !CountX , _ , !CountY , _ , !CountZ
set % . %MyArrayVarName !Value
(eg %Myarray1_1_1 )

4 dimensional array  var[A,b,c,d]etc
set %MYArrayVarNAme %MyArray , !CountA , _ , !CountB , _ , !CountC , _ , !CountD
set % . %MyArrayVarName !Value
(eg %Myarray1_1_1_1 )


In your case you probably just need a One Dimensional Array  (you have already used them with my MiniRail system you just might not have realised - Every time you add a way point you add a record to 3 one dimensional arrarys  x[], y[], z[])

[NObama]

Ahhhh...that helps put them in perspective.

I really only need a one dimensional array.  I'm looking to do:

if X in #property
ignore id

[TrailMyx]

Tm i belive has some array subs on these boards some place...

Indeed:


http://www.scriptuo.com/index.php?topic=19.msg19#msg19

[NObama]

Heh - that thread is only somewhat less arcane to me as when I first commented on it...=P

Codingz is hard

[NObama]

Okay - I'm stripping this down to components to try and solve it one piece at a time.

This definitely works to establish the bad NPC names:

Code: [Select]

goSub Setup_Ignore_NPC_Type_Values
halt
;--------------------------------------------------------------
Sub Setup_Ignore_NPC_Type_Values
  gosub Add_Ignore_NPC_Type guildmaster
  gosub Add_Ignore_NPC_Type banker
  gosub Add_Ignore_NPC_Type minter
Return
;--------------------------------------------------------------
Sub Add_Ignore_NPC_Type
  if %Ignore_NPC_Type_Max = N/A
     set %Ignore_NPC_Type_Max 0
  set %Ignore_NPC_Type_Max %Ignore_NPC_Type_Max + 1
  set %Ignore_NPC_Type_Max . %Ignore_NPC_Type_Max %1
Return
;--------------------------------------------------------------

Var Dump yields:
%IGNORE_NPC_TYPE_MAX: 3
%IGNORE_NPC_TYPE_MAX1: guildmaster
%IGNORE_NPC_TYPE_MAX2: banker
%IGNORE_NPC_TYPE_MAX3: minter

I still don't get why I have to have "MAX" in there, so if someone could educate me...

Now, I just need to apply the array values in a loop...

[NObama]

Ok - someone check my logic and tell me if I'm using #result correctly:

Given the following sub:

Code: [Select]

;--------------------------------------------------------------
sub Ignore_NPC_Types

set !loopvalue 1
  If %Ignore_NPC_TYPE_Max = N/A
    gosub Setup_Ignore_NPC_Type_Values
Repeat
  set #result true
  if %Ignore_NPC_TYPE_Max . !loopvalue notin #property
    {
    set #result false
    }
  set !loopvalue !loopvalue + 1
Until !loopvalue >= %Ignore_NPC_Type_Max
return #result
;--------------------------------------------------------------

Would this code execute the way I intend?

Code: [Select]

        if #result = false
           {
           set %npc_id . !npc_counter #findid
           set !npc_counter !npc_counter + 1
           set %npc_max !npc_counter
           }

I actually think I'm close to cracking this...

[Scrripty]

Why does this need to be so difficult?  There's not that many npcs that need to be ignored...

Code: [Select]

     if hairstylist in #property || sculptor in #property || Noble in #property || mage in #property || bride in #property || miner in #property || fighter in #property || peasant in #property || messenger in #property || guard in #property || adventure in #property || artist in #property || bard in #property || thief in #property || actor in #property || impresario in #property || beggar in #property || gypsy in #property || mondain in #property || breeder in #property
        ignoreitem #findid
Done.

Yes there's more, but they are easy to find.  Make a list menu script that adds any #findrep invulnerable npcs to the list and you can just run around a big town like brit and get them all.  Then add them to the list.  It's fast to read the line and if it gets too long, you can use the + thingy to add to it on another line...

[NObama]

I could take the moral high ground here and claim that I was trying to better my coding skills...but the truth is that I just didn't think of doing it that way.

The good news is, I think I learned how to do this with an array.

I think this is a working version...

Code: [Select]

goSub Setup_Ignore_NPC_Type_Values
gosub Find_NPCs
;--------------------------------------------------------------
sub Find_NPCs
set !npc_counter 1
finditem IS G_30
  set !Exit 10
  Repeat
     set !Exit !exit - 1
     {
     finditem IS G_15
       if #findkind = 1 && #findrep = 7
         {
         event Property #findid
         gosub Ignore_NPC_Types
         if #result = false
           {
           set %npc_id . !npc_counter #findid
           set !npc_counter !npc_counter + 1
           set %npc_max !npc_counter
           }
         }
         ignoreitem #findid
  Until #findkind = -1
return
;--------------------------------------------------------------
sub Ignore_NPC_Types

set !loopvalue 1
  If %Ignore_NPC_TYPE_Max = N/A
    gosub Setup_Ignore_NPC_Type_Values
Repeat
  set #result true
  if %Ignore_NPC_TYPE_Max . !loopvalue notin #property
    {
    set #result false
    }
  set !loopvalue !loopvalue + 1
Until !loopvalue >= %Ignore_NPC_Type_Max
return #result
;--------------------------------------------------------------
Sub Setup_Ignore_NPC_Type_Values
  gosub Add_Ignore_NPC_Type guildmaster
  gosub Add_Ignore_NPC_Type banker
  gosub Add_Ignore_NPC_Type minter
Return
;--------------------------------------------------------------
Sub Add_Ignore_NPC_Type
  if %Ignore_NPC_Type_Max = N/A
     set %Ignore_NPC_Type_Max 0
  set %Ignore_NPC_Type_Max %Ignore_NPC_Type_Max + 1
  set %Ignore_NPC_Type_Max . %Ignore_NPC_Type_Max %1
Return
;--------------------------------------------------------------

Var Dump:
%NPC_ID1: BVKLCC
%NPC_ID10: SWSMM
%NPC_ID2: JQNXXB
%NPC_ID3: QNLOM
%NPC_ID4: HAIOM
%NPC_ID5: BCPNM
%NPC_ID6: ZEPNM
%NPC_ID7: XMHNM
%NPC_ID8: KJHNM
%NPC_ID9: HYUMM

Booyah. 

 

[Scrripty]

You still need a type LIST correct?  So you're still doing what I just did there... just in a more complex way.  As EN would say about now:  KISS.  Keep it simple stupid.

[NObama]

Ok - the six-letter NPC IDs above are guildmasters and guildmistresses.  Any idea why this code is excluded everything on the list properly except those two words?

;--------------------------------------------------------------
Sub Setup_Ignore_NPC_Type_Values
  gosub Add_Ignore_NPC_Type guildmaster
  gosub Add_Ignore_NPC_Type guildmistress
  gosub Add_Ignore_NPC_Type banker
  gosub Add_Ignore_NPC_Type minter
  gosub Add_Ignore_NPC_Type trainer

Return
;--------------------------------------------------------------

[NObama]

Whoops.  Found my problem.  A wee tiny logical error.  Working sub below:

Code: [Select]

ignoreitem #charid
goSub Setup_Ignore_NPC_Type_Values
gosub Find_NPCs
event exmsg #charid 3 0 done$
halt
;--------------------------------------------------------------
sub Find_NPCs
set !npc_counter 1
finditem HS_IS G_15
  set !Exit 10
  Repeat
     set !Exit !exit - 1
     {
     finditem HS_IS G_15
       if #findkind = 1 && #findrep = 7
         {
         event Property #findid
         gosub Ignore_NPC_Types
         if #result = false
           {
           set %npc_id . !npc_counter #findid
           set !npc_counter !npc_counter + 1
           set %npc_max !npc_counter
           event exmsg #charid 3 0 adding #property $
           }
         }
         ignoreitem #findid
  Until #findkind = -1
return
;--------------------------------------------------------------
sub Ignore_NPC_Types

set !loopvalue 1
  If %Ignore_NPC_TYPE_Max = N/A
    gosub Setup_Ignore_NPC_Type_Values
Repeat
  set #result true
  if %Ignore_NPC_TYPE_Max . !loopvalue notin #property
    {
    event exmsg #charid 3 0 not %Ignore_NPC_TYPE_Max . !loopvalue
    set #result false
    }
  if %Ignore_NPC_TYPE_Max . !loopvalue in #property
    event exmsg #charid 3 0 matches %Ignore_NPC_TYPE_Max . !loopvalue
  set !loopvalue !loopvalue + 1
  if #result = true
    {
    event exmsg #charid 3 0 IGNORING NPC!
    return
    }
Until !loopvalue >= %Ignore_NPC_Type_Max
return #result
;--------------------------------------------------------------
Sub Setup_Ignore_NPC_Type_Values
  gosub Add_Ignore_NPC_Type guildmaster
  gosub Add_Ignore_NPC_Type guildmistress
  gosub Add_Ignore_NPC_Type banker
  gosub Add_Ignore_NPC_Type minter
  gosub Add_Ignore_NPC_Type trainer
  gosub Add_Ignore_NPC_Type vet
Return
;--------------------------------------------------------------
Sub Add_Ignore_NPC_Type
  if %Ignore_NPC_Type_Max = N/A
     set %Ignore_NPC_Type_Max 0
  set %Ignore_NPC_Type_Max %Ignore_NPC_Type_Max + 1
  set %Ignore_NPC_Type_Max . %Ignore_NPC_Type_Max %1
Return
;--------------------------------------------------------------

Gosh, this is a rush.

 

[rana70]

Hi,

just in case you are too lazy to search :-)

Code: [Select]

     if #FindType in HS_IS
      Set %RACE HUMAN
     if #FindType in XU_AV
      Set %RACE ELF
     if  #FindType in OCB_NCB
      Set %RACE GARGOYLE