TrailMyx's Advanced CLAw FULL - The Ultimate Autolooter - Public Release!

[TrailMyx]

Here's an excerpt from the Admin chat channel where Cerveza and I were discussing the looting time comparisons of the EUO and OEUO version of the CLAw:

------------------------------------

Here's an even more impressive test.  I have single expression evaluation working so things like:

Magery > 10  (i.e. no complex rules yet)

Are evaluated in this example (113 pieces of jewelry):

(16 active rules)

Code: [Select]

FINDITEM time: 5.597000 seconds for 112 items
Hit Chance Increase match!
Strength Bonus match!
Hit Chance Increase match!
Dexterity Bonus match!
Magery match!
Magery match!
Luck match!
Luck match!
Dexterity Bonus match!
Luck match!
Magery match!
Hit Chance Increase match!
Intelligence Bonus match!
Luck match!
Lower Reagent Cost match!
Luck match!
Luck match!
Strength Bonus match!
Luck match!
Container eval time: 5.710000 seconds for 112 items
Rules executed = 2912
done looting

So the script executed 2912 rules in 113 milliseconds.  That means each rule takes 38.8 microseconds.  Going back to the CLAw, @9-15 milliseconds/rule, that means this script is 250-390 times faster.  This would take the old CLAw 26.2-43.7 seconds instead of 113 milliseconds.

Ah, math.  Annoying because people will still bitch about that 5.597 seconds it takes OEUO to do the finditem.  The event property doesn't add much overhead at all; that's all FINDITEM.

Will probably be able to really get some interesting looting profiles with OEUO!

[Crome969]

Here's an excerpt from the Admin chat channel where Cerveza and I were discussing the looting time comparisons of the EUO and OEUO version of the CLAw:

------------------------------------

Here's an even more impressive test.  I have single expression evaluation working so things like:

Magery > 10  (i.e. no complex rules yet)

Are evaluated in this example (113 pieces of jewelry):

(16 active rules)

Code: [Select]

FINDITEM time: 5.597000 seconds for 112 items
Hit Chance Increase match!
Strength Bonus match!
Hit Chance Increase match!
Dexterity Bonus match!
Magery match!
Magery match!
Luck match!
Luck match!
Dexterity Bonus match!
Luck match!
Magery match!
Hit Chance Increase match!
Intelligence Bonus match!
Luck match!
Lower Reagent Cost match!
Luck match!
Luck match!
Strength Bonus match!
Luck match!
Container eval time: 5.710000 seconds for 112 items
Rules executed = 2912
done looting

So the script executed 2912 rules in 113 milliseconds.  That means each rule takes 38.8 microseconds.  Going back to the CLAw, @9-15 milliseconds/rule, that means this script is 250-390 times faster.  This would take the old CLAw 26.2-43.7 seconds instead of 113 milliseconds.

Ah, math.  Annoying because people will still bitch about that 5.597 seconds it takes OEUO to do the finditem.  The event property doesn't add much overhead at all; that's all FINDITEM.

Will probably be able to really get some interesting looting profiles with OEUO!

As i always said
euo --> Trunk
oeuo --> supreme
and when u finish that i think i can trunk my own looter

[HomePig]

Amm...
I feel Kinda stupid.. where do I get this script ?

[MeWonUo]

Amm...
I feel Kinda stupid.. where do I get this script ?

Start with reading the site rules...

[NObama]

Alright.  I've manually ready about 2/3s of this thread looking for what I need.  I either missed it or I'm never going to be patient enough to find it.

I'm looking for the discussion on how to integrate CLAW looting into my own script.  I saw TM's post in another thread about the global variable to monitor, but I can't find the discussion here.  Point me to a post number?

[TrailMyx]

If you look into the quester 2.0, the code is there.

[Khameleon]

Its been a while since I've sat down and looked at the code but I got something like this.. I probbaly ripped it out of the quester THANKS TM!

Code: [Select]

Sub LootChest
set %container %Chest
  gosub OpenContainerID %container
  wait 5
  gosub TM_EvaluateContainer %container #Backpackid
  set #LPC 2
  repeat
    gosub TM_LootInProgress
  until #RESULT = #FALSE
  set #LPC 1000
Return

;------------------------------------------------------------
; sub TM_EvaluateContainer
; %1 - source container to evaluate
; %2 - destination container ID to place items passing evaluation
; return:
;   none
sub TM_EvaluateContainer
  namespace push
  namespace global TM_loot
  set !TM_loot_artifact_success #FALSE
  set !TM_loot_success #FALSE
  set !TM_eval_source %1
  set !TM_eval_destination %2
  set !TM_eval_request #TRUE
  set !TM_loot_in_progress #TRUE ; needed??? probably, due to time taken to start looter.
  namespace pop
return

;------------------------------------------------------------
; sub TM_LootInProgress
; return:
;   #TRUE if Looting is in progress, wait until #FALSE
;   #FALSE looting is idle.
sub TM_LootInProgress
  namespace push
  namespace global TM_loot
  set #RESULT !TM_loot_in_progress
  namespace pop
return #RESULT

[NObama]

Beautiful!  Thanks very much!

[Neo]

First of all, I'd like to thank TM for this script, I've been using it extensively the last few days, and the possibilities are endless...

When I started testing this with my crafter, sometimes I found that it the script continued right past the until #result = #false line, even if lootinprogress should be #true...

I have no idea as to why this would happen, but I fixed this putting a wait in there... So the code I use looks something like this:

Code: [Select]

gosub TM_EvaluateContainer %recyclebag %armorbag ;
set %temp_LPC #LPC
set #LPC 2
wait 20
repeat
gosub TM_LootInProgress
until #RESULT = #FALSE
set #LPC %temp_LPC

Hope this is useful

neo

EDIT: This was mainly ripped from the heartwood quester...

[NObama]

Another easy question:

I kill many things.  I wish to loot all their corpses.  Can I send a single command to the CLAW like so:

    finditem YFM G_2
    For u! 1 #findcnt
      {
      gosub TM_EvaluateContainer #findid G_2
      ignoreitem #findid
      }

Because it's no workin' Cap'n.  SHE NEEDS MORE POWER!

[Neo]

Another easy question:

I kill many things.  I wish to loot all their corpses.  Can I send a single command to the CLAW like so:

    finditem YFM G_2
    For u! 1 #findcnt
      {
      gosub TM_EvaluateContainer #findid G_2
      ignoreitem #findid
      }

Because it's no workin' Cap'n.  SHE NEEDS MORE POWER!

I think this would work like this:

Code: [Select]

finditem YFM G_2
    For !u 1 #findcnt
      {
      set #lobjectid #findid
      event macro 17
      gosub gumpwait #contname #contsize
      gosub TM_EvaluateContainer #findid #backpackid
      set %temp_LPC #LPC
      set #LPC 2
      wait 20
      repeat
      gosub TM_LootInProgress
      until #RESULT = #FALSE
      set #LPC %temp_LPC
      gosub offsetclick x y r ; (a line to close the corpse you just evaluated)
      ignoreitem #findid
      }

edit: !u

[NObama]

Thanks, frneo.  I'll give that a shot.  I could just hardcode in the items I'm looting, but dammit I'm going to learn how to do CLAW implementation!

[MR_X]

I've read all 40 pages of this thread and let me tell you I am so very excited to get to try this out and tweak it to my item looting needs.  If this works as well as I've been reading, you will have saved me about 1 million double clicks. 

[MeWonUo]

I've read all 40 pages of this thread and let me tell you I am so very excited to get to try this out and tweak it to my item looting needs.  If this works as well as I've been reading, you will have saved me about 1 million double clicks. 

1 million is on the low side of things. 

[THERA]

outstanding script! Timeless as ever however I do have a question. Scripting down in Heartwood at the fletchers. I wanna keep Ward Removal talismans but there's no option for that and the user defined text didn't work. Any suggestions? Thank you in advance.