;===================================================================
; Script Name: Crisis SOS Chest Fisher
; Author: Crisis
; Version: 3.0
; Client Tested with: 7.0.87.1
; EUO version tested with: 1.6.0 (version 335)
; Shard OSI / FS: OSI
; Release Date: 05/07/2012
; Revision Date: 10/12/2020
; Purpose:
;     Completely automates the operation of fishing up treasure chests when you are in the correct area of your SOS.
;     Works great with Kal In Ex's SOS Master
;
; Features:
;     . Automatically fishes until you fish up a treasure chest. Cuts bones after fishing up chest.
;
; Revisions:
;     . Added bone cutting sub
;     . Cleaned up code
;     . Added Chest Sorter (sorts magery scrolls into the 8 circles, necro scrolls, reagents, and gems into storage containers)
;     . Added Item Mover (moves everything from one container to another to combine chests to allow for more time on the water)
;     . Added Bag Clean Up (empties into the trashcan for cleanup points)
;     . Fixed Buttons
;
; Requirements:
;     . You should be on a boat in the area of your SOS.
;     . Must have the SOS and fishing pole in your backpack.
;     . You must hard code in your sorting containers.
;     . You must have your backpack open when you start fishing.
;
; Possible Updates:
;     .
;
; Special Thanks:
;     . TrailMyx for helping me iron out the kinks and for TrailMyx's Advanced Journal Handler and Chest Sorter
;     . _C2_ for the Menu Tutorial http://www.scriptuo.com/index.php?topic=1535.0
;     . Gaderian for help with the new EUO menu changes and cleaning the code up some!
;
; Changes that you will need to make will be marked like this:
;XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
;XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
; Watch for these changes and make them accordingly
;XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
;XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
;
; Copyright: 2020 Crisis


This is my first script so be gentle.

This is a very basic script to be used with Kal In Ex's SOS Master Script.

Make sure you read the requirements!! At this time, you must hard code in your containers that you want to sort loot into!

I got tired of double clicking my fishing rod and was fishing up endless sunken wreckage so I put this together.

1. Grab a beer, a pirate hat, and be ready to recover sunken booty.
2. Get on boat.
3. Use Kal In Ex's SOS master to load your SOS and then sail to them.
4. Use Crisis SOS Chest Fish them up.
5, Drink more beer and prepare to do more!

Enjoy!

Update 6-16-2013 Version 2.4
  Added Menu - 3 buttons, Fishing, Cut Bones, Sort Loot
  Cleaned up code.

Update 6-19-2013 Version 2.5
  Added hard coding of sort chests to the top
  Cleaned up code

Update 10-12-2020 Version 3.0
  Updated the EUO menu to make the buttons work again (Thanks Gaderian!)
  Added the ability to move items from one container to another
  Added the ability to sort the chests moving mage scrolls (by circle), necro scrolls, reagents, and gems into storage containers
  Added the ability to empty the pack of fished up items into the trash can for clean-up points.

Little Johnny walks into school one day to find a substitute in place of his regular teacher.

She says, "Hello class, I'm Mrs. Prussy. When you say my name class remember it has an "r" after the first letter."

The entire class says, "Hello Mrs. Prussy."

A few days later the regular teacher is still sick when Little Johnny gets to his desk the teacher asks what her name is.

Johnny thinks hard and the says to the teacher, "I remember it has an "r" after the first letter."

"That's right!" she coaxed.

Then after a few seconds Little Johnny says, "Mrs. Crunt?"

I am not sure if I am on the right track or not, guessing not because it is not stopping once the chest is pulled up. I may be using the wrong term to end the script, I am using halt.

gosub TM_AdvJournalSync FISHING
finditem XHF_KDF C_ , #BACKPACKID
  if #FINDKIND = -1
  {
    finditem XHF_KDF C_ , #CHARID
    if #FINDKIND = -1
    {
      display ok How can you fish without your fishing pole?
      halt
    }
  }
  set %fishingpole #FINDID
 
SOSFishLoop:
 findItem XHF 1
 set #LObjectID #FindID
 set #LTargetKind 2
 set #LTargetX 0 + #CharPosX
 set #LTargetY 4 + #CharPosY
 event macro 17 0
 target
 event macro 22 0
 set %fishtimeout #SCNT + 9
 target 12s

 gosub TM_AdvJournalScan FISHING VALID chest_from_the_depths_of_the_ocean
 if #RESULT = #TRUE
    {
    TM_AdvJournalSync Fishing
    goto endSOSFish
      }
 goto SOSFishLoop
 
EndSOSFishLoop:
 Halt

;=================================================================
;------------------------  Call interface  -----------------------
;=================================================================
set !TM_FunctionCalled #FALSE
if %0 = 1
  gosub %1
if %0 = 2
  gosub %1 %2
if %0 = 3
  gosub %1 %2 %3
if %0 = 4
  gosub %1 %2 %3 %4
if %0 = 5
  gosub %1 %2 %3 %4 %5
if %0 = 6
  gosub %1 %2 %3 %4 %5 %6
if %0 = 7
  gosub %1 %2 %3 %4 %5 %6 %7
if %0 = 8
  gosub %1 %2 %3 %4 %5 %6 %7 %8
if %0 = 9
  gosub %1 %2 %3 %4 %5 %6 %7 %8 %9
if %0 = 10
  gosub %1 %2 %3 %4 %5 %6 %7 %8 %9 %10
if %0 = 11
  gosub %1 %2 %3 %4 %5 %6 %7 %8 %9 %10 %11
if %0 > 11
{
  display ok Too many arguments for "call", edit file.
  stop
}

if !TM_FunctionCalled = #TRUE
  exit
if %0 = N/A
  display ok You may not run this script directly.
else
  display ok Function " , %1 , " not found.
stop
;-------------------------------------------------------------------------------
sub TM_AdvJournalGetTrigger
  namespace push
  namespace local TM_AdvJS_ , %1
  set #RESULT !trigger
  namespace pop
  set !TM_FunctionCalled #TRUE
return #RESULT
;-------------------------------------------------------------------------------
; %1 - Journal Name
; %2 - #LPC setting (optional)
; Brings !_jindex up to the most recent #journal entry
sub TM_AdvJournalSync
  namespace push
  namespace local TM_AdvJS_ , %1
  set !_jindex #jindex + 1
  if %0 > 1
    set !lpc_set %2
  namespace pop
  set !TM_FunctionCalled #TRUE
return
;-------------------------------------------------------------------------------
; %1 - Journal Name
; %2 - NONE, ADVANCE , ( _VALID ) - advances jindex pointer, anything else
; %3, %4, %5, etc strings to match
; returns #TRUE for match, #FALSE for no match
;  Will not advance !_jindex pointer to allow for scanning journal history for more than one search.
;  Also searches for : , #SPC in journal entry to be sure someone isn't spamming the text
;  About %2 arguments:
;    NONE: defaults to basic journal scan (no SPAM checking, no #jindex pointer copy advancing)
;    ADVANCE: no spam checking, advances #jindex copy
;    VALID: invokes SPAM filtering, no advance of #jindex copy
;    VALID_ADVANCE, VALIDADVANCE, ADVANCE_VALID, etc.: invokes SPAM filtering, advances of #jindex copy
sub TM_AdvJournalScan
  namespace push
  namespace local TM_AdvJS_ , %1
  set !args %2
  set !temp_lpc #LPC
  if !lpc_set = N/A
    set #LPC 1000
  else
    set #LPC !lpc_set
  set !num_args %0
  set !first_arg 3
  set !sampled_jindex #JINDEX
  if !_jindex = N/A
    set !_jindex !sampled_jindex
  if !charname = N/A
  {
    set !charname #CHARNAME
AdvJournalScan_loop1:
    str pos !charname #SPC
    if #STRRES <> 0
    {
      set !val #STRRES - 1
      str left !charname !val
      set !left #STRRES
      set !val !val + 1
      str del !charname 1 !val
      set !charname !left , _ , #STRRES
      goto AdvJournalScan_loop1
    }
  }
  set !index !first_arg
  repeat
    set !temp_jindex !_jindex
    set !text % . !index
    while !temp_jindex <= !sampled_jindex
    {
      scanjournal !temp_jindex
      str pos #JOURNAL !charname 1
      set !namepos #STRRES
      str count #JOURNAL !charname
      set !namecnt #STRRES
      str pos #JOURNAL :_ 1
      set !smcpos #STRRES
      str pos #JOURNAL !text 1
      set !textpos #STRRES
      if !textpos < !smcpos && !smcpos <> 0 || !smcpos = 1 || :_ notin #JOURNAL || VALID notin !args
        set !pass #TRUE
      else
        set !pass #FALSE
      if ( !text in #journal && ( ( !namepos = 1 && !namecnt <= 1 ) || !pass ) )
      {
        set !temp_jindex !temp_jindex + 1
        if ADVANCE in !args
          set !_jindex !temp_jindex
        set !trigger !text
        set #LPC !temp_lpc
        namespace pop
        set !TM_FunctionCalled #TRUE
        return #TRUE
      }
      set !temp_jindex !temp_jindex + 1
    }
    set !index !index + 1
  until !index - !first_arg > !num_args - !first_arg
  set %10 !sampled_jindex - !_jindex
  set %10 %1 , _ , %10 ; for debugging purposes
  set #LPC !temp_lpc
  set TM_AdvJournalGetTrigger #FALSE
  namespace pop
  set !TM_FunctionCalled #TRUE
return #FALSE
;-------------------------------------------------------------------------------



Ok I am using Kal In Ex's SOS Master to take me to SOS locations for SOS that I have on me. I can do quite a few quickly and was getting tired of double clicking the fishing pole so I decided to try and write a very basic script to fish there until it pulls up a treasure chest. I am getting stuck on the journal scan, the rest is working fine. It keeps fishing after the chest is pulled from the water.

finditem XHF_KDF C_ , #BACKPACKID ; this first part is borrowed from TM
  if #FINDKIND = -1                     
  {
    finditem XHF_KDF C_ , #CHARID
    if #FINDKIND = -1
    {
      display ok How can you fish without your fishing pole?
      halt
    }
  }
  set %fishingpole #FINDID

findItem XHF 1
set #LObjectID #FindID
set #LTargetKind 2
set #LTargetX 2 + #CharPosX
set #LTargetY #CharPosY
event macro 17 0
target
event macro 22 0
set %fishtimeout #SCNT + 9
target 12s
{
if You_pull_up_a_heavy_chest_from_the_depths_of_the_ocean in #journal
halt
}
return
Any help would be appreciated and I would love for someone to explain anything that I did wrong.

Thanks!

After a long night of making love, the guy notices a photo of another man, on the womans nightstand. He nervously asks,'Is this your husband? 'No, silly,' she replies, 'Your boyfriend, then?' he continues. 'No, not at all,' she says, Is it your your brother?' he inquires, hoping to be reassured. 'No, no, no! You are so hot when you're jealous!' she answers. 'Well, who in the hell is he, then?' he demands. She whispers in his ear. 'That's me before the surgery

lol

As long as you loot the maps yourself, they are extremely profitable. I never buy maps because it takes a lot of the profit away. I get most of my maps from Maisma so it is 0 cost. The ones from the chest are level 6 and you can level 5 on the body. 5k per level so 25k to 30k right off the bat. Most of the arties are easy to find cheap so I usually unravel them but you can put them up for like 10k and they usually sell ok. If you have an inbuer, you can unravel everything or just the stuff that unravels into essences which is what I do. The sot's can be sold for a decent amount along with the essences that come in the chest. There is one per level and can usually be sold in stacks of 10 for anywhere from 100k-500k depending on server. You also get the gold and loot from the guardians. That usually adds up to 10-20k for 5th and 6th level. On the level 6 chests, there is also a chance for a level 7 map. I also manipulate the chest (that sounds bad doesn't it? lol) when I am done pulling what I want. I can usually get an extra 10-15 mobs to spawn but pulling something up and letting it fall back in. People also like the skeleton keys and pet treats. If you look at it as a per chest profit, then it doesn't seem like much but they are quick and easy to do. They add up quickly and are fun to do.

I know this is an older post but decided to answer it just in case someone else was wondering the same thing. Treasure hunting and fishing are my main pleasures in UO.

The vet account token sounds like it would be a cool idea for an extra house. It would be nice if they would let an account have a house on a production shard and one on siege as well.