Author Topic: Bod Filler Expanded to Newer Craft Options  (Read 24140 times)

0 Members and 1 Guest are viewing this topic.

Offline GaderianTopic starter

  • Elite
  • *
  • *
  • Posts: 486
  • Activity:
    0%
  • Reputation Power: 10
  • Gaderian barely matters.Gaderian barely matters.
  • Respect: +50
  • Referrals: 3
    • View Profile
Re: Bod Filler Expanded to Newer Craft Options
« Reply #30 on: October 14, 2021, 12:46:48 AM »
0
"Wood Container Engraving Tool" gets hung up when the wood type is other than normal.

Was this for an exceptional SBod? If so, then I found and fixed this issue. It would have been more generic to apply to any of the items that are for an exceptional SBod and where the color is always the same regardless of source materials.

If it was not for an exceptional SBod, then I need more information.

"Go ahead ask me: 'Should I use hard waits or timers?'"
You say:"Should I"
Gaderian:"Timers!"
You Say:"use hard waits or timers?"

The serious side of timer use is illustrated here: http://www.scriptuo.com/index.php?topic=12094.msg101926#msg101926

However, every time I go back and look at this [AutoLooter] script, I realize I had wrote it in my zen state of EUO scripting - so it makes my brain hurt.

Offline TrackStar

  • Jr. Member
  • **
  • Posts: 84
  • Activity:
    0%
  • Reputation Power: 1
  • TrackStar has no influence.
  • Respect: +1
  • Referrals: 0
    • View Profile
Re: Bod Filler Expanded to Newer Craft Options
« Reply #31 on: October 14, 2021, 03:56:59 AM »
0
In every case it was a normal oak.

Wood container not metal container like we discussed earlier.

Offline GaderianTopic starter

  • Elite
  • *
  • *
  • Posts: 486
  • Activity:
    0%
  • Reputation Power: 10
  • Gaderian barely matters.Gaderian barely matters.
  • Respect: +50
  • Referrals: 3
    • View Profile
Re: Bod Filler Expanded to Newer Craft Options
« Reply #32 on: October 14, 2021, 09:32:43 AM »
0
I understand this is a carpentry item.
Is the name of the crafted item “wood” or “wooden”? All the online documentation state wooden.
If it really is “wood container engraving tool” then craftinfo needs to change. If it is “Woden” then I need to step through the code.
"Go ahead ask me: 'Should I use hard waits or timers?'"
You say:"Should I"
Gaderian:"Timers!"
You Say:"use hard waits or timers?"

The serious side of timer use is illustrated here: http://www.scriptuo.com/index.php?topic=12094.msg101926#msg101926

However, every time I go back and look at this [AutoLooter] script, I realize I had wrote it in my zen state of EUO scripting - so it makes my brain hurt.

Offline TrackStar

  • Jr. Member
  • **
  • Posts: 84
  • Activity:
    0%
  • Reputation Power: 1
  • TrackStar has no influence.
  • Respect: +1
  • Referrals: 0
    • View Profile
Re: Bod Filler Expanded to Newer Craft Options
« Reply #33 on: October 14, 2021, 01:50:29 PM »
0
"Wooden Container Engraving Tool"

Offline GaderianTopic starter

  • Elite
  • *
  • *
  • Posts: 486
  • Activity:
    0%
  • Reputation Power: 10
  • Gaderian barely matters.Gaderian barely matters.
  • Respect: +50
  • Referrals: 3
    • View Profile
Re: Bod Filler Expanded to Newer Craft Options
« Reply #34 on: October 14, 2021, 07:41:26 PM »
0
So, Wooden Container Engraving Tool (WCET) has 2 ingredients: boards and ingots. So this is more related to the Nunchaku solution than the tinkered items which make the item in only 1 color.
Bone armor makes items in 1 color and has 2 ingredients (leather of some color and bones) - so were affected by both issues.

I included a bunch of items that should override for the correct color of the item for tinkering. I did not test all of these.

I fixed the logic that any ingredients other than the first one would have plain (0) for it's color. I only tested the WCET and Bone armor (I made spined bone for one item and barbed bone for all the rest, but made a complete set of bods to cover a suit).

If I get more feedback, I will work at stuff next week when I am off, otherwise it will likely be the end of the calendar year to fix anything else that is deep.

New version posted 3.14.15.3
"Go ahead ask me: 'Should I use hard waits or timers?'"
You say:"Should I"
Gaderian:"Timers!"
You Say:"use hard waits or timers?"

The serious side of timer use is illustrated here: http://www.scriptuo.com/index.php?topic=12094.msg101926#msg101926

However, every time I go back and look at this [AutoLooter] script, I realize I had wrote it in my zen state of EUO scripting - so it makes my brain hurt.

Offline TrackStar

  • Jr. Member
  • **
  • Posts: 84
  • Activity:
    0%
  • Reputation Power: 1
  • TrackStar has no influence.
  • Respect: +1
  • Referrals: 0
    • View Profile
Re: Bod Filler Expanded to Newer Craft Options
« Reply #35 on: October 14, 2021, 07:42:51 PM »
0
I'm going hard on BODs lately and will continue reporting any issues I find.

Offline Thargorff

  • Jr. Member
  • **
  • Posts: 15
  • Activity:
    0%
  • Reputation Power: 1
  • Thargorff has no influence.
  • Respect: +1
  • Referrals: 0
    • View Profile
Re: Bod Filler Expanded to Newer Craft Options
« Reply #36 on: October 20, 2021, 05:32:26 AM »
0
Thank you for your hard work on this Gaderian. And thank you for the opportunity i had to help you testing it in the development phase

Offline GaderianTopic starter

  • Elite
  • *
  • *
  • Posts: 486
  • Activity:
    0%
  • Reputation Power: 10
  • Gaderian barely matters.Gaderian barely matters.
  • Respect: +50
  • Referrals: 3
    • View Profile
Re: Bod Filler Expanded to Newer Craft Options
« Reply #37 on: October 20, 2021, 10:29:21 AM »
0
Thargorff,
Between you and REEFHAWK, you two did 99% of testing and great feedback. This project would still be a dream without both of you helping. Much appreciated.
"Go ahead ask me: 'Should I use hard waits or timers?'"
You say:"Should I"
Gaderian:"Timers!"
You Say:"use hard waits or timers?"

The serious side of timer use is illustrated here: http://www.scriptuo.com/index.php?topic=12094.msg101926#msg101926

However, every time I go back and look at this [AutoLooter] script, I realize I had wrote it in my zen state of EUO scripting - so it makes my brain hurt.

Offline Hitechs

  • Full Member
  • ***
  • Posts: 116
  • Activity:
    0%
  • Reputation Power: 2
  • Hitechs has no influence.
  • Respect: +28
  • Referrals: 1
    • View Profile
Re: Bod Filler Expanded to Newer Craft Options
« Reply #38 on: December 06, 2021, 11:39:56 AM »
0
Great script, thanks gaderian and everyone that helped,

Inscribe:
just put 5 full sets for circle 7 larges , 5 full sets for circle 4 larges in backpack and hit play, it filled them all.
also called this script from mine and filled like 600 smalls.

Seems to have issues filling the larges, but if i stop and restart, it will add a few smalls to the large and error again

other problems found so far was one reg, and one scroll
(not sure if they my edit errors , or my errors helping in development, or me running old versions)

outstanding job , all !













Offline Hitechs

  • Full Member
  • ***
  • Posts: 116
  • Activity:
    0%
  • Reputation Power: 2
  • Hitechs has no influence.
  • Respect: +28
  • Referrals: 1
    • View Profile
« Last Edit: December 06, 2021, 11:57:32 AM by Hitechs »

Offline GaderianTopic starter

  • Elite
  • *
  • *
  • Posts: 486
  • Activity:
    0%
  • Reputation Power: 10
  • Gaderian barely matters.Gaderian barely matters.
  • Respect: +50
  • Referrals: 3
    • View Profile
Re: Bod Filler Expanded to Newer Craft Options
« Reply #40 on: December 06, 2021, 08:09:22 PM »
0
It is a script based issue. It is trying to match up the color of the large and the small together. Think about it from the standpoint of colored materials - spined leather or copper ingots - and it makes sense.

When it comes to some items that either have the same color regardless of material (tinkered clippers are the same color, as an example) then there are exceptions to the above rule. This is the rule that needs to be used for inscription. I suspect that all the inscription LBOD/SBOD filling requires this kind of exception.

That is without looking at it or trying it - sorry a bit overwhelmed on my current time schedule. I will have more time next week if you still need more help.

Gaderian
"Go ahead ask me: 'Should I use hard waits or timers?'"
You say:"Should I"
Gaderian:"Timers!"
You Say:"use hard waits or timers?"

The serious side of timer use is illustrated here: http://www.scriptuo.com/index.php?topic=12094.msg101926#msg101926

However, every time I go back and look at this [AutoLooter] script, I realize I had wrote it in my zen state of EUO scripting - so it makes my brain hurt.

Offline TrackStar

  • Jr. Member
  • **
  • Posts: 84
  • Activity:
    0%
  • Reputation Power: 1
  • TrackStar has no influence.
  • Respect: +1
  • Referrals: 0
    • View Profile
Re: Bod Filler Expanded to Newer Craft Options
« Reply #41 on: December 07, 2021, 09:42:31 AM »
0
I'm jumping into BODs heavily again now that the event is over. Will probably fill 10k~. Will report issues as I go.

Offline Hitechs

  • Full Member
  • ***
  • Posts: 116
  • Activity:
    0%
  • Reputation Power: 2
  • Hitechs has no influence.
  • Respect: +28
  • Referrals: 1
    • View Profile
Re: Bod Filler Expanded to Newer Craft Options
« Reply #42 on: December 07, 2021, 05:10:59 PM »
0
guess i need better debug skillz,
(could start up private test shard, and make my own bods)

4 sets & larges (left 1 small out of each large for testing)
crafted all smalls for large but 1, script filled all smalls no issues
got error a few times filling large,
stopping and starting script a few times got the larges filled

picked up last 4 smalls, hit play,
only adding 1 small to each large completed without error.

guess i need to test / debug more,

here a lame video, ya i know lol
but has the easyuo var list in view
(might need to wait little more for youtube to make HD)


https://www.youtube.com/watch?v=iQH784fE6kw&t=791s = time it starts to fill larges with errors

https://www.youtube.com/watch?v=iQH784fE6kw&t=1147s = time i start it with last small for each, that completes without error

https://www.youtube.com/watch?v=iQH784fE6kw = whole video


Offline Hitechs

  • Full Member
  • ***
  • Posts: 116
  • Activity:
    0%
  • Reputation Power: 2
  • Hitechs has no influence.
  • Respect: +28
  • Referrals: 1
    • View Profile
Re: Bod Filler Expanded to Newer Craft Options
« Reply #43 on: December 07, 2021, 05:58:39 PM »
0
made 2nd video,

three full bod sets & larges,
starting script multiple times after errors, finally got all the larges filled
(might need little more time for youtube to make HD)

https://www.youtube.com/watch?v=qCN-7k03cK0&t=696s = time script starts filling larges / errors

Offline GaderianTopic starter

  • Elite
  • *
  • *
  • Posts: 486
  • Activity:
    0%
  • Reputation Power: 10
  • Gaderian barely matters.Gaderian barely matters.
  • Respect: +50
  • Referrals: 3
    • View Profile
Re: Bod Filler Expanded to Newer Craft Options
« Reply #44 on: December 07, 2021, 06:45:05 PM »
0
My guess is that there is a ghost item in your backpack.

The script issues a finditem for all BOD types in your backpack and the first one receives the #findcol value, which is 0. This doesn't look like the case because you do not seem to have a random scroll (of the same type as a BOD - there are others that share this type) in your backpack.

Now it passes that #findcol value to figure out what type it is among valid BODs and produces the error.
What is interesting is your first video manages to fill the initial large except for the lacking SBOD. Then it is the second attempt to fill a large of the same types that fails. At this point several of the SBods would have been combined into the LBod, so the ghost item seems likely. I am not sure I tested filling several LBods of the exact same specifications, so I think your error is valid.

You should prove it by displaying a little more information before making a fix. How would I do that? Adjust the s7FindSBod routine to display the information and give me a chance to examine what my variables are at the point of the error.
Test it with the following alteration to this routine:
Code: [Select]
;///////////////////////////////////;
; s7FindSBod
; finds a filled sbod in backpack by name, quantity, and quality
;///////////////////////////////////;
sub s7FindSBod
  set %FSBProp %2
  set %FSBcnt %1
  finditem EYM C_ , #backpackid
  set %FSBfindcnt #findcnt
; Insert test code here
if #findcol = 0
 {
 display ok script paused because #findcol = 0 - verify the #find... variables
 pause
 }
; End test code
  gosub SetBodType #findcol
  set %s7BFSbodType #result
  for %FSBfindI 1 %FSBfindcnt
  {
    finditem EYM %FSBfindI C_ , #backpackid
    gosub s7GetProperty #findid A , #spc , Bulk , #spc , Order , #spc , Deed$
    if %FSBProp in #property && large , #spc , bulk notin #property && ( ( %s7BFLbodExceptional && exceptional in #property ) || ( ! %s7BFLbodExceptional && exceptional notin #property ) )
    {
      gosub s7GetBodAmountMade
      gosub GetBodMaterial #Property %s7BFSbodType
      set %s7BFSBodMaterial #result
      if %s7BFBodAmountMade = %FSBCnt && _ , %s7BFSBodMaterial , _ in _ , %s7BFLBodMaterial , _
        return #true
    }
  }
return #false
"Go ahead ask me: 'Should I use hard waits or timers?'"
You say:"Should I"
Gaderian:"Timers!"
You Say:"use hard waits or timers?"

The serious side of timer use is illustrated here: http://www.scriptuo.com/index.php?topic=12094.msg101926#msg101926

However, every time I go back and look at this [AutoLooter] script, I realize I had wrote it in my zen state of EUO scripting - so it makes my brain hurt.

Tags: