Are these new item properties?

No, the new one is  Assassin Honed, it give a bonus di, when you "follow" the enemy (face same direction) i think it will overpower moving shot, and dismount chars.

damage eater = 18%, specific eater = 30%

don't working on last patch, the find vendor is with problem, "ps i have allready fix the findrep thing."

=D i found the error is juts change to


if #findrep <> 7

Again =[

Gotos make it hard to convert it later in other scriptlanguanges(Openuo as Example) As best is replace Gotos with repeat .. until. and when not need anymore break through with break or "reach" the until.

This break help a lot

Code: [Select]

Finditem ZLF C ;No Backpackonly?
if #findkind <> -1 {
for #findindex 1 #findcnt {
if #scnt > %Factiontime && Factionbandage = YES{
event property #findid
if Enchanted in #property{
set #lobjectID #findid
event macro 17
target ;Default 3s if you would have lagg at the targeting moment, no missing of bandage
event macro 23
set %Factiontime #scnt + 12
break ;Break trough the for loop
}
}
Else{
if Clean in #property{
set #lobjectID #findid
event macro 17
target ;Default 3s if you would have lagg at the targeting moment, no missing of bandage
event macro 23
break ;Break trough the for loop
}
}
}
}just a small Idea

I will use your routine, only now i'm starting to understand how break is useful =D, i will make a test today ( i will do a champ alone) then i post if is stop my loop issue.

#FINDCOL will always return the correct information about what color something is. What I'm saying is that the bandage color may not be what you are looking for. Aren't Faction bandages dyable?

If the color of faction bandages can change, then #findcol will never find them, correct? Will the name ever change? Thus #property > #findcol.

Something that will never change, like ORE for example would be an excellent use of #findcol.

Code: [Select]

sub PropertyPwnsFindcol
finditem ZLF C_ , #backpackID
if #findCnt > 0
  {
  event Property #findID
  if faction in #property
    {
    msg Hey look, faction bandages $
    msg Maybe I should do whatever it was I wanted to do with them $
    return
    }
  msg Hey look, bandages that are NOT faction bandages $
  msg I'm just going to ignore these things and move on $
  ignoreitem #findID
  }
msg Didn't find any bandages, sorry $
return

Hmm, you show to us another way of do the check in tree =) , with your example is just add   if faction in #property && %counter < #scnt then inside the counter just add set %counter #scnt + 14 (the timer is 18 but if you was max dex you still need 4 seconds to do the next bandage so 14 is fine.

My one actually isn't that clean

finditem ZLF C
if #findkind <> -1
{
for #findindex 1 #findcnt
{
if #scnt > %Factiontime && %Factionbandage = YES
{
event Property #findID
set %factband #findstack , #spc , Enchanted , #spc ,
if %factband in #property
 {
  set #lobjectid #findid
  event macro 17 0
  target 1s
  event macro 23 0
  ; set %Factiontime #scnt + 12
 } ; if %factband in #property
} ;if #scnt > %Factiontime
else
{
event Property #findID
set %factband #findstack , #spc , Clean , #spc ,
if %factband in #property
 {
  set #lobjectid #findid
  event macro 17 0
  target 1s
  event macro 23 0
  } ; if %factband in #property
} ; Else
} ; for #findindex 1 #findcnt
} ; if #findkind <> -1
For example Cerveza at your way don't have a chance of 50% in the first bandage it use normal bandage without the faction one even if the timer is right ?

because you finditem first then only after make the find property, if the first search isn't the right one (faction), it will use normal bandage, to after try again the faction, and if you are unlucky again and again you never will use the faction right?

Not sure about euox interpreters, but at first read i thinked on that.

Is there a reason no one has mentioned #FINDCOL ?  This is offhand, but it would look something like this?

<sub>Finditem ZLF C_ , #backpackID
if #findkind <> -1
{
 for #findindex 1 #findcnt
 {
  if #FINDCOL = XXXX    ; I don't know the faction color offhand
   gosub FactionBandage
  if #FINDCOL = 0       ; Regular bandage
   gosub RegularBandage
 }

}</sub>

With Event Property you can easily move too fast if you have any type of lag and get a "$" (default) value meaning your script  will not see the bandage as a faction bandage.  I don't think it's going to make a huge difference in time, but I would bet #findcol is a little faster since you have to do the finditem anyway.

If you do plan on just using the #Property you might want to write in a holding sub to make sure you give the script enough time to update the variable.  It's been a while since I've written, so if something I've suggested isn't correct please correct me. 

_{Sub WaitForProperty
set %MaxDelay #Scnt + 2
While #Property = $ && %MaxDelay > #Scnt
wait 1
if #Property = $
 return #False
else
 return #True}

Does this make sense?

Why make 2 If findcol, isn't better for the euox make if and else, so it will use regular bands and enhanted(nofact) ones, but i like the idea of findcol