neo's Bod Swapper Public Edition v1.0 out 09/22/2011

[Neo]

Code: [Select]

;===================================================================================
; Script Name: neo's Bod Swapper Public Edition
; Author: neo
; Version: 1.0
; Client Tested With: 7.0.18.0
; EUO version tested with: 1.50 202
; Shard OSI / FS: OSI
; Revision Date: 09/22/2011
; Public Release: 09/06/2011
; Purpose: Swaps filled bods at NPC. Will recall home to drop off stuff.
;          Only for Smith BODS!
;-----------------------------------------------------------------------------------
; Special Thanks: - TM for his NGFS and Recall subs.
;                 - 12timesover for his XIIxMaxWeight sub
;                 - MeWonUo who's the co-author of our private edition :)
;                 - Newsman for debugging v0.2 with me for people with low ping!
;-----------------------------------------------------------------------------------
; Url:     http://www.scriptuo.com/index.php?topic=8460.0
;------------------------------------------------------------------------------------
; Version   1.0 Lots of changes:
;               - Changed recall subs. You can now choose whatever runes for all 4
;                 runes you wish to use
;               - Redid menu, and the way setup works
;               - Saving will now work properly
;               - If an NPC can't be found within 2 tiles, it will search for an NPC up
;                 to 7 tiles away, and then walk over to them to do the swapping.
;                 Won't open doors though, so make sure there aren't any doors
;                 between you and the NPC. And it won't pathfind either, so have a
;                 clear path to the NPC! Thank you TM for this suggestion! :)
;               - Will now finish putting away your stuff after the last bod is swapped.
;               - Removed gloves from 'return item' list. Turns out you can't return
;                 gloves, and I had forgotten about it! :)
;               - Added gargoyle pickaxes to 'return item' list
;-------------------------------------------------------------------------------------
; Version   0.4 - Changed #findrep back to 7, which is fixed in EUO 1.50 202
;-------------------------------------------------------------------------------------
; Version   0.3 - Made the script a little slower to prevent issues to people with
;                 low ping.
;               - A few minor fixes
;-------------------------------------------------------------------------------------
; Version   0.2 - Fixed not finding NPC issue with new EUO/Client version
;               - Added option to chose your travel method
;-------------------------------------------------------------------------------------
; Instructions: - You must setup your containers at home for each kind of reward. You
;                 can chose some rewards that you don't want to keep to be returned to
;                 the NPC. If a container for your mining stuff (ie pickaxes, prospect, etc.)
;                 gets full, those items will be added to the return list, and start being
;                 returned to the NPC.
;               - You must write the rune numbers of both runes for each location in the edit box
;                 in the menu.
;                 2 runes for smith, 2 runes for home. They MUST be consecutive runes
;                 in your book, i.e. 7 & 8 for your home runes, or 3 & 4 for you smithy runes
;                 Remember to mark runes close enough to the NPCs
;               - You can save/load your setup, so that you don't have to set your containers and rune books
;                 every time you run the script
;               - After everything is set, you must recall to the smithy and hit the start button ONLY WHEN
;                 YOU'RE AT THE SMITHY! If you hit start being somewhere else, the script won't work
;---------------------------------------------------------------------------------------------------------
; This is a variation of a personal script I wrote for personal use, so I decided to modify it a bit
; and post this public version. Hope to get some feedback so I can keep fixing
; and improving this until it's stable enough for everyone to run it flawlessly.
;-----------------------------------------------------------------------------------------------------

Hey guys... I wanted to share with you the script I use to swap bods at the NPC. This is for smith bods ONLY.
I had to modify it from my private version a bit for a public release, but it should still be pretty useful, if you don't like that whole packy swap thing...

Remember to read the instructions before using. Please tell me any issues you find too, so that I can keep improving this for everyone's use!

cheers

neo

[Ultima]

Frneo I will give this a go next time I turn in BODs instead of Penny's BOD Swapper.

Right now all my accounts are busy collecting BODs.

[Neo]

Sounds good man...

You'll notice it has a lot of room for improvement, especially aesthetically speaking...

But for now I would like to get people's opinion on how to improve the main functionality of it, and then I can start making it prettier hehe...

Thanks for giving it a whirl!

neo

[Goliath]

Frneo... Sorry I haven't gotten back to you on the Lumberjacking script yet but I am planning on hacking that one out on 2 different characters this weekend (gargoyle and human) using a different account and completely different runebooks/setup to make sure I test it all.  Will post results when finished.

As for this script I will give it a shot tonight and get back with you.  Working smithy bods has been exactly one of the things I have been doing this week.  I look forward to testing this one out!

[Newsman]

Tested and not functioning with euo 200.  I believe the problem is with the euo version or a change in euo.  Two bod swap scripts, this and penny's can not recognize the blacksmith npcs. 

Can you take a look? 

Pennys has me select the npc and the script rejects the npc i've always used while yours just tells me there is no npc found.

[Neo]

Tested and not functioning with euo 200.  I believe the problem is with the euo version or a change in euo.  Two bod swap scripts, this and penny's can not recognize the blacksmith npcs. 

Can you take a look? 

Pennys has me select the npc and the script rejects the npc i've always used while yours just tells me there is no npc found.

They changed #findrep with the new client/euo, that was the issue...

Should be all fixed now, tell me if you find any issues though...

[Newsman]

Okay issues that I'm noticing with the script.

It pulls too many bods out and then doesn't necessarily turn the bods in. 

It keeps getting hung up trying to hand in the unfilled bods it collected.  it'll get a new bod and try to hand it in, all while it keeps pulling filled bods from the bod book.


From an efficiency standpoint it appears to try and recall after every reward it gets.  Perhaps you can have it collect several a time, and then turn them back to the house.    This would save a ton of transit time and be a real competitor with penny's bod swap.

[Newsman]

It also doesn't save your setting for what item to return and the runebook settings.

[MeWonUo]

From an efficiency standpoint it appears to try and recall after every reward it gets.  Perhaps you can have it collect several a time, and then turn them back to the house.    This would save a ton of transit time and be a real competitor with penny's bod swap.

.

How many items do you have in your backpack?  It's coded to recall when you have 110 items in your pack.  

You could change this line to a number greater than 110

if %property > 110

[Neo]

Okay issues that I'm noticing with the script.

It pulls too many bods out and then doesn't necessarily turn the bods in. 

It keeps getting hung up trying to hand in the unfilled bods it collected.  it'll get a new bod and try to hand it in, all while it keeps pulling filled bods from the bod book.


From an efficiency standpoint it appears to try and recall after every reward it gets.  Perhaps you can have it collect several a time, and then turn them back to the house.    This would save a ton of transit time and be a real competitor with penny's bod swap.

Well, I really don't know why that's happening to you...

First, the script is only supposed to recall home to dropoff stuff IF you're close to maxweight or if you have more than 110 items in your backpack. Could you check to see if you're working with a backpack with more than 110 items.

The other issue you mentioned of it just dropping several bods into the backpack, from all the testing I did, would only happen if you get the "backpack is full" error...

Could you check those things for me and get back to me please?

Thank you...

neo

[Neo]

It also doesn't save your setting for what item to return and the runebook settings.

I left the "item to return" out of the saved variables on purpose, so that people wouldn't return stuff by accident, after loading up the saved config...

The runebook settings were supposed to be loaded up, but I guess I know what may be causing it to not load properly... I'm gonna try and get the new version out with that fixed in a few...

[Newsman]

Okay, it's not trying to recall back every time now that my item count is lower

However, it still tries to pull multiple bods out.  The longer its on the more bods that spill out into the bag.

I believe the issue is that right away when it starts, it pull 2 filled bods out.

It begins confusing item ids as more bods come out, compounding the problem.

I ran a test and paused it to remove that extra bod so it starts with just 1 bod in pack.  Perhaps the issue is its trying to pick things up too quickly?

Also, The problem causes it to throw filled bods into the empty book.

[Neo]

Okay, it's not trying to recall back every time now that my item count is lower

However, it still tries to pull multiple bods out.  The longer its on the more bods that spill out into the bag.

I believe the issue is that right away when it starts, it pull 2 filled bods out.

It begins confusing item ids as more bods come out, compounding the problem.

I ran a test and paused it to remove that extra bod so it starts with just 1 bod in pack.  Perhaps the issue is its trying to pick things up too quickly?

You can't have any bods in your pack before starting...

That will definitely break the script, at least for now...

You must start the script having 0 bods in your pack, just the bod books...

[Newsman]

Okay, it's not trying to recall back every time now that my item count is lower

However, it still tries to pull multiple bods out.  The longer its on the more bods that spill out into the bag.

I believe the issue is that right away when it starts, it pull 2 filled bods out.

It begins confusing item ids as more bods come out, compounding the problem.

I ran a test and paused it to remove that extra bod so it starts with just 1 bod in pack.  Perhaps the issue is its trying to pick things up too quickly?

You can't have any bods in your pack before starting...

That will definitely break the script, at least for now...

You must start the script having 0 bods in your pack, just the bod books...

I am.  The script is pulling too many bods from the book of filled box and then everything breaks down.  it's not always the first time it pulls a bod upon more testing, it's just usually the first bod.

[Neo]

Okay, it's not trying to recall back every time now that my item count is lower

However, it still tries to pull multiple bods out.  The longer its on the more bods that spill out into the bag.

I believe the issue is that right away when it starts, it pull 2 filled bods out.

It begins confusing item ids as more bods come out, compounding the problem.

I ran a test and paused it to remove that extra bod so it starts with just 1 bod in pack.  Perhaps the issue is its trying to pick things up too quickly?

You can't have any bods in your pack before starting...

That will definitely break the script, at least for now...

You must start the script having 0 bods in your pack, just the bod books...

I am.  The script is pulling too many bods from the book of filled box and then everything breaks down.  it's not always the first time it pulls a bod upon more testing, it's just usually the first bod.

That's really odd. This never happened here... I could think of 3 possible causes for this from the top of my head:
- You're not close enough to the npc to whom the script is trying to move the filled bod to
- You're backpack is full
- You have a bod inside your backpack before starting...

If you're sure none of the above is your case, I'll have to try and recreate your situation here to see what may be causing that issue for you...

Thanks for all the replies...

neo