ScriptUO
Official ScriptUO EasyUO Scripts => Script Library => Crafting => Topic started by: MeWonUo on October 05, 2011, 01:01:02 PM
-
;==============================================
; Script Name: MeWon's Smith BOD Sorter-er
; Author: MeWonUo
; Version: 0.1.7
; Client Tested With: 7.0.16.3
; EUO version tested with: 1.50 202
; Shard OSI / FS: OSI
; Revision Date: 10/05/2011
; Public Release: 10/05/2011
; Purpose: Sorts Smith BODs.
;----------------------------------------------
;**Special Thanks**
;-Neo: Thanks for answering all of my stupid
; questions along the way. And for your
; help with the safety measures for
; those with high pings!
;-12x: Appreciate you giving this a run in
; it's earlier stages and giving me some
; pointers in "Scripts for Dummies" talk.
;===============================================
So, I finally took the time to get this cleaned up and ready for public consumption. This is the first script that I've written from top to bottom, and seems stable enough to let others play with. Be gentle.
What it does:
Sorts smithing BODs into 13 different book based on reward. (Easily altered to fit your needs. Currently set to how I prefer to sort.)
General Setup:
1. Need a container in your main pack with the 13 different books to sort into.
(Pulling books one at a time out of a secure is a huge waste of time to me, I have an idea in the works that will handle secure support)
2. Book of BODs to be sorted in your pack.
3. Books need to be named as such:
Plate Keepers - Stores small and large pieces for bods that are worth combining.
Chain Keepers - "
Ring Keepers - "
BZ Runic - Stores smalls that give 100% chance at BZ runic
CP Runic - " but Copper
SH Runic - " but Shadow
DC Runic - " but DC
DCSH Runic - Stores smalls that return 60% DC and 40% Shadow Hammers
POF 20 - Stores smalls that give a 20% chance at POF
POF 90 - Stores smalls that give a 90% chance at POF
Never Fill - Stores large bods that are not worth doing.
Small Fill - Stores smalls to fill and turn back into the smith.
Color Junk - Smalls that you can choose to fill, or trash.
Other than that, it's pretty straight forward. I hope it is of some use to some out there.
-
This thing here is what made me want to start doing BODs again...
Really nice way to get your bods organized.... I'd recommend this for any bod person out there! :)
-
This thing here is what made me want to start doing BODs again...
Really nice way to get your bods organized.... I'd recommend this for any bod person out there! :)
Thanks Neo! Was a lot of fun getting it all figured out.
-
Ran this last night for a while and it worked like a charm. I did find that filled my backpack quickly but after dumping the never fill stuff and grabbing new books for small and color junk it was fine. I'll have to review it more but it works great.
-
Ran this last night for a while and it worked like a charm. I did find that filled my backpack quickly but after dumping the never fill stuff and grabbing new books for small and color junk it was fine. I'll have to review it more but it works great.
Appreciate the feedback, Canuker.
I do have a couple ideas on how to handle the books automatically as they fill up so they don't have to be swapped out by hand. But I'm not entirely sure how to implement quite yet. Definitely something I'd like to add in the near future however.
Thanks again!
-
I was running this last night and noticed that the never fill book was getting small colored bods placed into it. I thought this was odd because there is also a colored junk one which I thought these would land in and the "never" would be for large iron and useless colored large. Is this by design or a error somewhere as it seems that you lose on the cycling for new bods when turning in.
-
I was running this last night and noticed that the never fill book was getting small colored bods placed into it. I thought this was odd because there is also a colored junk one which I thought these would land in and the "never" would be for large iron and useless colored large. Is this by design or a error somewhere as it seems that you lose on the cycling for new bods when turning in.
First off, do you happen to know what bods were going into the incorrect books? I can check the score for those specific bods and check that there isn't a typo in there somewhere.
And how was your connection last night when you were running it? I have noticed on rare occasions if I'm getting some lag spikes, that it can cause an error where the bod doesn't get scored correctly and gets put into the never fill book. I just double check my never fill books to make sure nothing got put in there due to that.
But if you can recall what bods were being put in there, I'd like to double check the score for them to be sure.
Thanks. :)
-
Were the bods partially filled? That could also be the issue...
-
Were the bods partially filled? That could also be the issue...
This too! Thanks for reminding me Neo.
-
No the issue was on my side. I had made a new bag for the bod books and forgot to make the POF 20. User error but certainly a good idea to remind all users to have the correct set up. Sorry for the alarm.
-
No the issue was on my side. I had made a new bag for the bod books and forgot to make the POF 20. User error but certainly a good idea to remind all users to have the correct set up. Sorry for the alarm.
Glad you got it squared away, Canuker. It will definitely do some odd things if the setup isn't exact.
You can also change the names of the books in the script pretty easily if you'd like them named something else.
-
** I found a small bug with one of the BOD categories this morning. **
Will get a fix posted as soon as I'm able to get back home and test it.
-
This was working fine for me the other night but now suddenly it stops and suggests there are no more bods to sort. If I check the book, there are and if Start the script again, it will start sorting them. It then stops again before it should.
-
I did quite a bit of testing with this myself and managed to pull BOD's that I wanted to pull out of a lot of books with little to no effort on my part.
I had about 20 books or so with hundreds of BOD's in each totally mixed between Tailor and Smith, these were books I simply collected into without sorting for a long time.
For starters, keep in mind that the list is customizable. What I was doing was setting everything to go to a general "Smith BOD's" book that didn't meet POF20 or POF90. Then I ran it against a book. When I was done I had 2 POF books and the remainder of my books were all sorted to Tailor and Smith.
One suggestion, and maybe you have already changed this with your public release (I have only tested the pre-release you shared with me), since this only does Smith BOD's you should add to the script to first click "Clear Filter" then select "Blacksmith". There is no reason to have Tailor BOD's show up at all, it just wastes time.
I had some feature thoughts for a future release but I don't want to put those out there just yet and overwhelm the bug-fix process! ;)
I messed around with your code a bit in the version I have so I'll try to give this another whirl later using your Public release because I don't remember what I had changed other than the feedback I gave you through PM lol.
This will be a great add to our Public Script Library once any issues are worked out!
X
edit - hey I just noticed the props in the header, thanks man ;)
-
One question, just looking at the public code:
repeat
finditem EYM c_ , #backpackid
event property #findid
until weight in #property || #scnt > %findtimeout
Not sure if you're open to suggestion but I'll throw it out there anyhow, I'm not sure what you gain with this. You're saying to keep attempting to find something in the backpack until either some time has gone by or you do find something in the backpack with the word "weight" in the property. For starters, when you do a finditem EYM, it's either going to find it (#findkind <> -1) or not (#findkind = -1). There really is no need to keep searching for a period of time or to event property the item to see if you really did find it. You could consider cleaning it up a bit by simplifying it:
finditem EYM c_ , #backpackid
if #findkind = -1
{
Display No more BOD's to sort
Halt
}
;then continue sub from here
To be honest, I would suggest checking to see if a BOD actually dropped into the pack before you exit the DropBOD sub then only call the GetBODScore sub if one does indeed drop out of the book:
repeat
gosub DropBod
gosub EvalDrop
gosub DropToBook
until #false
;;-----------;;
;;--DropBod--;;
;;-----------;;
sub DropBod
wait 10 ;<-----xiix comment - not sure that you really need this here
finditem %SortBook
set #lobjectid %SortBook
event macro 17 0
wait 10 ;<-----xiix comment - your WaitForGump sub should take care of this timing too
gosub WaitForGump
set %clickx #contposx + 41
set %clicky #contposy + 104
click %clickx %clicky f
gosub WaitForGump
click %clickx %clicky r
wait 10
;;;;xiixadd here;;;;
finditem EYM c_ , #backpackid
if #findkind = -1
{
display Seem to be out of BOD's
halt
}
else
gosub GetBODScore #findid
return
;;---------------;;
;;--GetBODScore--;;
;;---------------;;
sub GetBODScore
set %BOD %1
set %score 0
event property %BOD
; go and get the score and do your thing
return
So anyhow, just some thoughts on script flow and a little logic thought there. This isn't exaclty what you would necessarily use here, there is certainly more to think about but I just wanted to give an example to get the general idea across.
X
-
It was me who suggested this part:
repeat
finditem EYM c_ , #backpackid
event property #findid
until weight in #property || #scnt > %findtimeout
In my view, a fixed wait of 10 isn't always enough to see if the bod was dropped in the backpack or not... If you have a high enough ping, that often won't be enough... I know this first hand, using the earlier versions of the sorter...
So, this snippet is actually meant to make sure the item is found, AND make sure that the #property is properly set, no matter what connection you have with the server... Adjustments apart could be made of course, but this is the best way I found to make sure both the item is found and the #property is properly set...
-
It was me who suggested this part:
repeat
finditem EYM c_ , #backpackid
event property #findid
until weight in #property || #scnt > %findtimeout
In my view, a fixed wait of 10 isn't always enough to see if the bod was dropped in the backpack or not... If you have a high enough ping, that often won't be enough... I know this first hand, using the earlier versions of the sorter...
So, this snippet is actually meant to make sure the item is found, AND make sure that the #property is properly set, no matter what connection you have with the server... Adjustments apart could be made of course, but this is the best way I found to make sure both the item is found and the #property is properly set...
Makes sense. I still like the idea of checkig for a BOD before outing to the Score sub but there are as many ways to code as there are coders so have at it.
X
-
It was me who suggested this part:
repeat
finditem EYM c_ , #backpackid
event property #findid
until weight in #property || #scnt > %findtimeout
In my view, a fixed wait of 10 isn't always enough to see if the bod was dropped in the backpack or not... If you have a high enough ping, that often won't be enough... I know this first hand, using the earlier versions of the sorter...
So, this snippet is actually meant to make sure the item is found, AND make sure that the #property is properly set, no matter what connection you have with the server... Adjustments apart could be made of course, but this is the best way I found to make sure both the item is found and the #property is properly set...
Makes sense. I still like the idea of checkig for a BOD before outing to the Score sub but there are as many ways to code as there are coders so have at it.
X
Actually, I totally agree with you on that one, checking for a bod before doing the score sub would definitely be a nice safety improvement....
-
@12x - I'm ALWAYS open to suggestions. I know I still have a lot to learn, and any feedback I can get is beyond appreciated. I've got your ideas here in front of me now. Looks like an added check to make sure a bod is in the pack before heading into the scoring section is in order. I'll also do some testing with removing those waits. For some reason, I'm thinking that I was having issues without those waits in there, but lots has changed over the time this thing has been evolving. Thanks yet again for your help!
@Neo - As always man.. Thanks! Where the hell you been lately anyway?? hah
@anewbe4u - Can you possibly detail me on where in the script that is happening? Do you have any tailor bods in the book? Is the bod book filter cleared or set to smith bods only? Any other info would be appreciated. I'd like to get it fixed up for you.
I will keep playing with this, and updating as I'm able to figure things out. At my scripting level....one thing at a time.. :D
-
Glad you posted this I will try to see if i can get my bods filtered and let you know how it goes. Thanks agqain !!!
-
Hey,
I think it might have just been me being stupid and not sorting the book correctly....
-
First off congratulations on a great script. Here are some improvements i would like to see in order to get this lovely peice of work into the official script library. Please dont take any offense by below rather take it as a learning experience.
(1) you have subs without returns
subs setup, bookscan <-- not sure why no returns on these sub perhaps an oversight
(2) A clean exit from the script. Your script halts in the middle of the sub GetBODScore. I would recommend you create a Var for example called %ExitScript, set it to false... and instead of halting in the middle of the sub have the code return to the main loop and exit thier. Such modifications as below would achieve this.
if #scnt > %findtimeout
{
set %exitscript #true ; display No more BODs to sort
return ; halt
}
and modify you base repeat loop to exit
set %exitscript #false
repeat
gosub DropBod
gosub GetBodScore
if ! %exitscript
{
gosub EvalDrop
gosub DropToBook
}
until %Exitscript = #true
halt
(3) Property Scan: your property sometimes fails I would recommend you take the finditem out of the property loop. As and add a secondary loop that waits such as below...
finditem EYM c_ , #backpackid
set %findtimeout #scnt + 10
repeat
event property #findid
set %Proptimeout #scnt + 2
repeat
wait 1
until weight in #property || #scnt > %proptimeout
until weight in #property || #scnt > %findtimeout
(4) Code Indentation: You may wish to consider Indenting your code; it makes it far easier to read and maintian and catch errors such as missing returns... standardly you indent x spaces for every block (for me x=2), ie this is easier to read than that
thjis
sub justdoit
while w > p
{
repeat
if x =a
for y = 1 20
set z z + 20
until q < r
}
return
that
sub justdoit
while w > p
{
repeat
if x =a
for y = 1 20
set z z + 20
until q < r
}
return
(5) CLoth Bods : i did a simple mod to make it support cloth bods, you might wish to consider something like this as well... as its not appropriate my odd cloth bods end up in never fill (each 2 line bit goes into diff section)
if Cloth in #property
set %Cloth #findid
if cloth in #property
set %score %score + 1000000
if %score >= 1000000
set %DropBook %Cloth
Once again congratualtions on the script submission ;D
-
Alot of issues like EN is talking about can be caught by the SUO syntax checker. Here's the sample output for your script:
Method count: 56
Command count: 56
*** Pass 1 - Label accounting:
*** Warning - Tag ClickLoop1: - Line 55 already exists. First occurance: 43
*** Error - Subroutine BookScan - Line 66 nested without return.
Subroutine labels = 7
Tag labels = 1
7 Code block(s).
1 Warnings(s) encountered.
*** Pass 2 - Execution [SYNTAXCHECK]
There is also a nice indentation formatter --> /Tools/Auto Indent Script
-
Update.
The occasional script finishing before the bod book is empty.. isnt from not reading the property correctly as i previously throught but rather from the bod drop routine not being successful.
great little script tho it nicely sorted over 600 bods for me.
-
Works great. I would add one note - it appears to go into an infinite loop if you select a bag with BOD books outside of your backpack.
-
Did a book of 200 for test run. only forget 15 BOD, maybe lag, all the Bod when where the are suppose too. Question: Why did you split all the Runic hammers, can have only 9 books instead of 13. This is gonna safe me lot of time. sure. I have lot of book to turn in, so I let you know how it turn.
-
This is working great! Thanks for the contribution!
-
testing
-
Works great. I did have the problem of it not dropping bods out of the book at times, and the script prematurely stopping, but other than that, works fine!
I really like your method of organizing the bods by assigning numbers. It made it easy for me to adapt the script to how I wanted them organized. I only have 3 books: Trash, Keepers, Recycle. I then export the Keepers to an outside program which gives me a nice overview of the bods I have and how close I am to getting the needed sbods for the lbods I want to fill.
Keep up the great work!!!
Post Merge: May 27, 2012, 09:46:07 PM
I've used your script to create a sorting method for tailor bods and for taming bods. While there are many tailor sorters out there, not many are as easy to customize as this one for the novice scripter. Also, I don't believe I've seen a taming sorter out there that will sort from a bod book to other books.
I'm not sure if I can post the changes here or not. If a moderator says it's ok for me to do so, and if there's any interest, then I will gladly post my changes to make this script usable with tailor and taming bods.
Cheers!
-
Thanks to everyone that has used this over the past months, glad it was of some help to some of you. :)
I'm starting to get back into UO again and see that I will be needing to make some changes to how BODs are sorted now that bribing plays a part in the equation. If anyone has suggestions as to how they would like to see things sorted, please let me know.
Also, I believe I will be doing a tailoring BOD version as well now that sewing kits are worth something. :D
Thanks again.
-
Tailoring BODs would be AWESOME! im in need of a few kits and trying to find a script that works is killing me lol, badwolfs doesnt work for tailor bods, if you need some one test it out you can give me a shout :)
-
I have so many tailoring deeds that i just refuse to try and sort and figure it out by hand so I would really like to try and help on that one. I have used the smith one several times and works flawlessly
-
Tailoring BODs would be AWESOME! im in need of a few kits and trying to find a script that works is killing me lol, badwolfs doesnt work for tailor bods, if you need some one test it out you can give me a shout :)
Thanks D. Any ideas on how to setup the books to do tailoring?
I have so many tailoring deeds that i just refuse to try and sort and figure it out by hand so I would really like to try and help on that one. I have used the smith one several times and works flawlessly
I haven't done TBods is such a ridiculously long time that I'm not exactly sure where to begin. First idea is just to separate everything into junk/fill and then the different outfits. Cloth 4 part bods can give spined kits, so finding those quickly and easily sounds like a good start. I'd really like to avoid having to put 40 different books on your character to sort into.
Any ideas from those here would be highly welcomed. The basic function of the script is already done, but the bribing aspect really has thrown a bit more complexity into the system.
-
at the moment i tried to use badwolfs so i have my books for tailoring named for each type, so 10/except/small/leather 10/normal/small/leather and so on so i have loads of books but the script didnt work well enough and missed loads of bods.
I think i would be cool to have the books based on rewards like you have with the smith bods so something like leather bods for spined, horned, barbed, and the same for cloth bods, small fill, boots, never fill, bone? maybe, i dont fill bone kits in at the mo but if i got a horned kit i would so maybe a bone spined kit, bone horned kit, bone barbed kit, then i would farm bones for just those and ditch the rest of the bone bods.
so depending on material stocks i could pull the book to fill, all runic kits that need leather or horned leather or barbed, bone, cloth etc but that could be alot of books, and im not sure how many bods cross over between runics like 5 part exceptional spined will get a horned kit but 6 part would get a barbed so which book would you put the small bods in?
is 4:40am here so im a bit tired lol i give it some more though after some sleep :)
-
Using this script and sorting thru all of my Smith Bods, I have ended up with over 500 Plate Keepers, 300 Ring Keepers and 300 Chain Keepers -- what do I do with these?
I think I have over 500 Never Fills as well -- do I just trash them?
-
i have always saved all my bods was here looking for a good sorter havent had one in years
thay made a change to bod rewards years ago and all mine were good again and this last one bribe made all mine good again onnes maked 20 ps with one bribe are worth a barbed kit now
as a bog lover never trash them set them on a vendor with no sale and just save them
thats how you can find my house 30 vendors full of no sale bods lol
-
Great little script here. Got it running the first time with the instructions given, exactly as you would hope for any script.
One question about a possible feature. A lot of people in the bulk bod business collect both tailor and smith bods and put them into 1 book for each char and after a couple months they'd use something like this to "sort". I see that you have a tailor sorter as well, and here is my question:
Can you add a "book type" so when you do the 'smith' sort on a book, that any tailor bods it pulls out it puts into a "tailor bod"
book so you can run that in your tailor sorter? Currently it just pulls the tailor bods out and mixes them in with the "never fill" because it doesn't recognize them I'm sure. I guess I could run the sorter on that book, though if it didn't have the smith ones in it it'd be easier.
-
Great little script here. Got it running the first time with the instructions given, exactly as you would hope for any script.
One question about a possible feature. A lot of people in the bulk bod business collect both tailor and smith bods and put them into 1 book for each char and after a couple months they'd use something like this to "sort". I see that you have a tailor sorter as well, and here is my question:
Can you add a "book type" so when you do the 'smith' sort on a book, that any tailor bods it pulls out it puts into a "tailor bod"
book so you can run that in your tailor sorter? Currently it just pulls the tailor bods out and mixes them in with the "never fill" because it doesn't recognize them I'm sure. I guess I could run the sorter on that book, though if it didn't have the smith ones in it it'd be easier.
Appreciate the kind words, glad it worked as you had hoped it would.
As for adding the ability to drop the tailor bods into their own book, I don't think that is really possible because of how I did the scoring categories. Anything that doesn't score into one of the specific books variables is automatically tossed into the "never fill" book. I would have to create a specific score for all of the tailor bods to do what you are asking.
A simple solution I suppose would be to add an additional book filter to this script as I have in the Tailor Bod sorter. It checks off the "Tailoring" filter in the book menu so only TBods show up in the list for sorting. I can see about adding that sub to this script as well. Then after running the smith sorter, just run the tailor sorter on the same book since there would be nothing but tailor bods left in the book.
I will toy around with that when I have some time tomorrow.
-
Works great, very clean code so easy to modify the books and BODs to be sorted :) My only issue is that it is VERY sensitive to lag, which will lead to the 'No more BODs to fill' message. Perhaps a Yes/No lag variable to increase all of the wait times to compensate?
-
Congratulations your Script has been moved to Script library
(If you feel the script is in the wrong section please send me a pm.)
Thank you for your submission.
-
Awesome script, use the hell outta this.
Thanks soooo much!!!
-
MeWon any idea why I never get and SH runic ones? ive gone through probably 10,000 deeds and haveent gotten not one put into that book its labeled SH Runic?
-
Did the function for secures ever get added? I have 3 secure containers for smithy bods so they wont fit in backpack. If not I guess I will need to have 14 bod books in each secure.
-
MeWonUo, Thanks for sharing this script! Its working very well! All 10s.
I am however having an issue with my exceptional iron bods going into the never fill book (normal ones go into the fill book properly). I am on a free shard so I'm sure this is the cause of my issue. Anyone have any ideas on what I need to modify to make this work?
-
Going to give this a try! Trying to make BODs as easy as possible!