Buying regs from faction vendors

[Noobie]

I wrote this to just stand in one spot and buy regs from the faction vendors. I think there are like 10 reg vendors on Legends and I have got this to cycle through each vendor and buy all the regs one line at a time. I was wondering if some of the experienced scripters could take a look at this and help me improve it some possibly speeding it up.
Basically right now it stand in one spot and buys regs. I would like to make it pull gold from the bank and maybe a menu to count what you have spent and how many of each reg it has bought. Also maybe throw in a timer that will wait while the regs respawn.

Update:5/15/2010
now pulls gold from the bank until you run the count up to make it charge stright from the bank. Also will cash any checks it finds.
added the ability to buy potion bottles
added GUI
added user set number of potion bottles
added counter for each type of reg and bottles
added a start and pause button to the GUI
Update:5/31/2010
now casts invisibility while waiting for regs to respawn
Added check boxes so that user can choose what reg to buy
Update: 12/25/2010
Fixed bug with buying potion bottles and amount to buy

[JackCiaran]

I dont know if I can mention using razor but use the razor buy option it will help speed things up a lot! instead of purchasing them individually put u would have to change ur script to loot them off the ground and bank em =) unless u only wanna buy like certain amount of regs at a time so it only falls in ur pack def something to check out

[Noobie]

Well I have messed with this some more today and this is what i have came up with now. Updated from the first post it will pull gold from bank and will buy all of each reg on the vendor I am pretty much a noobie when it comes to scripting so if some one will take a look at my code and give advice on ways to do it better it would be great.

[Noobie]

Has anyone ever used the #gold variable? I used it in this script to check the amount of gold in your backpack but if i droped 60k in my pack it made #gold show a negative number that i could not figure out. Has anyone ever seen this or know a better way to check the amount of gold in the backpack?


;----------check backpack for gold-------------------
sub goldck
event macro 8 2
finditem POF C_ , #BACKPACKID
if #GOLD < 10000
gosub getgold
return

[Noobie]

Anyone willing to criticize this thing and give me some ideas to grow my skill on? I know it is rather simple, but at this point I at my limit because of my scripting skills. I am to the point that every time i set down to play uo I end up thinking about what ever I am trying to script it. Any suggestions for me to grow on would be greatly appreciated.

[darian]

Hi, you might take a look at Raven's Resource Buying Script over on Easyuo, i think the currently updated version that ive been taking care of is on like page 3 of that forum. ive been keeping it updated with all the new patches of late, cause noone else does, it might give you some idea's bro.

[luv2luvlong]

my favorite is still Gen's auto item buyer
http://www.scriptuo.com/index.php?topic=3099.0;highlight=buyer

[darian]

Yeah, ive used that one too, I like them both

[12TimesOver]

Heya Noobie.

Thanks for the submission. I've been a little AFK in IRL as of late so sorry I haven't tried giving any feedback. I will give things a shot when I can get back in front of the game this week.

Just a comment here on your thread though, you should consider 1) removing your code from all of the posts in this thread other than the first one in order to maintain some version integrity and 2) instead of posting the whole script as a

Code: [Select]

Code Block
you should attach the file instead. This will make the thread a lot more easily read, the code itself easier to download, and for you to have a little more control over what code people are running for you.

Let me know if you want me to help clean the thread up for you.

X

Oh, and PS - on the #gold question, I would suggest simply searching for POF and getting the #findcnt value, a lot more reliable.

[Noobie]

12X Thanks for you suggestions!
 I updated the thread based on your suggestions. I would appreciate any suggestions on how to make my script run better, layout, or ideas.

Thanks

[12TimesOver]

Ah me likes...much better organization!!

Ok, in return I promise I'll check it out when I get in game next - I might actually play again tonight (played last night for the first time in weeks)!

X

[Noobie]

Added some more functionality for the user. If anyone could give this a try and provide some feed back on what i am doing i would appreciate it greatly. I am trying to learn just need some feed back on what i am doing or some ideas on what i could do better.


Thanks
Noobie

[darian]

hi there, i used this for awhile today on Pacific shard, all in all i think it has alot of potential. One problem i ran into was, after it bought the regs, and they dropped to my pack, then it moved them one at a time to my bank box, but fter moving them, it then moved them back to my pack. maybe have an option to choose a bag within your bank to drop the purchased regs into. That would be nice. but like i said, all in all a very good script, one that is very useful to the community i think. 

[Noobie]

Thanks a bunch! I was wondering if anyone else would have issues with it. I appreciate the feed back and adding a bag to drop in to is simple at this point so I will see what i can do.

When you say it moved them one at a time do you mean one reg or one stack? It should move the whole stack, but if not i think i can figure that out.

[darian]

yes, moved a stack of regs, dropped into bank, did that for all the stacks, then moved them back to my pack. LOL!