im trying to figure out how to make sure a bag gump is open. the way im checking for weight is item count in a bad and it only works if the bag is open so i want it to check to amke sure the bad is open every time
id imagine id look a little something like this


FINDITEM %containerid
 if FINDKIND <> -1
{
gosub opencontainer
}

return
 

ok ive done some editing and now it stops opens the corpse and then when it doesnt find anything it returns to attacking so my new problem is that it doesnt find the TMAP on the body i think i have the code right im not sure


;-----------------Variables-------------------
;
;
SET %creature WD ;Dark Guardian
SET %loot XVH ;gold TMAPS ect
SET %homebook OXGABND
SET %doombook UWVWWQD
SET %secure ;trashcan
SET %backpack #backpackid
SET %CORPSE YFM
set %safety 4 ;DO NOT EDIT
set %spellTimer #scnt2 ;DO NOT EDIT
set %attacking #false
set %noloot #true

;-----------------MAINLOOP------------------------
main:
if %setupWW = #TURE
{
gosub pixelFirst
}
gosub weightcheck
gosub attack
goto main
;============================================================================
;-----------------MAINSUBS------------------------
;===========================================================================

;-----------------------------------------------------------------------------
sub weightcheck
finditem * c_%backpack
IF #weight > 400 || #findcnt > 120
   {
   gosub gohome
   }
   return
;------------------------------------------------------


sub attack
FINDITEM %creature G_6
if ( #findkind = -1 )
{
gosub loot
}
if ( #findkind = -1 ) && ( %noloot = #TRUE )
{
  event pathfind 362 15
wait 20
event pathfind 365 15
wait 20
 }
if #findkind <> -1
 {
 attackloop:
set %attacking #TRUE
if #findcnt > 0 && ( %spellTimer < #scnt2 )
gosub execSec
if #FINDKIND = -1 4
finditem %creature
set %attack #findid
set #LTARGETID %attack
event macro 27 0
if #findid <> %attack
 {
set %attack #findid
set #LTARGETID %attack
event macro 27 0
goto attackloop
}
  }
  set %attacking #false
return
;------------------------------------------------

sub loot
;gosub get claw to start looting
;wait 90s for claw to finish and respawn time to pass
FINDITEM %CORPSE G_3
if ( #FINDKIND > -1 ) && ( %attacking = #false )
   {
   set %noloot #false
   goto lootloop
   }
if #findkind = -1
   {
   set %noloot #true
   }
lootloop:
set %newcorpse #findID
set #LOBJECTID %newcorpse
EVENT MACRO 17
set %openorpse #contID
wait 20
FINDITEM C_%opencorpse %loot ;<<<<<<<<<<<<<<<<<<<<this is the line that i think is wrong
 if #FINDCNT > 0
   {
   Pause
   exevent drag #findID
   wait 10
   EVENT DROPC %lootbag
   }
ignoreitem %newcorpse 1

return
;------------------------------------------------

sub execSec
    cmppix 3 f
       {
       event macro 36 0
       wait 5
       }
return

;------------------------------------------------
;----------------SetUP Subs----------------------



sub pixelFirst
display First we need to adjust the script to your spells.
wait 3
gosub setpixel-secondary
set %setupWW #false
return

sub setpixel-secondary
    event macro 36 0
    display Move the mouse to the BOTTOM LEFT CORNER of the secondary Weapon Move button. You have 2 seconds
    wait 2s
    savePix #CURSORX #CURSORY 3
    wait 5
    event macro 36 0
    display Everything is set!
return

Welcome to the fam

Wolcome to SUO

hey guys thanks for the replies much appriciated should have my M&S glasses soon!

fixed the attack sub it works perfectly now thanks for your guys' contributions now i was wondering if i could get help with the looting part? like how do you make it the script stop to loot? and how do you put the corpse ids on ignore like TMs CLAw does? thanks!

Updated attack sub

;------------------------------------------------------

sub attack
FINDITEM %creature G_5
IF #FINDKIND = -1
{
move 368 15 1
wait 30
move 362 15 1
wait 30
}
IF #FINDKIND <> -1
{
FINDITEM %creature
SET %enemy #FINDID
SET #LTARGETID %enemy
move #FINDX #FINDY a
EVENT macro 27 0
IF #FINDID <> %enemy
{
  set %enemy #FINDID
set #LTARGETID %enemy
event macro 27 0
  }
}
return
;------------------------------------------------

this is what i have written in the loot sub so far

sub loot
  FINDITEM %corpse G_4
IF #FINDKIND <> -1
  {
  SET %corpseid #FINDID
  SET #LOBJECTID %corpseid
  event macro 19 0
  }
  return
thanks in advance guys im trying to learn as much as i can by myself but its a little more confussing then i thought it would be

Hey guys i spent all night trying to research what i was doing and i apparently got it wrong >.< can someone look it over and tell me what i did that was bad? its not finished i dont have the loot or drop off subs written but as bad as ive done i dont think theyd work anyway
;------------------------------------
;-- Script Name:Dark Guardian Farm
;-- Author: Tana
;-- Version: 1.0
;-- Client Tested with: 7.0.6.5 (Patch 95)
;-- EUO version tested with:
;-- Shard OSI
;-- Revision Date:
;-- Public Release:
;-- Purpose: Faming TMAPS for clean up/Deamon bones for golden skulls
;-- Copyright: 2016
;-----------------Variables-------------------
;
;
SET %creature WD ;WD
SET %loot POF_XVH
SET %homebook OXGABND
SET %doombook UWVWWQD
SET %secure
SET %backpack CJSXQOD
;-----------------MAINLOOP------------------------
main:
gosub weightcheck
gosub spawn
gosub attack
gosub loot
repeat
;-----------------MAINSUBS------------------------

sub weightcheck
finditem * c_ %backpack
IF #weight > 400 || #findcnt > 120
   {
   gosub gohome
   }
   else
   {
   return
   }
;------------------------------------------------------

sub spawn
FINDITEM %creature G_, 10
IF #FINDKIND = -1
{
event pathfind 366 15
wait 100
event pathfind 362 15
}
else
{
return
}

;----------------------------------------

sub attack
FINDITEM %creature G_, 10
SET #LTARGETID #FINDID
SET %enemy #FINDID
EVENT macro 27
FINDITEM !_enemy G_
IF #FINDKIND <> -1
{
repeat
}
else
{
return
}
;------------------------------------------------

sub loot
wait 200
return
;------------------------------------------------

;--------------TRAVEL SUBS-----------------------

sub gohome
EVENT pathfind 356 14
wait 5
EVENT MACRO 22 0
wait 5
EVENT pathfind 352 14
SET #LTARGETID %homebook
EVENT MACRO 15 210
wait 5
EVENT MACRO 12 0
wait 5
gosub dropoff
;---------------------------------------------------

sub dropoff
    gosub godemons

;---------------------------------------------------
sub godemons
SET #LTARGETID %doombook
EVENT MACRO 15 210
wait 5
EVENT MACRO 22 0
wait 10
EVENT pathfind 355 15
EVENT MACRO 12 0
EVENT pathfind 356 14
  goto main:
;----------------------------------------------------


thanks for your reply i was thinking the same thing im a total noob when it comes to script writing im trying to figure it out by reading the guides and disecting other peoples scripts, on that note could you maybe give me an idea an how a single script for doing this would work? like make guardians spawn kill guardians wait for loot then make guardians spawn again