ScriptUO

Official ScriptUO EasyUO Scripts => Scripting Chat => Topic started by: thekidnick on November 21, 2008, 11:31:31 AM

Title: New Smith Script
Post by: thekidnick on November 21, 2008, 11:31:31 AM
Almost done with the v 1 of my new smith script using salvage bag, but I am having one problem.  The script makes a Tinker Tool EVERY I  have narrowed it down to the IF statement I am using, but I have tried it many ways and cannot figure it out.

LOOP:
findItem JTL C_ , %Salvage ; If less than 2 tinker make 1
  set %tinker #findcnt
  if %tinker < 2
  gosub TinkerTool
  else
  continue
findItem OBG C_ , %Salvage ; If less than 1 tinker make 1
  set %tong #findcnt
  if %tong < 2
   gosub Tong
  else 
gosub makelast


If you need the whole script let me know.
Title: Re: New Smith Script
Post by: TrailMyx on November 21, 2008, 11:39:24 AM
You might need to post the whole thing.  I think the problem might be with your continue statement; you may have to rethink your logic there.
Title: Re: New Smith Script
Post by: thekidnick on November 21, 2008, 11:40:44 AM
here is the script
Title: Re: New Smith Script
Post by: TrailMyx on November 21, 2008, 11:46:49 AM
Well, take a look at your looping assumptions with "continue".  continue/breaks are only meant to work with for, while and repeat/until. 
Title: Re: New Smith Script
Post by: thekidnick on November 21, 2008, 11:51:50 AM
hmm ok will work on that tonight at work.

Thanks again
Title: Re: New Smith Script
Post by: TrailMyx on November 29, 2008, 01:14:21 PM
Did you get a chance to do an update to your script?  I'm bored between family outings, so I'm looking at the dangling threads.  :)
Title: Re: New Smith Script
Post by: 12TimesOver on November 30, 2008, 03:34:34 PM
And just an added thought, at about 95 or so you should consider switching from Circlet to Royal Circlet. Still takes only 6 ingots but trains you faster than Circlets alone (requires a little bit higher skill).

You can take those to 120 or you could break it down a little further and go for Platemail Hiro Sode somewhere between 105 and 110, they take twice the ingots but keep you closer to that 50% success rate sweet-spot.

XII