Bod Filler Expanded to Newer Craft Options

[Gaderian]

I will look at it when I get time.

[TrackStar]

Sometimes "Metal container engraving tool" is used in place of the "tinker's tools" causing the script to get stuck.

[Gaderian]

Sometimes "Metal container engraving tool" is used in place of the "tinker's tools" causing the script to get stuck.

This one needs more information. There is code specifically in the script to handle these based on the color of the items. While the type is the same, both tinker's tools and the metal container engraving tool are differentiated by testing the color of the item to make sure it matches.

My curiosity is piqued by the 'Sometimes'...

Are you saying you have seen both:

• it SUCCEED to fully craft items and fill the SBod?
• it FAIL to fully craft items and fill the SBod?

Whatever the failure, it must be reproducible and 100% of the time the script logic has to run that course.

The script crafts its own tools, so it won't pull a tinker's tool from a secure to make something. The only thing that will be pulled from the primary secure are finished items to add  to the SBod.

It keeps using the same craft tool until it wears out, so for it to switch to a new craft tool item in the middle of the craft cycle the tinker tool must break. This will cause it to select a new tinker tool.

The craft tool selection happens by 1 routine, but there is a special case to handle tinker's tools vs the other craft tools. Since there is a 'tinker's tools' SBod, this gets some special treatment to make sure we do not use the last tinker tool. (This coincides with my comment about not pulling tools from the resource container, but always making what it needs.)

There are several SBods that have the same TYPE but different color or name, so I gave a lot of attention to testing these cases (tinkered jewelry, tinker's tools/metal container engraving tool, scribe's pen/spellbook inscription tool, fletching and carpentry weapons, etc.).

To have no metal container engraving tools in your backpack and start to craft to fill an SBod (I have tested this), it works - making the items and combining the SBod.

Since the script would loop on the engraving tool, the next time you experience this can you give some more details about what is happening and what is in your backpack? Are there 0 tinker's tools? Are there 3 tinker's tools? Did it just craft new tinker's tools?
If it is reusing the metal container engraving tool as a tinker's tool, then you should be able to put 2 engraving tools in your backpack, 1 tinker tool and the script should try to use the metal container engraving tool once the tinker's tool wears out - when filling ANY tinker SBods. Please test this situation with your setup.

I ask you to test it because there may be something in your environment and setup that I didn't think about.

We'll get to the bottom of it.

Thanks!
Gaderian

[/list]

[TrackStar]

It fails and starts using the engraving tool when the tinker tool runs out in the middle of the process. That is 100% reproducible for me so far.

This occurs even if there are other tools in the bag.

[Gaderian]

Nunchaku fixed in my version. These had a double issue. I corrected the generic issue that will apply to color material but with more than 1 material (the first issue with Nunchaku) - this was looking for a color of ingot and the same color for board. Now it only looks for the color of ingot (correctly) and uses plain colored materials for the remainder of boards, ingots or cloth (I do not know if any have a 2nd ingredient as leather... need to check that). The second issue was the same as Bola Balls - no matter what material you craft with, the finished item has a fixed color.

Before releasing this, I would like to ask for some help with some data gathering. I don't have time to do it, but I would like to figure out all the items this applies to before going further. I do not want to release 100 versions of the script just to fix 1 item at a time. If no one can help, it will get done by me eventually, but probably 1-3 months.

Here is what the work would be:
craft one of each item in some colored material (like dull copper or oak) and get the color data. Do any items not have the same color as the primary colored material?
Craft a nunchaku in dull copper, it is named "dull copper nunchaku" with a color of 0 instead of 2419 (dull copper color). I already did all the names over the summer, but I did not research the colors. Now I wish I had, but we are where we are.
A simple script could be created to do the data gathering. It would take a supply of cheap colored ore (wouldn't matter what, so dull copper and any of the lesser woods (oak (2010) or ash (1191)) would be sufficient. I placed the colors that match the material in parentheses.

Craft skills to be tested are: carpentry, tinkering, fletching.

As for the metal container engraving tool/tinker's tool issue, I will need an SBod. If you are willing to give 1 or a few to me, I can work on it.

[TrackStar]

I think I've filled all of my container engraving BODs but I am probably going to be done filling all my other BODs later today and doing turn ins so I'll probably have some more tonight or tomorrow that I can give you.

I play on Atlantic.

As for the testing you need done I will try to get to it when my time allows. I spend way more time scripting UO than actually playing it right now because of parenting and family duties. I might be able to get some of it done tonight though.

[Gaderian]

So here is the tinkering list that needs to be modified for the exceptions.
This list needs to be reduced by how many items cannot have a SBOD with anything other than iron ingot and plain wood.
If someone is willing to try bribing up the bods and see which get no more bribes after basic material, exceptional, 20 count, that would be helpful.

Carpentry and Fletching may have some items that need to be added to the list.

Again, this list is items crafted with material like dull copper, ash boards, spined leather, but are not taking on that color of the material.
There are 2 kinds of entries needed:
1) doesn't matter the material used - crafted as the same color (example 'clippers')
2) more than 1 material but can call for other colored resources (this needs to be filled out - nunchaku had metal and wood. The metal could be a different material, but for the wood the color doesn't matter).

Item	Always a Color	Multiple ingredients
=====================	=============	=========
Axle	yes	no
Axle With Gears	yes	2
Barrel Hoops	yes	?
Barrel Tap	yes	no
Bola Balls	yes	?
Bolas	yes	2
Clippers	yes	no
Clock	yes	2
Clock Frame	yes	1
Clock Parts	yes	1
Copper Key	yes	1
Dovetail Saw	yes	1
Draw Knife	yes	1
Dull Copper Hammer	yes	1
Dull Copper Hatchet	yes	1
Dull Copper Nunchaku	yes	2
Dull Copper Pickaxe	yes	1
Dull Copper Sledge Hammer	yes	1
Dull Copper Smith's Hammer	yes	1
Fancy Wind Chimes	yes	?
Fletcher's Tools	yes	1
Flour Sifter	yes	1
Froe	yes	1
Gears	yes	?
Hinge	yes	1
Inshave	yes	1
Jeweled Filigree	yes	?
Jointing Plane	yes	1
Lockpick	yes	1
Mapmaker's Pen	yes	1
Metal Container Engraving Tool	yes	?
Mortar And Pestle	yes	1
Moulding Planes	yes	1
Paper Lantern	yes	?
Rolling Pin	yes	1
Round Paper Lantern	yes	1
Saw	yes	1
Scissors	yes	1
Scorp	yes	1
Scribe's Pen	yes	1
Sewing Kit	yes	1
Sextant	yes	1
Sextant Parts	yes	1 (Parts menu)
Shoji Lantern	yes	1
Shovel	yes	1
Skillet	yes	1
Smoothing Plane	yes	1
Springs	yes	1
Tinker's Tools	yes	1
Tongs	yes	1
Wind Chimes	yes	?
My current guesses: Tinkering - wood color doesn't matter. Carpentry only wood color would matter, but there may be some items where regardless the material the color is the same. (still needs investigation). Fletching - only wood color would matter, but does the multiple resource items come in color matching the wood??

[TrackStar]

Finally got around to turning in my Tinkering BODs to get new ones and help you with this but the script I have for turning in BODs and gathering the rewards doesn't work on tinkering for some reason.

I was using Penny's BOD Swapper ( http://www.scriptuo.com/index.php?topic=14992.msg125421;topicseen#msg125421 )

Manually turning in these bods (500+) for points is very time consuming. I need to find a solution.

[Insideout]

All I can say is thank you! Ran it with some fletching and alchemy bods once I figured out set up it worked flawless.

[TrackStar]

Ran into a big issue with tailoring.

Had a spined leather bone helmet 10 normal BOD.

The script was making them endlessly and trashing them. They were all exceptional bone helmets so I am thinking that maybe because they were exceptional it was having an issue with them?

I didn't catch it until it had trashed 91~ helmets. Luckily I caught it and was able to pull them all out before they were deleted.

[Gaderian]

What color are spines bone helms? Is it the same color as spines leather or just regular bone helm color? What is the value for #findcol when you find a helm?

[TrackStar]

The helmets are normal color.

[Gaderian]

That is the same issue as the table of tinkered items. Thanks for reporting that. I will be able to correct that with the next version.

[TrackStar]

This appears to be the case for all bone armor with none normal leather.

[TrackStar]

"Wood Container Engraving Tool" gets hung up when the wood type is other than normal.