DOOM BONE CUTTER

[waggler]

Code: [Select]

;==================================
; Script Name: Doom Bone Cutter
; Author: Guild writer
; Version: 1
; EUO version tested with: 1.5
; Shard OSI
; Revision Date: 2008-09-05
; Public Release: 2007-06-11
; Purpose: cuts Unholy Bones from the Dark Father in Doom places.
;==================================


;Drag your dagger and put #LLIFTEDID HERE ***
;==================================
set %dagger NYPUMRD
;==================================

;==== The Lower the # the slower you cut
set #lpc 5
;==== Beware of going to fast, it gets quite obvious

;DO NOT EDIT BELOW THIS POINT
set %bones MNF_QNF_PNF_KNF_JNF_LNF
ignoreitem reset
scan:
finditem %bones G_9
if #findkind = 1 2
set #ltargetid #findid
set #ltargetkind 1
event property #findid
if corpse in #property 2
  ignoreitem #findid
  goto scan
if bones in #property
  goto cut
while #charghost = yes
 pause
goto scan

cut:
while #targcurs = 1
 {
 goto cut
 }
set #lobjectid %dagger
event macro 17 0
wait 5
event macro 22 0
wait 7
goto scan


[pwnage pimp]

Anyone else have problems with this script not finishing when it's in the middle of cutting a bone pile?

Every time i run it if the targcurs doesn't click the pile then it basically halts. It resumes if i press esc or target the pile myself

[Khameleon]

I lowered the G distance
to finditem %bones G_4

[Cerveza]

I lowered the G distance
to finditem %bones G_4

You can cut bones out to 15. I suspect the problem is with ignoring once they have been cut.

There's an unintrusive cutter on EUO that works perfectly.

[Beertje]

The problem I have with most cutters is that they recognize bones from a corpse as bones to cut. Is that the case with this cutter ?

[Khameleon]

it shouldn't since it scans the property to make sure its not a corpse

[bernietrue]

when i using this script,im healing my pet with razor macro,some bones dont get cut.any solutions?

[Djego]

when i using this script,im healing my pet with razor macro,some bones dont get cut.any solutions?

Yes, the target of the bandages gets in conflict with the target cursor of the dagger for cutting the bones maybe writing a check in the script "if #targcurs = 1" or something like that to ensure both target cursors dont get in conflict

[Cerveza]

As I mentioned before... there is a VERY GOOD non-intrusive bone cutter on EUO.

LINK

It already has a wait if the target cursor is active. Bones can be cut out to 15.

If you were to use a different one you need to include this in your main loop so you don't cut while the cursor is active...

while #targCurs = 1
wait 0

which will pause until the cursor is not active. You might want to use a #charStatus as well, so you don't cut while casting. You'd have to test it a bit to see if it's needed.

[Boydon]

That script is not that good.
It is not a good practice to goto out of a sub.

[Cerveza]

That script is not that good.
It is not a good practice to goto out of a sub.

Don't like it? Don't use it.

Goto's are bad all around. He could have coded around it, but in this case it's clean enough. The GOTO in question is when the cursor is active (as in target). He simply has the script go back to the waiting loop.

A fix for this would be to replace those with a WHILE/WAIT 0.

Code: [Select]

scan:
if #targCurs = 1
 goto scanwould become

Code: [Select]

scan:
while #targCurs = 1
  wait 0
and

Code: [Select]

sub cut
if #targCurs = 1
 goto scanbecomes

Code: [Select]

sub cut
while #targCurs = 1
  wait 0
If I were doing a rewrite of this script I would even remove the scan: and goto loop, turn it into a REPEAT/UNTIL, change the IF NOT FOUND to a IF FOUND. I suppose if you don't post the code as your own, you could always change it around.

[TrailMyx]

It is not a good practice to goto out of a sub.

I agree!  I think Cheffe has a limit on the number of times you can do that however.