Help :)

[Toptwo]

OK, OK...I am attempting to actually write/modify a script. What I want to make is a server line healer script. I know there is a lot of healing scripts out there but they all seem to require damaging your char, and I would like to try making one that utilizes a server line to do this.

So far, I have managed to write the first part..I can make my char walk 4 steps, turn around, and walk 4 steps back. WOOHOO!!!!!!

How would I go about writing in a pause after the 4 steps though, I am confused if I would actually need to make him pause, or just the act of using a bandage would make him pause (I dont think using the bandage will do it, I think I need a real pause)...right??

Here is what I have so far:

set %X #CHARPOSX
set %XX #CHARPOSX + 4
set %Y #CHARPOSY

menu text scriptstatus
HealTrainingLoop:
   {
   move %X %Y 0 4s

   move %XX %Y 0 4s
        }
Goto HealTrainingLoop
Return



hehe pretty simple for you guys, but it took me over a hour to do it LOL!!

Thanks

[TrailMyx]

After your second move, you could just apply the bandage and then add a "wait".  If you are bandaging yourself, the wait time is based off your healing/anatomy.  There's a formula on stratics that tells of this wait time, but is like 6 seconds or so.  So perhaps "wait 6s".  Dunno if that's what you had in mind.

[Toptwo]

Thanks TM, I actually managed to figure that out since I posted...now I am dealing with another problem (well, for me problem) LOL This is what I have

set %X #CHARPOSX
set %XX #CHARPOSX + 6
set %Y #CHARPOSY

menu text scriptstatus
HealTrainingLoop:
   {
   move %X %Y 0 6s
wait 200


I actually used a wait 200. I think that is 10 seconds...which would be what it takes to heal at only 20 skill...


   move %XX %Y 0 6s
        }

now, running this makes him move East and West

How do I change that to make him walk North and South??

Thanks!!!

[TrailMyx]

You just need to set another variable using #CHARPOSY + 6 just like you did for #CHARPOSX.  If you do it with a sub instead, it'll make it easier:

Code: [Select]

HealTrainingLoop:
  gosub MoveYourself 6 0
  wait 200
  gosub MoveYourself -6 0
  wait 200
  gosub MoveYourself 0 6
  wait 200
  gosub MoveYourself 0 -6
goto HealTrainingLoop
;---------------------------------
sub MoveYourself
  set %X #CHARPOSX + %1
  set %Y #CHARPOSY + %2
  move %X %Y 0 6s
return


[Toptwo]

HOLY CRAP!!!!!!!!!!!!!

I (with your help, and cerv's tutorial) JUST WROTE MY FIRST SCRIPT!!!

and IT WORKS!!!!!!!!!!

I have it set up at a server line...wearing everything I can find to add HP (crimson etc...) When I cross server line and my HP goes down, the script throws a bandage on me...I heal...walk back across server line..and heal again..over and over...WOOOTTTTTTTTT!!!!!!!!!!

[Cerveza]

Now theres no stopping you!

Congrats!!

[Toptwo]

Thanks Cerv!!

Here is what the whole thing looks like...dont know if it could be made more efficient or not...but I know it is working.

------------------------------------------------------------------------

gosub MoveYourself 0 6
  wait 160
  gosub MoveYourself 0 -6
goto HealTrainingLoop:

sub MoveYourself
  set %X #CHARPOSX + %1
  set %Y #CHARPOSY + %2
  move %X %Y 0 6s

FindItem ZLF C_ , #BackpackID
  if #findkind = -1
    {
      Display ok You have run out of bandages.$
            + Please get more and restart the script.$
            +$
            +Script is Halting$
            Halt
    }
Set #LObjectID #FindID

menu text scriptstatus 110 268 Using Bandage
Event Macro 17 0        ; Use Last Object (Bandages)
 Target
Event Macro 23 0        ; Target Self
wait 200
Goto HealTrainingLoop
Return

[TrailMyx]

Careful with what you are doing, you are jumping out of your subroutine.  That's bad mojo.  Follow the script flow a bit to make sure it's doing what you think it should be doing... 

Just get rid of the "goto HealTrainingLoop:" I don't think you have the tag, so it won't actually do anything, but it's good to understand that.

Also, you are relying on the script to start over again.  You might want to fix it so the loop happens under your control  perhaps something like this:

Code: [Select]

repeat
  gosub MoveYourself 0 6
  wait 160
  gosub MoveYourself 0 -6
until #FALSE

sub MoveYourself
  set %X #CHARPOSX + %1
  set %Y #CHARPOSY + %2
  move %X %Y 0 6s
 
  FindItem ZLF C_ , #BackpackID
  if #findkind = -1
  {
    Display ok You have run out of bandages.$
    + Please get more and restart the script.$
    +$
    +Script is Halting$
    Halt
  }
  Set #LObjectID #FindID
 
  menu text scriptstatus 110 268 Using Bandage
  Event Macro 17 0        ; Use Last Object (Bandages)
  Target
  Event Macro 23 0        ; Target Self
  wait 200
Return


[12TimesOver]

Congrats M8!!

Just want to mention that it is good practice to avoid using GOTO statements to jump in and out of subroutines. In your example you may want to simply remove the "GOTO HealTrainingLoop" at the end of your MoveYourself sub.

If you wanted to, you could also break into an "ApplyBandage" sub and seperate that logic a litle bit from the move sub. Maybe something like:

Code: [Select]

Loop:
   Gosub moveyourself 0 6
   Gosub healyourself
   Gosub moveyourself 0 -6
   Gosub healyourself
GoTo Loop
Just some "good practice" stuff for ya but either way keep it up!!

XII

<edit> doh TM beat me to the Reply button!!

[Toptwo]

Thanks Guys!

Yep, and with all you guys have said here I still managed a stinking goto live and learn!!!

TM..I think I understand...by putting return in there and the #FALSE, you are telling the script to run until stopped or until out of bandages...is that correct??


Thanks Guys!!

I might even get faster someday....that little timy bit o script took me 6 hours to accomplish LOLOL!!!

[12TimesOver]

You can most certainly use GoTo's - that's why the command exists; however, there is a time and a place. TM's example though is a good way to run your main loop without one, the "Repeat" tells the loop to run and the "Until" criteria is never met thus it loops indefinitely unless you have logic builtin elsewhere else to tell it to stop (like when you are out of bandages).

Most importantly, if you DO use a GoTo, NEVER (repeat - NEVER) use GoTo to hop between subs.

Also, I don't see a menu anywhere in there so I think you can get rid of your 'menu text' line.

XII

[TrailMyx]

Well the idea behind:

Code: [Select]

repeat
...
until #FALSE

This is really the same as:

Code: [Select]

loop:
...
goto loop

repeat/until #FALSE is an infinite loop since there's NOT a way for the until to be #TRUE. 

[12TimesOver]

Didn't I say that?

[Cerveza]

#TRUE is always true, unless it's false.

*TM made a mainloop without a goto  ... sorry... got a little teary there.... 

It's the greatest day of my life!

[Toptwo]

roflmao!!