Recent Posts

Pages: [1] 2 3 ... 10
1
Crafting / Re: Bod Filler Expanded to Newer Craft Options
« Last post by Gaderian on December 08, 2021, 09:43:22 PM »
So in each of these cases it is pulling items from the secure which are the same color but a different name for the alchemy potions?

If you do not have any premade potions, does the script work?
2
Crafting / Re: Bod Filler Expanded to Newer Craft Options
« Last post by TrackStar on December 08, 2021, 07:10:37 PM »
Had another similar experience to the one above.

BOD is asking for 15 heal potions and the script keeps grabbing 6 lesser heal potions out of my secure and getting hung up.
3
Crafting / Re: Bod Filler Expanded to Newer Craft Options
« Last post by TrackStar on December 08, 2021, 01:12:12 PM »
20 lesser poison potion BOD... I keep getting the message "This item is not in the request." and the BOD filler thinks its made 20/20 potions but there are only 15 regular poison potions in my bag.

After removing the potions it began operating normally again and made the proper potions.
4
Crafting / Re: Bod Filler Expanded to Newer Craft Options
« Last post by TrackStar on December 08, 2021, 12:49:28 PM »
Doing Alchemy BODs for the first time...

Script hangs on nightsight potions.
5
Crafting / Re: Bod Filler Expanded to Newer Craft Options
« Last post by Gaderian on December 07, 2021, 08:06:25 PM »
I was running that routine above through my head. It is troublesome to me.

The only way that could be valid is in the case where you have only 1 kind of SBOD/LBOD that you are trying to fill, I think. So the error you are experiencing doesn't even belong as a validation step, because the type of BOD can be retrieved in the loop as it processes each BOD - which is where that kind of logic belongs. Also, it should be more lenient and if a #findcol returns a bad result, that item should just be skipped in the loop.

Of course, all this is without any testing on my part. I have observed a few minutes that you indicated from your videos and looked up the situations where the error message can be generated.

So, at this novice moment, I believe that whole setting of %s7BFSbodType #result by #findcol is wrong. (I believe I am entitled to such a judgment as the author.  :angel: )
6
Crafting / Re: Bod Filler Expanded to Newer Craft Options
« Last post by Gaderian on December 07, 2021, 06:45:05 PM »
My guess is that there is a ghost item in your backpack.

The script issues a finditem for all BOD types in your backpack and the first one receives the #findcol value, which is 0. This doesn't look like the case because you do not seem to have a random scroll (of the same type as a BOD - there are others that share this type) in your backpack.

Now it passes that #findcol value to figure out what type it is among valid BODs and produces the error.
What is interesting is your first video manages to fill the initial large except for the lacking SBOD. Then it is the second attempt to fill a large of the same types that fails. At this point several of the SBods would have been combined into the LBod, so the ghost item seems likely. I am not sure I tested filling several LBods of the exact same specifications, so I think your error is valid.

You should prove it by displaying a little more information before making a fix. How would I do that? Adjust the s7FindSBod routine to display the information and give me a chance to examine what my variables are at the point of the error.
Test it with the following alteration to this routine:
Code: [Select]
;///////////////////////////////////;
; s7FindSBod
; finds a filled sbod in backpack by name, quantity, and quality
;///////////////////////////////////;
sub s7FindSBod
  set %FSBProp %2
  set %FSBcnt %1
  finditem EYM C_ , #backpackid
  set %FSBfindcnt #findcnt
; Insert test code here
if #findcol = 0
 {
 display ok script paused because #findcol = 0 - verify the #find... variables
 pause
 }
; End test code
  gosub SetBodType #findcol
  set %s7BFSbodType #result
  for %FSBfindI 1 %FSBfindcnt
  {
    finditem EYM %FSBfindI C_ , #backpackid
    gosub s7GetProperty #findid A , #spc , Bulk , #spc , Order , #spc , Deed$
    if %FSBProp in #property && large , #spc , bulk notin #property && ( ( %s7BFLbodExceptional && exceptional in #property ) || ( ! %s7BFLbodExceptional && exceptional notin #property ) )
    {
      gosub s7GetBodAmountMade
      gosub GetBodMaterial #Property %s7BFSbodType
      set %s7BFSBodMaterial #result
      if %s7BFBodAmountMade = %FSBCnt && _ , %s7BFSBodMaterial , _ in _ , %s7BFLBodMaterial , _
        return #true
    }
  }
return #false
7
Crafting / Re: Bod Filler Expanded to Newer Craft Options
« Last post by Hitechs on December 07, 2021, 05:58:39 PM »
made 2nd video,

three full bod sets & larges,
starting script multiple times after errors, finally got all the larges filled
(might need little more time for youtube to make HD)

https://www.youtube.com/watch?v=qCN-7k03cK0&t=696s = time script starts filling larges / errors
8
Crafting / Re: Bod Filler Expanded to Newer Craft Options
« Last post by Hitechs on December 07, 2021, 05:10:59 PM »
guess i need better debug skillz,
(could start up private test shard, and make my own bods)

4 sets & larges (left 1 small out of each large for testing)
crafted all smalls for large but 1, script filled all smalls no issues
got error a few times filling large,
stopping and starting script a few times got the larges filled

picked up last 4 smalls, hit play,
only adding 1 small to each large completed without error.

guess i need to test / debug more,

here a lame video, ya i know lol
but has the easyuo var list in view
(might need to wait little more for youtube to make HD)


https://www.youtube.com/watch?v=iQH784fE6kw&t=791s = time it starts to fill larges with errors

https://www.youtube.com/watch?v=iQH784fE6kw&t=1147s = time i start it with last small for each, that completes without error

https://www.youtube.com/watch?v=iQH784fE6kw = whole video

9
Crafting / Re: Bod Filler Expanded to Newer Craft Options
« Last post by TrackStar on December 07, 2021, 09:42:31 AM »
I'm jumping into BODs heavily again now that the event is over. Will probably fill 10k~. Will report issues as I go.
10
Crafting / Re: Bod Filler Expanded to Newer Craft Options
« Last post by Gaderian on December 06, 2021, 08:09:22 PM »
It is a script based issue. It is trying to match up the color of the large and the small together. Think about it from the standpoint of colored materials - spined leather or copper ingots - and it makes sense.

When it comes to some items that either have the same color regardless of material (tinkered clippers are the same color, as an example) then there are exceptions to the above rule. This is the rule that needs to be used for inscription. I suspect that all the inscription LBOD/SBOD filling requires this kind of exception.

That is without looking at it or trying it - sorry a bit overwhelmed on my current time schedule. I will have more time next week if you still need more help.

Gaderian
Pages: [1] 2 3 ... 10