Fishing sub

[VicVega]

I was wondering if there is a better way to handle the spots where I can't fish in the fishing sub (too close spots or too far ones) in order to avoid them.

Right now the badspots are handle with "sub badspots" called from the fishing sub.

Also I would like to know if it's better to call the "badspots" passing parameters like this:

Code: [Select]

gosub badSpots %x %y
And then use %1 and %2 in the sub, or if it's the same and it does not improve stability.

Code: [Select]

set %poleType NSL_KSL
set %pathReconnect reconnect.txt
set %maxTimeOutScan 20

sub fishing
  for %x -5 5
  {
    for %y -5 5
    {
      if #contkind = ORLB
          call %pathReconnect
      if #weight < %maxweight
      {
        event sysmessage %x %y
        gosub badSpots
        if #result = good
        {
           gosub usePole
           gosub scan
           deletejournal
           gosub pickupFish
        }

      }
    }
  }
return

sub pickUpFish
    finditem %fishType G_2
    if #findkind <> -1
        call pickupFish.txt
return

sub badSpots
  if %x = -5 && %y = -5 ; too far
     return bad
  if %x = -5 && %y = 5 ; too far
     return bad
     
  if %x = -1 && %y = 0 ; too close
     return bad
  if %x = -1 && %y = -1 ; too close
     return bad
  if %x = -1 && %y = 1 ; too close
     return bad
     
  if %x = 0 && %y = -1 ; too close
     return bad
  if %x = 0 && %y = 0 ; too close
     return bad
  if %x = 0 && %y = 1 ; too close
     return bad
     
  if %x = 1 && %y = 0 ; too close
     return bad
  if %x = 1 && %y = -1 ; too close
     return bad
  if %x = 1 && %y = 1 ; too close
     return bad


  if %x = 5 && %y = -4 ; too far
     return bad
  if %x = 5 && %y = -5 ; too far
     return bad
return good

sub scan
  set %timeout #scnt + %maxTimeOutScan
  set %jrnl #jindex
  scanjournal %jrnl

  while #scnt < %timeout
  {
    if %jrnl < #jindex
    {
      set %jrnl %jrnl + 1
      scanjournal %jrnl
    }
   
    if ( mala_suerte in #journal || Pescaste in #journal )
    {
      set %timeout #scnt + %maxTimeOutScan
      gosub usePole
    }
   
    if ( no_hay_peces in #journal || demasiado_lejos in #journal
        + || no_puedes_pescar in #journal || mejor_pesca in #journal )
    {
      wait 5
      return
    }
  }

sub UsePole
set #lTargetKind 2
set #lTargetX #CHARPOSX + %x
set #lTargetY #CHARPOSY + %y
finditem %poleType
set #LOBJECTID #FINDID
event macro 17
target 3s
event macro 22
return

sub pickUpFish
    finditem %fishType G_2
    if #findkind <> -1
        call pickupFish.txt
return

[TrailMyx]

Will you be fishing from a boat?  If so you can really simplify you code by only fishing once in each 8x8 resource block.  You can look at my fisherman here, but the gist is that you only need to fish N, S, E, W and 4 spaces from your character.  This covers the entire 8x8 resource allocation of UO.

Also, I think you saw how useful the journal can be for fishing, so you can use a journal scanner to tell when you have depleted your area or are fishing an an invalid area.

[VicVega]

Where is that fisherman script?, I didn't find it

What do you mean only fishing once in each 8x8 block?

Right now my character fish in every spot that can be fished, if fish or fail to fish, tries again in the same spot, and when is depleted, it goes to the next one.

Why I don't think fishing only once per spot a good idea?

Because I would end my area of fishing very quickly without fishing all the fish around me.

I fish in ports over water, each time the character goes to fish, walks a random amount of steps in order to change the fishing zone.

[TrailMyx]

8x8 resource blocks are how UO handles resources that respawn.  Resources don't restock in a tile/tile basis.  So when you just fish in 4x4 blocks around you, you are depleting all possible resources by only fishing in 4 spots!

Actually it works out pretty close actually.  If you fish one 4x4 square to being empty, then the other 3, you are really close to having the resources replenished.  Trust me, I have a couple fishing scripts out there and have been doing the fishing thing for just about the beginning of my scripting life, so I've tweaked it a bunch.  It's all come to successful fishing attempts/hr so if you over-fish an area, you'll waste a lot of time in that same area knowing you won't fish anything up.

So I guess I didn't explain correctly.  When I meant fish "once", I meant fish in one area of a 4x4 block and exhaust the fish.  That effectively fishes out the whole area and then you just shift N,S,E,W to the next 4x4 block.  You can effectively fish in one place constantly and never run out of places to fish and you'll only fail to fish 4 times.  Try it, it works...

Here's a link to my fish hunter:

http://www.scriptuo.com/index.php?topic=133.0

The other one is for the Elite members and that one handles collection, archery and slayer books, ancient AOS farming, etc.

Oh, and there are places in UO where you can use this 4x4 method off land so you don't even need a boat!

[VicVega]

I always thought that the minerals, fishes, etc, where respawned tile by tile

The shard I play it's sphere 0.56b, if that matters

Thanks for the explanation but I don't know if I understood you correctly.

You mean that if I do my bucles to only fish in a 4x4 squares, and then in the other oposite 4x4 square, they do not deplete so quickly?

So:
11112222
11112222
11112222
11112222
33334444
33334444
33334444
33334444

Fish first in zone 1, then zone 2, then zone 3, then zone 4 and then move?

Or like this:
11111111
11111111
11111111
11111111
22222222
22222222
22222222
22222222

[TrailMyx]

Great example!

Your first graphic explains it best.  Picture yourself standing at the 4-corners of your example.  What I do is just fish zone 1, then 2, then 3 and finally 4.  By the time I've fished back to zone 1, the fish have nearly always replenished.

You may have to do some experimentation with Sphere.  I can't speak for that server since I've never played a shard based on it.  Only OSI and RunUO for me.  But my guess is that it'll be something similar.  Really it comes down to memory management and it's much more memory efficient to manage resources in 8x8 groups than it is to do it on a tile/tile basis.  (read: hella-smaller - 64x compression)

[TrailMyx]

Here's another look at what I do (using your example):

F111 222F
1111 2222
1111 2222
1111 2222
      C
3333 4444
3333 4444
3333 4444
F333 444F

If you fish out to the 4 corners labeled by "F", it really doesn't matter where you are at in the world coordinates because you should aways be fishing into 4 different resources 8x8 squares.

[VicVega]

I understand better now, so as I said, I fish over a port shape in a line form.

And each round the character goes fishing, I walk a random amount of steps from my initial fishing zone.

So, if for example I have 30 steps maximum to walk, I can make the first random amount of stepts between 0 and 8, and the next one between 8 and 16, and so on.

Would that improve the code and minimize the depleting zones?

Or I should better instead of fishing straight in line, fish something like this:

[TrailMyx]

I guess the most efficient way of getting away with this is to figure out a way to not move at all.  I think that's why I first started using a ship instead of fishing from shore.  Instead of physically moving your character, I just sail forward 16 spaces and I'm in a completely new set of resource spots.  Finally I just don't really move the ship at all. 

Is your need to move at all just a matter of style, or is there some other reason for it?  I'm not sure if there's additional requirements on Sphere.  I just know that I've been able to minimize the need to move at all.

[TrailMyx]

Seeing from your picture, I'll bet you could get away with fishing and not moving at all.  Again, there's probably something different from Sphere.  But if you can get away with just fishing those 4 zones, then you only have 4 coordinates to set (you can even steal those from my fisher) and then a simple journal scanner.

[VicVega]

In the shard I play there is no ships, I have to fish like this.

I moved the character because I thought the respawn was tile by tile.

So, something like this then:



Or if I'm lucky, I can test first only the first zone, right?

[TrailMyx]

NO SHIPS!?!?!?  Barf!

Anyhow...

Ya, that might simply things.

[VicVega]

Some more aclarations that I still don't get:

F111 222F
1111 2222
1111 2222
1111 2222
      C
3333 4444
3333 4444
3333 4444
F333 444F

Do you mean that if the character stands at C, it will deplenish all the fish in the Zone 1 (4x4 tiles) only fishing in the (-4, 4) spot (marked with F) ?

It wouldn't be necessary to fish on the other "Zone 1" spots marked with 1? They would be empty once fished the (-4, 4 ) spot?

8x8 resource blocks are how UO handles resources that respawn.  Resources don't restock in a tile/tile basis.  So when you just fish in 4x4 blocks around you, you are depleting all possible resources by only fishing in 4 spots!

Also I don't understand this.

So a 8x8 zone has four 4x4 zones inside. If a 8x8 resource blocks is how UO handles the fish respawn and not 4x4 zones, then  if you deplenish only one of the 4x4 zones, it wouldn't be also deplenishing the rest of the 8x8 zone?

If you fish out to the 4 corners labeled by "F", it really doesn't matter where you are at in the world coordinates because you should aways be fishing into 4 different resources 8x8 squares.

Do you mean "you should aways be fishing into 4 different resources 4x4 squares", instead of "you should aways be fishing into 4 different resources 8x8 squares." ?

I ask the question because of this:

I guess the most efficient way of getting away with this is to figure out a way to not move at all.  I think that's why I first started using a ship instead of fishing from shore.  Instead of physically moving your character, I just sail forward 16 spaces and I'm in a completely new set of resource spots.  Finally I just don't really move the ship at all.

Is your need to move at all just a matter of style, or is there some other reason for it?  I'm not sure if there's additional requirements on Sphere.  I just know that I've been able to minimize the need to move at all.

Thanks for the help.

[VicVega]

I talk about this with one of the shard's scripts and he told me this:

I don't know how it works in RunUO, but here if you fish in one spot, it will respawn in that spot in one hour, just that simple.

[TrailMyx]

It might be worth some experimentation for you.  I can only tell you how it works with OSI and RunUO.  I've heard that Sphere is pretty different for some implementations and this might be one of them.  1 hour spawn time alone doesn't sound right.  On OSI/RunUO it's around 10 minutes.

Oh, I definitely mean 4x4 when I'm talking about this method.  Yes, it's 8x8 when it comes to the resource distribution, but if you stand anywhere in an 8x8 resource block and fish 4 spaces in any direction, you'll reach the neighboring 8x8 resource blocks.  That's where the 4x4 method comes from that I'm talking about.

But again, this seems to be server distribution dependent.  It would be pretty easy to throw together a test script validate this.  From what it sounds like, I won't be running off to find a Sphere-based server any time soon for my fishing needs.