MeWon's Smith BOD Sorter-er

[MeWonUo]

Code: [Select]

;==============================================
; Script Name: MeWon's Smith BOD Sorter-er
; Author: MeWonUo
; Version: 0.1.7
; Client Tested With: 7.0.16.3
; EUO version tested with: 1.50 202
; Shard OSI / FS: OSI
; Revision Date: 10/05/2011
; Public Release: 10/05/2011
; Purpose: Sorts Smith BODs.
;----------------------------------------------
;**Special Thanks**
;-Neo: Thanks for answering all of my stupid
;      questions along the way. And for your
;      help with the safety measures for
;      those with high pings!
;-12x: Appreciate you giving this a run in
;      it's earlier stages and giving me some
;      pointers in "Scripts for Dummies" talk.
;===============================================

So, I finally took the time to get this cleaned up and ready for public consumption.  This is the first script that I've written from top to bottom, and seems stable enough to let others play with.  Be gentle.


What it does:
Sorts smithing BODs into 13 different book based on reward. (Easily altered to fit your needs. Currently set to how I prefer to sort.)


General Setup:
1. Need a container in your main pack with the 13 different books to sort into.
(Pulling books one at a time out of a secure is a huge waste of time to me, I have an idea in the works that will handle secure support)
2. Book of BODs to be sorted in your pack.
3. Books need to be named as such:

Plate Keepers  - Stores small and large pieces for bods that are worth combining.
Chain Keepers  - "
Ring Keepers    - "
BZ Runic         - Stores smalls that give 100% chance at BZ runic
CP Runic         - " but Copper
SH Runic         - " but Shadow
DC Runic         - " but DC
DCSH Runic     - Stores smalls that return 60% DC and 40% Shadow Hammers
POF 20           - Stores smalls that give a 20% chance at POF
POF 90           - Stores smalls that give a 90% chance at POF
Never Fill        - Stores large bods that are not worth doing.
Small Fill         - Stores smalls to fill and turn back into the smith.
Color Junk       - Smalls that you can choose to fill, or trash.


Other than that, it's pretty straight forward.  I hope it is of some use to some out there.

[Neo]

This thing here is what made me want to start doing BODs again...

Really nice way to get your bods organized.... I'd recommend this for any bod person out there!

[MeWonUo]

This thing here is what made me want to start doing BODs again...

Really nice way to get your bods organized.... I'd recommend this for any bod person out there!

Thanks Neo!  Was a lot of fun getting it all figured out.

[Canuker]

Ran this last night for a while and it worked like a charm.  I did find that filled my backpack quickly but after dumping the never fill stuff and grabbing new books for small and color junk it was fine.  I'll have to review it more but it works great.

[MeWonUo]

Ran this last night for a while and it worked like a charm.  I did find that filled my backpack quickly but after dumping the never fill stuff and grabbing new books for small and color junk it was fine.  I'll have to review it more but it works great.

Appreciate the feedback, Canuker. 

I do have a couple ideas on how to handle the books automatically as they fill up so they don't have to be swapped out by hand.  But I'm not entirely sure how to implement quite yet.  Definitely something I'd like to add in the near future however.

Thanks again!

[Canuker]

I was running this last night and noticed that the never fill book was getting small colored bods placed into it.  I thought this was odd because there is also a colored junk one which I thought these would land in and the "never" would be for large iron and useless colored large.  Is this by design or a error somewhere as it seems that you lose on the cycling for new bods when turning in.

[MeWonUo]

I was running this last night and noticed that the never fill book was getting small colored bods placed into it.  I thought this was odd because there is also a colored junk one which I thought these would land in and the "never" would be for large iron and useless colored large.  Is this by design or a error somewhere as it seems that you lose on the cycling for new bods when turning in.

First off, do you happen to know what bods were going into the incorrect books?  I can check the score for those specific bods and check that there isn't a typo in there somewhere.

And how was your connection last night when you were running it?  I have noticed on rare occasions if I'm getting some lag spikes, that it can cause an error where the bod doesn't get scored correctly and gets put into the never fill book.  I just double check my never fill books to make sure nothing got put in there due to that.

But if you can recall what bods were being put in there, I'd like to double check the score for them to be sure.

Thanks.

[Neo]

Were the bods partially filled? That could also be the issue...

[MeWonUo]

Were the bods partially filled? That could also be the issue...

This too!  Thanks for reminding me Neo.

[Canuker]

No the issue was on my side.  I had made a new bag for the bod books and forgot to make the POF 20.  User error but certainly a good idea to remind all users to have the correct set up.  Sorry for the alarm.

[MeWonUo]

No the issue was on my side.  I had made a new bag for the bod books and forgot to make the POF 20.  User error but certainly a good idea to remind all users to have the correct set up.  Sorry for the alarm.

Glad you got it squared away, Canuker.   It will definitely do some odd things if the setup isn't exact. 

You can also change the names of the books in the script pretty easily if you'd like them named something else.

[MeWonUo]

** I found a small bug with one of the BOD categories this morning. **

Will get a fix posted as soon as I'm able to get back home and test it.

[anewbe4u]

This was working fine for me the other night but now suddenly it stops and suggests there are no more bods to sort. If I check the book, there are and if Start the script again, it will start sorting them. It then stops again before it should.

[12TimesOver]

I did quite a bit of testing with this myself and managed to pull BOD's that I wanted to pull out of a lot of books with little to no effort on my part.

I had about 20 books or so with hundreds of BOD's in each totally mixed between Tailor and Smith, these were books I simply collected into without sorting for a long time.

For starters, keep in mind that the list is customizable. What I was doing was setting everything to go to a general "Smith BOD's" book that didn't meet POF20 or POF90. Then I ran it against a book. When I was done I had 2 POF books and the remainder of my books were all sorted to Tailor and Smith.

One suggestion, and maybe you have already changed this with your public release (I have only tested the pre-release you shared with me), since this only does Smith BOD's you should add to the script to first click "Clear Filter" then select "Blacksmith". There is no reason to have Tailor BOD's show up at all, it just wastes time.

I had some feature thoughts for a future release but I don't want to put those out there just yet and overwhelm the bug-fix process!

I messed around with your code a bit in the version I have so I'll try to give this another whirl later using your Public release because I don't remember what I had changed other than the feedback I gave you through PM lol.

This will be a great add to our Public Script Library once any issues are worked out!

X

edit - hey I just noticed the props in the header, thanks man

[12TimesOver]

One question, just looking at the public code:

Code: [Select]

repeat
finditem EYM c_ , #backpackid
event property #findid
until weight in #property || #scnt > %findtimeout
Not sure if you're open to suggestion but I'll throw it out there anyhow, I'm not sure what you gain with this. You're saying to keep attempting to find something in the backpack until either some time has gone by or you do find something in the backpack with the word "weight" in the property. For starters, when you do a finditem EYM, it's either going to find it (#findkind <> -1) or not (#findkind = -1). There really is no need to keep searching for a period of time or to event property the item to see if you really did find it. You could consider cleaning it up a bit by simplifying it:

Code: [Select]

finditem EYM c_ , #backpackid
if #findkind = -1
   {
   Display No more BOD's to sort
   Halt
   }
;then continue sub from here
To be honest, I would suggest checking to see if a BOD actually dropped into the pack before you exit the DropBOD sub then only call the GetBODScore sub if one does indeed drop out of the book:

Code: [Select]

repeat
  gosub DropBod
  gosub EvalDrop
  gosub DropToBook
until #false

;;-----------;;
;;--DropBod--;;
;;-----------;;

sub DropBod

wait 10 ;<-----xiix comment - not sure that you really need this here

finditem %SortBook
set #lobjectid %SortBook
event macro 17 0
wait 10 ;<-----xiix comment - your WaitForGump sub should take care of this timing too
gosub WaitForGump

set %clickx #contposx + 41
set %clicky #contposy + 104
click %clickx %clicky f

gosub WaitForGump

click %clickx %clicky r
wait 10

;;;;xiixadd here;;;;
finditem EYM c_ , #backpackid
if #findkind = -1
   {
   display Seem to be out of BOD's
   halt
   }
else
   gosub GetBODScore #findid
return

;;---------------;;
;;--GetBODScore--;;
;;---------------;;

sub GetBODScore
set %BOD %1
set %score 0

event property %BOD
; go and get the score and do your thing
return

So anyhow, just some thoughts on script flow and a little logic thought there. This isn't exaclty what you would necessarily use here, there is certainly more to think about but I just wanted to give an example to get the general idea across.


X